)]}'
{"kibana/templates/bin/_create_kibana_index_patterns.sh.tpl":[{"author":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"change_message_id":"43b7e5cfca144e80f52e5f75535b7eea58de82fd","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.wait_for_kibana_pods_readiness }}"},{"line_number":18,"context_line":"echo \"Waiting for all Kibana pods to become Ready\""},{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n osh-infra -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""}],"source_content_type":"text/x-smarty","patch_set":9,"id":"27843594_ca442f5e","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":41},"updated":"2021-08-23 16:50:35.000000000","message":"what if the namespace is not osh-infra?","commit_id":"2af83907d77b03dcaff682cb6756ddd724be9cc3"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e4c533ed531ef17d360f306ee42e2e377e1f429a","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.wait_for_kibana_pods_readiness }}"},{"line_number":18,"context_line":"echo \"Waiting for all Kibana pods to become Ready\""},{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n osh-infra -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""}],"source_content_type":"text/x-smarty","patch_set":9,"id":"bd2920ef_d588cd6c","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":41},"in_reply_to":"27843594_ca442f5e","updated":"2021-08-23 16:55:28.000000000","message":"kibana pod is in osh-infra only. For upstream, this query is not being run.","commit_id":"2af83907d77b03dcaff682cb6756ddd724be9cc3"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5aae54c97f618bda1c5ef2dddf47d17a71accb4c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.wait_for_kibana_pods_readiness }}"},{"line_number":18,"context_line":"echo \"Waiting for all Kibana pods to become Ready\""},{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n osh-infra -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""}],"source_content_type":"text/x-smarty","patch_set":9,"id":"dc26b902_aebac669","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":41},"in_reply_to":"bd2920ef_d588cd6c","updated":"2021-08-23 17:31:37.000000000","message":"There is a {{ .Release.Namespace }} we could use here instead of hardcoding","commit_id":"2af83907d77b03dcaff682cb6756ddd724be9cc3"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"0c42fb5ead28b7b9de30737d6e2de6efd50fb390","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.wait_for_kibana_pods_readiness }}"},{"line_number":18,"context_line":"echo \"Waiting for all Kibana pods to become Ready\""},{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n osh-infra -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""}],"source_content_type":"text/x-smarty","patch_set":9,"id":"fdeebfcb_9b741fb6","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":41},"in_reply_to":"dc26b902_aebac669","updated":"2021-08-23 17:39:33.000000000","message":"ok, will change to {{ .Release.Namespace }}","commit_id":"2af83907d77b03dcaff682cb6756ddd724be9cc3"},{"author":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"change_message_id":"26b801c50dccb547c7d6244c15e7e2cdbb8ce6e9","unresolved":true,"context_lines":[{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n {{ .Release.Namespace }} -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":"  ((count++))"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"1d38f464_e7db9211","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":28},"updated":"2021-08-23 17:44:13.000000000","message":"do we want to wait up to 30 minutes for the kibana pods to become ready?","commit_id":"e560a53df0248e4c10db21d0113f380b4b6794da"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"aa2b1182a8db54f60295b45fae1dd93a5a948e05","unresolved":true,"context_lines":[{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n {{ .Release.Namespace }} -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":"  ((count++))"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"4c976a62_bb876b2c","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":28},"in_reply_to":"1d38f464_e7db9211","updated":"2021-08-23 17:51:40.000000000","message":"I saw a case that goes up to 12+ mins for downstream when we have 3 pod instances. So, this 30 mins in just a little bit of padding.  But for upstream with only one instance, it usually comes up in a few minutes.","commit_id":"e560a53df0248e4c10db21d0113f380b4b6794da"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"6b2ef81e1c2f82e094ec9091494078d4f1fa60ee","unresolved":true,"context_lines":[{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n {{ .Release.Namespace }} -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":"  ((count++))"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"b934b6fe_032736b2","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":28},"in_reply_to":"22a6abb8_a3fba0fd","updated":"2021-08-23 18:57:29.000000000","message":"I will put a \"break\" to let it fall thru.\nAlso, keep in mind this script does not extend the kibana deployment time to become longer. It tries its best effort to wait for kibana deployment to complete and in the end gives up.  If it has to wait for this long, the kibana pods deployment already has issue.","commit_id":"e560a53df0248e4c10db21d0113f380b4b6794da"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"989d540e1294a2f05598e3ae73659246960db98b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"count\u003d1"},{"line_number":20,"context_line":"while [[ $(kubectl get pods -n {{ .Release.Namespace }} -l application\u003dkibana,component\u003ddashboard -o \u0027jsonpath\u003d{..status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027) \u003d~ \"False\" ]]; do"},{"line_number":21,"context_line":"  sleep 30"},{"line_number":22,"context_line":"  if [[ $count -eq 60 ]]; then"},{"line_number":23,"context_line":"    echo \"Timed out waiting for all Kibana pods to become Ready, proceed to create index patterns.\""},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":"  ((count++))"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"22a6abb8_a3fba0fd","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":28},"in_reply_to":"4c976a62_bb876b2c","updated":"2021-08-23 18:03:42.000000000","message":"so this is potentially 30s x 60 \u003d 1800s wait we are potentially adding?  but at the end, even when it times out, you are just going to proceed to create the index patterns, then why wait that long at all?  what does it break otherwise?\n\nSpeaking of \"break\", you probably need to add a break statement here somewhere after echo.","commit_id":"e560a53df0248e4c10db21d0113f380b4b6794da"}]}