)]}'
{"id":"openstack%2Fopenstack-helm-infra~811826","triplet_id":"openstack%2Fopenstack-helm-infra~master~I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d","project":"openstack/openstack-helm-infra","branch":"master","topic":"ceph-osd-apply-job-labels","hashtags":[],"change_id":"I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d","subject":"Helm 3 - Fix Job labels","status":"MERGED","created":"2021-09-30 02:25:03.000000000","updated":"2021-09-30 23:57:29.000000000","submitted":"2021-09-30 23:56:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"811826-ceph-osd-apply-job-labels","meta_rev_id":"1af2714b10b530979c79eed6efd878490eca83c7","_number":811826,"virtual_id_number":811826,"owner":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-30 23:56:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-09-30 23:05:32.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":2,"date":"2021-09-30 22:06:02.000000000","_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-09-30 23:05:32.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-30 04:00:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-30 22:06:02.000000000","updated_by":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"reviewer":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"state":"REVIEWER"},{"updated":"2021-09-30 23:05:32.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"}],"messages":[{"id":"acdcc41d07c7de31f944656be3624862696fd3a1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 02:25:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a375eeba87021f7cd3b5f475001a212f2e4deec2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 03:05:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9befa2c7ba4459fd43366bed22617636b07e6693","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 03:07:29.000000000","message":"Topic ceph-osd-apply-job-labels removed","accounts_in_message":[],"_revision_number":2},{"id":"cc6fad1e6f9c8759ce43cf40c86c11559720ff2c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 04:00:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/86bae927878147d39590c5e3679475fd : SUCCESS in 5m 42s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/baafa05202184c3a82ea223da38ada0d : FAILURE in 4m 41s\n- openstack-helm-infra-deploy https://zuul.opendev.org/t/openstack/build/60e1bb0267154d7a9fdbf2334cb149cf : SUCCESS in 8m 40s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/dfdc8e165dde4054990d64deaf162154 : SUCCESS in 36m 42s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/3521d20f58034f97a5ee77cad818df2d : SUCCESS in 29m 19s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/72bf901ccfa148c5852753c94137fa43 : SUCCESS in 48m 32s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/04277f84385a48369e322906a55d6ab2 : SUCCESS in 47m 35s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/08e8cad684b540918d0ab00bba50fd1f : SUCCESS in 17m 00s","accounts_in_message":[],"_revision_number":2},{"id":"2d34322181045e09909bf39a030c5350e98e5c71","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 13:07:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"398b8e1116e46bf6ba97d4bb11850c24eaf63f87","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 13:22:38.000000000","message":"Topic ceph-osd-apply-job-labels removed","accounts_in_message":[],"_revision_number":3},{"id":"b50f24fc2441bbcffbcdfd038b4e1bf3e36f75e6","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 13:23:15.000000000","message":"Topic set to helm3-job-labels","accounts_in_message":[],"_revision_number":3},{"id":"0b843efd35e490e3661b3987237d7563b821af8b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 13:59:00.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a03f7f38bd084dcdbc458dcdf4a7194e : SUCCESS in 3m 57s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/0f07877ff3024c169e2b4574f1d70b79 : FAILURE in 3m 42s\n- openstack-helm-infra-deploy https://zuul.opendev.org/t/openstack/build/e0b1d218aab84e2c935b726a60f52454 : SUCCESS in 6m 07s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/53772bd292204a45a609187da053b1ea : SUCCESS in 39m 26s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/e425c7f1f3bf4812a0a56d0547c5577d : SUCCESS in 26m 33s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/6315e1281a9145a69ed8ef8d8a357569 : SUCCESS in 47m 20s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/1864a8396460465d988a3a960a757f50 : SUCCESS in 47m 26s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/b972834ceb6247b684aef7f9b97da328 : SUCCESS in 14m 24s","accounts_in_message":[],"_revision_number":3},{"id":"a932e2cde457217e09921db59b6441414b1af84f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 19:25:32.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"05ad1cba7d3d25199e583418723816de4a1ddbd5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 20:16:48.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ef0b381c2dc49a6bf307fa32e20c9f2 : SUCCESS in 3m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/72234d1d6ac140e1ac0c93f2a69928c8 : FAILURE in 3m 24s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/cf094b72a2ec48a89fde1c68b6aca242 : SUCCESS in 4m 28s\n- openstack-helm-infra-deploy https://zuul.opendev.org/t/openstack/build/a954f24015864b479e484f1935f5ad72 : SUCCESS in 6m 13s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/2d68219fba4c418eb831184d68e1c189 : SUCCESS in 37m 21s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/b8a323b5214d4f3d8a2792da08d2d844 : SUCCESS in 25m 42s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/e3683f57caf541538474b25ed6220132 : SUCCESS in 47m 20s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/66bf47bfbde648ef9d876501c8d5e0a1 : SUCCESS in 45m 55s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/5b7df671591f455ba22a74bb9e029e14 : SUCCESS in 13m 31s","accounts_in_message":[],"_revision_number":4},{"id":"1e7f1df18afc1e13cf197498fd7c67c12555f1b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"date":"2021-09-30 21:01:57.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"abdd546e13647c763444ad0725e251fa72f92c4f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 21:55:35.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e4e4cde7f974fc299877bef313e6af2 : SUCCESS in 3m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5dd7afeaa7e64beb8e81d8d788153a96 : SUCCESS in 3m 41s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/9aa5554bbb0c481883cc0d597954252f : SUCCESS in 4m 39s\n- openstack-helm-infra-deploy https://zuul.opendev.org/t/openstack/build/adcc54e220ce40368d61c89c17484d46 : SUCCESS in 6m 14s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/939e92c17d7a46e2baa48b2d3e82b960 : SUCCESS in 37m 26s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/0e198af0f102438081384bf10aa44c6d : SUCCESS in 26m 06s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/35dc144f5cf944ab9c9b2d0562fcd5e6 : SUCCESS in 49m 07s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/cfbc7b6a19db43daa0fa1fcd6e192863 : SUCCESS in 48m 17s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/91e4d13b3ddb4538a47c3ad12fddd691 : SUCCESS in 14m 18s","accounts_in_message":[],"_revision_number":5},{"id":"04af7a522fd51d8ac19b94ccf914e527993f7652","author":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"date":"2021-09-30 22:06:02.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"7da54e0878ae94a9f14b9dd61bf0624f647db66a","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-09-30 23:05:32.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"2a3c343a30a93e5d867bd6be139bda7b3e962b28","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 23:05:53.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"f0fe96552bd860a412242dd4eadc96af684d098f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 23:56:04.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91a8351c5eca4c7eb229d70e451a631f : SUCCESS in 4m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2ba195e747f64142b2babe26fcb95639 : SUCCESS in 4m 43s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/ce3bec7d7b0a442c82e271490fec398d : SUCCESS in 4m 59s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/f0826672c8ba4cb5b9b23b4104533c33 : SUCCESS in 42m 23s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/9762c33abf354525b85b30afc50d2ba4 : SUCCESS in 27m 45s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/6952dc1d40f04a7d8bec6c60681ebaa9 : SUCCESS in 47m 24s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/5b2da5abd0784d48a83a6c3dc7362c0d : SUCCESS in 50m 00s","accounts_in_message":[],"_revision_number":5},{"id":"2601e0048ff19a3fc0c4326936f27f2875a92fd8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 23:56:04.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"1af2714b10b530979c79eed6efd878490eca83c7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 23:57:29.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9f46ac84bb7f4c48bab3d23c239f5b4e : SUCCESS in 54s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b8af864b9f3e433eaf935a2ef43b3d72 : SUCCESS in 52s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b1a247e7f54ab12d830ab74f7634457b4e43f3ef","revisions":{"b04ea516980bfb6de05cc9ae3580b75a22720539":{"kind":"REWORK","_number":1,"created":"2021-09-30 02:25:03.000000000","uploader":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"ref":"refs/changes/26/811826/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/26/811826/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/1"}}},"commit":{"parents":[{"commit":"0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda","subject":"Merge \"feat(helm-toolkit): allow setting extra labels on pods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda"}]}],"author":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-29 21:33:44.000000000","tz":-300},"committer":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-29 21:33:44.000000000","tz":-300},"subject":"Helm 3 Support: Fix HTK Jobs labels","message":"Helm 3 Support: Fix HTK Jobs labels\n\nIf labels are not specified on a Job, kubernete\u0027s defaults them\nto include the labels of their underlying pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying pod template\u0027s labels. Job labels are\ndepended on by:\n\n- Armada pre-upgrade delete hookbs\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nand likely other places. Thus this adds matching labels to the Jobs\nin HTK so that dependent charts can integrate them.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b04ea516980bfb6de05cc9ae3580b75a22720539"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b04ea516980bfb6de05cc9ae3580b75a22720539"}]},"branch":"refs/heads/master"},"2304d55e8d3fadd56abe8473797b3ae7d415c4d6":{"kind":"REWORK","_number":2,"created":"2021-09-30 03:05:50.000000000","uploader":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"ref":"refs/changes/26/811826/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/26/811826/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/2"}}},"commit":{"parents":[{"commit":"0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda","subject":"Merge \"feat(helm-toolkit): allow setting extra labels on pods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda"}]}],"author":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-29 21:33:44.000000000","tz":-300},"committer":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-30 03:03:28.000000000","tz":-300},"subject":"Helm 3: Fix Job labels","message":"Helm 3: Fix Job labels\n\nIf labels are not specified on a Job, kubernetes defaults them\nto include the labels of their underlying Pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying Pod template\u0027s labels. This is a\nproblem since Job labels are depended on by\n- Armada pre-upgrade delete hooks\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nThus for each Job template this adds labels matching the\nunderlying Pod template to retain the same labels that were\npresent with Helm 2.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2304d55e8d3fadd56abe8473797b3ae7d415c4d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2304d55e8d3fadd56abe8473797b3ae7d415c4d6"}]},"branch":"refs/heads/master"},"f7fadb70bf71d029108ecfb60e39442cbe17bb41":{"kind":"REWORK","_number":3,"created":"2021-09-30 13:07:17.000000000","uploader":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"ref":"refs/changes/26/811826/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/26/811826/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/3"}}},"commit":{"parents":[{"commit":"0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda","subject":"Merge \"feat(helm-toolkit): allow setting extra labels on pods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda"}]}],"author":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-29 21:33:44.000000000","tz":-300},"committer":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-30 13:07:01.000000000","tz":-300},"subject":"Helm 3: Fix Job labels","message":"Helm 3: Fix Job labels\n\nIf labels are not specified on a Job, kubernetes defaults them\nto include the labels of their underlying Pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying Pod template\u0027s labels. This is a\nproblem since Job labels are depended on by\n- Armada pre-upgrade delete hooks\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nThus for each Job template this adds labels matching the\nunderlying Pod template to retain the same labels that were\npresent with Helm 2.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/f7fadb70bf71d029108ecfb60e39442cbe17bb41"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/f7fadb70bf71d029108ecfb60e39442cbe17bb41"}]},"branch":"refs/heads/master"},"bac2ab31cca064fb238dc75f123666174a3e21bf":{"kind":"REWORK","_number":4,"created":"2021-09-30 19:25:32.000000000","uploader":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"ref":"refs/changes/26/811826/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/26/811826/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/4"}}},"commit":{"parents":[{"commit":"0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda","subject":"Merge \"feat(helm-toolkit): allow setting extra labels on pods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda"}]}],"author":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-29 21:33:44.000000000","tz":-300},"committer":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-30 19:25:19.000000000","tz":-300},"subject":"Helm 3: Fix Job labels","message":"Helm 3: Fix Job labels\n\nIf labels are not specified on a Job, kubernetes defaults them\nto include the labels of their underlying Pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying Pod template\u0027s labels. This is a\nproblem since Job labels are depended on by\n- Armada pre-upgrade delete hooks\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nThus for each Job template this adds labels matching the\nunderlying Pod template to retain the same labels that were\npresent with Helm 2.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/bac2ab31cca064fb238dc75f123666174a3e21bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/bac2ab31cca064fb238dc75f123666174a3e21bf"}]},"branch":"refs/heads/master"},"b1a247e7f54ab12d830ab74f7634457b4e43f3ef":{"kind":"REWORK","_number":5,"created":"2021-09-30 21:01:57.000000000","uploader":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"ref":"refs/changes/26/811826/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/26/811826/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/26/811826/5"}}},"commit":{"parents":[{"commit":"0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda","subject":"Merge \"feat(helm-toolkit): allow setting extra labels on pods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0fa7e0fb7e69de7d4352f047531ccfbd2c11ecda"}]}],"author":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-29 21:33:44.000000000","tz":-300},"committer":{"name":"Sean Eagan","email":"seaneagan1@gmail.com","date":"2021-09-30 21:01:31.000000000","tz":-300},"subject":"Helm 3 - Fix Job labels","message":"Helm 3 - Fix Job labels\n\nIf labels are not specified on a Job, kubernetes defaults them\nto include the labels of their underlying Pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying Pod template\u0027s labels. This is a\nproblem since Job labels are depended on by\n- Armada pre-upgrade delete hooks\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nThus for each Job template this adds labels matching the\nunderlying Pod template to retain the same labels that were\npresent with Helm 2.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b1a247e7f54ab12d830ab74f7634457b4e43f3ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b1a247e7f54ab12d830ab74f7634457b4e43f3ef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}