)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"81d8dac342eb513eea14d0809cc30f85fbb77408","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove helm status from deployment scripts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the move to helm v3, helm status requires a namespace to be specified, but doing so breaks helm v2 compatability. In order to preserve our gating with both versions of helm while we make the change from v2 to v3, this change removes the usage of helm serve in openstack-helm\u0027s deployment scripts."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Once we fully move to helm v3, these scripts can be improved and cleaned up to be more compatible with the new v3 syntax."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idd97b6c8d2531c8cd55629a3ce91b2581af904f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"44119622_a335d86f","line":11,"range":{"start_line":9,"start_character":2,"end_line":11,"end_character":121},"updated":"2021-10-13 15:09:58.000000000","message":"reflow?","commit_id":"98a4c73a0b828bb51c37c8cdbe2ce05f3a6a1854"},{"author":{"_account_id":34017,"name":"jayonlau","display_name":"jinyuanliu","email":"jayonlau@gmail.com","username":"lau"},"change_message_id":"ff8d6979a5fe87cca21c3ff1a8bba856b54b47ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove helm status from deployment scripts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the move to helm v3, helm status requires a namespace to be specified, but doing so breaks helm v2 compatability. In order to preserve our gating with both versions of helm while we make the change from v2 to v3, this change removes the usage of helm serve in openstack-helm\u0027s deployment scripts."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Once we fully move to helm v3, these scripts can be improved and cleaned up to be more compatible with the new v3 syntax."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idd97b6c8d2531c8cd55629a3ce91b2581af904f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b320368f_35f25328","line":11,"range":{"start_line":9,"start_character":2,"end_line":11,"end_character":121},"in_reply_to":"44119622_a335d86f","updated":"2021-10-13 16:06:41.000000000","message":"Done","commit_id":"98a4c73a0b828bb51c37c8cdbe2ce05f3a6a1854"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"change_message_id":"0c69c8ab6297bce2d79210f5a47017525aad57bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3851c32e_37329914","updated":"2021-10-13 15:33:28.000000000","message":"This feels like we are taking out the \"helm status\" function to support Helm 2 which is EOL. Would it make more sense to put an if-statement to detect the helm version to support both Helm 2 and 3 if we still care for helm 2?","commit_id":"98a4c73a0b828bb51c37c8cdbe2ce05f3a6a1854"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"81d8dac342eb513eea14d0809cc30f85fbb77408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ceec7cd8_3be7c1eb","updated":"2021-10-13 15:09:58.000000000","message":"i wonder if we can\u0027t break this into smaller PS?\n","commit_id":"98a4c73a0b828bb51c37c8cdbe2ce05f3a6a1854"},{"author":{"_account_id":34017,"name":"jayonlau","display_name":"jinyuanliu","email":"jayonlau@gmail.com","username":"lau"},"change_message_id":"304a1a1f8df9a1169dc8cbdd0c2e0c2ef82e86a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f69bf181_b7629389","in_reply_to":"3851c32e_37329914","updated":"2021-10-13 16:05:33.000000000","message":"Helm2 is a very old version, and there seems to be no need to deal with it\n\nGagehugo\u0027s PS has been merged\nhttps://review.opendev.org/c/openstack/openstack-helm/ +/813313","commit_id":"98a4c73a0b828bb51c37c8cdbe2ce05f3a6a1854"},{"author":{"_account_id":34017,"name":"jayonlau","display_name":"jinyuanliu","email":"jayonlau@gmail.com","username":"lau"},"change_message_id":"304a1a1f8df9a1169dc8cbdd0c2e0c2ef82e86a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e63d80dd_6b378598","in_reply_to":"ceec7cd8_3be7c1eb","updated":"2021-10-13 16:05:33.000000000","message":"sure, I can change it according to the type.","commit_id":"98a4c73a0b828bb51c37c8cdbe2ce05f3a6a1854"}]}