)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"62dbca7d14692f2b7b4e24196df7f3b34e682018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5cc9f4bd_3cf10571","updated":"2021-10-26 14:35:03.000000000","message":"These are really nice improvements, thanks Phil!","commit_id":"a1f195a62deb2d92f3e4db1f950783d5d848cb96"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"9705648cc9c1d51578ec062bd50664c175b7cb45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ed881543_36684854","updated":"2021-10-28 19:04:12.000000000","message":"recheck","commit_id":"732df8ac86bbe00e3e8188470e9133933657e11b"}],"ceph-client/templates/job-ns-client-ceph-config.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"62dbca7d14692f2b7b4e24196df7f3b34e682018","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1c843bfb_3fcbaa28","updated":"2021-10-26 14:35:03.000000000","message":"This job isn\u0027t used downstream, and although it is used by the upstream gates, I\u0027m not sure it\u0027s a necessary job. I\u0027ll investigate a bit more..","commit_id":"a1f195a62deb2d92f3e4db1f950783d5d848cb96"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"0ab8347dd791cc786dd011768dbccba47c2578b7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"67ab414f_48a1f490","in_reply_to":"1c843bfb_3fcbaa28","updated":"2021-10-26 15:42:42.000000000","message":"Thanks, let me know. I went down a bit of a rabbit hole with this, but if it isn\u0027t needed I have no problem abandoning. The lifecycle of ceph.conf in the different ceph charts is a bit confusing.","commit_id":"a1f195a62deb2d92f3e4db1f950783d5d848cb96"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"9756ff48694ab7ed578974213361bf09f2110681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ce98da0d_42bf69eb","in_reply_to":"67ab414f_48a1f490","updated":"2021-10-26 16:53:40.000000000","message":"No need to abandon. These changes are needed. In fact, we could do similar improvements for the other ceph components as well (mostly talking about the use of a common snippet instead of having repeated code everywhere). If the job isn\u0027t needed, we can remove it later.","commit_id":"a1f195a62deb2d92f3e4db1f950783d5d848cb96"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"a598080f5da556fd16bb96ae4b23e6278c547d97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8fe4525a_124a12d9","in_reply_to":"ce98da0d_42bf69eb","updated":"2021-10-28 16:53:08.000000000","message":"\u003e This job isn\u0027t used downstream, and although it is used by the upstream gates, I\u0027m not sure it\u0027s a necessary job. I\u0027ll investigate a bit more..\n\nActually it turns out that setting manifests.job_ns_client_ceph_config\u003dfalse causes a rendering failure because of the leading \"---\" and trailing \"...\", so the job probably does need to be fixed, or removed if it isn\u0027t necessary.","commit_id":"a1f195a62deb2d92f3e4db1f950783d5d848cb96"}]}