)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"bc0dc0db7424e09d7350970f852a5f67414c1f39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea9f5634_54516991","updated":"2021-11-09 19:38:58.000000000","message":"Do we need to create a separate configmap for this instead of using the existing dashboards yaml/loop? (eg https://opendev.org/openstack/openstack-helm-infra/src/branch/master/grafana/templates/deployment.yaml#L123-L127)\n\nIf so, we\u0027ll need to add the volume/volumeMount for this new configmap in the grafana deployment\n","commit_id":"f52d9d643b7f4e500823c552dbda54944b8aa0ef"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"328d3b84e7534dae3129109ccfb070ded169a756","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"233fcc02_f1680e71","in_reply_to":"ea9f5634_54516991","updated":"2021-11-09 19:54:37.000000000","message":"Yes, I found out I missed the volume mount right after I uploaded the first ps.\n\nWe do need a separate configmap because the existing configmap which has all the dashboards is getting hugh, exceed the limit of 1M (1048576).  Here is the deployment error from alertmanger experience:\n\n[pod/armada-api-77fb6f6c47-dfppm/armada-api] 2021-07-31 04:18:15.573 10 ERROR armada.handlers.tiller \tdebug_error_string \u003d \"{\"created\":\"@1627705095.573657322\",\"description\":\"Error received from peer ipv4:127.0.0.1:24134\",\"file\":\"src/core/lib/surface/call.cc\",\"file_line\":1066,\"grpc_message\":\"release clcp-grafana failed: ConfigMap \"grafana-dashboards\" is invalid: []: Too long: must have at most 1048576 bytes\",\"grpc_status\":2}\"","commit_id":"f52d9d643b7f4e500823c552dbda54944b8aa0ef"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"60b5f04fac90dbb3d8e8df75c822e5bbe2aa045c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d516aec_e50c5c25","updated":"2021-11-09 20:26:19.000000000","message":"Oh, I see. Instead of creating new yaml definitions under values.conf, can we look at extending the existing dashboards {} object so that it supports creating multiple configmaps per \"group\" of dashboards? Something like this?\n\n```\n# values.yaml\nconf:\n  dashboards:\n    openstack:\n      nova: |-\n        ...\n      neutron: |-\n        ...\n    ceph:\n      cluster: |-\n        ...\n      osds: |-\n        ...\n\n# configmap-dashboards.yaml\n{{ range $section $dashboards :\u003d .Values.conf.dashboards }}\n---\napiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: grafana-dashboards-{{ $section }}\ndata:\n{{ range $name $data :\u003d $dashboards }}\n  {{$name}}.json: {{ $data | toJson }}\n{{ end }}\n{{ end }}\n```","commit_id":"bfc4e8b8eeae19cc3f4abd852b1e8d065127eae3"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"5ae579f5e6f500dfd0ccd5dd40f8c3a34e7d709d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bb29b98_d7c8dc61","in_reply_to":"5d516aec_e50c5c25","updated":"2021-11-09 23:07:53.000000000","message":"will experiment with this approach","commit_id":"bfc4e8b8eeae19cc3f4abd852b1e8d065127eae3"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"994b81d21b38cd3b22e8b943661451ff6108c0f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"67356cb4_8947e6e4","updated":"2021-11-10 02:10:13.000000000","message":"recheck","commit_id":"ee09c2a6734271f0a055e9c96d500a2f5fa8a832"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"e544180e446f2f5430f8f5c8121532b8c55687c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"eb55b698_c07af4a8","updated":"2021-11-10 20:57:38.000000000","message":"LGTM, but one nit though:","commit_id":"1f082e8d738ffa2ef90661d77ef56f10b6e4ef83"}],"grafana/values.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"e544180e446f2f5430f8f5c8121532b8c55687c9","unresolved":true,"context_lines":[{"line_number":367,"context_line":"  configmap_bin: true"},{"line_number":368,"context_line":"  configmap_etc: true"},{"line_number":369,"context_line":"  configmap_dashboards: true"},{"line_number":370,"context_line":"  configmap_dashboards_alertmanager: false"},{"line_number":371,"context_line":"  deployment: true"},{"line_number":372,"context_line":"  ingress: true"},{"line_number":373,"context_line":"  helm_tests: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f35cd1cb_da120320","line":370,"range":{"start_line":370,"start_character":2,"end_line":370,"end_character":42},"updated":"2021-11-10 20:57:38.000000000","message":"nit: Can be removed too","commit_id":"1f082e8d738ffa2ef90661d77ef56f10b6e4ef83"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"2ab735752d56e6ad6a1e7c3a085222ef5a4a8ae4","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  configmap_bin: true"},{"line_number":368,"context_line":"  configmap_etc: true"},{"line_number":369,"context_line":"  configmap_dashboards: true"},{"line_number":370,"context_line":"  configmap_dashboards_alertmanager: false"},{"line_number":371,"context_line":"  deployment: true"},{"line_number":372,"context_line":"  ingress: true"},{"line_number":373,"context_line":"  helm_tests: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fb3c904b_d360ef70","line":370,"range":{"start_line":370,"start_character":2,"end_line":370,"end_character":42},"in_reply_to":"271f0b4f_8cd3b914","updated":"2021-11-10 21:13:24.000000000","message":"Cool, thanks!","commit_id":"1f082e8d738ffa2ef90661d77ef56f10b6e4ef83"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b7a3bdeefdae9cb367dbe5599607b3d937caf3fb","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  configmap_bin: true"},{"line_number":368,"context_line":"  configmap_etc: true"},{"line_number":369,"context_line":"  configmap_dashboards: true"},{"line_number":370,"context_line":"  configmap_dashboards_alertmanager: false"},{"line_number":371,"context_line":"  deployment: true"},{"line_number":372,"context_line":"  ingress: true"},{"line_number":373,"context_line":"  helm_tests: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"271f0b4f_8cd3b914","line":370,"range":{"start_line":370,"start_character":2,"end_line":370,"end_character":42},"in_reply_to":"f35cd1cb_da120320","updated":"2021-11-10 21:03:44.000000000","message":"will remove","commit_id":"1f082e8d738ffa2ef90661d77ef56f10b6e4ef83"}]}