)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"10e25af939d8882d6d4ad0080ab12ffd352639e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2693a69d_5e2b0f25","updated":"2022-02-10 23:12:56.000000000","message":"LGTM - just one minor comment - may want to run the new script through shellcheck if you haven\u0027t already - it\u0027s helped me discover issues in the past that I didn\u0027t think were there.","commit_id":"ae17a61836c8d4d0b7e12bdf1b433b78c9afe24c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"36b4eaace174000ad68f545f28ace225eebad0b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"68d41bc7_df172ba9","updated":"2022-02-10 20:31:27.000000000","message":"recheck","commit_id":"ae17a61836c8d4d0b7e12bdf1b433b78c9afe24c"}],"ceph-mon/templates/bin/_post-apply.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"10e25af939d8882d6d4ad0080ab12ffd352639e5","unresolved":true,"context_lines":[{"line_number":68,"context_line":"     updatedNumberScheduled\u003d`echo $ds_query|jq -r .updatedNumberScheduled`"},{"line_number":69,"context_line":"     ds_check\u003d`echo \"$currentNumberScheduled $desiredNumberScheduled $numberAvailable $numberReady $updatedNumberScheduled\"| \\"},{"line_number":70,"context_line":"       tr \u0027 \u0027 \u0027\\n\u0027|sort -u|wc -l`"},{"line_number":71,"context_line":"     if [ $ds_check !\u003d 1 ]; then"},{"line_number":72,"context_line":"       echo \"Some pods in daemonset $ds are not ready\""},{"line_number":73,"context_line":"       exit"},{"line_number":74,"context_line":"     else"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"f84877e9_df00f470","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":24},"updated":"2022-02-10 23:12:56.000000000","message":"The operands in this check should probably be in quotes since we\u0027re comparing 2 strings. Was shellcheck ok with this?","commit_id":"ae17a61836c8d4d0b7e12bdf1b433b78c9afe24c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"011e1d1d276222441e93457a722743b80ff3eb40","unresolved":false,"context_lines":[{"line_number":68,"context_line":"     updatedNumberScheduled\u003d`echo $ds_query|jq -r .updatedNumberScheduled`"},{"line_number":69,"context_line":"     ds_check\u003d`echo \"$currentNumberScheduled $desiredNumberScheduled $numberAvailable $numberReady $updatedNumberScheduled\"| \\"},{"line_number":70,"context_line":"       tr \u0027 \u0027 \u0027\\n\u0027|sort -u|wc -l`"},{"line_number":71,"context_line":"     if [ $ds_check !\u003d 1 ]; then"},{"line_number":72,"context_line":"       echo \"Some pods in daemonset $ds are not ready\""},{"line_number":73,"context_line":"       exit"},{"line_number":74,"context_line":"     else"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"40f6272a_0546c2f1","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":24},"in_reply_to":"a51a5a30_94dd8b31","updated":"2022-02-11 20:01:52.000000000","message":"Ack","commit_id":"ae17a61836c8d4d0b7e12bdf1b433b78c9afe24c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"06e029ec982519ac197305c13511f05ee7977459","unresolved":true,"context_lines":[{"line_number":68,"context_line":"     updatedNumberScheduled\u003d`echo $ds_query|jq -r .updatedNumberScheduled`"},{"line_number":69,"context_line":"     ds_check\u003d`echo \"$currentNumberScheduled $desiredNumberScheduled $numberAvailable $numberReady $updatedNumberScheduled\"| \\"},{"line_number":70,"context_line":"       tr \u0027 \u0027 \u0027\\n\u0027|sort -u|wc -l`"},{"line_number":71,"context_line":"     if [ $ds_check !\u003d 1 ]; then"},{"line_number":72,"context_line":"       echo \"Some pods in daemonset $ds are not ready\""},{"line_number":73,"context_line":"       exit"},{"line_number":74,"context_line":"     else"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"a51a5a30_94dd8b31","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":24},"in_reply_to":"f84877e9_df00f470","updated":"2022-02-11 14:43:18.000000000","message":"I didn\u0027t run shellcheck on this. I just copied the script from the ceph-osd chart and made some modifications. In this case the strings are both numbers and the comparison should be fine due to the lack of whitespace in the strings, but ideally this should be changed to a -ne numeric comparison.\n\nI was thinking that it would be good to clean up both scripts in a separate change to address some of these issues.","commit_id":"ae17a61836c8d4d0b7e12bdf1b433b78c9afe24c"}]}