)]}'
{"helm-toolkit/templates/scripts/db-backup-restore/_backup_main.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"4001a80053c1c204b1c59f33348da734ea19bbc9","unresolved":true,"context_lines":[{"line_number":309,"context_line":"          if [[ $? -ne 0 ]]; then"},{"line_number":310,"context_line":"            # Log error but don\u0027t exit so we can finish the script"},{"line_number":311,"context_line":"            # because at this point we haven\u0027t sent backup to RGW yet"},{"line_number":312,"context_line":"            log ERROR \"${DB_NAME}_backup\" \"Failed to cleanup local backup. Cannot remove some of ${ARCHIVE_FILE}\""},{"line_number":313,"context_line":"          fi"},{"line_number":314,"context_line":"      fi"},{"line_number":315,"context_line":"    done"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"948e6cf6_67bb8e54","line":312,"range":{"start_line":312,"start_character":89,"end_line":312,"end_character":97},"updated":"2022-02-18 23:36:07.000000000","message":"Can\u0027t remove some of it?","commit_id":"0da2ebdcad3e7406545a9e67e2d7f3015de2dfb0"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"6b544d302a76ff376e62e2876937c754eabf100d","unresolved":false,"context_lines":[{"line_number":309,"context_line":"          if [[ $? -ne 0 ]]; then"},{"line_number":310,"context_line":"            # Log error but don\u0027t exit so we can finish the script"},{"line_number":311,"context_line":"            # because at this point we haven\u0027t sent backup to RGW yet"},{"line_number":312,"context_line":"            log ERROR \"${DB_NAME}_backup\" \"Failed to cleanup local backup. Cannot remove some of ${ARCHIVE_FILE}\""},{"line_number":313,"context_line":"          fi"},{"line_number":314,"context_line":"      fi"},{"line_number":315,"context_line":"    done"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"061d7f5e_fe41b72e","line":312,"range":{"start_line":312,"start_character":89,"end_line":312,"end_character":97},"in_reply_to":"948e6cf6_67bb8e54","updated":"2022-02-18 23:40:23.000000000","message":"Oh, I see what is meant - could be deleting multiple backups from that day.","commit_id":"0da2ebdcad3e7406545a9e67e2d7f3015de2dfb0"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"10ab160f301e26c5d3d88f8e6b52bb15e359dcaf","unresolved":true,"context_lines":[{"line_number":267,"context_line":"# +------------+---------------------------------------------------------------------------------------------------------+"},{"line_number":268,"context_line":"# | 6253434567 | \"tmp/mysql.backup.manual.2022-02-01T10:13:13Z.tar.gz\"                                                   |"},{"line_number":269,"context_line":"# +------------+---------------------------------------------------------------------------------------------------------+"},{"line_number":270,"context_line":"# We will use the explained above data stracture to cover rare, but still"},{"line_number":271,"context_line":"# possible case, when we have several backups of the same date. E.g."},{"line_number":272,"context_line":"# one manual, and one automatic."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"declare -A FILETABLE"},{"line_number":275,"context_line":"create_hash_table() {"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"34b402b3_9ac30992","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":32},"updated":"2022-02-28 20:58:08.000000000","message":"Consider removing this as backup can be scheduled to run multiple times per day.","commit_id":"1da245f608a9ed35450f7cb7a779e6706126fc15"},{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"b1421d9c41667414649f0811655fb289ac3b755e","unresolved":false,"context_lines":[{"line_number":267,"context_line":"# +------------+---------------------------------------------------------------------------------------------------------+"},{"line_number":268,"context_line":"# | 6253434567 | \"tmp/mysql.backup.manual.2022-02-01T10:13:13Z.tar.gz\"                                                   |"},{"line_number":269,"context_line":"# +------------+---------------------------------------------------------------------------------------------------------+"},{"line_number":270,"context_line":"# We will use the explained above data stracture to cover rare, but still"},{"line_number":271,"context_line":"# possible case, when we have several backups of the same date. E.g."},{"line_number":272,"context_line":"# one manual, and one automatic."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"declare -A FILETABLE"},{"line_number":275,"context_line":"create_hash_table() {"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"72490dd3_51f5b87b","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":32},"in_reply_to":"34b402b3_9ac30992","updated":"2022-02-28 21:17:19.000000000","message":"Agree. Probably, could be done as a \u0027code clean-up\u0027","commit_id":"1da245f608a9ed35450f7cb7a779e6706126fc15"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"10ab160f301e26c5d3d88f8e6b52bb15e359dcaf","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        log INFO \"${DB_NAME}_backup\" \"Keeping file(s) ${ARCHIVE_FILE}.\""},{"line_number":305,"context_line":"      else"},{"line_number":306,"context_line":"        log INFO \"${DB_NAME}_backup\" \"Deleting file(s) ${ARCHIVE_FILE}.\""},{"line_number":307,"context_line":"          rm -rf $ARCHIVE_FILE"},{"line_number":308,"context_line":"          if [[ $? -ne 0 ]]; then"},{"line_number":309,"context_line":"            # Log error but don\u0027t exit so we can finish the script"},{"line_number":310,"context_line":"            # because at this point we haven\u0027t sent backup to RGW yet"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"e1a83736_133cb527","line":307,"range":{"start_line":307,"start_character":14,"end_line":307,"end_character":17},"updated":"2022-02-28 20:58:08.000000000","message":"This seems to be existing code, but consider remove \"r\" as it\u0027s dangerous if $ARCHIVE_FILE somehow erroneously set to /","commit_id":"1da245f608a9ed35450f7cb7a779e6706126fc15"},{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"b1421d9c41667414649f0811655fb289ac3b755e","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        log INFO \"${DB_NAME}_backup\" \"Keeping file(s) ${ARCHIVE_FILE}.\""},{"line_number":305,"context_line":"      else"},{"line_number":306,"context_line":"        log INFO \"${DB_NAME}_backup\" \"Deleting file(s) ${ARCHIVE_FILE}.\""},{"line_number":307,"context_line":"          rm -rf $ARCHIVE_FILE"},{"line_number":308,"context_line":"          if [[ $? -ne 0 ]]; then"},{"line_number":309,"context_line":"            # Log error but don\u0027t exit so we can finish the script"},{"line_number":310,"context_line":"            # because at this point we haven\u0027t sent backup to RGW yet"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"43b75107_d83d38c9","line":307,"range":{"start_line":307,"start_character":14,"end_line":307,"end_character":17},"in_reply_to":"e1a83736_133cb527","updated":"2022-02-28 21:17:19.000000000","message":"Agreed, and yes, this line caught my attention, too. However, \u0027-r\u0027 just gets ignored when we are removing files.","commit_id":"1da245f608a9ed35450f7cb7a779e6706126fc15"}]}