)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"58df587dab46cd79fb35188f38a2e07f91797b85","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Lo, Chi (cl566n) \u003ccl566n@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-23 12:25:45 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[CPINF-1171] Removing -x from database backup script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The set -x has produced 6 identical log strings every time the"},{"line_number":10,"context_line":"log_backup_error_exit function is called.  Prometheus is using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8fce0acc_5b4ce725","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":12},"updated":"2022-02-23 22:04:23.000000000","message":"I think this snuck back in","commit_id":"556e4c75d0b497ba302d3b659d6d98a43bf50712"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"12bb6812b1dfba47a8e9481c64444310a2500ae7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lo, Chi (cl566n) \u003ccl566n@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-23 12:25:45 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[CPINF-1171] Removing -x from database backup script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The set -x has produced 6 identical log strings every time the"},{"line_number":10,"context_line":"log_backup_error_exit function is called.  Prometheus is using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8b88421b_65889a87","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":12},"in_reply_to":"8fce0acc_5b4ce725","updated":"2022-02-24 00:11:50.000000000","message":"Ack","commit_id":"556e4c75d0b497ba302d3b659d6d98a43bf50712"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"098f6ad04a1f38fb138174e62e6f6a06cd83744c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6411f6bf_a03a816b","updated":"2022-02-22 23:52:52.000000000","message":"Shouldn\u0027t Prometheus look at the exit code or query the job status for a more reliable indicator?","commit_id":"00cea2a83ccd84a40591937d2d731b8d104f08a6"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bd1d239948e31abd9b81381e327644ec75af622a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d62fce39_53a0186b","updated":"2022-02-22 23:52:33.000000000","message":"cleaning up the output is fine and welcome, but it\u0027s not clear given all the other pods and how things work in these charts that removing -x is the right approach, rightly or wrongly (wrongly, very wrongly) we use that to debug and manage what are extremely fragile poorly tested and debugged script fragments\n\nif the reasoning here being connected to something external which could/should trigger differently is surely more at issue?\n","commit_id":"00cea2a83ccd84a40591937d2d731b8d104f08a6"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ca021abff020348cdfd339619e188350434ee44e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8139903e_f9250e3f","updated":"2022-02-23 15:54:51.000000000","message":"recheck","commit_id":"00cea2a83ccd84a40591937d2d731b8d104f08a6"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"6b33f87862556d5f567c3d96653ec61de0e2320d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48d4364a_9bc61579","in_reply_to":"6411f6bf_a03a816b","updated":"2022-02-23 00:45:38.000000000","message":"No.  Prometheus does not look at exit code or query job status.  Prometheus looks at metrics to determine when alerts need to be fired. If metrics generated by any system is not reliable, then those system needs to be fixed.","commit_id":"00cea2a83ccd84a40591937d2d731b8d104f08a6"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"6b33f87862556d5f567c3d96653ec61de0e2320d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd69e684_59b92309","in_reply_to":"d62fce39_53a0186b","updated":"2022-02-23 00:45:38.000000000","message":"There is a ES exporter that queries ES database and counts the number of backup logs generated that indicate a problem.  Those counts are sent to prometheus as metrics.  Prometheus (based on requirements) determines when to fire alert based on the metrics value received over a period of time.  Mariadb backup job needs to generate ONE log if it encounters a problem each time the job is run, not multiple logs when it means the same problem for each failure event.","commit_id":"00cea2a83ccd84a40591937d2d731b8d104f08a6"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"ba1f6fac0f66b1576d41cc512ca0bdf24f18f13f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d529cd9c_1d46603a","updated":"2022-02-23 18:34:43.000000000","message":"Agreed with Cliff","commit_id":"20462be318792b099183a59a056774a17b7ce64b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"23719dc9b46d2618ab46a633b18c19bd712764e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9dfd097_5216fafd","updated":"2022-02-23 18:35:08.000000000","message":"Just remove the brackets, the title describes it enough IMO","commit_id":"20462be318792b099183a59a056774a17b7ce64b"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"0b894d9f74ebf16195e543a2c42ac32422acf1eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f09442fe_947c4648","updated":"2022-02-23 18:33:10.000000000","message":"Normally we don\u0027t put downstream artifacts like \"CPINF-1171\" into our upstream commits. Maybe replace it with [MariaDBBackup] or something like that..","commit_id":"20462be318792b099183a59a056774a17b7ce64b"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"90ff3509167fc835b84e7269347b0c21c467b6b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e78afca2_e2c8b923","in_reply_to":"d529cd9c_1d46603a","updated":"2022-02-23 18:56:55.000000000","message":"done","commit_id":"20462be318792b099183a59a056774a17b7ce64b"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"90ff3509167fc835b84e7269347b0c21c467b6b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"119c4110_53693a30","in_reply_to":"f9dfd097_5216fafd","updated":"2022-02-23 18:56:55.000000000","message":"done","commit_id":"20462be318792b099183a59a056774a17b7ce64b"}],"helm-toolkit/templates/scripts/db-backup-restore/_backup_main.sh.tpl":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"96eabb9f0eae84f08dc80f85c1db2b569e38d5a4","unresolved":true,"context_lines":[{"line_number":78,"context_line":"#      than the number of days specified by the \"REMOTE_DAYS_TO_KEEP\" variable."},{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Note: not using set -e in this script because more elaborate error handling"},{"line_number":82,"context_line":"# is needed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"log_backup_error_exit() {"},{"line_number":85,"context_line":"  MSG\u003d$1"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"c2bff4f9_f33d3c26","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":12},"updated":"2022-02-23 16:32:51.000000000","message":"This note isn\u0027t really needed now either.","commit_id":"20462be318792b099183a59a056774a17b7ce64b"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"12bb6812b1dfba47a8e9481c64444310a2500ae7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#      than the number of days specified by the \"REMOTE_DAYS_TO_KEEP\" variable."},{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Note: not using set -e in this script because more elaborate error handling"},{"line_number":82,"context_line":"# is needed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"log_backup_error_exit() {"},{"line_number":85,"context_line":"  MSG\u003d$1"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"8f211640_8a7faf1a","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":12},"in_reply_to":"970ebca0_ff954b8d","updated":"2022-02-24 00:11:50.000000000","message":"Done","commit_id":"20462be318792b099183a59a056774a17b7ce64b"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"c477da79a56d57b28670bad0029700cd21c5cdba","unresolved":true,"context_lines":[{"line_number":78,"context_line":"#      than the number of days specified by the \"REMOTE_DAYS_TO_KEEP\" variable."},{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Note: not using set -e in this script because more elaborate error handling"},{"line_number":82,"context_line":"# is needed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"log_backup_error_exit() {"},{"line_number":85,"context_line":"  MSG\u003d$1"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"970ebca0_ff954b8d","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":12},"in_reply_to":"c2bff4f9_f33d3c26","updated":"2022-02-23 17:13:07.000000000","message":"The note talks about -e, not -x.  I think it tries to remind people not to add \"set -e\"","commit_id":"20462be318792b099183a59a056774a17b7ce64b"}]}