)]}'
{"id":"openstack%2Fopenstack-helm-infra~833927","triplet_id":"openstack%2Fopenstack-helm-infra~master~I3b96c688030b581d94348990b30922eced2e3047","project":"openstack/openstack-helm-infra","branch":"master","topic":"libvirt-pid-wrapper","attention_set":{},"removed_from_attention_set":{"8898":{"account":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"last_update":"2022-11-10 17:51:42.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I3b96c688030b581d94348990b30922eced2e3047","subject":"[libvirt] \u0027exec\u0027 to libvirtd even when using secrets","status":"ABANDONED","created":"2022-03-15 22:00:31.000000000","updated":"2022-11-10 17:51:42.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2f0d38210d2b70e85d44dc06ea9ff8035c52e3f7","_number":833927,"virtual_id_number":833927,"owner":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-03-16 05:35:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-03-16 05:24:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-15 22:52:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-03-16 05:24:50.000000000","updated_by":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"reviewer":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"state":"REVIEWER"}],"messages":[{"id":"ce098a2d70f7e355a1e282ee4cb39e90512ffa4d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2022-03-15 22:00:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"496b6148455ee580e398622f7bced6700c6f5f0f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-15 22:52:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/115e740d9331474d89e2cfad2ef10413 : SUCCESS in 5m 56s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/7e9e8ee7612c4819a706a3e52fbdbc37 : FAILURE in 5m 18s\n- openstack-helm-infra-deploy https://zuul.opendev.org/t/openstack/build/ec4675e8238f48f2aa12f13adbd21910 : SUCCESS in 15m 20s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/8043a72dac6d4aa59b05606c685d64f7 : SUCCESS in 35m 10s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/4acb447687f6428aa04219c254f81bb5 : SUCCESS in 31m 13s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/5473f025b7f440548ec6a23570043440 : SUCCESS in 43m 51s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/f6ade1a3a3ea443c8635b942e8be1009 : SUCCESS in 47m 22s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/de17bd5b6432483dbbf615566962a981 : SUCCESS in 17m 28s","accounts_in_message":[],"_revision_number":1},{"id":"0d502e8c5ae08d476676cc91f833a106078a4e67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2022-03-16 04:45:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6eb7594fb7621d7ae31c1bc4dca57011f6a9d06d","author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"date":"2022-03-16 05:24:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"22591d74c8d482fb21bd6bbbf2444ac445a9fc5e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-16 05:35:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6a4a96d7ae6941a8830e97b8a0923e28 : SUCCESS in 4m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/615b848d48f041f080316d8278f3591a : SUCCESS in 5m 30s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/1a665f94a4a14140a944643319c2170c : SUCCESS in 5m 31s\n- openstack-helm-infra-deploy https://zuul.opendev.org/t/openstack/build/4c63b37b0984489093346e94c9523561 : SUCCESS in 13m 03s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/c2b4c15cbc3d403296eff59ada8b3e26 : SUCCESS in 33m 08s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/84c4b8206a4044f9a6d61405f93445ff : SUCCESS in 28m 18s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/89714b059739413aad7d8c1f3fb74112 : SUCCESS in 39m 49s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/444636d6698144cdaffafd22f7e51d80 : SUCCESS in 45m 19s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/c1e120c2d3084a6aba4e0d657f200962 : SUCCESS in 15m 20s","accounts_in_message":[],"_revision_number":2},{"id":"2f0d38210d2b70e85d44dc06ea9ff8035c52e3f7","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2022-11-10 17:51:42.000000000","message":"Abandoned\n\nAuto-abandon: unmergable change is 239 days old.\n\nPlease restore if needed again.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5e4cf86d8f911e875a16d5fc5ead6760b4eb87b8","revisions":{"0163ce99d0034873e04ec37a05f03603c8739ce3":{"kind":"REWORK","_number":1,"created":"2022-03-15 22:00:31.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/27/833927/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/27/833927/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/1"}}},"commit":{"parents":[{"commit":"3a10c5ba95568b18f94e14eb54b5ca4b9268d137","subject":"ingress: Add option to assign VIP as externalIP","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/3a10c5ba95568b18f94e14eb54b5ca4b9268d137"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2022-03-15 21:57:31.000000000","tz":-300},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2022-03-15 21:57:31.000000000","tz":-300},"subject":"[libvirt] \u0027exec\u0027 to libvirtd even when using secrets","message":"[libvirt] \u0027exec\u0027 to libvirtd even when using secrets\n\nwhen \"hostPid: true\" we don\u0027t want the entrypoint process (pid) to be\ndecoupled from libvirtd as breaks libvirtd restarting\n\nthe fix for now is\n\n  * start libvirtd\n  * inject secrets\n  * kill it\n\nthen start it again using \u0027exec\u0027 so the libvirtd is the entrypoint pid\nand container lifesystem should work as expected\n\nChange-Id: I3b96c688030b581d94348990b30922eced2e3047\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0163ce99d0034873e04ec37a05f03603c8739ce3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/0163ce99d0034873e04ec37a05f03603c8739ce3"}]},"branch":"refs/heads/master"},"5e4cf86d8f911e875a16d5fc5ead6760b4eb87b8":{"kind":"REWORK","_number":2,"created":"2022-03-16 04:45:44.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/27/833927/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/27/833927/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/27/833927/2"}}},"commit":{"parents":[{"commit":"3a10c5ba95568b18f94e14eb54b5ca4b9268d137","subject":"ingress: Add option to assign VIP as externalIP","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/3a10c5ba95568b18f94e14eb54b5ca4b9268d137"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2022-03-15 21:57:31.000000000","tz":-300},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2022-03-16 04:45:17.000000000","tz":-300},"subject":"[libvirt] \u0027exec\u0027 to libvirtd even when using secrets","message":"[libvirt] \u0027exec\u0027 to libvirtd even when using secrets\n\nwhen \"hostPid: true\" we don\u0027t want the entrypoint process (pid) to be\ndecoupled from libvirtd as breaks libvirtd restarting\n\nthe fix for now is\n\n  * start libvirtd\n  * inject secrets\n  * kill it\n\nthen start it again using \u0027exec\u0027 so the libvirtd is the entrypoint pid\nand container lifesystem should work as expected\n\nChange-Id: I3b96c688030b581d94348990b30922eced2e3047\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5e4cf86d8f911e875a16d5fc5ead6760b4eb87b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5e4cf86d8f911e875a16d5fc5ead6760b4eb87b8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}