)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e4f5739f8e5b0e385adbbef43fc4730722ff0e10","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exec libvirt instead of forking from bash"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With \"hostPid: true\" we don\u0027t want the entrypoint process (pid) to be"},{"line_number":10,"context_line":"decoupled from libvirtd as it can prevent libvirtd from restarting"},{"line_number":11,"context_line":"properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The fix for now is"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"8207b8e1_fc89405a","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":9},"updated":"2022-03-18 17:29:43.000000000","message":"With \"hostPid: true\" we want the entrypoint process to be libvirtd not a wrapper so that process lifecycle management works as expected.","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"},{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"0ae8d4aed7b60d6453593463be6ed358509248f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exec libvirt instead of forking from bash"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With \"hostPid: true\" we don\u0027t want the entrypoint process (pid) to be"},{"line_number":10,"context_line":"decoupled from libvirtd as it can prevent libvirtd from restarting"},{"line_number":11,"context_line":"properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The fix for now is"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5b5b8f54_fd7f7769","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"8207b8e1_fc89405a","updated":"2022-03-18 18:04:10.000000000","message":"Done","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e4f5739f8e5b0e385adbbef43fc4730722ff0e10","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  * create secrets (libvirtd needs to be running for this)"},{"line_number":17,"context_line":"  * kill it"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"then start it again using \u0027exec\u0027 so libvirtd is the entrypoint pid"},{"line_number":20,"context_line":"and container lifecycle should work as expected."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9ef8a66da0fba70e8db4be3301833263de0617e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9bb0eba3_1ccb19b9","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":31},"updated":"2022-03-18 17:29:43.000000000","message":"over use of quotes (that\u0027s on me sorry)","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"},{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"0ae8d4aed7b60d6453593463be6ed358509248f3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  * create secrets (libvirtd needs to be running for this)"},{"line_number":17,"context_line":"  * kill it"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"then start it again using \u0027exec\u0027 so libvirtd is the entrypoint pid"},{"line_number":20,"context_line":"and container lifecycle should work as expected."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9ef8a66da0fba70e8db4be3301833263de0617e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bc10af31_4d252dae","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":31},"in_reply_to":"9bb0eba3_1ccb19b9","updated":"2022-03-18 18:04:10.000000000","message":"Done","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"5577afa0d86c1be0456562c404246e89b425ecb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92dc7a33_24e0f36e","updated":"2022-03-18 03:47:39.000000000","message":"Why is this change happening?","commit_id":"4da4ded067a6c6a4c084d18f7ba46f5b89db7c02"},{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"238362cffa5971dd51ba42f7456585450c50cc32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db81f2e8_7589d620","updated":"2022-03-18 15:20:59.000000000","message":"updated","commit_id":"7095cdbd8d9ce37662b64396fb388e90677f7e66"},{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"0ae8d4aed7b60d6453593463be6ed358509248f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36f69c6c_66fe367f","updated":"2022-03-18 18:04:10.000000000","message":"updated","commit_id":"9e9ba7473051494eeb64e40a88eb1c1260236c24"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2d196ba5f4d2df94c16b9af04ff917f4ded12456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f6a3bc29_73e43a24","updated":"2022-03-22 00:07:00.000000000","message":"recheck","commit_id":"a097816ead97f5e873cee75bbe1b9b6a372075e8"}],"libvirt/templates/bin/_libvirt.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"659322c5e1aa95f2893ba901b103525ea2e02e71","unresolved":true,"context_lines":[{"line_number":172,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":173,"context_line":"  kill $(cat /var/run/libvirtd.pid)"},{"line_number":174,"context_line":"  # delay long enough for it to terminate"},{"line_number":175,"context_line":"  sleep 1"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"fi"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9b9470f0_7450994b","line":175,"range":{"start_line":175,"start_character":2,"end_line":175,"end_character":9},"updated":"2022-03-18 15:04:50.000000000","message":"Why not wait for the process to exit instead of sleeping?\n\nLIBVIRTD_PID\u003d$(cat /var/run/libvirtd.pid)\nkill $LIBVIRTD_PID\ntail --pid\u003d$LIBVIRTD_PID -f /dev/null","commit_id":"4a625ff5d997e7a076611e7be14198ff15464c3a"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a4b59e0aeaeda90ffd9b809da49e9dbce83f2f9f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":173,"context_line":"  kill $(cat /var/run/libvirtd.pid)"},{"line_number":174,"context_line":"  # delay long enough for it to terminate"},{"line_number":175,"context_line":"  sleep 1"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"fi"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"fcafa727_07e13273","line":175,"range":{"start_line":175,"start_character":2,"end_line":175,"end_character":9},"in_reply_to":"9b9470f0_7450994b","updated":"2022-03-18 15:20:55.000000000","message":"Done","commit_id":"4a625ff5d997e7a076611e7be14198ff15464c3a"},{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"238362cffa5971dd51ba42f7456585450c50cc32","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":173,"context_line":"  kill $(cat /var/run/libvirtd.pid)"},{"line_number":174,"context_line":"  # delay long enough for it to terminate"},{"line_number":175,"context_line":"  sleep 1"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"fi"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"dc7f22db_36854313","line":175,"range":{"start_line":175,"start_character":2,"end_line":175,"end_character":9},"in_reply_to":"9b9470f0_7450994b","updated":"2022-03-18 15:20:59.000000000","message":"Updated.","commit_id":"4a625ff5d997e7a076611e7be14198ff15464c3a"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e4f5739f8e5b0e385adbbef43fc4730722ff0e10","unresolved":true,"context_lines":[{"line_number":173,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":174,"context_line":"  LIBVIRTD_PID\u003d$(cat /var/run/libvirtd.pid)"},{"line_number":175,"context_line":"  kill $LIBVIRTD_PID"},{"line_number":176,"context_line":"  tail --pid\u003d$LIBVIRTD_PID -f /dev/null"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"fi"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"1d746e7e_015ca518","line":176,"range":{"start_line":176,"start_character":2,"end_line":176,"end_character":39},"updated":"2022-03-18 17:29:43.000000000","message":"what does this do?","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"598ce32abc048159afe53c7a14d0277863b4a1df","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":174,"context_line":"  LIBVIRTD_PID\u003d$(cat /var/run/libvirtd.pid)"},{"line_number":175,"context_line":"  kill $LIBVIRTD_PID"},{"line_number":176,"context_line":"  tail --pid\u003d$LIBVIRTD_PID -f /dev/null"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"fi"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"c9d71512_2623fe0a","line":176,"range":{"start_line":176,"start_character":2,"end_line":176,"end_character":39},"in_reply_to":"0c557cf5_766fd65f","updated":"2022-03-18 18:03:23.000000000","message":"The only real difference is that wait will return the exit code of libvirtd. Probably not an issue, but in case it matters, tail doesn\u0027t.","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"622f6cc5362d5fcd3e16763a255ba58ee8b078c1","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":174,"context_line":"  LIBVIRTD_PID\u003d$(cat /var/run/libvirtd.pid)"},{"line_number":175,"context_line":"  kill $LIBVIRTD_PID"},{"line_number":176,"context_line":"  tail --pid\u003d$LIBVIRTD_PID -f /dev/null"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"fi"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"4dff628e_85b591c5","line":176,"range":{"start_line":176,"start_character":2,"end_line":176,"end_character":39},"in_reply_to":"1d746e7e_015ca518","updated":"2022-03-18 17:30:42.000000000","message":"oh, i see waits for the pid","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"93a14dbe4ab2d1247a64bceb1538089ed4113e14","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  # stop libvirtd; we needed it up to create secrets"},{"line_number":174,"context_line":"  LIBVIRTD_PID\u003d$(cat /var/run/libvirtd.pid)"},{"line_number":175,"context_line":"  kill $LIBVIRTD_PID"},{"line_number":176,"context_line":"  tail --pid\u003d$LIBVIRTD_PID -f /dev/null"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"fi"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"0c557cf5_766fd65f","line":176,"range":{"start_line":176,"start_character":2,"end_line":176,"end_character":39},"in_reply_to":"4dff628e_85b591c5","updated":"2022-03-18 17:33:20.000000000","message":"why not wait?","commit_id":"18361e23987c4d649080dd61ecbaad85ca16388c"}]}