)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35024},"change_message_id":"5323459e6be4306feea20be8a12a6fabc4b82674","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c41ebf60_9d6d4c60","updated":"2022-06-29 15:27:52.000000000","message":"This still needs code to do things like \u0027docker login...\u0027, just trying to get the template done correctly first","commit_id":"5b4affa11512d6b4e9c0937db0a8bf44d2d115b8"},{"author":{"_account_id":35024},"change_message_id":"4f2bc6eca7242883320aa229f0b59f7ddf146940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3cbcb827_02a76dfc","updated":"2022-07-11 15:39:51.000000000","message":"Looks like this needs a rebase to fix a merge conflict, will do that today if the rebase button doesn\u0027t work.","commit_id":"23310345d615e398d36c1f99ec75e511ade8ce36"},{"author":{"_account_id":35024},"change_message_id":"1bd61d41170b2cc9807b6b4a5358e27f9055862d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8ea9c153_b2e720c0","updated":"2022-07-08 21:21:54.000000000","message":"recheck some pods didn\u0027t start","commit_id":"23310345d615e398d36c1f99ec75e511ade8ce36"},{"author":{"_account_id":35024},"change_message_id":"757dbe9cf31550643b20653d5f8c4ed5c49aa701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b014e3ab_0a15af9c","updated":"2022-07-14 15:09:58.000000000","message":"recheck keystone pod did not start","commit_id":"c3362ae99040e784de8e238c3450c0fe1021402d"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"44dfceb4a6cf8373f3c59644f88b1fca90b9f445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3ce92608_21f6e521","updated":"2022-07-19 21:22:44.000000000","message":"recheck","commit_id":"a4efc859d04be727601c9aec9e50fca45104aba3"},{"author":{"_account_id":35024},"change_message_id":"1e7a75baae1e03b02538ae3580ad85a902cf40fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"76b13884_6c3b738a","updated":"2022-07-20 20:50:00.000000000","message":"I can\u0027t vote since I did some of the work, but Dustin\u0027s additions look good to me.","commit_id":"f31cfb2ef937ce08eae9d957158900d6bb5cdea8"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"03ceabd4b5b56016750104c68667de9227626de6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ea1e0d5a_69edca8b","updated":"2022-07-23 13:13:04.000000000","message":"To other reviewers, I recommend the following order:\n1. read the proposed spec\n2. review helm-toolkit changes\n3. pick a Helm chart like memcached to see secret-registry and config added\n4. note kube-dns doesn\u0027t use serviceaccount template, so added config for imagePullSecrets\n5. Other Helm charts are just like memcached example. Some charts like ca-issuer and posecuritypolicy were not modified because they don\u0027t have any images","commit_id":"f31cfb2ef937ce08eae9d957158900d6bb5cdea8"}],"calico/templates/secret-registry.yaml":[{"author":{"_account_id":34668,"name":"Dylan Murphy","email":"v-dymurphy@microsoft.com","username":"dmurphy-igms"},"change_message_id":"2f425355b57dbecc7fe962f1d294ab1c904b8476","unresolved":true,"context_lines":[{"line_number":10,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":11,"context_line":"See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.secret_registry .Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":16,"context_line":"{{ include \"helm-toolkit.manifests.secret_registry\" ( dict \"envAll\" . \"registryUser\" .Chart.Name ) }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ca429501_5d4e5944","line":13,"updated":"2022-07-19 20:09:48.000000000","message":"nit: Do we need whitespace removal here? I think the newline would be on the end of the line, so the cleanup at the beginnings of the statements might not catch the newlines here and after.","commit_id":"a4efc859d04be727601c9aec9e50fca45104aba3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"b25041d9d50cbcfc24981fd862a67a6bfdf28979","unresolved":false,"context_lines":[{"line_number":10,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":11,"context_line":"See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.secret_registry .Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":16,"context_line":"{{ include \"helm-toolkit.manifests.secret_registry\" ( dict \"envAll\" . \"registryUser\" .Chart.Name ) }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7e5b379f_fb169035","line":13,"in_reply_to":"c5b15d2e_375047a6","updated":"2022-07-21 14:55:11.000000000","message":"Just checked and not needed.\n\nI deployed Umbrella Chart with overrides to use image pull secrets. Then I executed the ./tools/gate/tests/validate-umbrella-upgrade-no-side-effects.sh script successfully.","commit_id":"a4efc859d04be727601c9aec9e50fca45104aba3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"50ecb1707bdf0f291db2c4adf9369c63532f5f4f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":11,"context_line":"See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.secret_registry .Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":16,"context_line":"{{ include \"helm-toolkit.manifests.secret_registry\" ( dict \"envAll\" . \"registryUser\" .Chart.Name ) }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c5b15d2e_375047a6","line":13,"in_reply_to":"ca429501_5d4e5944","updated":"2022-07-20 19:30:06.000000000","message":"I don\u0027t it\u0027s needed, but I can double check.","commit_id":"a4efc859d04be727601c9aec9e50fca45104aba3"}],"helm-toolkit/templates/manifests/_secret-registry.yaml.tpl":[{"author":{"_account_id":35024},"change_message_id":"51e8b8d7b7a9bc4169058eb20f38f9ce85bd263c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  name: {{ $secretName }}"},{"line_number":82,"context_line":"type: kubernetes.io/dockerconfigjson"},{"line_number":83,"context_line":"data:"},{"line_number":84,"context_line":"  dockerconfigjson: {{ $dockerAuth }}"},{"line_number":85,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"1040e780_f6db5e83","line":84,"range":{"start_line":84,"start_character":2,"end_line":84,"end_character":18},"updated":"2022-07-11 21:39:07.000000000","message":"Missing preceding \u0027.\u0027 here - Dustin found this offline (thanks!), will push a new update","commit_id":"23310345d615e398d36c1f99ec75e511ade8ce36"},{"author":{"_account_id":35024},"change_message_id":"35005fe33f7980bb1e634dac7935fe91d9118f07","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  name: {{ $secretName }}"},{"line_number":82,"context_line":"type: kubernetes.io/dockerconfigjson"},{"line_number":83,"context_line":"data:"},{"line_number":84,"context_line":"  dockerconfigjson: {{ $dockerAuth }}"},{"line_number":85,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"6272da3e_4391be2e","line":84,"range":{"start_line":84,"start_character":2,"end_line":84,"end_character":18},"in_reply_to":"1040e780_f6db5e83","updated":"2022-07-11 22:34:03.000000000","message":"Done","commit_id":"23310345d615e398d36c1f99ec75e511ade8ce36"}],"prometheus-blackbox-exporter/values.yaml":[{"author":{"_account_id":35024},"change_message_id":"849c9e13e99f039363ecbe65a5ef6333f6ec1e2a","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"secrets:"},{"line_number":34,"context_line":"  oci_image_registry:"},{"line_number":35,"context_line":"    prometheus-blackbox-exporter: prometheus-blackbox-exporter"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"endpoints:"},{"line_number":38,"context_line":"  cluster_domain_suffix: cluster.local"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"6916aced_d59c8429","line":35,"updated":"2022-07-20 19:21:51.000000000","message":"Seems to be missing trailing -oci-image-registry-key in value","commit_id":"a4efc859d04be727601c9aec9e50fca45104aba3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"50ecb1707bdf0f291db2c4adf9369c63532f5f4f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"secrets:"},{"line_number":34,"context_line":"  oci_image_registry:"},{"line_number":35,"context_line":"    prometheus-blackbox-exporter: prometheus-blackbox-exporter"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"endpoints:"},{"line_number":38,"context_line":"  cluster_domain_suffix: cluster.local"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"0d2f6081_994fc7dc","line":35,"in_reply_to":"6916aced_d59c8429","updated":"2022-07-20 19:30:06.000000000","message":"Good catch! Done","commit_id":"a4efc859d04be727601c9aec9e50fca45104aba3"}],"tools/pull-images.sh":[{"author":{"_account_id":35024},"change_message_id":"a3de8ba8160d77c6e4e5b2a79208392575c427a4","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      #PASSWORD\u003d$(yq \u0027.endpoints.oci_image_registry.${CHART_NAME}.username\u0027 ${CHART_DIR}values.yaml)"},{"line_number":39,"context_line":"      echo \"Auth enabled, logging into this repository\""},{"line_number":40,"context_line":"      #sudo docker login $REPO -u $USER -p $PASSWORD"},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    for IMAGE in $(cat ${CHART_DIR}values.yaml | yq \u0027.images.tags | map(.) | join(\" \")\u0027 | tr -d \u0027\"\u0027); do"},{"line_number":43,"context_line":"      sudo docker inspect $IMAGE \u003e/dev/null|| sudo docker pull $IMAGE"},{"line_number":44,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":4,"id":"c3f04d0d_c9f3e52a","line":41,"updated":"2022-07-07 15:21:39.000000000","message":"So I don\u0027t think this code belongs here, it might needed in the bootstrap template, or???","commit_id":"664a59c7781987efc452cf37a2109e3bef238e98"},{"author":{"_account_id":35024},"change_message_id":"4f2bc6eca7242883320aa229f0b59f7ddf146940","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      #PASSWORD\u003d$(yq \u0027.endpoints.oci_image_registry.${CHART_NAME}.username\u0027 ${CHART_DIR}values.yaml)"},{"line_number":39,"context_line":"      echo \"Auth enabled, logging into this repository\""},{"line_number":40,"context_line":"      #sudo docker login $REPO -u $USER -p $PASSWORD"},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    for IMAGE in $(cat ${CHART_DIR}values.yaml | yq \u0027.images.tags | map(.) | join(\" \")\u0027 | tr -d \u0027\"\u0027); do"},{"line_number":43,"context_line":"      sudo docker inspect $IMAGE \u003e/dev/null|| sudo docker pull $IMAGE"},{"line_number":44,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":4,"id":"f07dfb48_9d830472","line":41,"in_reply_to":"81c51dac_c88f69a0","updated":"2022-07-11 15:39:51.000000000","message":"Done","commit_id":"664a59c7781987efc452cf37a2109e3bef238e98"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"46fab3fa22fe0a6c2f671eacbc060aa565ff8371","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      #PASSWORD\u003d$(yq \u0027.endpoints.oci_image_registry.${CHART_NAME}.username\u0027 ${CHART_DIR}values.yaml)"},{"line_number":39,"context_line":"      echo \"Auth enabled, logging into this repository\""},{"line_number":40,"context_line":"      #sudo docker login $REPO -u $USER -p $PASSWORD"},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    for IMAGE in $(cat ${CHART_DIR}values.yaml | yq \u0027.images.tags | map(.) | join(\" \")\u0027 | tr -d \u0027\"\u0027); do"},{"line_number":43,"context_line":"      sudo docker inspect $IMAGE \u003e/dev/null|| sudo docker pull $IMAGE"},{"line_number":44,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":4,"id":"81c51dac_c88f69a0","line":41,"in_reply_to":"c3f04d0d_c9f3e52a","updated":"2022-07-07 15:23:00.000000000","message":"I don\u0027t think this is needed at all from a deployment perspective.\n\nThe scripts within tools directory exist to aid developers. These scripts are not used by automation to my understanding.","commit_id":"664a59c7781987efc452cf37a2109e3bef238e98"}]}