)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35024},"change_message_id":"a691e492dd09bf55113843bae242f1eb34f3b090","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Idempotency for deploy-k8s script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The change makes sure that the script runs idempotently"},{"line_number":10,"context_line":"and if run twice in a row now extra job is going to be done"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifc055b32528bc4702b480f2de92c544578c96d73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"0a2fb9f7_a19ff028","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":29},"updated":"2022-07-15 15:52:52.000000000","message":"nit: Was this supposed to be \u0027no\u0027 ?","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"0c7343bf8293b02e53f34981e2cf328e1a98402b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Idempotency for deploy-k8s script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The change makes sure that the script runs idempotently"},{"line_number":10,"context_line":"and if run twice in a row now extra job is going to be done"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifc055b32528bc4702b480f2de92c544578c96d73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"5177dd93_35dcdbd1","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":29},"in_reply_to":"0a2fb9f7_a19ff028","updated":"2022-07-15 16:07:39.000000000","message":"Done","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8dcabf639c8eea7b052d4ee888e49aadb02c522c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b03a28b4_ef18bb3f","updated":"2022-07-08 01:21:05.000000000","message":"recheck","commit_id":"c2dd3231b2ec7162720f6a4815db1bc4e9e07de9"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"525c28983cebae9a684a0333680ddfebb522b392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5e49d04e_d8d0fe31","updated":"2022-07-13 21:53:49.000000000","message":"recheck","commit_id":"163a5e1b70fbf7747f5dd9de88b78a52e521f077"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"e146c5097899e02a4ad7d86f43519f8329e092ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"8b698235_fbe0f8ea","updated":"2022-07-15 21:42:08.000000000","message":"Would be nice to see this script executed twice in a Zuul job to prevent this script from becoming not idempotent again in the future.","commit_id":"4c7031a6d9938492b27c70b8746483463a6edcfa"}],"tools/gate/deploy-k8s.sh":[{"author":{"_account_id":35024},"change_message_id":"a691e492dd09bf55113843bae242f1eb34f3b090","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    echo -e ${dns_servers} | sudo tee -a /etc/resolv.conf"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  grep -q \"${dns_servers}\" /run/systemd/resolve/resolv.conf || \\"},{"line_number":67,"context_line":"    echo -e ${dns_servers} | sudo tee /run/systemd/resolve/resolv.conf"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  local search_options\u003d\u0027search svc.cluster.local cluster.local\u0027"},{"line_number":70,"context_line":"  grep -q \"${search_options}\" /etc/resolv.conf || \\"}],"source_content_type":"text/x-sh","patch_set":24,"id":"40ae4c30_1d28cd2f","line":67,"updated":"2022-07-15 15:52:52.000000000","message":"Might want to put a comment as to why this isn\u0027t tee -a like the others. It\u0027s obvious in this change looking at L48 in the original, but some future person might think it was just a typo.","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"0c7343bf8293b02e53f34981e2cf328e1a98402b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    echo -e ${dns_servers} | sudo tee -a /etc/resolv.conf"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  grep -q \"${dns_servers}\" /run/systemd/resolve/resolv.conf || \\"},{"line_number":67,"context_line":"    echo -e ${dns_servers} | sudo tee /run/systemd/resolve/resolv.conf"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  local search_options\u003d\u0027search svc.cluster.local cluster.local\u0027"},{"line_number":70,"context_line":"  grep -q \"${search_options}\" /etc/resolv.conf || \\"}],"source_content_type":"text/x-sh","patch_set":24,"id":"d5395f59_cf514ce1","line":67,"in_reply_to":"40ae4c30_1d28cd2f","updated":"2022-07-15 16:07:39.000000000","message":"Done","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"},{"author":{"_account_id":35024},"change_message_id":"44fad6cb9d346c2066c0359c5d5a30dd6bf255eb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    echo -e ${dns_servers} | sudo tee -a /etc/resolv.conf"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  grep -q \"${dns_servers}\" /run/systemd/resolve/resolv.conf || \\"},{"line_number":67,"context_line":"    echo -e ${dns_servers} | sudo tee /run/systemd/resolve/resolv.conf"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  local search_options\u003d\u0027search svc.cluster.local cluster.local\u0027"},{"line_number":70,"context_line":"  grep -q \"${search_options}\" /etc/resolv.conf || \\"}],"source_content_type":"text/x-sh","patch_set":24,"id":"8c2b37f9_195a25a9","line":67,"in_reply_to":"d5395f59_cf514ce1","updated":"2022-07-15 18:41:33.000000000","message":"You marked this Done but I don\u0027t see any change.","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"},{"author":{"_account_id":35024},"change_message_id":"a691e492dd09bf55113843bae242f1eb34f3b090","unresolved":true,"context_lines":[{"line_number":303,"context_line":"  name: ${NAMESPACE}"},{"line_number":304,"context_line":"EOF"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"kubectl apply -f /tmp/${NAMESPACE}-ns.yaml"},{"line_number":307,"context_line":"done"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"make all"}],"source_content_type":"text/x-sh","patch_set":24,"id":"20e70a8d_7dac06dd","line":306,"updated":"2022-07-15 15:52:52.000000000","message":"So I had to google what the difference was between create and apply, and from what I can tell they aren\u0027t exactly the same (imperative versus declarative management), \nhttps://www.containiq.com/post/kubectl-apply-vs-create describes it pretty will with links back to kubernetes.io. Someone with more knowledge will have to decide if this change is appropriate.","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"0c7343bf8293b02e53f34981e2cf328e1a98402b","unresolved":true,"context_lines":[{"line_number":303,"context_line":"  name: ${NAMESPACE}"},{"line_number":304,"context_line":"EOF"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"kubectl apply -f /tmp/${NAMESPACE}-ns.yaml"},{"line_number":307,"context_line":"done"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"make all"}],"source_content_type":"text/x-sh","patch_set":24,"id":"fa401490_24ad624a","line":306,"in_reply_to":"20e70a8d_7dac06dd","updated":"2022-07-15 16:07:39.000000000","message":"To make things idempotent, we have to switch to a declarative approach. This is deliberate.","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"cc96890edd7a71dfaaedafcbd1eb4c38289d70ce","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  name: ${NAMESPACE}"},{"line_number":304,"context_line":"EOF"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"kubectl apply -f /tmp/${NAMESPACE}-ns.yaml"},{"line_number":307,"context_line":"done"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"make all"}],"source_content_type":"text/x-sh","patch_set":24,"id":"e6c038d2_5fbba2e4","line":306,"in_reply_to":"fa401490_24ad624a","updated":"2022-07-15 16:07:52.000000000","message":"Done","commit_id":"3e15e5e3e949c26b857505c5e4225e780ad4da6f"}]}