)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35014,"name":"Vamshi Kondaparthi","email":"v-vamshiko@microsoft.com","username":"v-vamshiko"},"change_message_id":"b0e2582ccb8a8b4230f76e3c59f83dbd6b3a15dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18276e24_74a41014","updated":"2022-11-03 19:31:15.000000000","message":"Changes to \"openvswitch/templates/bin/_openvswitch-vswitchd.sh.tpl\" and \"openvswitch/values.yaml\" to enable hardware offload .","commit_id":"383de85551859e28a9b3c0ae3c819361b09983eb"}],"openvswitch/Chart.yaml":[{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"7f950793b03849fedd34f841fbafb2d3347a34ba","unresolved":true,"context_lines":[{"line_number":15,"context_line":"appVersion: v1.0.0"},{"line_number":16,"context_line":"description: OpenStack-Helm OpenVSwitch"},{"line_number":17,"context_line":"name: openvswitch"},{"line_number":18,"context_line":"version: 2.9.8"},{"line_number":19,"context_line":"home: http://openvswitch.org"},{"line_number":20,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Neutron/OpenStack_Project_Neutron_vertical.png"},{"line_number":21,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"88c3f423_4e2f9799","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":12},"updated":"2022-11-03 20:44:23.000000000","message":"why such big jump on chart version?","commit_id":"55fd9ca2774a93955977260e089ca253746b6428"},{"author":{"_account_id":35014,"name":"Vamshi Kondaparthi","email":"v-vamshiko@microsoft.com","username":"v-vamshiko"},"change_message_id":"04b86630f02963f60aa2176775712e60e8481f58","unresolved":false,"context_lines":[{"line_number":15,"context_line":"appVersion: v1.0.0"},{"line_number":16,"context_line":"description: OpenStack-Helm OpenVSwitch"},{"line_number":17,"context_line":"name: openvswitch"},{"line_number":18,"context_line":"version: 2.9.8"},{"line_number":19,"context_line":"home: http://openvswitch.org"},{"line_number":20,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Neutron/OpenStack_Project_Neutron_vertical.png"},{"line_number":21,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f000b6e5_a0ca1e20","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":12},"in_reply_to":"88c3f423_4e2f9799","updated":"2022-11-03 22:11:47.000000000","message":"I have given the current version of OVS that has been used as part of deployment. will update this with right vrsion.","commit_id":"55fd9ca2774a93955977260e089ca253746b6428"}],"openvswitch/templates/bin/_openvswitch-vswitchd.sh.tpl":[{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"7f950793b03849fedd34f841fbafb2d3347a34ba","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  ovs-vsctl --db\u003dunix:${OVS_SOCKET} --no-wait show"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  ovs-vsctl --db\u003dunix:${OVS_SOCKET} --no-wait set Open_vSwitch . other_config:hw-offload\u003d{{ .Values.conf.ovs_hw_offload.enabled }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{{- if .Values.conf.ovs_other_config.handler_threads }}"},{"line_number":47,"context_line":"  ovs-vsctl --db\u003dunix:${OVS_SOCKET} --no-wait set Open_vSwitch . other_config:n-handler-threads\u003d{{ .Values.conf.ovs_other_config.handler_threads }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"6e86e21b_2a41c473","line":44,"updated":"2022-11-03 20:44:23.000000000","message":"you should add this line with condition, because when it is not enabled it should be here\n{{- if ..Values.conf.ovs_hw_offload.enabled }}\n#and here your command\n{{- end }}","commit_id":"55fd9ca2774a93955977260e089ca253746b6428"},{"author":{"_account_id":35014,"name":"Vamshi Kondaparthi","email":"v-vamshiko@microsoft.com","username":"v-vamshiko"},"change_message_id":"04b86630f02963f60aa2176775712e60e8481f58","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  ovs-vsctl --db\u003dunix:${OVS_SOCKET} --no-wait show"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  ovs-vsctl --db\u003dunix:${OVS_SOCKET} --no-wait set Open_vSwitch . other_config:hw-offload\u003d{{ .Values.conf.ovs_hw_offload.enabled }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{{- if .Values.conf.ovs_other_config.handler_threads }}"},{"line_number":47,"context_line":"  ovs-vsctl --db\u003dunix:${OVS_SOCKET} --no-wait set Open_vSwitch . other_config:n-handler-threads\u003d{{ .Values.conf.ovs_other_config.handler_threads }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"54d3ab67_2d130f1d","line":44,"in_reply_to":"6e86e21b_2a41c473","updated":"2022-11-03 22:11:47.000000000","message":"Ack","commit_id":"55fd9ca2774a93955977260e089ca253746b6428"}],"openvswitch/values.yaml":[{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"7f950793b03849fedd34f841fbafb2d3347a34ba","unresolved":true,"context_lines":[{"line_number":226,"context_line":"    handler_threads: null"},{"line_number":227,"context_line":"    revalidator_threads: null"},{"line_number":228,"context_line":"  ovs_hw_offload:"},{"line_number":229,"context_line":"    enabled: true"},{"line_number":230,"context_line":"  ovs_dpdk:"},{"line_number":231,"context_line":"    enabled: false"},{"line_number":232,"context_line":"    ## Mandatory parameters. Please uncomment when enabling DPDK"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"11f4f34d_9bba482b","line":229,"range":{"start_line":229,"start_character":13,"end_line":229,"end_character":17},"updated":"2022-11-03 20:44:23.000000000","message":"by default it should be false not true","commit_id":"55fd9ca2774a93955977260e089ca253746b6428"},{"author":{"_account_id":35014,"name":"Vamshi Kondaparthi","email":"v-vamshiko@microsoft.com","username":"v-vamshiko"},"change_message_id":"04b86630f02963f60aa2176775712e60e8481f58","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    handler_threads: null"},{"line_number":227,"context_line":"    revalidator_threads: null"},{"line_number":228,"context_line":"  ovs_hw_offload:"},{"line_number":229,"context_line":"    enabled: true"},{"line_number":230,"context_line":"  ovs_dpdk:"},{"line_number":231,"context_line":"    enabled: false"},{"line_number":232,"context_line":"    ## Mandatory parameters. Please uncomment when enabling DPDK"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"61a85100_bfb3046b","line":229,"range":{"start_line":229,"start_character":13,"end_line":229,"end_character":17},"in_reply_to":"11f4f34d_9bba482b","updated":"2022-11-03 22:11:47.000000000","message":"This was written in an assumption to enable hardware offload. Will set it false.","commit_id":"55fd9ca2774a93955977260e089ca253746b6428"}]}