)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"5e525a6cb361a1ca02bf214ec968df7ee17d1d20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"53e78bf1_f58db3e7","updated":"2022-11-17 16:19:18.000000000","message":"Addressed review comments","commit_id":"db86c0828733bbe6dddb9d857966c830a2e18682"}],"playbooks/osh-infra-collect-logs.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a906ed805c5073d816f5151b673ab8df4353d04c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  vars:"},{"line_number":18,"context_line":"    work_dir: \"{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":19,"context_line":"    logs_dir: \"/tmp/logs\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - gather-host-logs"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"d5df4e4f_1baa935f","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"updated":"2022-11-18 16:38:28.000000000","message":"?","commit_id":"db86c0828733bbe6dddb9d857966c830a2e18682"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"4ba5f8b704ec5864684fd16b0c444a7e9832a2a4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  vars:"},{"line_number":18,"context_line":"    work_dir: \"{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":19,"context_line":"    logs_dir: \"/tmp/logs\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - gather-host-logs"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"b42cdfad_fe0f18ea","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"d5df4e4f_1baa935f","updated":"2022-11-18 20:04:13.000000000","message":"Ack","commit_id":"db86c0828733bbe6dddb9d857966c830a2e18682"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c42f6f9fd408e5e9a3c49c331ccecbc4e01ee1c8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  vars:"},{"line_number":18,"context_line":"    work_dir: \"{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":19,"context_line":"    logs_dir: \"/tmp/logs\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - gather-host-logs"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff322a8f_bbb1f66d","line":20,"updated":"2022-11-22 22:14:59.000000000","message":"deliberate?","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"9a3915e7e7239953bb8274b01c8d78408b64e285","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  vars:"},{"line_number":18,"context_line":"    work_dir: \"{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":19,"context_line":"    logs_dir: \"/tmp/logs\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - gather-host-logs"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"6b197484_57101860","line":20,"in_reply_to":"ff322a8f_bbb1f66d","updated":"2022-11-28 15:13:34.000000000","message":"removed extra line","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"}],"playbooks/osh-infra-deploy-k8s.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c42f6f9fd408e5e9a3c49c331ccecbc4e01ee1c8","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - deploy-kube-master"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# - hosts: nodes"},{"line_number":36,"context_line":"#  vars_files:"},{"line_number":37,"context_line":"#    - vars.yaml"},{"line_number":38,"context_line":"#  vars:"},{"line_number":39,"context_line":"#    work_dir: \"{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":40,"context_line":"#  roles:"},{"line_number":41,"context_line":"#    - deploy-kubeadm-node"},{"line_number":42,"context_line":"#  tags:"},{"line_number":43,"context_line":"#    - deploy-kube-nodes"},{"line_number":44,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"96d282d5_ffcaa294","line":44,"range":{"start_line":35,"start_character":0,"end_line":44,"end_character":3},"updated":"2022-11-22 22:14:59.000000000","message":"what\u0027s the plan later with this?","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"9a3915e7e7239953bb8274b01c8d78408b64e285","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - deploy-kube-master"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# - hosts: nodes"},{"line_number":36,"context_line":"#  vars_files:"},{"line_number":37,"context_line":"#    - vars.yaml"},{"line_number":38,"context_line":"#  vars:"},{"line_number":39,"context_line":"#    work_dir: \"{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":40,"context_line":"#  roles:"},{"line_number":41,"context_line":"#    - deploy-kubeadm-node"},{"line_number":42,"context_line":"#  tags:"},{"line_number":43,"context_line":"#    - deploy-kube-nodes"},{"line_number":44,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"e62894fa_81a1d66e","line":44,"range":{"start_line":35,"start_character":0,"end_line":44,"end_character":3},"in_reply_to":"96d282d5_ffcaa294","updated":"2022-11-28 15:13:34.000000000","message":"Nodes deployment functionality has been moved to playbooks/osh-infra-add-worker.yaml.","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"}],"roles/build-helm-packages/tasks/setup-helm-serve.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4b2d115a72b31a2c0beaaeb3a46e1df9031303a5","unresolved":true,"context_lines":[{"line_number":17,"context_line":"      environment:"},{"line_number":18,"context_line":"        HELM_VERSION: \"{{ version.helm }}\""},{"line_number":19,"context_line":"      args:"},{"line_number":20,"context_line":"        executable: /usr/bin/bash"},{"line_number":21,"context_line":"      register: need_helm"},{"line_number":22,"context_line":"      ignore_errors: True"},{"line_number":23,"context_line":"    - name: install helm client"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"562ac205_57f3c826","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":26},"updated":"2022-11-16 01:46:13.000000000","message":"?","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"d15361ec650d63618b5f3c8f98c8a5b0edfdf388","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      environment:"},{"line_number":18,"context_line":"        HELM_VERSION: \"{{ version.helm }}\""},{"line_number":19,"context_line":"      args:"},{"line_number":20,"context_line":"        executable: /usr/bin/bash"},{"line_number":21,"context_line":"      register: need_helm"},{"line_number":22,"context_line":"      ignore_errors: True"},{"line_number":23,"context_line":"    - name: install helm client"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"6788373f_37491d44","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":26},"in_reply_to":"562ac205_57f3c826","updated":"2022-11-16 06:32:02.000000000","message":"It was reporting /bin/bash not found. so I used /usr/bin/bash","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a906ed805c5073d816f5151b673ab8df4353d04c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"      environment:"},{"line_number":18,"context_line":"        HELM_VERSION: \"{{ version.helm }}\""},{"line_number":19,"context_line":"      args:"},{"line_number":20,"context_line":"        executable: /usr/bin/bash"},{"line_number":21,"context_line":"      register: need_helm"},{"line_number":22,"context_line":"      ignore_errors: True"},{"line_number":23,"context_line":"    - name: install helm client"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"fb3c678b_6142c212","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":25},"updated":"2022-11-18 16:38:28.000000000","message":"?\nwhere doesn\u0027t /bin/bash work?","commit_id":"db86c0828733bbe6dddb9d857966c830a2e18682"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"4ba5f8b704ec5864684fd16b0c444a7e9832a2a4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      environment:"},{"line_number":18,"context_line":"        HELM_VERSION: \"{{ version.helm }}\""},{"line_number":19,"context_line":"      args:"},{"line_number":20,"context_line":"        executable: /usr/bin/bash"},{"line_number":21,"context_line":"      register: need_helm"},{"line_number":22,"context_line":"      ignore_errors: True"},{"line_number":23,"context_line":"    - name: install helm client"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"bd856fb8_f63ed95a","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":25},"in_reply_to":"fb3c678b_6142c212","updated":"2022-11-18 20:04:13.000000000","message":"removed /usr/","commit_id":"db86c0828733bbe6dddb9d857966c830a2e18682"}],"tools/gate/deploy-k8s-kubeadm.sh":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"b3963651e974a5fde437ea3e98f14fefee509458","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# Enable br_netfilter kernel module"},{"line_number":130,"context_line":"if [ ! -f /etc/modules-load.d/br_netfilter.conf ];then"},{"line_number":131,"context_line":"\tsudo -E tee /etc/modules-load.d/br_netfilter.conf \u003c\u003cEOF"},{"line_number":132,"context_line":"br_netfilter"},{"line_number":133,"context_line":"EOF"},{"line_number":134,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":32,"id":"c2a43dd9_358c79d3","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":1},"updated":"2022-11-17 00:39:56.000000000","message":"nit, tab here","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"5e525a6cb361a1ca02bf214ec968df7ee17d1d20","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# Enable br_netfilter kernel module"},{"line_number":130,"context_line":"if [ ! -f /etc/modules-load.d/br_netfilter.conf ];then"},{"line_number":131,"context_line":"\tsudo -E tee /etc/modules-load.d/br_netfilter.conf \u003c\u003cEOF"},{"line_number":132,"context_line":"br_netfilter"},{"line_number":133,"context_line":"EOF"},{"line_number":134,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":32,"id":"d907006c_377ba45c","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":1},"in_reply_to":"c2a43dd9_358c79d3","updated":"2022-11-17 16:19:18.000000000","message":"Fixed","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"}],"tools/gate/deploy-k8s.sh":[{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"447cc9a9c56919d9b991aab6bf468f1d13498411","unresolved":true,"context_lines":[{"line_number":129,"context_line":"fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Install required packages for K8s on host"},{"line_number":132,"context_line":"#wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":133,"context_line":"wget -q https://download.ceph.com/keys/release.asc"},{"line_number":134,"context_line":"sudo apt-key add release.asc"},{"line_number":135,"context_line":"RELEASE_NAME\u003d$(grep \u0027CODENAME\u0027 /etc/lsb-release | awk -F\u003d \u0027{print $2}\u0027)"}],"source_content_type":"text/x-sh","patch_set":32,"id":"ef4ac2a2_d345d727","line":132,"updated":"2022-11-16 21:38:12.000000000","message":"I do not see what the changes are here","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"5e525a6cb361a1ca02bf214ec968df7ee17d1d20","unresolved":false,"context_lines":[{"line_number":129,"context_line":"fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Install required packages for K8s on host"},{"line_number":132,"context_line":"#wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":133,"context_line":"wget -q https://download.ceph.com/keys/release.asc"},{"line_number":134,"context_line":"sudo apt-key add release.asc"},{"line_number":135,"context_line":"RELEASE_NAME\u003d$(grep \u0027CODENAME\u0027 /etc/lsb-release | awk -F\u003d \u0027{print $2}\u0027)"}],"source_content_type":"text/x-sh","patch_set":32,"id":"dde3171f_efdc5976","line":132,"in_reply_to":"ef4ac2a2_d345d727","updated":"2022-11-17 16:19:18.000000000","message":"I noticed build failures. Dont know the exact cause, but seems data is getting scrambled when wget send it to apt-get. This change will ensure that file is getting download properly and then pass to apt-get to add key.","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"b3963651e974a5fde437ea3e98f14fefee509458","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    nodeset: openstack-helm-ubuntu"},{"line_number":89,"context_line":"    vars:"},{"line_number":90,"context_line":"      osh_params:"},{"line_number":91,"context_line":"        openstack_release: train"},{"line_number":92,"context_line":"        container_distro_name: ubuntu"},{"line_number":93,"context_line":"        container_distro_version: bionic"},{"line_number":94,"context_line":"      # gate_scripts_relative_path: ../openstack-helm-infra"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"59dd7747_6090c774","line":91,"range":{"start_line":91,"start_character":27,"end_line":91,"end_character":32},"updated":"2022-11-17 00:39:56.000000000","message":"Feel free to bump this version up to something newer.","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"5e525a6cb361a1ca02bf214ec968df7ee17d1d20","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    nodeset: openstack-helm-ubuntu"},{"line_number":89,"context_line":"    vars:"},{"line_number":90,"context_line":"      osh_params:"},{"line_number":91,"context_line":"        openstack_release: train"},{"line_number":92,"context_line":"        container_distro_name: ubuntu"},{"line_number":93,"context_line":"        container_distro_version: bionic"},{"line_number":94,"context_line":"      # gate_scripts_relative_path: ../openstack-helm-infra"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bbb75d13_bfeae91d","line":91,"range":{"start_line":91,"start_character":27,"end_line":91,"end_character":32},"in_reply_to":"59dd7747_6090c774","updated":"2022-11-17 16:19:18.000000000","message":"Changes release to Xena.","commit_id":"f610ee3735a38cf9aa9c4895f270eaf465ffa0b2"}],"zuul.d/project.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c42f6f9fd408e5e9a3c49c331ccecbc4e01ee1c8","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        - openstack-helm-infra-deploy"},{"line_number":26,"context_line":"        - openstack-helm-infra-aio-logging"},{"line_number":27,"context_line":"        - openstack-helm-infra-aio-monitoring"},{"line_number":28,"context_line":"       #  - openstack-helm-infra-openstack-support"},{"line_number":29,"context_line":"       #  - openstack-helm-infra-openstack-support-ssl"},{"line_number":30,"context_line":"        - openstack-helm-infra-metacontroller"},{"line_number":31,"context_line":"        - openstack-helm-infra-deploy-kubeadm"},{"line_number":32,"context_line":"        # NOTE(gagehugo): Disabling this job until it\u0027s fixed"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"52f6788e_657ae8eb","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":54},"updated":"2022-11-22 22:14:59.000000000","message":"expected?","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"b1c19c38752be2005ab56afe6722d6964dcda762","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        - openstack-helm-infra-deploy"},{"line_number":26,"context_line":"        - openstack-helm-infra-aio-logging"},{"line_number":27,"context_line":"        - openstack-helm-infra-aio-monitoring"},{"line_number":28,"context_line":"       #  - openstack-helm-infra-openstack-support"},{"line_number":29,"context_line":"       #  - openstack-helm-infra-openstack-support-ssl"},{"line_number":30,"context_line":"        - openstack-helm-infra-metacontroller"},{"line_number":31,"context_line":"        - openstack-helm-infra-deploy-kubeadm"},{"line_number":32,"context_line":"        # NOTE(gagehugo): Disabling this job until it\u0027s fixed"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"23c05445_9000c67a","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":54},"in_reply_to":"52f6788e_657ae8eb","updated":"2022-11-29 00:37:49.000000000","message":"Done","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"1ea68f76ccadbc1e22ca78f413ddb353c6cee946","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        - openstack-helm-infra-deploy"},{"line_number":26,"context_line":"        - openstack-helm-infra-aio-logging"},{"line_number":27,"context_line":"        - openstack-helm-infra-aio-monitoring"},{"line_number":28,"context_line":"       #  - openstack-helm-infra-openstack-support"},{"line_number":29,"context_line":"       #  - openstack-helm-infra-openstack-support-ssl"},{"line_number":30,"context_line":"        - openstack-helm-infra-metacontroller"},{"line_number":31,"context_line":"        - openstack-helm-infra-deploy-kubeadm"},{"line_number":32,"context_line":"        # NOTE(gagehugo): Disabling this job until it\u0027s fixed"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"b7dc520d_10a40864","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":54},"in_reply_to":"52f6788e_657ae8eb","updated":"2022-11-29 05:21:51.000000000","message":"jobs successful","commit_id":"4e8ce4b8afd13065bdf6bebfeb1178c6939e4cab"}]}