)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"66625ca43d121f28677cf9354650994451505bb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f83c4640_469e8772","updated":"2023-03-15 03:45:27.000000000","message":"I did some additional research on this. \n\nAs I wrote in the previous comment according to the Pacific release notes we have to use this option `--yes-i-really-mean-it` when we try to set the size to one even if this property `mon_allow_pool_size_one` is set to true.\nSo we have to add such option here https://opendev.org/openstack/openstack-helm-infra/src/branch/master/ceph-client/templates/bin/pool/_init.sh.tpl#L223 where we set the size.\n\nAlso as you pointed out cinder chart itself tries to set the size as well. So we also have to use this option here https://opendev.org/openstack/openstack-helm/src/branch/master/cinder/templates/bin/_storage-init.sh.tpl#L37 ","commit_id":"2495be2519eafe9f239520156dbb80a1d50012cb"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"e8439d82ff5691bf0fceb7c1b0c3fdf0d269ff38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7095585f_a3681779","in_reply_to":"f83c4640_469e8772","updated":"2023-03-15 13:18:29.000000000","message":"Done. Also see https://review.opendev.org/c/openstack/openstack-helm/+/877477","commit_id":"2495be2519eafe9f239520156dbb80a1d50012cb"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f91e2b7185cfd798cdb519fb180ec749f67849cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c6204a53_8112c791","updated":"2023-03-16 12:12:46.000000000","message":"recheck","commit_id":"f80049faa17338d658f532e4d644f7b993ba7908"}],"tools/deployment/multinode/030-ceph.sh":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6e0ba28778588aacdf7ffd831d3576e3297235d6","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  ceph:"},{"line_number":65,"context_line":"    global:"},{"line_number":66,"context_line":"      fsid: ${CEPH_FS_ID}"},{"line_number":67,"context_line":"      mon_allow_pool_size_one: true"},{"line_number":68,"context_line":"  rgw_ks:"},{"line_number":69,"context_line":"    enabled: true"},{"line_number":70,"context_line":"  pool:"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fa28217_cfc68e64","line":67,"updated":"2023-03-14 21:16:50.000000000","message":"I didn\u0027t find where we explicitly set the size of an existing pool to 1. According to the doc we have to use `--yes-i-really-mean-it` option even if this `mon_allow_pool_size_one` is set to true.\n\nIn some scripts we set osd_pool_default_size. Wouldn\u0027t it be better to align these two options in all places and set them both?","commit_id":"2495be2519eafe9f239520156dbb80a1d50012cb"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"aad99375f0b466c70dd896da551d161c9d0bc82b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  ceph:"},{"line_number":65,"context_line":"    global:"},{"line_number":66,"context_line":"      fsid: ${CEPH_FS_ID}"},{"line_number":67,"context_line":"      mon_allow_pool_size_one: true"},{"line_number":68,"context_line":"  rgw_ks:"},{"line_number":69,"context_line":"    enabled: true"},{"line_number":70,"context_line":"  pool:"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3ae7eae3_9c388782","line":67,"in_reply_to":"5fa28217_cfc68e64","updated":"2023-03-15 13:19:00.000000000","message":"Done","commit_id":"2495be2519eafe9f239520156dbb80a1d50012cb"}]}
