)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"01086837dff92eb5d1782ff72698769fd53fe90b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"aefe911e_5c6de523","updated":"2023-09-22 20:57:11.000000000","message":"recheck","commit_id":"cdf5485e596d12af2c64000d37872245cd5d6212"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a5fcfc9e54b46230fc97ebfd898de86bc70f1df4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":79,"id":"1c87e235_d3ddc949","updated":"2023-09-27 19:42:47.000000000","message":"recheck","commit_id":"00f0b17658c8027d3ac5ffe590b9bfe5798dfe8e"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8231eecf6ccd64bd54228c76a9fb999cace97bde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":82,"id":"e088e2ab_186c7948","updated":"2023-10-02 17:54:42.000000000","message":"IMO it is better to rely of a particular chart version from the official Rook Helm repository instead of having copies of their charts.","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"}],"ceph-mon/templates/bin/keys/_storage-keyring-manager.sh.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8231eecf6ccd64bd54228c76a9fb999cace97bde","unresolved":true,"context_lines":[{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_CLIENT_KEY\u003d\"\""},{"line_number":32,"context_line":"ROOK_CEPH_TOOLS_POD\u003d$(kubectl -n ceph get pods --no-headers | awk \u0027/rook-ceph-tools/{print $1}\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ -n \"${ROOK_CEPH_TOOLS_POD}\" ]]; then"},{"line_number":35,"context_line":"  CEPH_AUTH_KEY_NAME\u003d$(echo \"${CEPH_KEYRING_NAME}\" | awk -F. \u0027{print $2 \".\" $3}\u0027)"}],"source_content_type":"text/x-smarty","patch_set":82,"id":"c4c6dbda_43b076af","line":32,"updated":"2023-10-02 17:54:42.000000000","message":"It is better to take the namespace from the template env Release.Namespace instead of hard coding it.","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4ed3f7f5502f8eebfceaec87376372ada67d56e5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_CLIENT_KEY\u003d\"\""},{"line_number":32,"context_line":"ROOK_CEPH_TOOLS_POD\u003d$(kubectl -n ceph get pods --no-headers | awk \u0027/rook-ceph-tools/{print $1}\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ -n \"${ROOK_CEPH_TOOLS_POD}\" ]]; then"},{"line_number":35,"context_line":"  CEPH_AUTH_KEY_NAME\u003d$(echo \"${CEPH_KEYRING_NAME}\" | awk -F. \u0027{print $2 \".\" $3}\u0027)"}],"source_content_type":"text/x-smarty","patch_set":82,"id":"09730f4e_78e2b4cb","line":32,"in_reply_to":"c4c6dbda_43b076af","updated":"2023-10-02 20:15:48.000000000","message":"Done","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"}],"tools/deployment/openstack-support-rook/020-ceph.sh":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8231eecf6ccd64bd54228c76a9fb999cace97bde","unresolved":true,"context_lines":[{"line_number":356,"context_line":"  enabled: false"},{"line_number":357,"context_line":"EOF"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"#helm repo add rook-release https://charts.rook.io/release"},{"line_number":360,"context_line":"#helm install --create-namespace --namespace rook-ceph rook-ceph rook-release/rook-ceph -f /tmp/rook.yaml"},{"line_number":361,"context_line":"helm upgrade --install --create-namespace --namespace rook-ceph rook-ceph ./rook-ceph -f /tmp/rook.yaml"},{"line_number":362,"context_line":"./tools/deployment/common/wait-for-pods.sh rook-ceph"}],"source_content_type":"text/x-sh","patch_set":82,"id":"6256e349_18c8e7bb","line":359,"updated":"2023-10-02 17:54:42.000000000","message":"Let\u0027s fix the rook version in an env variable and install rook from their official helm repo.","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4ed3f7f5502f8eebfceaec87376372ada67d56e5","unresolved":false,"context_lines":[{"line_number":356,"context_line":"  enabled: false"},{"line_number":357,"context_line":"EOF"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"#helm repo add rook-release https://charts.rook.io/release"},{"line_number":360,"context_line":"#helm install --create-namespace --namespace rook-ceph rook-ceph rook-release/rook-ceph -f /tmp/rook.yaml"},{"line_number":361,"context_line":"helm upgrade --install --create-namespace --namespace rook-ceph rook-ceph ./rook-ceph -f /tmp/rook.yaml"},{"line_number":362,"context_line":"./tools/deployment/common/wait-for-pods.sh rook-ceph"}],"source_content_type":"text/x-sh","patch_set":82,"id":"9a1bafd8_1939c3ed","line":359,"in_reply_to":"6256e349_18c8e7bb","updated":"2023-10-02 20:15:48.000000000","message":"Done","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8523853722986a9d4f7090e5bfc39d83f7916fe9","unresolved":true,"context_lines":[{"line_number":45,"context_line":"tee /tmp/rook.yaml \u003c\u003cEOF"},{"line_number":46,"context_line":"image:"},{"line_number":47,"context_line":"  repository: rook/ceph"},{"line_number":48,"context_line":"  tag: ${ROOK_RELEASE_TAG}"},{"line_number":49,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":50,"context_line":"crds:"},{"line_number":51,"context_line":"  enabled: true"}],"source_content_type":"text/x-sh","patch_set":83,"id":"a6e2c476_0853511d","line":48,"updated":"2023-10-02 20:36:12.000000000","message":"Please consider to specify the chart version instead of image tag? For a specific chart version default image tag will also be fixed and you can be sure that you are using specific templates.","commit_id":"771e42d92f6ca881895c9eba4d91c5f91916de07"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"b5584c713c77539cd8de9a1530e14a914016967e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"tee /tmp/rook.yaml \u003c\u003cEOF"},{"line_number":46,"context_line":"image:"},{"line_number":47,"context_line":"  repository: rook/ceph"},{"line_number":48,"context_line":"  tag: ${ROOK_RELEASE_TAG}"},{"line_number":49,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":50,"context_line":"crds:"},{"line_number":51,"context_line":"  enabled: true"}],"source_content_type":"text/x-sh","patch_set":83,"id":"07440faf_eb87a55f","line":48,"in_reply_to":"a6e2c476_0853511d","updated":"2023-10-03 13:15:19.000000000","message":"Done","commit_id":"771e42d92f6ca881895c9eba4d91c5f91916de07"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"a20402cc2c863c642637503f6c1ac4613784b416","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    --ceph-osd-dbwal ${CEPH_OSD_DB_WAL_DEVICE:\u003d${free_loop_devices[1]}}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Lint and package chart"},{"line_number":27,"context_line":"for CHART in rook-library rook-ceph rook-ceph-cluster; do"},{"line_number":28,"context_line":"  make \"${CHART}\""},{"line_number":29,"context_line":"done"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":84,"id":"5de8f6e8_c6a6de64","line":27,"updated":"2023-10-02 21:49:58.000000000","message":"Now since you use official rook charts you don\u0027t need this, right?","commit_id":"273c8b7b31ef694cd91608207d20452f951bbba1"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"b5584c713c77539cd8de9a1530e14a914016967e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    --ceph-osd-dbwal ${CEPH_OSD_DB_WAL_DEVICE:\u003d${free_loop_devices[1]}}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Lint and package chart"},{"line_number":27,"context_line":"for CHART in rook-library rook-ceph rook-ceph-cluster; do"},{"line_number":28,"context_line":"  make \"${CHART}\""},{"line_number":29,"context_line":"done"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":84,"id":"73401d18_54eda3ab","line":27,"in_reply_to":"5de8f6e8_c6a6de64","updated":"2023-10-03 13:15:19.000000000","message":"Done","commit_id":"273c8b7b31ef694cd91608207d20452f951bbba1"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6ff8a773c05608e6c575b5fa995873235a360351","unresolved":true,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"manifests:"},{"line_number":700,"context_line":"  daemonset_mon: false"},{"line_number":701,"context_line":"  daemonset_osd: false"},{"line_number":702,"context_line":"  deployment_checkdns: true"},{"line_number":703,"context_line":"  deployment_mds: false"},{"line_number":704,"context_line":"  deployment_mgr: false"}],"source_content_type":"text/x-sh","patch_set":86,"id":"6d19954f_775e4c8b","line":701,"updated":"2023-10-03 15:32:48.000000000","message":"nit: this is not defined in the ceph-mon chart.","commit_id":"a58f80599bfd07f70a2829365ddd6fc28f3f7e09"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5c4c2c2529fd1489df80232d6b9b69bfbcc5fdb8","unresolved":true,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"manifests:"},{"line_number":700,"context_line":"  daemonset_mon: false"},{"line_number":701,"context_line":"  daemonset_osd: false"},{"line_number":702,"context_line":"  deployment_checkdns: true"},{"line_number":703,"context_line":"  deployment_mds: false"},{"line_number":704,"context_line":"  deployment_mgr: false"}],"source_content_type":"text/x-sh","patch_set":86,"id":"f07026b7_87921f3d","line":701,"in_reply_to":"6d19954f_775e4c8b","updated":"2023-10-03 15:35:26.000000000","message":"Yes, this is an artifact of zuul jobs historically using a single yaml file for all of the ceph charts and my copying and pasting for this new job.","commit_id":"a58f80599bfd07f70a2829365ddd6fc28f3f7e09"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6ff8a773c05608e6c575b5fa995873235a360351","unresolved":true,"context_lines":[{"line_number":699,"context_line":"manifests:"},{"line_number":700,"context_line":"  daemonset_mon: false"},{"line_number":701,"context_line":"  daemonset_osd: false"},{"line_number":702,"context_line":"  deployment_checkdns: true"},{"line_number":703,"context_line":"  deployment_mds: false"},{"line_number":704,"context_line":"  deployment_mgr: false"},{"line_number":705,"context_line":"  deployment_mgr_sa: false"}],"source_content_type":"text/x-sh","patch_set":86,"id":"081b0969_5ffc3a3a","line":702,"updated":"2023-10-03 15:32:48.000000000","message":"ditto","commit_id":"a58f80599bfd07f70a2829365ddd6fc28f3f7e09"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6ff8a773c05608e6c575b5fa995873235a360351","unresolved":true,"context_lines":[{"line_number":700,"context_line":"  daemonset_mon: false"},{"line_number":701,"context_line":"  daemonset_osd: false"},{"line_number":702,"context_line":"  deployment_checkdns: true"},{"line_number":703,"context_line":"  deployment_mds: false"},{"line_number":704,"context_line":"  deployment_mgr: false"},{"line_number":705,"context_line":"  deployment_mgr_sa: false"},{"line_number":706,"context_line":"  deployment_moncheck: false"}],"source_content_type":"text/x-sh","patch_set":86,"id":"1059bdaf_38150032","line":703,"updated":"2023-10-03 15:32:48.000000000","message":"ditto","commit_id":"a58f80599bfd07f70a2829365ddd6fc28f3f7e09"}],"zuul.d/project.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8231eecf6ccd64bd54228c76a9fb999cace97bde","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        - openstack-helm-infra-logging"},{"line_number":36,"context_line":"        - openstack-helm-infra-monitoring"},{"line_number":37,"context_line":"        - openstack-helm-infra-openstack-support"},{"line_number":38,"context_line":"        - openstack-helm-infra-openstack-support"},{"line_number":39,"context_line":"        - openstack-helm-infra-openstack-support-ssl"},{"line_number":40,"context_line":"    post:"},{"line_number":41,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":82,"id":"1e598e72_98c427f6","line":38,"updated":"2023-10-02 17:54:42.000000000","message":"you probably meant openstack-helm-infra-openstack-support-rook","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4ed3f7f5502f8eebfceaec87376372ada67d56e5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        - openstack-helm-infra-logging"},{"line_number":36,"context_line":"        - openstack-helm-infra-monitoring"},{"line_number":37,"context_line":"        - openstack-helm-infra-openstack-support"},{"line_number":38,"context_line":"        - openstack-helm-infra-openstack-support"},{"line_number":39,"context_line":"        - openstack-helm-infra-openstack-support-ssl"},{"line_number":40,"context_line":"    post:"},{"line_number":41,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":82,"id":"9b93c57b_f273fd53","line":38,"in_reply_to":"1e598e72_98c427f6","updated":"2023-10-02 20:15:48.000000000","message":"Done","commit_id":"5f751085b32f79b00c504c97bdfcc646167f99c9"}]}