)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2772342773d6e51745006ad206e2cc1c414f94ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5bc136c6_562a3598","updated":"2023-06-06 21:39:00.000000000","message":"The commit message seem to be irrelevant to the change. At least I can not see any ES/Kibana update.","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"9c8c445aeec1b7e6331071678689bca7f9ad1df9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"d699c3d9_15fb04a4","updated":"2023-07-05 05:08:56.000000000","message":"recheck","commit_id":"b6fbed525016322de8667b21ff816d51c95c5170"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"9095f981e6438119a89164dd24fda41d533d7241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"ed057d14_c7294121","updated":"2023-07-05 16:02:46.000000000","message":"recheck","commit_id":"b6fbed525016322de8667b21ff816d51c95c5170"},{"author":{"_account_id":15232,"name":"Leontii","email":"leontii.istomin@intel.com","username":"listomin"},"change_message_id":"f5d459a68b129cc186955e7a1804125343ab1934","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"7ecf40e0_bcb4fe99","updated":"2023-08-22 13:24:05.000000000","message":"recheck","commit_id":"83b89a90a662ca5363d63f09a0646010056d40df"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"80f31990a2444e6e5602aa14e63ba13b0eac0a64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"06bd018e_32d4ebd3","updated":"2023-08-23 20:40:12.000000000","message":"recheck","commit_id":"02de6640f5f1e1173f355fd5e537091810e98129"}],"elasticsearch/Chart.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b0b8ec4225d4e52fb07d0956ae6e1664189483cc","unresolved":true,"context_lines":[{"line_number":15,"context_line":"appVersion: v8.7.1"},{"line_number":16,"context_line":"description: OpenStack-Helm ElasticSearch"},{"line_number":17,"context_line":"name: elasticsearch"},{"line_number":18,"context_line":"version: 0.2.25"},{"line_number":19,"context_line":"home: https://www.elastic.co/"},{"line_number":20,"context_line":"sources:"},{"line_number":21,"context_line":"  - https://github.com/elastic/elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b4a45b49_0b481d07","line":18,"updated":"2023-06-08 02:23:44.000000000","message":"Please also update releasenotes/notes/elasticsearch.yaml","commit_id":"7487e3834051cf27f884edcacfb478058c656a78"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c28a1a1286808b1e1f831dacdab84bd862a492ee","unresolved":false,"context_lines":[{"line_number":15,"context_line":"appVersion: v8.7.1"},{"line_number":16,"context_line":"description: OpenStack-Helm ElasticSearch"},{"line_number":17,"context_line":"name: elasticsearch"},{"line_number":18,"context_line":"version: 0.2.25"},{"line_number":19,"context_line":"home: https://www.elastic.co/"},{"line_number":20,"context_line":"sources:"},{"line_number":21,"context_line":"  - https://github.com/elastic/elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4b8da420_136fe182","line":18,"in_reply_to":"b4a45b49_0b481d07","updated":"2023-06-09 20:48:02.000000000","message":"Done","commit_id":"7487e3834051cf27f884edcacfb478058c656a78"}],"elasticsearch/templates/bin/_elasticsearch.sh.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2772342773d6e51745006ad206e2cc1c414f94ce","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"64358e04_c0e18115","line":149,"updated":"2023-06-06 21:39:00.000000000","message":"Please add newline here","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c28a1a1286808b1e1f831dacdab84bd862a492ee","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"838e4532_a55b7b8b","line":149,"in_reply_to":"64358e04_c0e18115","updated":"2023-06-09 20:48:02.000000000","message":"Done","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"}],"elasticsearch/templates/deployment-client.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d19131db9c84a56ee482d0c04f5529b5a0f9cbcc","unresolved":true,"context_lines":[{"line_number":136,"context_line":"{{ tuple $envAll \"elasticsearch\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":137,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.client | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":138,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"client\" \"container\" \"elasticsearch_client\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":139,"context_line":"          command: [\"/bin/bash\",\"-c\"]"},{"line_number":140,"context_line":"          args:"},{"line_number":141,"context_line":"            - ulimit -l unlimited;"},{"line_number":142,"context_line":"              runuser -u elasticsearch -G root -- /tmp/elasticsearch.sh start"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4fcd61a7_51e8d41b","line":139,"updated":"2023-06-09 21:28:02.000000000","message":"Usually it is better to have something like\n```\ncommand:\n- /bin/bash\n- -c\n- |\n  ulimit -l unlimited\n  runuser -u elasticsearch -G root -- /tmp/elasticsearch.sh start\n```","commit_id":"162b470a934c5eee73880eaa31ec367ad47a85ad"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d19131db9c84a56ee482d0c04f5529b5a0f9cbcc","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            preStop:"},{"line_number":145,"context_line":"              exec:"},{"line_number":146,"context_line":"                command:"},{"line_number":147,"context_line":"                  - runuser -u elasticsearch -G root -- /tmp/elasticsearch.sh stop"},{"line_number":148,"context_line":"          ports:"},{"line_number":149,"context_line":"            - name: transport"},{"line_number":150,"context_line":"              containerPort: {{ tuple \"elasticsearch\" \"internal\" \"discovery\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c19a8cc4_b00285af","line":147,"updated":"2023-06-09 21:28:02.000000000","message":"This is not going to be run inside a shell","commit_id":"162b470a934c5eee73880eaa31ec367ad47a85ad"}],"elasticsearch/templates/statefulset-master.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2772342773d6e51745006ad206e2cc1c414f94ce","unresolved":true,"context_lines":[{"line_number":192,"context_line":"            storage: {{ .Values.storage.master.requests.storage  }}"},{"line_number":193,"context_line":"        storageClassName: {{ .Values.storage.master.storage_class }}"},{"line_number":194,"context_line":"{{- end }}"},{"line_number":195,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"aeba29b2_463e0fcd","line":195,"updated":"2023-06-06 21:39:00.000000000","message":"Please add newline","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c28a1a1286808b1e1f831dacdab84bd862a492ee","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            storage: {{ .Values.storage.master.requests.storage  }}"},{"line_number":193,"context_line":"        storageClassName: {{ .Values.storage.master.storage_class }}"},{"line_number":194,"context_line":"{{- end }}"},{"line_number":195,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"756e92ba_64d9a319","line":195,"in_reply_to":"aeba29b2_463e0fcd","updated":"2023-06-09 20:48:02.000000000","message":"Done","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"}],"elasticsearch/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2772342773d6e51745006ad206e2cc1c414f94ce","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"  service_logging: true"},{"line_number":1001,"context_line":"  statefulset_data: true"},{"line_number":1002,"context_line":"  statefulset_master: true"},{"line_number":1003,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"94319cd8_366bd1c9","line":1003,"updated":"2023-06-06 21:39:00.000000000","message":"newline","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c28a1a1286808b1e1f831dacdab84bd862a492ee","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"  service_logging: true"},{"line_number":1001,"context_line":"  statefulset_data: true"},{"line_number":1002,"context_line":"  statefulset_master: true"},{"line_number":1003,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"05edd9ba_c542e977","line":1003,"in_reply_to":"94319cd8_366bd1c9","updated":"2023-06-09 20:48:02.000000000","message":"Done","commit_id":"39d649e03482a3cbac2dc21b4e7093b3eaaaeb84"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b0b8ec4225d4e52fb07d0956ae6e1664189483cc","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    apache_proxy: docker.io/library/httpd:2.4"},{"line_number":21,"context_line":"    memory_init: docker.io/openstackhelm/heat:wallaby-ubuntu_focal"},{"line_number":22,"context_line":"    elasticsearch: docker.io/openstackhelm/elasticsearch-s3:latest-7_6_2"},{"line_number":23,"context_line":"    curator: docker.io/bobrik/curator:5.8.1"},{"line_number":24,"context_line":"    ceph_key_placement: docker.io/openstackhelm/ceph-config-helper:ubuntu_focal_17.2.6-1-20230508"},{"line_number":25,"context_line":"    s3_bucket: docker.io/openstackhelm/ceph-daemon:ubuntu_focal_17.2.6-1-20230508"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"489b2a65_a417cec4","line":22,"updated":"2023-06-08 02:23:44.000000000","message":"Taking into account the commit message, images should be also updated. But before that you have to prepare a PR that builds elasticsearch 8.7.1 images.","commit_id":"7487e3834051cf27f884edcacfb478058c656a78"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c28a1a1286808b1e1f831dacdab84bd862a492ee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    apache_proxy: docker.io/library/httpd:2.4"},{"line_number":21,"context_line":"    memory_init: docker.io/openstackhelm/heat:wallaby-ubuntu_focal"},{"line_number":22,"context_line":"    elasticsearch: docker.io/openstackhelm/elasticsearch-s3:latest-7_6_2"},{"line_number":23,"context_line":"    curator: docker.io/bobrik/curator:5.8.1"},{"line_number":24,"context_line":"    ceph_key_placement: docker.io/openstackhelm/ceph-config-helper:ubuntu_focal_17.2.6-1-20230508"},{"line_number":25,"context_line":"    s3_bucket: docker.io/openstackhelm/ceph-daemon:ubuntu_focal_17.2.6-1-20230508"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba88fc59_6eaf377d","line":22,"in_reply_to":"489b2a65_a417cec4","updated":"2023-06-09 20:48:02.000000000","message":"Done","commit_id":"7487e3834051cf27f884edcacfb478058c656a78"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d19131db9c84a56ee482d0c04f5529b5a0f9cbcc","unresolved":true,"context_lines":[{"line_number":168,"context_line":"          privileged: true"},{"line_number":169,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":170,"context_line":"          runAsNonRoot: false"},{"line_number":171,"context_line":"          runAsUser: 0"},{"line_number":172,"context_line":"        apache_proxy:"},{"line_number":173,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":174,"context_line":"        elasticsearch_client:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4f228c8c_5162fa1d","line":171,"updated":"2023-06-09 21:28:02.000000000","message":"Do we really need this here if we already have this on the pod level security context?","commit_id":"162b470a934c5eee73880eaa31ec367ad47a85ad"},{"author":{"_account_id":32204,"name":"Arina Stebenkova","display_name":"Arina Triandafilidi","email":"astebenkova@mirantis.com","username":"astebenkova"},"change_message_id":"6ea74395c76ac9833ac23ca27e9b5b581bf013d1","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    ceph_key_placement: docker.io/openstackhelm/ceph-config-helper:ubuntu_focal_17.2.6-1-20230508"},{"line_number":25,"context_line":"    s3_bucket: docker.io/openstackhelm/ceph-daemon:ubuntu_focal_17.2.6-1-20230508"},{"line_number":26,"context_line":"    s3_user: docker.io/openstackhelm/ceph-config-helper:ubuntu_focal_17.2.6-1-20230508"},{"line_number":27,"context_line":"    helm_tests: docker.io/rsingh2023/elasticsearch:8.7.1"},{"line_number":28,"context_line":"    prometheus_elasticsearch_exporter: docker.io/justwatch/elasticsearch_exporter:1.1.0"},{"line_number":29,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:v1.0.0"},{"line_number":30,"context_line":"    snapshot_repository: docker.io/openstackhelm/ceph-config-helper:ubuntu_focal_17.2.6-1-20230508"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5db0ba4f_7542bfbb","line":27,"updated":"2023-06-29 19:22:37.000000000","message":"As with elasticsearch_template image, we can use the openstackhelm/ceph-config-helper image here, since it already contains curl and python3:\n\nhttps://opendev.org/openstack/openstack-helm-images/src/branch/master/ceph-config-helper/Dockerfile.ubuntu_focal#L29\n\nThis way we don\u0027t need to build a custom image for elasticsearch.","commit_id":"a0ba896d9c15fdc61737ed70bc02c64aeca5dd0c"},{"author":{"_account_id":32204,"name":"Arina Stebenkova","display_name":"Arina Triandafilidi","email":"astebenkova@mirantis.com","username":"astebenkova"},"change_message_id":"6ea74395c76ac9833ac23ca27e9b5b581bf013d1","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    prometheus_elasticsearch_exporter: docker.io/justwatch/elasticsearch_exporter:1.1.0"},{"line_number":29,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:v1.0.0"},{"line_number":30,"context_line":"    snapshot_repository: docker.io/openstackhelm/ceph-config-helper:ubuntu_focal_17.2.6-1-20230508"},{"line_number":31,"context_line":"    elasticsearch_templates: docker.io/rsingh2023/elasticsearch:8.7.1"},{"line_number":32,"context_line":"    image_repo_sync: docker.io/library/docker:17.07.0"},{"line_number":33,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":34,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"0dd213c9_52ed3ed2","line":31,"updated":"2023-06-29 19:22:37.000000000","message":"Why not use an image that has jq and curl packages already installed? For instance, openstackhelm/ceph-config-helper (btw, it\u0027s already used here in this chart)?\nhttps://opendev.org/openstack/openstack-helm-images/src/branch/master/ceph-config-helper/Dockerfile.ubuntu_focal#L37","commit_id":"a0ba896d9c15fdc61737ed70bc02c64aeca5dd0c"}]}
