)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6b0bd86b04e472f0b2621b6f5a16662234737899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3bf991dd_ef2f270f","updated":"2023-08-29 01:28:23.000000000","message":"recheck","commit_id":"084f378467ddb0b5e1947f34f59f13ee1cab1059"}],"libvirt/templates/configmap-bin.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8d478e00b961ef4987d32f0c1905a8e726c28477","unresolved":true,"context_lines":[{"line_number":28,"context_line":"{{ tuple \"bin/_libvirt.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":29,"context_line":"{{- if .Values.manifests.vencrypt }}"},{"line_number":30,"context_line":"  cert-init.sh: |"},{"line_number":31,"context_line":"{{ tpl .Values.conf.vencrypt.cert_init_sh . | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":34,"context_line":"  ceph-keyring.sh: |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"2a344bc9_d79275c7","line":31,"updated":"2023-08-28 23:20:39.000000000","message":"let\u0027s put this to the bin/_cert-init.sh.tpl and use \"helm-toolkit.utils.template\" to render it here.","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"f380a75eba69429f48c51c288cb821be96237c35","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{{ tuple \"bin/_libvirt.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":29,"context_line":"{{- if .Values.manifests.vencrypt }}"},{"line_number":30,"context_line":"  cert-init.sh: |"},{"line_number":31,"context_line":"{{ tpl .Values.conf.vencrypt.cert_init_sh . | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":34,"context_line":"  ceph-keyring.sh: |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"6ffa173c_8dbda823","line":31,"in_reply_to":"2a344bc9_d79275c7","updated":"2023-08-29 01:28:01.000000000","message":"Ok, looks like having this script defined in values.yaml can be convenient for some cases. Like for example when a user wants to have more advanced login in the script.","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":20248,"name":"Jaymes Mosher","email":"jmosher@mirantis.com","username":"jmosher"},"change_message_id":"a06553de731ea6f9d5285b0aa629655c1e5a4c93","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{{ tuple \"bin/_libvirt.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":29,"context_line":"{{- if .Values.manifests.vencrypt }}"},{"line_number":30,"context_line":"  cert-init.sh: |"},{"line_number":31,"context_line":"{{ tpl .Values.conf.vencrypt.cert_init_sh . | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":34,"context_line":"  ceph-keyring.sh: |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"f4f0fe30_22b85e82","line":31,"in_reply_to":"2a344bc9_d79275c7","updated":"2023-08-29 01:28:13.000000000","message":"Script is in .Values and not bin/ so that it can be overridden, if necessary.  Updated values.yaml to clarify this.","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"}],"libvirt/templates/role-cert-manager.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"54d9a844582c0ced6bc699f12ab8b221ba17c9e4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.vencrypt }}"},{"line_number":16,"context_line":"{{- $serviceAccountName :\u003d \"libvirt\" }}"},{"line_number":17,"context_line":"---"},{"line_number":18,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"d09e8918_32d218a7","line":15,"updated":"2023-08-28 23:28:53.000000000","message":"probably it is better to add a boolean field .Values.manifests.role_cert_manager and use it to render this part.","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":20248,"name":"Jaymes Mosher","email":"jmosher@mirantis.com","username":"jmosher"},"change_message_id":"a06553de731ea6f9d5285b0aa629655c1e5a4c93","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.vencrypt }}"},{"line_number":16,"context_line":"{{- $serviceAccountName :\u003d \"libvirt\" }}"},{"line_number":17,"context_line":"---"},{"line_number":18,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"85fe82bf_2e4d0267","line":15,"in_reply_to":"d09e8918_32d218a7","updated":"2023-08-29 01:28:13.000000000","message":"Done","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"}],"libvirt/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"54d9a844582c0ced6bc699f12ab8b221ba17c9e4","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    group: \"kvm\""},{"line_number":124,"context_line":"  kubernetes:"},{"line_number":125,"context_line":"    cgroup: \"kubepods.slice\""},{"line_number":126,"context_line":"  vencrypt:"},{"line_number":127,"context_line":"    # Issuer to use for the vencrypt certs."},{"line_number":128,"context_line":"    issuer:"},{"line_number":129,"context_line":"      kind: ClusterIssuer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3c33b1f9_5fae717d","line":126,"updated":"2023-08-28 23:28:53.000000000","message":"Let\u0027s put here the field `enabled: \u003ctrue/false\u003e` and use it for rendering vencrypt parts. \n\n.Values.manifests section is used for enabling/disabling whole manifests.","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":20248,"name":"Jaymes Mosher","email":"jmosher@mirantis.com","username":"jmosher"},"change_message_id":"a06553de731ea6f9d5285b0aa629655c1e5a4c93","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    group: \"kvm\""},{"line_number":124,"context_line":"  kubernetes:"},{"line_number":125,"context_line":"    cgroup: \"kubepods.slice\""},{"line_number":126,"context_line":"  vencrypt:"},{"line_number":127,"context_line":"    # Issuer to use for the vencrypt certs."},{"line_number":128,"context_line":"    issuer:"},{"line_number":129,"context_line":"      kind: ClusterIssuer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"8daaf582_4eaee68d","line":126,"in_reply_to":"3c33b1f9_5fae717d","updated":"2023-08-29 01:28:13.000000000","message":"Changed instead to use the value of vnc_tls, to be similar to the nova chart.","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"f380a75eba69429f48c51c288cb821be96237c35","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    group: \"kvm\""},{"line_number":124,"context_line":"  kubernetes:"},{"line_number":125,"context_line":"    cgroup: \"kubepods.slice\""},{"line_number":126,"context_line":"  vencrypt:"},{"line_number":127,"context_line":"    # Issuer to use for the vencrypt certs."},{"line_number":128,"context_line":"    issuer:"},{"line_number":129,"context_line":"      kind: ClusterIssuer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"8449a666_1df47429","line":126,"in_reply_to":"3c33b1f9_5fae717d","updated":"2023-08-29 01:28:01.000000000","message":"This looks not actual any more since you changed the condition to look at conf.qemu.vnc_tls","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8d478e00b961ef4987d32f0c1905a8e726c28477","unresolved":true,"context_lines":[{"line_number":136,"context_line":"      # But, it\u0027s included here to allow overriding in the case that communication happens"},{"line_number":137,"context_line":"      # over an IP other than the pod IP, for whatever reason."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"      cat \u003c\u003cEOF | kubectl apply -f -"},{"line_number":140,"context_line":"      apiVersion: cert-manager.io/v1"},{"line_number":141,"context_line":"      kind: Certificate"},{"line_number":142,"context_line":"      metadata:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"d8aa8e78_714ac401","line":139,"updated":"2023-08-28 23:20:39.000000000","message":"Are we going to generate a new cert every time when the pod is restarted?","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"},{"author":{"_account_id":20248,"name":"Jaymes Mosher","email":"jmosher@mirantis.com","username":"jmosher"},"change_message_id":"fb34ac49be1e6b4f8b6852583fbab200e15d5df6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"      # But, it\u0027s included here to allow overriding in the case that communication happens"},{"line_number":137,"context_line":"      # over an IP other than the pod IP, for whatever reason."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"      cat \u003c\u003cEOF | kubectl apply -f -"},{"line_number":140,"context_line":"      apiVersion: cert-manager.io/v1"},{"line_number":141,"context_line":"      kind: Certificate"},{"line_number":142,"context_line":"      metadata:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"b816ea67_15bb28af","line":139,"in_reply_to":"d8aa8e78_714ac401","updated":"2023-08-29 17:04:52.000000000","message":"Ack","commit_id":"6a8aa16dffa763f5b69196c98af44b07b19f7ac0"}]}