)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34667,"name":"Dustin Spears","email":"ds443n@att.com","username":"ds443n"},"change_message_id":"f859d969952f8abd44953dc62745b4f66ae7f8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"614b0e0c_8259bf52","updated":"2023-08-14 15:36:40.000000000","message":"recheck","commit_id":"dbd5a0dcbd70e53383463455bb256799bcf82f48"},{"author":{"_account_id":34667,"name":"Dustin Spears","email":"ds443n@att.com","username":"ds443n"},"change_message_id":"c870830b7d92fa4a0b57642e9217011a2702a663","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75505221_18f0bf25","updated":"2023-08-14 13:39:47.000000000","message":"recheck","commit_id":"dbd5a0dcbd70e53383463455bb256799bcf82f48"}],"openvswitch/templates/bin/_openvswitch-vswitchd.sh.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b25ebac72ebc21490a29ccbea985e8b487e31504","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    latest_file\u003d\"\""},{"line_number":112,"context_line":"    latest_mtime\u003d0"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    for file in /run/openvswitch/*.ctl; do"},{"line_number":115,"context_line":"        if [ -f \"$file\" ] \u0026\u0026 [ \"$(stat -c %U \"$file\")\" \u003d\u003d \"{{ .Values.pod.lifecycle.poststart.rootUser }}\" ]; then"},{"line_number":116,"context_line":"            current_mtime\u003d$(stat -c %Y \"$file\")"},{"line_number":117,"context_line":"            if [ \"$current_mtime\" -gt \"$latest_mtime\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"e41e5c61_9e3b20eb","line":114,"updated":"2023-08-15 19:11:04.000000000","message":"I am ok with this implementation. It is easy to read it. But it could be much shorter, something like this `ls -lt /run/openvswitch/*.ctl | awk \u0027NR\u003d\u003d1 {if ($3 \u003d\u003d \"{{ .Values.pod.lifecycle.poststart.rootUser }}\") print $NF}\u0027`","commit_id":"dbd5a0dcbd70e53383463455bb256799bcf82f48"},{"author":{"_account_id":34667,"name":"Dustin Spears","email":"ds443n@att.com","username":"ds443n"},"change_message_id":"72b7272c7f80dfedbacd898a30d05bd03debf65a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    latest_file\u003d\"\""},{"line_number":112,"context_line":"    latest_mtime\u003d0"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    for file in /run/openvswitch/*.ctl; do"},{"line_number":115,"context_line":"        if [ -f \"$file\" ] \u0026\u0026 [ \"$(stat -c %U \"$file\")\" \u003d\u003d \"{{ .Values.pod.lifecycle.poststart.rootUser }}\" ]; then"},{"line_number":116,"context_line":"            current_mtime\u003d$(stat -c %Y \"$file\")"},{"line_number":117,"context_line":"            if [ \"$current_mtime\" -gt \"$latest_mtime\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"27a369d9_49d90af8","line":114,"in_reply_to":"e41e5c61_9e3b20eb","updated":"2023-08-15 19:38:44.000000000","message":"I\u0027ve updated the function to use this instead.","commit_id":"dbd5a0dcbd70e53383463455bb256799bcf82f48"}],"openvswitch/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b25ebac72ebc21490a29ccbea985e8b487e31504","unresolved":true,"context_lines":[{"line_number":110,"context_line":"          enabled: true"},{"line_number":111,"context_line":"          min_ready_seconds: 0"},{"line_number":112,"context_line":"          max_unavailable: 1"},{"line_number":113,"context_line":"    poststart:"},{"line_number":114,"context_line":"      timeout: 5"},{"line_number":115,"context_line":"      rootUser: \"root\""},{"line_number":116,"context_line":"  resources:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f187ed8_699ba2d5","line":113,"updated":"2023-08-15 19:11:04.000000000","message":"This whole `pod` branch in the values.yaml file is used to define parameters that are mapped to some K8s API parameters. But here we set parameters that are exclusively used in the script. IMO the `conf` branch in the values.yaml file is more appropriate for this.","commit_id":"dbd5a0dcbd70e53383463455bb256799bcf82f48"},{"author":{"_account_id":34667,"name":"Dustin Spears","email":"ds443n@att.com","username":"ds443n"},"change_message_id":"72b7272c7f80dfedbacd898a30d05bd03debf65a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"          enabled: true"},{"line_number":111,"context_line":"          min_ready_seconds: 0"},{"line_number":112,"context_line":"          max_unavailable: 1"},{"line_number":113,"context_line":"    poststart:"},{"line_number":114,"context_line":"      timeout: 5"},{"line_number":115,"context_line":"      rootUser: \"root\""},{"line_number":116,"context_line":"  resources:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1e0ec42f_9b12116b","line":113,"in_reply_to":"5f187ed8_699ba2d5","updated":"2023-08-15 19:38:44.000000000","message":"Done","commit_id":"dbd5a0dcbd70e53383463455bb256799bcf82f48"}]}
