)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"85dd5a43bf6052d4d4cbe03c9625d54e68abed52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82f128b0_76999116","updated":"2023-09-14 00:14:30.000000000","message":"In general I like the idea to deploy gateway controllers separately since this is the common case. But the manifests are almost identical and probably it is better to have a common snippet for controller and controller-gw here in the ovn chart.\n\nAlthough it is not related to this change the same is for ovsdb-sb/nb statefulsets.","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"918701923047deab5d5236ccf996315ec7997e8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a14fa44_ee5941d8","updated":"2023-09-06 09:33:38.000000000","message":"recheck","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"}],"ovn/templates/daemonset-controller.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"85dd5a43bf6052d4d4cbe03c9625d54e68abed52","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":29,"context_line":"  labels:"},{"line_number":30,"context_line":"{{ tuple $envAll \"ovn\" \"ovn-controller\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"    type: hv"},{"line_number":32,"context_line":"spec:"},{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f15e7535_6b0c2373","line":31,"updated":"2023-09-14 00:14:30.000000000","message":"I see no reason to have this here. If you\u0027d like to have different labels for controller and gw, then you can use different component names. For example for gw you can use this\n\n```\ntuple $envAll \"ovn\" \"ovn-controller-gw\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\"\n```\n\nor you can also define labels in the .values.pod.labels","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"b3ec84c255d213e6583a588dd2a03a8d5a82f9e7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":29,"context_line":"  labels:"},{"line_number":30,"context_line":"{{ tuple $envAll \"ovn\" \"ovn-controller\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"    type: hv"},{"line_number":32,"context_line":"spec:"},{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b8dd618d_136ecfbb","line":31,"in_reply_to":"f15e7535_6b0c2373","updated":"2024-10-23 13:17:44.000000000","message":"Acknowledged","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"85dd5a43bf6052d4d4cbe03c9625d54e68abed52","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"    spec:"},{"line_number":47,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":48,"context_line":"      hostNetwork: true"},{"line_number":49,"context_line":"      dnsPolicy: {{ .Values.pod.dns_policy }}"},{"line_number":50,"context_line":"      nodeSelector:"},{"line_number":51,"context_line":"        {{ .Values.labels.ovn_controller.node_selector_key }}: {{ .Values.labels.ovn_controller.node_selector_value }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f413a512_fcc1d188","line":48,"updated":"2023-09-14 00:14:30.000000000","message":"Thanks for fixing this.","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"b3ec84c255d213e6583a588dd2a03a8d5a82f9e7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"    spec:"},{"line_number":47,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":48,"context_line":"      hostNetwork: true"},{"line_number":49,"context_line":"      dnsPolicy: {{ .Values.pod.dns_policy }}"},{"line_number":50,"context_line":"      nodeSelector:"},{"line_number":51,"context_line":"        {{ .Values.labels.ovn_controller.node_selector_key }}: {{ .Values.labels.ovn_controller.node_selector_value }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4468fd79_9a4bc3f8","line":48,"in_reply_to":"f413a512_fcc1d188","updated":"2024-10-23 13:17:44.000000000","message":"Done","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"}],"ovn/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"4bf9200334029469e258713623c459327cb1fd5e","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"labels:"},{"line_number":37,"context_line":"  ovn_ovsdb_nb:"},{"line_number":38,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":39,"context_line":"    node_selector_value: enabled"},{"line_number":40,"context_line":"  ovn_ovsdb_sb:"},{"line_number":41,"context_line":"    node_selector_key: openstack-compute-node"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"708fddcb_db72e3c7","line":38,"updated":"2023-09-14 00:49:56.000000000","message":"I would avoid deploying on compute nodes anything except compute components. So let\u0027s not change this line or at least consider using openstack-control-plane","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"b3ec84c255d213e6583a588dd2a03a8d5a82f9e7","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"labels:"},{"line_number":37,"context_line":"  ovn_ovsdb_nb:"},{"line_number":38,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":39,"context_line":"    node_selector_value: enabled"},{"line_number":40,"context_line":"  ovn_ovsdb_sb:"},{"line_number":41,"context_line":"    node_selector_key: openstack-compute-node"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d3d68e18_a66cbb5e","line":38,"in_reply_to":"708fddcb_db72e3c7","updated":"2024-10-23 13:17:44.000000000","message":"Acknowledged","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"4bf9200334029469e258713623c459327cb1fd5e","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":39,"context_line":"    node_selector_value: enabled"},{"line_number":40,"context_line":"  ovn_ovsdb_sb:"},{"line_number":41,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":42,"context_line":"    node_selector_value: enabled"},{"line_number":43,"context_line":"  ovn_northd:"},{"line_number":44,"context_line":"    node_selector_key: openstack-compute-node"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4e648116_b323fb25","line":41,"updated":"2023-09-14 00:49:56.000000000","message":"ditto","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"b3ec84c255d213e6583a588dd2a03a8d5a82f9e7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":39,"context_line":"    node_selector_value: enabled"},{"line_number":40,"context_line":"  ovn_ovsdb_sb:"},{"line_number":41,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":42,"context_line":"    node_selector_value: enabled"},{"line_number":43,"context_line":"  ovn_northd:"},{"line_number":44,"context_line":"    node_selector_key: openstack-compute-node"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"aa2a1359_2ba7ce3b","line":41,"in_reply_to":"4e648116_b323fb25","updated":"2024-10-23 13:17:44.000000000","message":"Acknowledged","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"4bf9200334029469e258713623c459327cb1fd5e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":42,"context_line":"    node_selector_value: enabled"},{"line_number":43,"context_line":"  ovn_northd:"},{"line_number":44,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":45,"context_line":"    node_selector_value: enabled"},{"line_number":46,"context_line":"  ovn_controller:"},{"line_number":47,"context_line":"    node_selector_key: openstack-compute-node"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"28304ceb_d6617f65","line":44,"updated":"2023-09-14 00:49:56.000000000","message":"ditto","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"b3ec84c255d213e6583a588dd2a03a8d5a82f9e7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":42,"context_line":"    node_selector_value: enabled"},{"line_number":43,"context_line":"  ovn_northd:"},{"line_number":44,"context_line":"    node_selector_key: openstack-compute-node"},{"line_number":45,"context_line":"    node_selector_value: enabled"},{"line_number":46,"context_line":"  ovn_controller:"},{"line_number":47,"context_line":"    node_selector_key: openstack-compute-node"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2fe3e7fa_54bb25ba","line":44,"in_reply_to":"28304ceb_d6617f65","updated":"2024-10-23 13:17:44.000000000","message":"Acknowledged","commit_id":"c25f8583085206078805122d1d6348b27ebdaf33"}]}