)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"d6c3ff34881e569bf61f136bf68e8a06d01e8384","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14ac8182_80b2affc","updated":"2023-12-01 23:34:37.000000000","message":"recheck","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"}],"mariadb-backup/templates/cron-job-backup-mariadb.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"12dedf07aa31168a0117edbe100a4739b0c6af46","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"mariadb-backup\" \"backup\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"{{  index $envAll.Values.conf.backup \"labels\"  | toYaml | indent 4}}"},{"line_number":30,"context_line":"spec:"},{"line_number":31,"context_line":"  schedule: {{ .Values.jobs.mariadb_backup.cron | quote }}"},{"line_number":32,"context_line":"  successfulJobsHistoryLimit: {{ .Values.jobs.mariadb_backup.history.success }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2e38975c_7119a1b3","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":9},"updated":"2023-12-04 15:55:03.000000000","message":"There is a std method to add lables (See the line above). maybe it\u0027s better to re-use that? (maybe with minor changes)\n\nwhat if someone doesn\u0027t use this functionality with staggereb backups\nthe code doesn\u0027t check if that label isn\u0027t set.","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"0efcc5536301136e2c5ba38e3235ac79d9f00744","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":27,"context_line":"  labels:"},{"line_number":28,"context_line":"{{ tuple $envAll \"mariadb-backup\" \"backup\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":29,"context_line":"{{  index $envAll.Values.conf.backup \"labels\"  | toYaml | indent 4}}"},{"line_number":30,"context_line":"spec:"},{"line_number":31,"context_line":"  schedule: {{ .Values.jobs.mariadb_backup.cron | quote }}"},{"line_number":32,"context_line":"  successfulJobsHistoryLimit: {{ .Values.jobs.mariadb_backup.history.success }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f906d26c_4e6c1ed4","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":9},"in_reply_to":"2e38975c_7119a1b3","updated":"2023-12-04 16:35:47.000000000","message":"Unfortunately, the HTK does not provide a label type suitable here.\nI have added a condition on the labels, so it is works both ways now.","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"}],"mariadb-backup/values.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"12dedf07aa31168a0117edbe100a4739b0c6af46","unresolved":true,"context_lines":[{"line_number":225,"context_line":"    enabled: false"},{"line_number":226,"context_line":"    base_path: /var/backup"},{"line_number":227,"context_line":"    labels:"},{"line_number":228,"context_line":"      staggered-backups: enabled"},{"line_number":229,"context_line":"    affinity:"},{"line_number":230,"context_line":"      podAntiAffinity:"},{"line_number":231,"context_line":"        requiredDuringSchedulingIgnoredDuringExecution:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f0162a18_871a4535","line":228,"updated":"2023-12-04 15:55:03.000000000","message":"hmm.. I think there are already some labels on line 37.\nThere is a way to separate them: jobs vs pods.. not sure if it\u0027s a good idea to duplicate that.","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"0efcc5536301136e2c5ba38e3235ac79d9f00744","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    enabled: false"},{"line_number":226,"context_line":"    base_path: /var/backup"},{"line_number":227,"context_line":"    labels:"},{"line_number":228,"context_line":"      staggered-backups: enabled"},{"line_number":229,"context_line":"    affinity:"},{"line_number":230,"context_line":"      podAntiAffinity:"},{"line_number":231,"context_line":"        requiredDuringSchedulingIgnoredDuringExecution:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"04269aff_872d248a","line":228,"in_reply_to":"f0162a18_871a4535","updated":"2023-12-04 16:35:47.000000000","message":"I just followed the example and added the labels on every level where we already had the label component\u003dbackup set.","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"}],"mariadb-backup/values_overrides/staggered-backups.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"a1a48731d1a3bb1ca9200bb1aae002b63a8dbaee","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  labels:"},{"line_number":9,"context_line":"    backup:"},{"line_number":10,"context_line":"      staggered_backups: enabled"},{"line_number":11,"context_line":"  mariadb_backup:"},{"line_number":12,"context_line":"    affinity:"},{"line_number":13,"context_line":"      podAntiAffinity:"},{"line_number":14,"context_line":"        requiredDuringSchedulingIgnoredDuringExecution:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"62908931_79f536e7","line":11,"updated":"2023-12-04 23:12:57.000000000","message":"This still contradicts with the current agreement. Let\u0027s make it like\n\n```\npod:\n  affinity:\n    mariadb_backup:\n      ...\n```","commit_id":"4cbcfec1bdb89e317582bf5e786fa07822924aa0"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"1550124c62f124106dd9eac299be614517b5bd0e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  labels:"},{"line_number":9,"context_line":"    backup:"},{"line_number":10,"context_line":"      staggered_backups: enabled"},{"line_number":11,"context_line":"  mariadb_backup:"},{"line_number":12,"context_line":"    affinity:"},{"line_number":13,"context_line":"      podAntiAffinity:"},{"line_number":14,"context_line":"        requiredDuringSchedulingIgnoredDuringExecution:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"31f4f347_949089d4","line":11,"in_reply_to":"62908931_79f536e7","updated":"2023-12-05 04:10:50.000000000","message":"Done","commit_id":"4cbcfec1bdb89e317582bf5e786fa07822924aa0"}],"mariadb/values_overrides/staggered-backups.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2b52266d2d6c4683f9a520763a8adb2888f0faaa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    enabled: true"},{"line_number":5,"context_line":"    remote_backup:"},{"line_number":6,"context_line":"      enabled: false"},{"line_number":7,"context_line":"    labels:"},{"line_number":8,"context_line":"      staggered-backups: enabled"},{"line_number":9,"context_line":"    affinity:"},{"line_number":10,"context_line":"      podAntiAffinity:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a3e9687f_307c8b97","line":7,"updated":"2023-12-04 17:55:55.000000000","message":"Although in general there is no any standards for the values.yaml format we in openstack-helm have an agreement about where to put values related to kubernetes objects and where to put services configurations.\n\nAs per the agreement this is definitely a wrong place for affinity and labels. Conf branch is more for application\u0027s configuration.","commit_id":"604e4e5e3c73799059fb7ee8ce27310c61c6a763"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"9068e1e50b702503a96c1f54d4c3842716ed46d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    enabled: true"},{"line_number":5,"context_line":"    remote_backup:"},{"line_number":6,"context_line":"      enabled: false"},{"line_number":7,"context_line":"    labels:"},{"line_number":8,"context_line":"      staggered-backups: enabled"},{"line_number":9,"context_line":"    affinity:"},{"line_number":10,"context_line":"      podAntiAffinity:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e1f97ad_324e0adb","line":7,"in_reply_to":"a3e9687f_307c8b97","updated":"2023-12-04 18:14:29.000000000","message":"ok, moved to jobs.mariadb_backup/postgresql_backup branch.","commit_id":"604e4e5e3c73799059fb7ee8ce27310c61c6a763"}],"postgresql/values.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"1fa2da88ffed496c65c10bd0d689162f16d3e132","unresolved":true,"context_lines":[{"line_number":333,"context_line":"                  values:"},{"line_number":334,"context_line":"                    - enabled"},{"line_number":335,"context_line":"            namespaces:"},{"line_number":336,"context_line":"              - openstack"},{"line_number":337,"context_line":"            topologyKey: kubernetes.io/os"},{"line_number":338,"context_line":"    days_to_keep: 3"},{"line_number":339,"context_line":"    pg_dumpall_options: \u0027--inserts --clean\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ccae7e4a_05a09100","line":336,"range":{"start_line":336,"start_character":14,"end_line":336,"end_character":25},"updated":"2023-12-04 15:45:16.000000000","message":"What if people who use the chart don\u0027t have this namespace?\nwill it be better to put this into override ather than into default values?","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"0efcc5536301136e2c5ba38e3235ac79d9f00744","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                  values:"},{"line_number":334,"context_line":"                    - enabled"},{"line_number":335,"context_line":"            namespaces:"},{"line_number":336,"context_line":"              - openstack"},{"line_number":337,"context_line":"            topologyKey: kubernetes.io/os"},{"line_number":338,"context_line":"    days_to_keep: 3"},{"line_number":339,"context_line":"    pg_dumpall_options: \u0027--inserts --clean\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d1842e81_275b647a","line":336,"range":{"start_line":336,"start_character":14,"end_line":336,"end_character":25},"in_reply_to":"ccae7e4a_05a09100","updated":"2023-12-04 16:35:47.000000000","message":"Done","commit_id":"ef8a5399a16ff4cdf8615881d07a9d1f72c96a92"}]}