)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"4be41543fcd20a743037d6efbae5531a0369858e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a84c1ad_ea04e7b8","updated":"2024-04-03 19:12:05.000000000","message":"Thanks a lot for this contribution. This is definitely could be useful for many users. But since this change is invasive and  potentially could affect all the deployments, can you please rebase it on https://review.opendev.org/c/openstack/openstack-helm-infra/+/914999","commit_id":"dd513143f76395cb9c041c0541e3a073c25a731e"},{"author":{"_account_id":36953,"name":"Karam Jameel Moore","display_name":"KRM","email":"KaramJameelMoore@gmail.com","username":"keyki","status":"FOUNDED ORACLE\nID NOTIFICATON"},"change_message_id":"4d9db2fb0d239ddd5da30bcffc7f0f929b33feff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a1990e0c_6e898020","updated":"2024-04-06 04:55:21.000000000","message":"b8d618b3b61e62dc7dc4b3ce8e2563bf192389ba","commit_id":"929ebf5200112d011b90415f1d82e4e1677909c5"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"65dc66c68741df6fa3864f7c32b1a462f572fd52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"521d7f4f_ac172f2b","updated":"2024-04-06 02:57:46.000000000","message":"recheck","commit_id":"929ebf5200112d011b90415f1d82e4e1677909c5"}],"helm-toolkit/templates/manifests/_job-s3-bucket.yaml.tpl":[{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"4cf6e28fad5c857be9171c1294189f763a96c44a","unresolved":true,"context_lines":[{"line_number":49,"context_line":"{{- end }}"},{"line_number":50,"context_line":"  annotations:"},{"line_number":51,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":52,"context_line":"{{ tuple $envAll $serviceName \"s3_bucket\" | include \"helm-toolkit.snippets.custom_job_annotations\" | indent 4 -}}"},{"line_number":53,"context_line":"{{- if $jobAnnotations }}"},{"line_number":54,"context_line":"{{ toYaml $jobAnnotations | indent 4 }}"},{"line_number":55,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"27ff2182_5b36a813","line":52,"updated":"2024-04-03 19:27:10.000000000","message":"In a last month we merged 2 snippets related to annotations. Both with an index syntax for components constructed like 0.name 1.path. I can understand why you used different order here but at the same time I see 3 different syntax examples from other snippets in this job template like \"$envAll \"s3_bucket\" $serviceAccountName\" or \"$envAll $serviceName \"s3-bucket\". The question is - maybe it\u0027s time to unify syntax starting from this change?","commit_id":"dd513143f76395cb9c041c0541e3a073c25a731e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"991229ec65466df18e3d90d34b9acc7f85d4e602","unresolved":true,"context_lines":[{"line_number":49,"context_line":"{{- end }}"},{"line_number":50,"context_line":"  annotations:"},{"line_number":51,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":52,"context_line":"{{ tuple $envAll $serviceName \"s3_bucket\" | include \"helm-toolkit.snippets.custom_job_annotations\" | indent 4 -}}"},{"line_number":53,"context_line":"{{- if $jobAnnotations }}"},{"line_number":54,"context_line":"{{ toYaml $jobAnnotations | indent 4 }}"},{"line_number":55,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"6f38abf4_2d62da28","line":52,"in_reply_to":"27ff2182_5b36a813","updated":"2024-04-03 20:12:19.000000000","message":"So directly above you comment you can see another invocation of this as:\n\n{{ tuple $envAll $serviceName \"s3-bucket\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\n\n$serviceAccountName isn\u0027t going to be correct because I think you\u0027d want the name to match the job name. Which matches all the other places in the values.yaml that the job name is referenced. That\u0027s why I originally went with the dash instead of the underscore, which I changed in the v2 as per your request.","commit_id":"dd513143f76395cb9c041c0541e3a073c25a731e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"5ee3bc54f0bb3c230524ac7bcd9e1fe4022e6fd0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{{- end }}"},{"line_number":50,"context_line":"  annotations:"},{"line_number":51,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":52,"context_line":"{{ tuple $envAll $serviceName \"s3_bucket\" | include \"helm-toolkit.snippets.custom_job_annotations\" | indent 4 -}}"},{"line_number":53,"context_line":"{{- if $jobAnnotations }}"},{"line_number":54,"context_line":"{{ toYaml $jobAnnotations | indent 4 }}"},{"line_number":55,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"9fda70b5_0b0f7ca2","line":52,"in_reply_to":"6f38abf4_2d62da28","updated":"2024-04-05 15:50:51.000000000","message":"Okay updated.","commit_id":"dd513143f76395cb9c041c0541e3a073c25a731e"}],"helm-toolkit/templates/snippets/_custom_job_annotations.tpl":[{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"43430ba86c69c112a58e2c405f69637e55411c77","unresolved":true,"context_lines":[{"line_number":22,"context_line":"          default:"},{"line_number":23,"context_line":"            custom.tld/key: \"value\""},{"line_number":24,"context_line":"            custom.tld/key2: \"value2\""},{"line_number":25,"context_line":"          keystone-domain-manage:"},{"line_number":26,"context_line":"            another.tld/foo: \"bar\""},{"line_number":27,"context_line":"    usage: |"},{"line_number":28,"context_line":"      {{ tuple \"keystone-domain-manage\" . | include \"helm-toolkit.snippets.custom_job_annotations\" }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"d07f4410_ad1cb1ba","line":25,"updated":"2024-04-02 18:32:55.000000000","message":"Please change dashes in to underscores in all snippet examples.","commit_id":"fd43035d7b68874cf0ae0931551f17e2424d493e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"b94885199d0b6dae88c549bc5f3e3ddb085b4e88","unresolved":false,"context_lines":[{"line_number":22,"context_line":"          default:"},{"line_number":23,"context_line":"            custom.tld/key: \"value\""},{"line_number":24,"context_line":"            custom.tld/key2: \"value2\""},{"line_number":25,"context_line":"          keystone-domain-manage:"},{"line_number":26,"context_line":"            another.tld/foo: \"bar\""},{"line_number":27,"context_line":"    usage: |"},{"line_number":28,"context_line":"      {{ tuple \"keystone-domain-manage\" . | include \"helm-toolkit.snippets.custom_job_annotations\" }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1fa8be4b_365f3cd1","line":25,"in_reply_to":"d07f4410_ad1cb1ba","updated":"2024-04-02 21:06:34.000000000","message":"Done","commit_id":"fd43035d7b68874cf0ae0931551f17e2424d493e"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"7816495dd61fd7a6156d48cb4f92d0882be7daea","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- define \"helm-toolkit.snippets.custom_job_annotations\" -}}"},{"line_number":61,"context_line":"{{- $envAll :\u003d index . 1 -}}"},{"line_number":62,"context_line":"{{- $component :\u003d printf \"%s_%s\" (index . 0 | replace \"-\" \"_\") -}}"},{"line_number":63,"context_line":"{{- if (hasKey $envAll.Values \"annotations\") -}}"},{"line_number":64,"context_line":"{{- if (hasKey $envAll.Values.annotations \"job\") -}}"},{"line_number":65,"context_line":"{{- $annotationsMap :\u003d $envAll.Values.annotations.job -}}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"29e411e6_762ee870","line":62,"updated":"2024-04-05 23:46:02.000000000","message":"This probably must be \n```\n{{- $component :\u003d index . 0 | replace \"-\" \"_\" -}}\n```\nOtherwise it will always set the default annotation.","commit_id":"323c23df62eb04a668bf0a3e02ac8d5968dbee9a"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"13a59d70cf3c3e26d0c730ce01f197b60cf0867c","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{- define \"helm-toolkit.snippets.custom_job_annotations\" -}}"},{"line_number":61,"context_line":"{{- $envAll :\u003d index . 1 -}}"},{"line_number":62,"context_line":"{{- $component :\u003d printf \"%s_%s\" (index . 0 | replace \"-\" \"_\") -}}"},{"line_number":63,"context_line":"{{- if (hasKey $envAll.Values \"annotations\") -}}"},{"line_number":64,"context_line":"{{- if (hasKey $envAll.Values.annotations \"job\") -}}"},{"line_number":65,"context_line":"{{- $annotationsMap :\u003d $envAll.Values.annotations.job -}}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"38456fc2_e555cfb7","line":62,"in_reply_to":"29e411e6_762ee870","updated":"2024-04-05 23:53:40.000000000","message":"Yep. Those good ol\u0027 last minute changes.","commit_id":"323c23df62eb04a668bf0a3e02ac8d5968dbee9a"}]}