)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"e1fa2b19ed0c3dff313fe981573dcfcf19661898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"787cd48a_1182d2ec","updated":"2024-06-13 18:16:55.000000000","message":"Am init container with a restart policy of Always is how sidecars are implemented in k8s when the feature gate is enabled\n\nhttps://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/","commit_id":"b946e5ba059c8402b147f39294c05145a4ae8a5f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"245689353fcc8f4eb824f7fa5405caadce6e1670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a5268efa_929e57f8","updated":"2024-06-13 17:57:52.000000000","message":"Technically it is not \"sidecar\" but init container.","commit_id":"b946e5ba059c8402b147f39294c05145a4ae8a5f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e8478c9d3b7170951c14519e1ae107b4e765deaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cb7fd66f_27a4c3e5","updated":"2024-06-13 19:00:21.000000000","message":"Thank you for this feature. But it would be great to have the comment in values that this gonna work for only \u003e1.28 with feature explicitly enabled.","commit_id":"b946e5ba059c8402b147f39294c05145a4ae8a5f"}],"grafana/templates/deployment.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"feec9acea59eb38b1e624a830f1fcf8eb2edf17e","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        {{ .Values.labels.grafana.node_selector_key }}: {{ .Values.labels.grafana.node_selector_value | quote }}"},{"line_number":52,"context_line":"      initContainers:"},{"line_number":53,"context_line":"{{ tuple $envAll \"grafana\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":54,"context_line":"{{- if .Values.conf.grafana.image_rendering_sidecar.enabled }}"},{"line_number":55,"context_line":"        - name: grafana-image-renderer"},{"line_number":56,"context_line":"{{ tuple $envAll \"grafana_image_renderer\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":57,"context_line":"          restartPolicy: Always"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f8b43fec_bc975535","line":54,"updated":"2024-06-13 17:58:53.000000000","message":"you probably meant to add this container to the list of containers, not to the list of init containers.","commit_id":"b946e5ba059c8402b147f39294c05145a4ae8a5f"},{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"e1fa2b19ed0c3dff313fe981573dcfcf19661898","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        {{ .Values.labels.grafana.node_selector_key }}: {{ .Values.labels.grafana.node_selector_value | quote }}"},{"line_number":52,"context_line":"      initContainers:"},{"line_number":53,"context_line":"{{ tuple $envAll \"grafana\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\"  | indent 8 }}"},{"line_number":54,"context_line":"{{- if .Values.conf.grafana.image_rendering_sidecar.enabled }}"},{"line_number":55,"context_line":"        - name: grafana-image-renderer"},{"line_number":56,"context_line":"{{ tuple $envAll \"grafana_image_renderer\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":57,"context_line":"          restartPolicy: Always"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"751bedac_1ad71ef9","line":54,"in_reply_to":"f8b43fec_bc975535","updated":"2024-06-13 18:16:55.000000000","message":"Init containers is correct. An init container with a restartPolicy of always is a \"first class\" sidecar \n\nhttps://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/\n\nassuming the feature gate is enabled.","commit_id":"b946e5ba059c8402b147f39294c05145a4ae8a5f"}]}