)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8f3761dc2caaad5a9463d957660fa819f0b0221b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e21bfb1f_27c2c38f","updated":"2024-09-17 10:44:30.000000000","message":"recheck","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"}],"helm-toolkit/templates/endpoints/_host_and_port_endpoint_uri_lookup.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8919c5c7888dc96f2311d3df9ef8c3694011a5e6","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            default: memcached"},{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5d62c90b_ba440b41","line":57,"updated":"2024-09-17 20:57:40.000000000","message":"Are you suggesting to deploy memcached as a statefulset? If no, then this is not the best name for this feature. If yes, then IMO it is not a good idea to make memcached stateful.","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ae8052b8dddf356c57cc9d57ec88e5f3b2aedb3e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            default: memcached"},{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"24784fed_c9922d51","line":57,"in_reply_to":"22bb9e59_aaf5d6ec","updated":"2024-09-18 12:22:44.000000000","message":"Done","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9f3f8279660177208d8025d178b38bd2842c1042","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            default: memcached"},{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"22bb9e59_aaf5d6ec","line":57,"in_reply_to":"52431fa8_52f9aab1","updated":"2024-09-18 05:07:30.000000000","message":"statefulset deployment does not mean that application inside is stateful, but it gives some benefits that other deployment topologies does not like ability to resolve each instance by DNS name. With any other kind Deployment or Daemonset its is not possible. Even when its a statefulset the aplication inside still remains stateless.","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"067e4c1049bfb79a6f885cc8e04d3aafc5278304","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            default: memcached"},{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"52431fa8_52f9aab1","line":57,"in_reply_to":"5d62c90b_ba440b41","updated":"2024-09-18 05:03:44.000000000","message":"yes, memcached like a rabbit should be deployed as statefulset as we need to set each host of memcached in the config. Why it is not good idea?","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8919c5c7888dc96f2311d3df9ef8c3694011a5e6","unresolved":true,"context_lines":[{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"},{"line_number":61,"context_line":"            memcache:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"63cbb705_12706179","line":58,"updated":"2024-09-17 20:57:40.000000000","message":"not necessary to have this `openstack-` prefix here.","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"067e4c1049bfb79a6f885cc8e04d3aafc5278304","unresolved":true,"context_lines":[{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"},{"line_number":61,"context_line":"            memcache:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"8332a39d_3d8f2d0a","line":58,"in_reply_to":"63cbb705_12706179","updated":"2024-09-18 05:03:44.000000000","message":"I think it depend on how you call helm release of memcache. If you call it openstack-memcached the service here will be openstack-memcached-memcached","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ae8052b8dddf356c57cc9d57ec88e5f3b2aedb3e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          host_fqdn_override:"},{"line_number":56,"context_line":"            default: null"},{"line_number":57,"context_line":"          statefulset:"},{"line_number":58,"context_line":"            name: openstack-memcached-memcached"},{"line_number":59,"context_line":"            replicas: 3"},{"line_number":60,"context_line":"          port:"},{"line_number":61,"context_line":"            memcache:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"eb396075_977a1a50","line":58,"in_reply_to":"8332a39d_3d8f2d0a","updated":"2024-09-18 12:22:44.000000000","message":"Done","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8919c5c7888dc96f2311d3df9ef8c3694011a5e6","unresolved":true,"context_lines":[{"line_number":76,"context_line":"{{- $endpointPort :\u003d tuple $type $endpoint $port $context | include \"helm-toolkit.endpoints.endpoint_port_lookup\" -}}"},{"line_number":77,"context_line":"{{- if $ssMap -}}"},{"line_number":78,"context_line":"{{-   $endpointHostPrefix :\u003d $ssMap.name -}}"},{"line_number":79,"context_line":"{{-   $endpointHostSuffix :\u003d tuple $type $endpoint $context | include \"helm-toolkit.endpoints.endpoint_host_lookup\" }}"},{"line_number":80,"context_line":"{{-   range $podInt :\u003d until ( atoi (print $ssMap.replicas ) ) -}}"},{"line_number":81,"context_line":"{{-     $endpointHostname :\u003d printf \"%s-%d.%s:%s\" $endpointHostPrefix $podInt $endpointHostSuffix $endpointPort -}}"},{"line_number":82,"context_line":"{{-     $_ :\u003d set $local \"endpointHosts\" ( append $local.endpointHosts $endpointHostname ) -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"4b0e2715_3d7d1a1f","line":79,"updated":"2024-09-17 20:57:40.000000000","message":"Please keep in mind that helm-toolkit.endpoints.endpoint_host_lookup returns the following pattern:\n```\nhost.namespace.svc.cluster.local\n```\nwhere host is taken from $type.hosts.$endpoint.\n\nFor the example you mentioned it will be: `openstack-memcached-memcached-0.memcached.openstack.svc.cluster.local:11211,openstack-memcached-memcached-1.memcached.openstack.svc.cluster.local:11211,openstack-memcached-memcached-2.memcached.openstack.svc.cluster.local:11211`","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"067e4c1049bfb79a6f885cc8e04d3aafc5278304","unresolved":true,"context_lines":[{"line_number":76,"context_line":"{{- $endpointPort :\u003d tuple $type $endpoint $port $context | include \"helm-toolkit.endpoints.endpoint_port_lookup\" -}}"},{"line_number":77,"context_line":"{{- if $ssMap -}}"},{"line_number":78,"context_line":"{{-   $endpointHostPrefix :\u003d $ssMap.name -}}"},{"line_number":79,"context_line":"{{-   $endpointHostSuffix :\u003d tuple $type $endpoint $context | include \"helm-toolkit.endpoints.endpoint_host_lookup\" }}"},{"line_number":80,"context_line":"{{-   range $podInt :\u003d until ( atoi (print $ssMap.replicas ) ) -}}"},{"line_number":81,"context_line":"{{-     $endpointHostname :\u003d printf \"%s-%d.%s:%s\" $endpointHostPrefix $podInt $endpointHostSuffix $endpointPort -}}"},{"line_number":82,"context_line":"{{-     $_ :\u003d set $local \"endpointHosts\" ( append $local.endpointHosts $endpointHostname ) -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"ff86e8df_fb8a0b1c","line":79,"in_reply_to":"4b0e2715_3d7d1a1f","updated":"2024-09-18 05:03:44.000000000","message":"yes its okay.","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ae8052b8dddf356c57cc9d57ec88e5f3b2aedb3e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"{{- $endpointPort :\u003d tuple $type $endpoint $port $context | include \"helm-toolkit.endpoints.endpoint_port_lookup\" -}}"},{"line_number":77,"context_line":"{{- if $ssMap -}}"},{"line_number":78,"context_line":"{{-   $endpointHostPrefix :\u003d $ssMap.name -}}"},{"line_number":79,"context_line":"{{-   $endpointHostSuffix :\u003d tuple $type $endpoint $context | include \"helm-toolkit.endpoints.endpoint_host_lookup\" }}"},{"line_number":80,"context_line":"{{-   range $podInt :\u003d until ( atoi (print $ssMap.replicas ) ) -}}"},{"line_number":81,"context_line":"{{-     $endpointHostname :\u003d printf \"%s-%d.%s:%s\" $endpointHostPrefix $podInt $endpointHostSuffix $endpointPort -}}"},{"line_number":82,"context_line":"{{-     $_ :\u003d set $local \"endpointHosts\" ( append $local.endpointHosts $endpointHostname ) -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"32de9291_1f0c9d20","line":79,"in_reply_to":"ff86e8df_fb8a0b1c","updated":"2024-09-18 12:22:44.000000000","message":"Done","commit_id":"4b2d606f1d5826599775a079c995b09feae36507"}]}