)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ca1c041d791d23ec05d1b121c6ff752f94d2d028","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57073572_122e268a","updated":"2024-09-16 15:31:24.000000000","message":"recheck","commit_id":"3245eb128a658a4c6dc1f9bcb05c38aaccfc8fc7"}],"libvirt/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ffc7f0cff8bd1e8d9fc970d08b2f0f920151d96b","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"      set -ex"},{"line_number":146,"context_line":"      export HOME\u003d/tmp"},{"line_number":147,"context_line":"      KVM_QEMU_CONF_HOST\u003d\"/etc/modprobe.d_host/qemu-system-x86.conf\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      if [[ ! -f \"${KVM_QEMU_CONF_HOST}\" ]]; then"},{"line_number":150,"context_line":"        if grep vmx /proc/cpuinfo; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3125cf2f_0a2c20cc","line":147,"updated":"2024-09-17 17:20:06.000000000","message":"modprobe.d_host?","commit_id":"865287258a90aef3f977ec48c353285315495de0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"70b9ab4bff712b0e6f6e776bc1efe3f78d21ab4f","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"      set -ex"},{"line_number":146,"context_line":"      export HOME\u003d/tmp"},{"line_number":147,"context_line":"      KVM_QEMU_CONF_HOST\u003d\"/etc/modprobe.d_host/qemu-system-x86.conf\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      if [[ ! -f \"${KVM_QEMU_CONF_HOST}\" ]]; then"},{"line_number":150,"context_line":"        if grep vmx /proc/cpuinfo; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b1e810a4_cccc5c27","line":147,"in_reply_to":"3125cf2f_0a2c20cc","updated":"2024-09-17 17:33:26.000000000","message":"yes, its mounted here from the host https://review.opendev.org/c/openstack/openstack-helm-infra/+/929510/2/libvirt/templates/daemonset-libvirt.yaml#92 I think it was done intentionally to have ability to see content of qemu-system-x86.conf provided by qemu package in docker image. If we will mount in same location data will not be available.","commit_id":"865287258a90aef3f977ec48c353285315495de0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ddffa9284f09066d018958a5f77e7da3681fda32","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"      set -ex"},{"line_number":146,"context_line":"      export HOME\u003d/tmp"},{"line_number":147,"context_line":"      KVM_QEMU_CONF_HOST\u003d\"/etc/modprobe.d_host/qemu-system-x86.conf\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      if [[ ! -f \"${KVM_QEMU_CONF_HOST}\" ]]; then"},{"line_number":150,"context_line":"        if grep vmx /proc/cpuinfo; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6d85019a_652d7ab3","line":147,"in_reply_to":"b1e810a4_cccc5c27","updated":"2024-09-17 18:49:01.000000000","message":"Done","commit_id":"865287258a90aef3f977ec48c353285315495de0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ffc7f0cff8bd1e8d9fc970d08b2f0f920151d96b","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      options kvm_intel ept\u003d1"},{"line_number":155,"context_line":"      EOF"},{"line_number":156,"context_line":"          modprobe -r kvm_intel || true"},{"line_number":157,"context_line":"          modprobe kvm_intel nested\u003d1"},{"line_number":158,"context_line":"        elif grep svm /proc/cpuinfo; then"},{"line_number":159,"context_line":"          cat \u003c\u003c EOF \u003e ${KVM_QEMU_CONF_HOST}"},{"line_number":160,"context_line":"      options kvm_amd nested\u003d1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"28f018ee_7e67414b","line":157,"updated":"2024-09-17 17:20:06.000000000","message":"Since previously you push options commands to the modprobe config, here it is not necessary to set `nested\u003d1` explicitly. It will be taken from the modprobe config.","commit_id":"865287258a90aef3f977ec48c353285315495de0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"70b9ab4bff712b0e6f6e776bc1efe3f78d21ab4f","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      options kvm_intel ept\u003d1"},{"line_number":155,"context_line":"      EOF"},{"line_number":156,"context_line":"          modprobe -r kvm_intel || true"},{"line_number":157,"context_line":"          modprobe kvm_intel nested\u003d1"},{"line_number":158,"context_line":"        elif grep svm /proc/cpuinfo; then"},{"line_number":159,"context_line":"          cat \u003c\u003c EOF \u003e ${KVM_QEMU_CONF_HOST}"},{"line_number":160,"context_line":"      options kvm_amd nested\u003d1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4c5f9a62_69f9c53d","line":157,"in_reply_to":"28f018ee_7e67414b","updated":"2024-09-17 17:33:26.000000000","message":"it seems it will not as we mount config file into /etc/modprobe.d_host","commit_id":"865287258a90aef3f977ec48c353285315495de0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ddffa9284f09066d018958a5f77e7da3681fda32","unresolved":false,"context_lines":[{"line_number":154,"context_line":"      options kvm_intel ept\u003d1"},{"line_number":155,"context_line":"      EOF"},{"line_number":156,"context_line":"          modprobe -r kvm_intel || true"},{"line_number":157,"context_line":"          modprobe kvm_intel nested\u003d1"},{"line_number":158,"context_line":"        elif grep svm /proc/cpuinfo; then"},{"line_number":159,"context_line":"          cat \u003c\u003c EOF \u003e ${KVM_QEMU_CONF_HOST}"},{"line_number":160,"context_line":"      options kvm_amd nested\u003d1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"83808cf8_e76e9cca","line":157,"in_reply_to":"4c5f9a62_69f9c53d","updated":"2024-09-17 18:49:01.000000000","message":"Done","commit_id":"865287258a90aef3f977ec48c353285315495de0"}]}
