)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6202857f30ba0341e0521db5379dcce10b52c454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0a1b23a_082249c7","updated":"2024-09-30 22:23:29.000000000","message":"can we add all the recommended labels? https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/","commit_id":"ef665b02f9ae61103c563ac182e7da509a80aa6e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"08922ab7f747880c86e27d6bbdff52166496f046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b5a891f_6d3407a4","updated":"2024-10-02 20:19:34.000000000","message":"If we\u0027re gonna set one of the recommended labels, let\u0027s set them all. Vlad, we also need to start considering when to deprecate and retire old things.","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"84576642841e55186fc7ad48d5c915461f4ee051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae13e791_079bfe47","updated":"2024-10-07 17:13:52.000000000","message":"Adding another core reviewer to this change","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e4b790217a4b75898a3e85f85ff09a7e6dfe095b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2cf1d128_d99f073b","updated":"2024-10-04 17:55:20.000000000","message":"recheck","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"300910c03d130080bd11ba08bd174bbed4193233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e446c9d_ebc330e6","updated":"2024-10-04 21:25:53.000000000","message":"recheck","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"a001311cea5a26b640bdfc84101bd44d296841c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"771a54f6_0f043934","updated":"2024-10-04 00:13:58.000000000","message":"recheck","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"8fe125a68f17c28ba1bccfceb5896fa931510365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"995d1d5f_c0e81be5","updated":"2024-10-03 21:25:22.000000000","message":"recheck","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6539d40a136bd878a75050c09cc2ac00cd82b4e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b80e842_aeb173f3","updated":"2024-10-07 14:18:15.000000000","message":"recheck timeout on unix socket","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"}],"helm-toolkit/templates/snippets/_kubernetes_metadata_labels.tpl":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"08922ab7f747880c86e27d6bbdff52166496f046","unresolved":true,"context_lines":[{"line_number":40,"context_line":"release_group: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":41,"context_line":"application: {{ $application }}"},{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":45,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"dab1416a_5a6b8a11","line":43,"updated":"2024-10-02 20:19:34.000000000","message":"Please add: \n```suggestion\napp.kubernetes.io/name: {{ $application }}\napp.kubernetes.io/component: {{ $component }}\napp.kubernetes.io/instance: {{ $envAll.Values.release_group | default $envAll.Release.Name }}\n```","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"210483f1ec6793fcef9af9b18c3fb940b352a692","unresolved":true,"context_lines":[{"line_number":40,"context_line":"release_group: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":41,"context_line":"application: {{ $application }}"},{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":45,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"af08cb58_c9f35e3d","line":43,"updated":"2024-10-01 17:24:36.000000000","message":"can we add all the recommended labels while you’re in here? https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ you’ve got the values.","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"},{"author":{"_account_id":37226,"name":"Johnny Chia","display_name":"Johnny Chia","email":"johnny.chialung@windriver.com","username":"jchialun"},"change_message_id":"ebf09ca6aaaca7624848166f0383d202a71253e0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"release_group: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":41,"context_line":"application: {{ $application }}"},{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":45,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"be1fe8c2_d417503e","line":43,"in_reply_to":"af08cb58_c9f35e3d","updated":"2024-10-03 16:41:55.000000000","message":"Done","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"},{"author":{"_account_id":37226,"name":"Johnny Chia","display_name":"Johnny Chia","email":"johnny.chialung@windriver.com","username":"jchialun"},"change_message_id":"ebf09ca6aaaca7624848166f0383d202a71253e0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"release_group: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":41,"context_line":"application: {{ $application }}"},{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":45,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"86d0b66f_d4c6d4d8","line":43,"in_reply_to":"dab1416a_5a6b8a11","updated":"2024-10-03 16:41:55.000000000","message":"Done","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"},{"author":{"_account_id":37078,"name":"Daniel Marques Caires","display_name":"Daniel Caires","email":"DanielMarques.Caires@windriver.com","username":"dcaires"},"change_message_id":"4cc4a83d130f009fc1bff6593a8eb77f76cc7eac","unresolved":true,"context_lines":[{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"app.kubernetes.io/component: {{ $component }}"},{"line_number":45,"context_line":"app.kubernetes.io/instance: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":46,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":47,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":48,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"44ac610f_0703c28f","line":45,"updated":"2024-10-03 17:14:05.000000000","message":"Just checking, none of the Helm charts inside Openstack Helm and Openstack Helm Infra have these labels hard coded into them right?","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":37226,"name":"Johnny Chia","display_name":"Johnny Chia","email":"johnny.chialung@windriver.com","username":"jchialun"},"change_message_id":"db9bbacfae267c80848849b9fd04bbba4ae83e24","unresolved":false,"context_lines":[{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"app.kubernetes.io/component: {{ $component }}"},{"line_number":45,"context_line":"app.kubernetes.io/instance: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":46,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":47,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":48,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"1ccfff47_3fc050c3","line":45,"in_reply_to":"1af0ed4e_02f58b6d","updated":"2024-10-03 17:52:19.000000000","message":"Done","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"},{"author":{"_account_id":37226,"name":"Johnny Chia","display_name":"Johnny Chia","email":"johnny.chialung@windriver.com","username":"jchialun"},"change_message_id":"a81e68f92fdda02fa2b47d0bec6d8d8bb7ad5f92","unresolved":true,"context_lines":[{"line_number":42,"context_line":"component: {{ $component }}"},{"line_number":43,"context_line":"app.kubernetes.io/name: {{ $application }}"},{"line_number":44,"context_line":"app.kubernetes.io/component: {{ $component }}"},{"line_number":45,"context_line":"app.kubernetes.io/instance: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":46,"context_line":"{{- if ($envAll.Values.pod).labels }}"},{"line_number":47,"context_line":"{{- if hasKey $envAll.Values.pod.labels $component }}"},{"line_number":48,"context_line":"{{ index $envAll.Values.pod \"labels\" $component | toYaml }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"1af0ed4e_02f58b6d","line":45,"in_reply_to":"44ac610f_0703c28f","updated":"2024-10-03 17:52:07.000000000","message":"Yes I checked and none of them have.","commit_id":"f9458d51b8c3b677e89cc95a5b2bc2012b391c19"}],"mariadb/templates/deployment-ingress.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"583b532bc45cc20b4dc52a4f9e7959267f39d524","unresolved":true,"context_lines":[{"line_number":223,"context_line":"  labels:"},{"line_number":224,"context_line":"{{ tuple $envAll \"mariadb\" \"ingress\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":225,"context_line":"    app.kubernetes.io/instance: {{ $serviceAccountName }}"},{"line_number":226,"context_line":"    app.kubernetes.io/name: \"mariadb\""},{"line_number":227,"context_line":"    app.kubernetes.io/component: \"ingress\""},{"line_number":228,"context_line":"    app.kubernetes.io/managed-by: {{ $envAll.Release.Service }}"},{"line_number":229,"context_line":"{{- if $envAll.Chart.AppVersion }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"58dffd91_dcfea80e","side":"PARENT","line":226,"updated":"2024-10-01 19:24:42.000000000","message":"Please be informed, that ingress is not a recommended way of managing mariadb endpoint. Please see https://review.opendev.org/c/openstack/openstack-helm-infra/+/929363","commit_id":"f361feb69aeef1c99f035e1aa9dbff19edf9918a"},{"author":{"_account_id":37226,"name":"Johnny Chia","display_name":"Johnny Chia","email":"johnny.chialung@windriver.com","username":"jchialun"},"change_message_id":"ebf09ca6aaaca7624848166f0383d202a71253e0","unresolved":false,"context_lines":[{"line_number":223,"context_line":"  labels:"},{"line_number":224,"context_line":"{{ tuple $envAll \"mariadb\" \"ingress\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":225,"context_line":"    app.kubernetes.io/instance: {{ $serviceAccountName }}"},{"line_number":226,"context_line":"    app.kubernetes.io/name: \"mariadb\""},{"line_number":227,"context_line":"    app.kubernetes.io/component: \"ingress\""},{"line_number":228,"context_line":"    app.kubernetes.io/managed-by: {{ $envAll.Release.Service }}"},{"line_number":229,"context_line":"{{- if $envAll.Chart.AppVersion }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"80393c68_1cdf391d","side":"PARENT","line":226,"in_reply_to":"58dffd91_dcfea80e","updated":"2024-10-03 16:41:55.000000000","message":"Done","commit_id":"f361feb69aeef1c99f035e1aa9dbff19edf9918a"}],"releasenotes/notes/helm-toolkit.yaml":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"d803f92569cdb4e1b4c170a03908e66f5db4d660","unresolved":true,"context_lines":[{"line_number":83,"context_line":"  - 0.2.74 Remove trailing slash in endpoinds"},{"line_number":84,"context_line":"  - 0.2.75 Add daemonset_overrides_root util"},{"line_number":85,"context_line":"  - 0.2.76 update tookit to support fqdn alias"},{"line_number":86,"context_line":"  - 0.2.77 Add label to allow FluxCD operator look for the status of every pod"},{"line_number":87,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1e056a0d_e470fd00","line":86,"updated":"2024-10-01 18:48:53.000000000","message":"nit: I think this message can be more generic, since adding the labels can be useful for more than only fluxcd operators integration.\n\nIMHO something aligned with you commit message would be better here:\n\"Add recommended kubernetes name label to pods definition\"","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"},{"author":{"_account_id":37226,"name":"Johnny Chia","display_name":"Johnny Chia","email":"johnny.chialung@windriver.com","username":"jchialun"},"change_message_id":"ebf09ca6aaaca7624848166f0383d202a71253e0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  - 0.2.74 Remove trailing slash in endpoinds"},{"line_number":84,"context_line":"  - 0.2.75 Add daemonset_overrides_root util"},{"line_number":85,"context_line":"  - 0.2.76 update tookit to support fqdn alias"},{"line_number":86,"context_line":"  - 0.2.77 Add label to allow FluxCD operator look for the status of every pod"},{"line_number":87,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c3df6b2a_d96e64b6","line":86,"in_reply_to":"1e056a0d_e470fd00","updated":"2024-10-03 16:41:55.000000000","message":"Done","commit_id":"613a4d9d8ceade6678dc6baa2a50b300b654521b"}]}