)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"7901c620aba575695c7424420e0b6020d48b0b0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"65ef6556_0714b012","updated":"2024-11-02 00:33:40.000000000","message":"FYI see the commend above","commit_id":"f630c152e8bba1fdf51601c7ae75e8f40f39c5b8"}],"mariadb/templates/job-cluster-wait.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e29bda1bbecc5a6847c11edd04614df3c4fece6e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"              mountPath: /etc/mysql/admin_user.cnf"},{"line_number":110,"context_line":"              subPath: admin_user.cnf"},{"line_number":111,"context_line":"              readOnly: true"},{"line_number":112,"context_line":"{{ dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.secrets.tls.oslo_db.server.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":113,"context_line":"      volumes:"},{"line_number":114,"context_line":"        - name: pod-tmp"},{"line_number":115,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fda62df_669a4a11","line":112,"updated":"2024-11-01 22:51:07.000000000","message":"As we discussed during PTG it is better to use common helm practices. Regarding volumes and volumeMounts this means having explicit lists of volumes in values.yaml instead of relying on implicit logic in helm-toolkit snippets. See for example [1].  \n\nHowever, the above is a part of a bigger picture and we will later discuss  values.yaml format re-factoring in the corresponding spec. \n\nThis particular PS looks good and follows the current paradigm.\n\n\n[1] https://github.com/bitnami/charts/blob/main/bitnami/mysql/values.yaml#L521-L526","commit_id":"3080e4d5e5125f41ff44a594db9c7aee4e36e77b"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"b88f9bbac19fec55b3c2b96465a7e4fa8fbbd2eb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"              mountPath: /etc/mysql/admin_user.cnf"},{"line_number":110,"context_line":"              subPath: admin_user.cnf"},{"line_number":111,"context_line":"              readOnly: true"},{"line_number":112,"context_line":"{{ dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.secrets.tls.oslo_db.server.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":113,"context_line":"      volumes:"},{"line_number":114,"context_line":"        - name: pod-tmp"},{"line_number":115,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7c19d428_24b2ce48","line":112,"in_reply_to":"1fda62df_669a4a11","updated":"2024-11-01 23:33:02.000000000","message":"Acknowledged","commit_id":"3080e4d5e5125f41ff44a594db9c7aee4e36e77b"}]}