)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"f9cef460be8c610cfdaecfd6550b4629f6e88343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"069c2bab_f7db6b69","updated":"2024-11-13 20:32:00.000000000","message":"recheck","commit_id":"ef707fa3f3c0ed19a524b183d0a4a60e0c30c626"}],"mariadb/templates/bin/_start.py.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2d253c68bf3e96b2f0662e57d4ba4ecf09673d2e","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3026039c_b8696512","line":897,"updated":"2024-11-13 02:03:00.000000000","message":"What about joining threads?\nmonitor_cluster_thread.join()\nleader_election_thread.join()","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d37b949dba2639a324a188b0e0e662d22c701cd2","unresolved":false,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"00bfe6c1_811a3d0c","line":897,"in_reply_to":"1a9b6178_5622f6ca","updated":"2024-11-13 19:10:05.000000000","message":"Done","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2938e6d2d91e8c4bc158b19101a3fbfe83fba8a2","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"be54a08a_9e00557e","line":897,"in_reply_to":"1e1d9af0_0f1e5665","updated":"2024-11-13 16:13:30.000000000","message":"I mean this change looks like you are trying to take care of these daemon threads before exiting but you don\u0027t even try to give them time to exit correctly.\n\nOn the other hand if you use daemon threads then they do not prevent you from being able to exit from the process and you can just ignore these daemon threads. So this change seems not to make much sense if you don\u0027t join to these threads. Maybe I am missing something.","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4e811a67598af0e793416851ae825c94b7824e25","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1e1d9af0_0f1e5665","line":897,"in_reply_to":"3026039c_b8696512","updated":"2024-11-13 11:53:19.000000000","message":"when you join() thread it will block unless thread is completed, our threads are daemons or I missed the question?","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2a9f8ab266fc804d898679304b987111cc67edda","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7f4e0368_a3959222","line":897,"in_reply_to":"74c0053e_2f375592","updated":"2024-11-13 18:26:28.000000000","message":"monitor_cluster_thread.join() - yes, otherwise this event doesn\u0027t make sense because the thread is daemon.","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"704fa539b6aebb1cfb39a621f9eddc3121c48fcd","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1a9b6178_5622f6ca","line":897,"in_reply_to":"7f4e0368_a3959222","updated":"2024-11-13 18:37:31.000000000","message":"I misunderstood comment, fixed now, it makes sense to join() to wait actuall that thread is finished.","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b4a0a0f9a7b1b712f5bb9dca166e6da4f5d95940","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"aecfbded_7cb36ae3","line":897,"in_reply_to":"a1f57f04_d0d6c921","updated":"2024-11-13 17:08:06.000000000","message":"And that is why you\u0027d better join to these threads.","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a20902eb22938ed9c703b792f17af98bf4e3e61f","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"74c0053e_2f375592","line":897,"in_reply_to":"aecfbded_7cb36ae3","updated":"2024-11-13 18:08:05.000000000","message":"monitor_cluster_thread.join() \u003c- this will block unless thread is finished\nleader_election_thread.join() \u003c-- this will never be called as previous thread is running with wile True inside.","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d9294ba4afc67f6fa4afe755925e125abeb056ff","unresolved":true,"context_lines":[{"line_number":894,"context_line":"def sigterm_shutdown(x, y):"},{"line_number":895,"context_line":"    \"\"\"Shutdown the instance of mysqld on shutdown signal.\"\"\""},{"line_number":896,"context_line":"    logger.info(\"Got a sigterm from the container runtime, time to go.\")"},{"line_number":897,"context_line":"    stop_event.set()"},{"line_number":898,"context_line":"    stop_mysqld()"},{"line_number":899,"context_line":"    sys.exit(0)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"a1f57f04_d0d6c921","line":897,"in_reply_to":"be54a08a_9e00557e","updated":"2024-11-13 17:00:10.000000000","message":"we still need to terminate them gracefully, we do not want to break the processes in the middle when they write data into state configmaps.","commit_id":"49b1a21d6d69291b09fdbdcf38edb88350b320ca"}]}