)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"c99ab63c89e967b0d6159c3701fe62a1038e0da2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36b2986a_b13997a7","updated":"2026-08-26 22:50:35.000000000","message":"We should hit the healthcheck endpoint for these and not top level.","commit_id":"0b184dfd2399ec153f55a97258e94a578c179415"}],"heat/templates/deployment-api.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c83fb7272297709b3c302b8eb51eb6624adc3d36","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"heatLivenessProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"orchestration\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /"},{"line_number":19,"context_line":"  {{- if .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":20,"context_line":"  port: {{ .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":21,"context_line":"  {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4e137218_e43cf6d4","line":18,"updated":"2026-08-27 21:00:01.000000000","message":"why didn\u0027t you use the same value here as in the readiness probe?","commit_id":"9c624eded3d59d92fdaee9cdc58b539180574b75"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e6fc2cc9d95e37f746d6c210f30fd1b0992f8c4f","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"heatLivenessProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"orchestration\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /"},{"line_number":19,"context_line":"  {{- if .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":20,"context_line":"  port: {{ .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":21,"context_line":"  {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f9bc9fc_c121e9ac","line":18,"in_reply_to":"393a6bf2_54b5484f","updated":"2026-09-01 21:14:06.000000000","message":"Nevermind. Now I see. My fault. You are right.","commit_id":"9c624eded3d59d92fdaee9cdc58b539180574b75"},{"author":{"_account_id":20248,"name":"Jaymes Mosher","email":"jmosher@mirantis.com","username":"jmosher"},"change_message_id":"5d2c2dc83162e205a5206056c3df944e0013415c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"heatLivenessProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"orchestration\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /"},{"line_number":19,"context_line":"  {{- if .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":20,"context_line":"  port: {{ .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":21,"context_line":"  {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c6fb7753_593a1d9f","line":18,"in_reply_to":"4e137218_e43cf6d4","updated":"2026-09-01 16:52:29.000000000","message":"The liveness probes currently default to hitting the uwsgi stats port on 1717, not the api port.  Neutron is the same way, so I left it as-is.  But, the uwsgi stats seems to respond the same regardless of URL (/ or /healthcheck).  Unless there was a particular reason to keep it as /, I think we could change to /healthcheck","commit_id":"9c624eded3d59d92fdaee9cdc58b539180574b75"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"f0a3cd4c3da4f5462deff82b548690a2cbe2e90c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"heatLivenessProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"orchestration\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /"},{"line_number":19,"context_line":"  {{- if .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":20,"context_line":"  port: {{ .Values.pod.probes.api.heat_api.liveness.port }}"},{"line_number":21,"context_line":"  {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"393a6bf2_54b5484f","line":18,"in_reply_to":"c6fb7753_593a1d9f","updated":"2026-09-01 19:20:00.000000000","message":"I mean you added the healthcheck endpoints for both api and cloudformation but the healthcheck path is hardcoded as \"/\". It should probably be something like\n```\npath: {{ tuple \"orchestration\" \"healthcheck\" \"internal\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}\n```","commit_id":"9c624eded3d59d92fdaee9cdc58b539180574b75"}]}