)]}'
{"id":"openstack%2Fopenstack-helm~1010598","triplet_id":"openstack%2Fopenstack-helm~master~I3f746b891c407a33082fccc472615ba4150183ba","project":"openstack/openstack-helm","branch":"master","topic":"tls-sidecar-nonroot","attention_set":{},"removed_from_attention_set":{"7102":{"account":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"last_update":"2026-10-15 17:56:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3f746b891c407a33082fccc472615ba4150183ba","subject":"Render the API extraContainers and extraVolumes through tpl","status":"MERGED","created":"2026-10-15 05:50:59.000000000","updated":"2026-10-15 17:57:29.000000000","submitted":"2026-10-15 17:56:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1010598-tls-sidecar-nonroot","meta_rev_id":"d4072acaa7de8772c9ea47fd7caf5bf0c0003eb7","_number":1010598,"virtual_id_number":1010598,"owner":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-15 17:56:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"all":[{"value":2,"date":"2026-10-15 16:59:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":2,"date":"2026-10-15 14:47:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"all":[{"value":1,"date":"2026-10-15 16:59:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-15 07:34:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-10-15 14:47:13.000000000","updated_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"reviewer":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"state":"REVIEWER"},{"updated":"2026-10-15 16:59:32.000000000","updated_by":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"reviewer":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"state":"REVIEWER"}],"messages":[{"id":"c355f949685165ad5d0dc7e48bf94c33803ad825","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2026-10-15 05:50:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e51c0430ec1a3316c8a2e211384c97a8a0771f2c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-15 07:34:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/89cc2073264643719110aba66e177cc2\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fbdfabff03854a1d83d1d458a9550891 : SUCCESS in 2m 50s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/db85815e228c4a76a0b4e47633f86ce2 : SUCCESS in 3m 03s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/a6585d4aaadb4cc3b83f1c68160c3203 : SUCCESS in 2m 41s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/32663689bfbf437b8fbadf96a6a3d72e : SUCCESS in 1m 20s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/b634d9a4d52c4b23b8d77e50e73effb0 : SUCCESS in 3m 49s\n- openstack-helm-compute-kit-2025-2-ubuntu_noble https://zuul.opendev.org/t/openstack/build/e4d5b970f688421bbd24aa428574135d : SUCCESS in 1h 37m 47s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/604a590a63874080a78f038edd799ca1 : SUCCESS in 58m 08s\n- openstack-helm-tls-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/9966b3eab8fe431da300ab54d41f79a9 : SUCCESS in 57m 03s\n- openstack-helm-dpdk-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/9d762deef0cb43f8a77bd8f21ce5e7ee : SUCCESS in 57m 08s\n- openstack-helm-crd-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/4c56c2dce3b448e9817bba0aea9bf443 : SUCCESS in 52m 51s\n- openstack-helm-operators-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/16a8199ba4b64eebb97f828387f2e09f : SUCCESS in 1h 15m 56s\n- openstack-helm-horizon-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/aa0565289ab144678bfa9a77be9a2c6f : SUCCESS in 26m 25s\n- openstack-helm-compute-kit-2026-2-ubuntu_resolute https://zuul.opendev.org/t/openstack/build/e93ec436b3ed4a8cb3c5f87820d6a173 : SUCCESS in 1h 15m 44s","accounts_in_message":[],"_revision_number":1},{"id":"67be6471dd3e00f64e840d4cd574d78c2171f32d","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-10-15 14:47:13.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ba88798eabd5710dd032ffb4fa7a22c7ec259fe2","author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"date":"2026-10-15 16:59:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"80d87a07ec051bfc545ee8bfcdfeca8dd2a9a461","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-15 16:59:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0e9e2a2ef28ff50cedef5cc92cf396f47518cf41","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-15 17:56:33.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bb05368b1f6e47a788d3a2b96155645f\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/320f150758594a4b86ecf13cf3a03d32 : SUCCESS in 3m 36s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/e3da200e073748a1afdf76ddc06d7ed8 : SUCCESS in 3m 19s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/8b0d6628ffd54c5c879da32145f1781c : SUCCESS in 2m 49s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/ea567c3656ab4c7faf1d6a603110f3cc : SUCCESS in 54m 29s\n- openstack-helm-logging https://zuul.opendev.org/t/openstack/build/caace82900d441b19bf1f258984e2e58 : SUCCESS in 42m 26s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/d1e25113dcfc4846a6814a5a02ff2e1e : SUCCESS in 19m 55s\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/openstack/openstack-helm/playbooks/prepare-hosts.yaml for job openstack-helm-compute-kit-2026-1-ubuntu_noble.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/openstack/openstack-helm/playbooks/mount-volumes.yaml for job openstack-helm-compute-kit-2026-1-ubuntu_noble.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/openstack/openstack-helm/playbooks/use-buildset-registry.yaml for job openstack-helm-compute-kit-2026-1-ubuntu_noble.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/openstack/openstack-helm/playbooks/inject-keys.yaml for job openstack-helm-compute-kit-2026-1-ubuntu_noble.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/openstack/openstack-helm/playbooks/deploy-env.yaml for job openstack-helm-compute-kit-2026-1-ubuntu_noble.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":1},{"id":"7a852f76ce2268792680e79e09a118d8b8086d23","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-15 17:56:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d4072acaa7de8772c9ea47fd7caf5bf0c0003eb7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-15 17:57:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c21d2bbfa12c41a793b3f10bd33795d4\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bf15628861d64ef78da8ba4ebe4487d7 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1275eff8c720d7271363ae42cb2360fcbd8e870a","revisions":{"1275eff8c720d7271363ae42cb2360fcbd8e870a":{"kind":"REWORK","_number":1,"created":"2026-10-15 05:50:59.000000000","uploader":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"ref":"refs/changes/98/1010598/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/98/1010598/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/98/1010598/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/98/1010598/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/98/1010598/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/98/1010598/1"}}},"commit":{"parents":[{"commit":"511a2e3fb085ab815df4deae5ad1ae2c0037f591","subject":"Merge \"fix(ironic): render the missing conductor pod annotations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/511a2e3fb085ab815df4deae5ad1ae2c0037f591"}]}],"author":{"name":"Thomas Bechtold","email":"thomasbechtold@jpberlin.de","date":"2026-10-15 04:43:54.000000000","tz":120},"committer":{"name":"Thomas Bechtold","email":"thomasbechtold@jpberlin.de","date":"2026-10-15 05:50:45.000000000","tz":120},"subject":"Render the API extraContainers and extraVolumes through tpl","message":"Render the API extraContainers and extraVolumes through tpl\n\nThe extraContainers and extraVolumes hooks added for the nginx TLS\nsidecars (992528) render their entries with toYaml only, so an entry\ncannot refer to values. The tls-gateway-and-sidecar.yaml overrides\nrepeat the sidecar image in every container spec, and since\nextraContainers is a list, a deployer who wants another image has to\ncopy the whole container.\n\nPass each entry through tpl. The ironic, libvirt, openvswitch and\nmemcached charts already render their extraContainers that way, and\nthe ironic prometheus-exporter.yaml override relies on it to take the\nimage from images.tags. The range stays, so a map of containers keeps\nworking as well. Entries without template actions render as before:\nevery chart renders the same with its default values.\n\nAlso fix the values comments that still pointed at the api-tls.yaml\noverrides.\n\nChangelog: changed: pod.extraContainers and pod.extraVolumes entries are rendered through tpl\nAssisted-by: Claude Opus 5.5\nChange-Id: I3f746b891c407a33082fccc472615ba4150183ba\nSigned-off-by: Thomas Bechtold \u003cthomasbechtold@jpberlin.de\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1275eff8c720d7271363ae42cb2360fcbd8e870a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1275eff8c720d7271363ae42cb2360fcbd8e870a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
