)]}'
{"id":"openstack%2Fopenstack-helm~1011048","triplet_id":"openstack%2Fopenstack-helm~master~I09dc433d05575fe19f13bb43d5ef09d4f60b4eaf","project":"openstack/openstack-helm","branch":"master","topic":"ironic-pxe-ipa-bootstrap","attention_set":{},"removed_from_attention_set":{"39426":{"account":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"last_update":"2026-10-21 12:36:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I09dc433d05575fe19f13bb43d5ef09d4f60b4eaf","subject":"fix(ironic): Render bootstrap without openstack user","status":"MERGED","created":"2026-10-17 05:11:46.000000000","updated":"2026-10-21 12:38:43.000000000","submitted":"2026-10-21 12:36:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1011048-ironic-pxe-ipa-bootstrap","meta_rev_id":"3278fc4714d97abe35ee9e891e7ac8309f532ec0","_number":1011048,"virtual_id_number":1011048,"owner":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-21 12:36:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"all":[{"value":2,"date":"2026-10-20 21:07:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":2,"date":"2026-10-20 07:32:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"all":[{"value":1,"date":"2026-10-20 21:07:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-17 05:41:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-10-19 15:25:44.000000000","updated_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"reviewer":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"state":"REVIEWER"},{"updated":"2026-10-20 21:07:54.000000000","updated_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"reviewer":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"state":"REVIEWER"}],"messages":[{"id":"cad9d1f4e7c69560b2dfa5907ad4afc4dc2fdd6a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"date":"2026-10-17 05:11:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf0c099225a8b59660c4017c9d16922815a082fb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-17 05:41:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3ac730ac137c45a4a41cd65a5a2c3ba5\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/949b657710c6417da0394b3422ee2055 : SUCCESS in 2m 43s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/cd1c642ee353444cadec25b594de22e5 : SUCCESS in 4m 23s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/93cd26d8b5f449c093da0c70210ff616 : SUCCESS in 2m 54s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/2d9c41e9be9a4458943fe1b952bd6e8d : SUCCESS in 1m 53s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/60338a83afa8419fa046887ca6e6f383 : SUCCESS in 2m 21s\n- openstack-helm-ironic-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/deaff86beea04585b2f2713690c3adc6 : SUCCESS in 24m 05s","accounts_in_message":[],"_revision_number":1},{"id":"f126af68cf2d72f37936c793529efa5bf1b46df9","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2026-10-19 15:25:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b0c734d1c5d22f773c18156aa8c7e97f2b3be09b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"date":"2026-10-20 07:32:55.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9342bda337d5576a2de02e22971b26d4c162cba2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-20 08:18:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ce6ce3b2b08f440687a590557a630502\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/57c78730824c4a6f92c79967b5c9d50f : SUCCESS in 6m 01s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/d548532a9d8042049e6c0378948da4d8 : SUCCESS in 3m 38s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/7ad319ea25304fc1944153b15040e218 : SUCCESS in 3m 38s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/a94f8848d3b8405c8663ac057ee98f36 : SUCCESS in 2m 04s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/1cc3b57b374b46c88144da995fdf4376 : SUCCESS in 3m 25s\n- openstack-helm-ironic-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/6b8840ad933149839c5c77ba5c35e804 : SUCCESS in 25m 30s","accounts_in_message":[],"_revision_number":2},{"id":"3344a6ef79068cb106bde22b2b3e74edb8f4e685","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-10-20 21:07:54.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bf39141687d67e2bdd3d3fc7ed47f5da47c1326f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 10:42:54.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"998751c2d2c0399b7ffcc468e944de56bd9b38d8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 12:36:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/53d2502792384cecbbacba446f1a2d0c\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6b38bce918d2453fb18959b5856160d4 : SUCCESS in 2m 33s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/f4350fddbd564fc8ada3b16dd40273c8 : SUCCESS in 3m 11s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/eb58720652d04ba58589d45e72d5f086 : SUCCESS in 2m 08s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/62ac38e240ae4105b87feefb0c426dc4 : SUCCESS in 1h 36m 35s\n- openstack-helm-logging https://zuul.opendev.org/t/openstack/build/43e5328fd06143988e8c5d8a3be8d231 : SUCCESS in 34m 47s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/7e9227fb1dc84c87a150b063ee39be6c : SUCCESS in 19m 48s","accounts_in_message":[],"_revision_number":2},{"id":"48948302ab99e62fd5cc9422e509594f7211c9a1","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 12:36:51.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"3278fc4714d97abe35ee9e891e7ac8309f532ec0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 12:38:43.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fc2064889e8044d894a2b184919877fd\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/02009545546e492e8ddcfe5fd0140aa6 : SUCCESS in 44s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a94707677d40cecc31590f4f7ec8eeed15cf32a4","revisions":{"64633353b4b7d5b1def9a2d82f17cc4c708ebb84":{"kind":"REWORK","_number":1,"created":"2026-10-17 05:11:46.000000000","uploader":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"ref":"refs/changes/48/1011048/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/48/1011048/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/1"}}},"commit":{"parents":[{"commit":"17d25b837ad25668a8eb11b221cc82873c63098f","subject":"fix(ironic): Bootstrap the diskimage-builder IPA","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/17d25b837ad25668a8eb11b221cc82873c63098f"}]}],"author":{"name":"Simon Zhou","email":"td@fivetime.ltd","date":"2026-10-17 05:08:33.000000000","tz":0},"committer":{"name":"Simon Zhou","email":"td@fivetime.ltd","date":"2026-10-17 05:08:57.000000000","tz":0},"subject":"fix(ironic): Render bootstrap without openstack user","message":"fix(ironic): Render bootstrap without openstack user\n\nWith bootstrap.image.openstack.enabled false the template called\ninclude \"helm-toolkit.manifests.job_bootstrap\" without its context\nargument, so rendering failed with \"wrong number of args for include\".\n\nBuild the same job in both cases and only set keystoneUser from\nbootstrap.image.openstack.ks_user when openstack is enabled; otherwise\nhelm-toolkit falls back to the ironic user. The job rendered with\nopenstack enabled is unchanged.\n\nChangelog: fixed: The chart renders with\n  bootstrap.image.openstack.enabled set to false\nAssisted-By: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I09dc433d05575fe19f13bb43d5ef09d4f60b4eaf\nSigned-off-by: Simon Zhou \u003ctd@fivetime.ltd\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/64633353b4b7d5b1def9a2d82f17cc4c708ebb84"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/64633353b4b7d5b1def9a2d82f17cc4c708ebb84"}]},"branch":"refs/heads/master"},"a94707677d40cecc31590f4f7ec8eeed15cf32a4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-10-20 07:32:55.000000000","uploader":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"ref":"refs/changes/48/1011048/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/48/1011048/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/48/1011048/2"}}},"commit":{"parents":[{"commit":"afc2e121a31f6a15106010378a23b29d1ce31b08","subject":"fix(ironic): Bootstrap the diskimage-builder IPA","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/afc2e121a31f6a15106010378a23b29d1ce31b08"}]}],"author":{"name":"Simon Zhou","email":"td@fivetime.ltd","date":"2026-10-17 05:08:33.000000000","tz":0},"committer":{"name":"Simon Zhou","email":"td@fivetime.ltd","date":"2026-10-20 07:28:23.000000000","tz":0},"subject":"fix(ironic): Render bootstrap without openstack user","message":"fix(ironic): Render bootstrap without openstack user\n\nWith bootstrap.image.openstack.enabled false the template called\ninclude \"helm-toolkit.manifests.job_bootstrap\" without its context\nargument, so rendering failed with \"wrong number of args for include\".\n\nBuild the same job in both cases and only set keystoneUser from\nbootstrap.image.openstack.ks_user when openstack is enabled; otherwise\nhelm-toolkit falls back to the ironic user. The job rendered with\nopenstack enabled is unchanged.\n\nChangelog: fixed: The chart renders with\n  bootstrap.image.openstack.enabled set to false\nAssisted-By: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I09dc433d05575fe19f13bb43d5ef09d4f60b4eaf\nSigned-off-by: Simon Zhou \u003ctd@fivetime.ltd\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a94707677d40cecc31590f4f7ec8eeed15cf32a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a94707677d40cecc31590f4f7ec8eeed15cf32a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
