)]}'
{"id":"openstack%2Fopenstack-helm~1011386","triplet_id":"openstack%2Fopenstack-helm~master~I39914330ae9ba4886c99072476463927f88da89b","project":"openstack/openstack-helm","branch":"master","attention_set":{},"removed_from_attention_set":{"5890":{"account":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"last_update":"2026-10-21 12:36:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I39914330ae9ba4886c99072476463927f88da89b","subject":"fix(manila): render the manila-share governing service","status":"MERGED","created":"2026-10-19 19:55:21.000000000","updated":"2026-10-21 12:36:43.000000000","submitted":"2026-10-21 12:36:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1011386","meta_rev_id":"a0dc61b329eb59fd7577b18585a594551b12f6c6","_number":1011386,"virtual_id_number":1011386,"owner":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-21 12:36:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"all":[{"value":2,"date":"2026-10-21 10:40:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":2,"date":"2026-10-20 21:06:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"all":[{"value":1,"date":"2026-10-21 10:40:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-19 20:31:33.000000000","updated_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"reviewer":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"state":"REVIEWER"},{"updated":"2026-10-19 21:37:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-10-21 10:40:58.000000000","updated_by":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"reviewer":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"state":"REVIEWER"}],"messages":[{"id":"e8fb7f7a13d3296f135726ffb73cf25ca81c7432","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-10-19 19:55:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b779e5b7280d0932e5d7b4f0134247e711c24453","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2026-10-19 20:31:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"044fad4b54535e4b7c2940f37ad7ced10d39a39a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-19 21:37:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/44a9e6c70a9d4bafa58230281a9330ac\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1cce051315f74f699f0cb2448c1c65c0 : SUCCESS in 4m 42s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/c46aea6f8b98444c95b153179c423351 : FAILURE in 2m 25s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/21fdcada768e4e229d721a997c88b0f2 : SUCCESS in 3m 12s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/aac1cb73c9414115856745a089d2b769 : SUCCESS in 2m 55s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/510b8d798341486e8a9fd08c73f44bde : SUCCESS in 2m 29s\n- openstack-helm-manila-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/fe6458d3d9e64508afe70d816ef5cfa6 : SUCCESS in 1h 35m 13s","accounts_in_message":[],"_revision_number":1},{"id":"431f09a82adc532d90fa3ace30fba9b510f7ac54","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-10-20 21:06:18.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0fbbdfa30c18385d29a9ea3f1a401c23569caacb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-20 22:41:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b78f658f0534497b9588b72a434ea263\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3205577c8d6a4abfab77a85e18d13e31 : SUCCESS in 2m 19s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/9e01595d7b86455c8ca42b362675d21e : SUCCESS in 2m 28s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/8a816dcafbd943dda838bbc437d014c9 : SUCCESS in 2m 51s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/910631eeb8f546749ad5f43ed0f00ec7 : SUCCESS in 1m 36s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/59d8d6af743540afb7d6ae97981f61ec : SUCCESS in 3m 30s\n- openstack-helm-manila-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/3010365af97a4234ba0516227f41b34c : SUCCESS in 1h 31m 23s","accounts_in_message":[],"_revision_number":2},{"id":"de1317eaaa59062cd79723e918194d2b920d9ef0","author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"date":"2026-10-21 10:40:58.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6a6822438a4ea4b2fc09b184c643865592243243","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 10:41:13.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"13be9a30648155d6731ee2f84fd314a25fbaa8b7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 12:36:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d746ce493f4e489b885257f0c04a1d4c\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8a6d34fe75eb45fc8c19a0ee557718d3 : SUCCESS in 2m 26s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/6f0c1511c4c9456f9ea3c931687d6ff7 : SUCCESS in 1m 57s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/34bc395503e34428816187aa2516f5bd : SUCCESS in 2m 40s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/ed81de00fc3f40468b99497f01f38d2e : SUCCESS in 1h 44m 00s\n- openstack-helm-logging https://zuul.opendev.org/t/openstack/build/3c83de2e538e4f3f909491bbc135650b : SUCCESS in 39m 51s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/ccb36a6802004f62856972bf238be214 : SUCCESS in 20m 00s","accounts_in_message":[],"_revision_number":2},{"id":"a0dc61b329eb59fd7577b18585a594551b12f6c6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-21 12:36:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a960bdcf060d3c30e23d41b3c429bf64f1a37278","revisions":{"c33dbf3ad089cc2ad50ac74961c5459f34330697":{"kind":"REWORK","_number":1,"created":"2026-10-19 19:55:21.000000000","uploader":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"ref":"refs/changes/86/1011386/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/86/1011386/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/1"}}},"commit":{"parents":[{"commit":"717bd7bb9aa17112858ffb258ce3a123b0ebddde","subject":"fix(manila): size the share init containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/717bd7bb9aa17112858ffb258ce3a123b0ebddde"}]}],"author":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-10-01 00:58:27.000000000","tz":-300},"committer":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-10-19 19:54:34.000000000","tz":-300},"subject":"fix(manila): render the manila-share governing service","message":"fix(manila): render the manila-share governing service\n\nThe opt-in manila-share StatefulSet names manila-share as its\nserviceName, but the chart never rendered that service, so the\nStatefulSet published no per-ordinal DNS. Render a headless service\nnamed manila-share under the same manifests.statefulset_share value,\nsince the two are never useful apart. manila-share listens on nothing,\nso the service declares no ports. It does not publish not-ready\naddresses: the pod has no readiness probe.\n\nAlso define\npod.lifecycle.upgrades.statefulsets.pod_replacement_strategy, which the\nchart did not carry, so kubernetes_upgrades_statefulset renders an\nexplicit updateStrategy instead of nothing.\n\nAssisted-by: Claude Opus 5.5\nChange-Id: I39914330ae9ba4886c99072476463927f88da89b\nSigned-off-by: Doug Goldstein \u003ccardoe@cardoe.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c33dbf3ad089cc2ad50ac74961c5459f34330697"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c33dbf3ad089cc2ad50ac74961c5459f34330697"}]},"branch":"refs/heads/master"},"a960bdcf060d3c30e23d41b3c429bf64f1a37278":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-10-20 21:06:18.000000000","uploader":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"ref":"refs/changes/86/1011386/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/86/1011386/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/86/1011386/2"}}},"commit":{"parents":[{"commit":"306a7faaad3ba32ac62a169520ec609247305d98","subject":"fix(manila): size the share init containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/306a7faaad3ba32ac62a169520ec609247305d98"}]}],"author":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-10-01 00:58:27.000000000","tz":-300},"committer":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-10-20 20:58:31.000000000","tz":-300},"subject":"fix(manila): render the manila-share governing service","message":"fix(manila): render the manila-share governing service\n\nThe opt-in manila-share StatefulSet names manila-share as its\nserviceName, but the chart never rendered that service, so the\nStatefulSet published no per-ordinal DNS. Render a headless service\nnamed manila-share under the same manifests.statefulset_share value,\nsince the two are never useful apart. manila-share listens on nothing,\nso the service declares no ports. It does not publish not-ready\naddresses: the pod has no readiness probe.\n\nAlso define\npod.lifecycle.upgrades.statefulsets.pod_replacement_strategy, which the\nchart did not carry, so kubernetes_upgrades_statefulset renders an\nexplicit updateStrategy instead of nothing.\n\nAssisted-by: Claude Opus 5.5\nChange-Id: I39914330ae9ba4886c99072476463927f88da89b\nSigned-off-by: Doug Goldstein \u003ccardoe@cardoe.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a960bdcf060d3c30e23d41b3c429bf64f1a37278"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a960bdcf060d3c30e23d41b3c429bf64f1a37278"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}