)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"9c7c5ec2b4d457e28255f9c126e9a0146c4be153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2751919b_10d86fd7","updated":"2026-10-22 17:49:50.000000000","message":"recheck","commit_id":"316571adb53d010ebf0aa7bc7301cad6f8aec903"}],"ovn/templates/daemonset-controller.yaml":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"aedd50ccd10dfb6e5a6bb5fea0887ac403082378","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    spec:"},{"line_number":74,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":75,"context_line":"{{- if $envAll.Values.pod.tolerations.ovn_controller.enabled }}"},{"line_number":76,"context_line":"{{ tuple $envAll \"ovn_controller\" | include \"helm-toolkit.snippets.kubernetes_tolerations\" | indent 6 }}"},{"line_number":77,"context_line":"{{- end }}"},{"line_number":78,"context_line":"      hostNetwork: true"},{"line_number":79,"context_line":"      hostPID: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"47639971_c73a4ac4","line":76,"updated":"2026-10-20 13:33:55.000000000","message":"When testing, I cannot render the resource when tolerations is enabled. This is because there are no default tolerations defined for the \"ovn_controller\" component in values.yaml.\n\nI also found that other charts don\u0027t define tolerations per resources. It\u0027s a generic one for all the resources. In this case, it would be \"ovn\". This also means the one for ovn-bgp-agent would need to be changed.","commit_id":"136a68aa773e191ed83139ec7debd3a1fbc8ec1b"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"b91361d6633367686a8fc7e738b6ab2528cb5bdb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    spec:"},{"line_number":74,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":75,"context_line":"{{- if $envAll.Values.pod.tolerations.ovn_controller.enabled }}"},{"line_number":76,"context_line":"{{ tuple $envAll \"ovn_controller\" | include \"helm-toolkit.snippets.kubernetes_tolerations\" | indent 6 }}"},{"line_number":77,"context_line":"{{- end }}"},{"line_number":78,"context_line":"      hostNetwork: true"},{"line_number":79,"context_line":"      hostPID: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1b54b13c_e300ec61","line":76,"in_reply_to":"47639971_c73a4ac4","updated":"2026-10-22 15:12:29.000000000","message":"Thanks, you are right: setting enabled alone did not render, because none of the four components had a default list. Patch set 2 gives each of them the same default as ovn_bgp_agent (control-plane, NoSchedule), so enabled: true alone renders; I checked each component on its own, and the defaults render exactly as before.\n\nOn one key for the whole chart, I would rather keep the per-component keys here. The OVN components run on different nodes: ovn-controller is a DaemonSet that has to run on every node that hosts ports, including tainted network and compute nodes, while the NB/SB databases and northd belong on the control plane. With a single key, the databases would have to tolerate every taint the controller needs. ceph-client, ceph-mon and ceph-provisioners use per-component keys for the same reason, and ovn_bgp_agent already has its own key (since 226a6f262), so renaming it now would break existing overrides. If you still prefer a single key, I can change it.","commit_id":"136a68aa773e191ed83139ec7debd3a1fbc8ec1b"}]}