)]}'
{"id":"openstack%2Fopenstack-helm~1016508","triplet_id":"openstack%2Fopenstack-helm~master~I0a7d16c20cca53a8b5cd769809bd4aa3be5a75d1","project":"openstack/openstack-helm","branch":"master","attention_set":{},"removed_from_attention_set":{"5890":{"account":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"last_update":"2026-11-20 19:54:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0a7d16c20cca53a8b5cd769809bd4aa3be5a75d1","subject":"fix(kubernetes-node-problem-detector): set maxUnavailable of the DaemonSet","status":"MERGED","created":"2026-11-19 16:16:55.000000000","updated":"2026-11-20 19:56:10.000000000","submitted":"2026-11-20 19:54:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1016508","meta_rev_id":"d889cedb73348b406f3c33b3533d5bf7c40376a0","_number":1016508,"virtual_id_number":1016508,"owner":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-11-20 19:54:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"all":[{"value":2,"date":"2026-11-19 19:30:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":2,"date":"2026-11-20 17:46:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"all":[{"value":0,"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":1,"date":"2026-11-20 17:46:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-19 17:44:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-11-19 19:30:46.000000000","updated_by":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"reviewer":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"state":"REVIEWER"},{"updated":"2026-11-20 17:46:19.000000000","updated_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"reviewer":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"state":"REVIEWER"}],"messages":[{"id":"5d9a1cfc7f305d34593e65894ba5cc7054b55f1f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-11-19 16:16:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee2c98bba17fed383d90230d43ef59cdac0dd502","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-19 17:44:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/39c968b4f6144c6f92455073eb14c2da\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ec64519877143b7aaf7d18315b6fa3f : SUCCESS in 4m 01s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/3f2d0f86dc004eb291532cda2580e78b : SUCCESS in 4m 47s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/439173f796724bd1b47a62bb22e969a9 : SUCCESS in 2m 55s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/4bea06b179204d168ac23431d49b5177 : SUCCESS in 1m 59s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/15133b38ac3e4406916ca8a65677ccd8 : SUCCESS in 3m 15s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/92ce95ce9ccf4eaf9b5b75cc3d7222af : SUCCESS in 36m 34s","accounts_in_message":[],"_revision_number":1},{"id":"93b85c5c64fd52ebe45c29fa61fd4015538f21a6","author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"date":"2026-11-19 19:30:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"07d51fb69224526bc53a3fdaf2e2b17b25fceee9","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2026-11-20 17:46:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"662241b315845b9df5b739d0c281c042f856c65a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-20 17:46:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f40fb0a399599a176ca28f57e1ded7fdb05d55e1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-20 19:54:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d79cc429c27a419bbd3015ada505a78b\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/168a964312b94c119ec0722e111b35cb : SUCCESS in 3m 20s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/7d44e7cdf96f442fb3d785863fb7926c : SUCCESS in 4m 25s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/8fac17482baa43a58b9065497bd9922b : SUCCESS in 1m 54s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/5f409816bb0b4a0e954939c1b90d6fed : SUCCESS in 1h 52m 26s\n- openstack-helm-logging https://zuul.opendev.org/t/openstack/build/d87beba3f67840d09038784fe457e0a4 : SUCCESS in 41m 00s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/d07d1031713044c7b1ec685c94afead2 : SUCCESS in 25m 43s","accounts_in_message":[],"_revision_number":1},{"id":"a5a901854ef0df95d0b84239f356b4ec64c4b146","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-20 19:54:59.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d889cedb73348b406f3c33b3533d5bf7c40376a0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-20 19:56:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f525de558f024976b15cb4e3ec2e4d86\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b6200fab08a04336bd19ff85897c00a9 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"be973aaeff587253da01f6d2b697f1a7731d0792","revisions":{"be973aaeff587253da01f6d2b697f1a7731d0792":{"kind":"REWORK","_number":1,"created":"2026-11-19 16:16:55.000000000","uploader":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"ref":"refs/changes/08/1016508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/08/1016508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/08/1016508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/08/1016508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/08/1016508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/08/1016508/1"}}},"commit":{"parents":[{"commit":"a1436e8673e2ba2d42d0d167bc6e54219399083e","subject":"Merge \"fix: drop the trailing document end from blazar and freezer templates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a1436e8673e2ba2d42d0d167bc6e54219399083e"}]}],"author":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-11-18 02:45:28.000000000","tz":-360},"committer":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-11-19 16:15:16.000000000","tz":-360},"subject":"fix(kubernetes-node-problem-detector): set maxUnavailable of the DaemonSet","message":"fix(kubernetes-node-problem-detector): set maxUnavailable of the DaemonSet\n\nhelm-toolkit.snippets.kubernetes_upgrades_daemonset reads\nmax_unavailable from pod.lifecycle.upgrades.daemonsets.node_problem_detector,\nbut the chart only sets it in pod.lifecycle.upgrades.rolling_update,\nwhich nothing reads. The DaemonSet is rendered with an empty\nmaxUnavailable, which does not validate against the DaemonSet schema.\n\nSet max_unavailable to 1, the value the chart meant to use and the one\nKubernetes falls back to for an empty field. The values that nothing\nreads stay, so existing overrides of them keep rendering.\n\nThe only difference in the rendered chart is \"maxUnavailable: 1\" in the\nDaemonSet, with the default values and with the values_overrides files.\n\nAssisted-By: Claude Opus 5.5\nChange-Id: I0a7d16c20cca53a8b5cd769809bd4aa3be5a75d1\nSigned-off-by: Doug Goldstein \u003ccardoe@cardoe.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/be973aaeff587253da01f6d2b697f1a7731d0792"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/be973aaeff587253da01f6d2b697f1a7731d0792"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
