)]}'
{"id":"openstack%2Fopenstack-helm~1016512","triplet_id":"openstack%2Fopenstack-helm~master~I030046eeeec3c1b472b273af54eddec42ea56280","project":"openstack/openstack-helm","branch":"master","attention_set":{"5890":{"account":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"last_update":"2026-11-20 19:48:47.000000000","reason":"\u003cGERRIT_ACCOUNT_7156\u003e replied on the change","reason_account":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I030046eeeec3c1b472b273af54eddec42ea56280","subject":"refactor: fill in the fluent logging handler with a helm-toolkit snippet","status":"NEW","created":"2026-11-19 16:16:55.000000000","updated":"2026-11-20 19:48:47.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"92d186bba4fde5dfffb7bedcef405393b6371474","_number":1016512,"virtual_id_number":1016512,"owner":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-11-20 00:51:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"all":[{"value":2,"date":"2026-11-20 19:48:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-19 19:58:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-11-20 19:48:47.000000000","updated_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"reviewer":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"state":"REVIEWER"}],"messages":[{"id":"825f3363028c4bfd4768a90c5cab7759bf4fc5d6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-11-19 16:16:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"11b2f2d457e7eaeb0933d1cb70c222d7bac11e54","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-19 19:58:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/78d2658e8acf4d729bbb325e70952e04\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/139ebcac94894a3d9c850b95619f5dc1 : SUCCESS in 4m 10s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/5089ce43103d4d608ea6d336b419dcf8 : SUCCESS in 2m 12s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/da5a345a2b7e46a8ac947f7da0153f00 : SUCCESS in 3m 46s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/47be53240ea849ac82caaa9ed3810095 : SUCCESS in 2m 07s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/29991690277c4bbf81da105f084857e2 : SUCCESS in 7m 26s\n- openstack-helm-compute-kit-2025-2-ubuntu_noble https://zuul.opendev.org/t/openstack/build/c1f456520ea643b389c87038d6e3515e : SUCCESS in 1h 53m 03s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/8fd8f2d8bd1e47a18c761b1049a5db88 : SUCCESS in 1h 52m 01s\n- openstack-helm-tls-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/a18e4fcdc7f8462bbf4332764ddf3c78 : SUCCESS in 1h 58m 14s\n- openstack-helm-dpdk-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/d7b25774980f4512b974dbdd78aa6021 : SUCCESS in 1h 00m 09s\n- openstack-helm-crd-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/a55c02926e584cbea2980ab83459a971 : SUCCESS in 1h 39m 11s\n- openstack-helm-operators-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/e2ccc83237574fcba8f4e0eaecf3b2d7 : SUCCESS in 1h 47m 34s\n- openstack-helm-octavia-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/8ae222b2eebb407db78c7ca313da3f8c : SUCCESS in 50m 29s\n- openstack-helm-octavia-ovn-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/004f0bad49894ce8a6c64dc9871a77c2 : SUCCESS in 51m 03s\n- openstack-helm-blazar-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/df2bc1602ecd42df8ce27a599b2a283f : SUCCESS in 53m 34s\n- openstack-helm-freezer-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/8d523fc4b9084486b93e2dc338a9d0f4 : SUCCESS in 30m 15s\n- openstack-helm-ironic-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/cefce42091e146da9f46fe9bb71278f6 : SUCCESS in 27m 22s\n- openstack-helm-manila-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/7c8dfec9e4c94637931654c97a63fb3f : SUCCESS in 1h 30m 37s\n- openstack-helm-watcher-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/c1a02e407f654e828fbe84cc10c9df5d : SUCCESS in 36m 46s\n- openstack-helm-zaqar-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/f0208ddcd59d49ffae0142a33ff3be11 : SUCCESS in 31m 34s\n- openstack-helm-compute-kit-2026-2-ubuntu_resolute https://zuul.opendev.org/t/openstack/build/a96ab05f8b804d7d8d4d5b0e1e6c86b1 : SUCCESS in 1h 18m 06s\n- openstack-helm-logging https://zuul.opendev.org/t/openstack/build/b68853a2282d4b05b6e9153f76735745 : SUCCESS in 33m 45s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/f11557aa09b04e5590dcd397a486fbb6 : SUCCESS in 28m 45s","accounts_in_message":[],"_revision_number":1},{"id":"8ca8cf9cb7780c867305905ee332582845d625de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-11-19 22:38:04.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nOutdated Votes:\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"35ee14189416454ccaf52a74698b486f6cf5d71f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-20 00:51:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/226da1b421cc479c99adb9bf214de871\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2512774fcf694c30b371e4b120a44307 : SUCCESS in 3m 27s\n- openstack-helm-linter https://zuul.opendev.org/t/openstack/build/3a5c3336d0684de395afad6d7db66e30 : SUCCESS in 3m 42s\n- openstack-helm-pre-commit https://zuul.opendev.org/t/openstack/build/60bb310a971a41f1a484a185de39a413 : SUCCESS in 2m 29s\n- openstack-helm-release-notes https://zuul.opendev.org/t/openstack/build/1226994f7c004044aae1a4d6d40fdfc5 : SUCCESS in 1m 42s\n- openstack-helm-build-charts https://zuul.opendev.org/t/openstack/build/c221d64c64e0424b957fc6b78c8cb1f1 : SUCCESS in 7m 06s\n- openstack-helm-compute-kit-2025-2-ubuntu_noble https://zuul.opendev.org/t/openstack/build/d28ec69f654342768ef4fba7b63d1789 : SUCCESS in 1h 46m 26s\n- openstack-helm-compute-kit-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/520458bed9834bd489d9083bf06cbb15 : SUCCESS in 1h 05m 32s\n- openstack-helm-tls-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/9f0756c01c5e45ecaecdfbdc99b91a71 : SUCCESS in 1h 54m 23s\n- openstack-helm-dpdk-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/dfffe5019a78406580c476229d357c7c : SUCCESS in 57m 51s\n- openstack-helm-crd-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/47d17423a2cd46409501566b0d925aff : SUCCESS in 1h 40m 00s\n- openstack-helm-operators-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/29cbf19e1a884d2fb65924576bcb211f : SUCCESS in 1h 37m 43s\n- openstack-helm-octavia-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/06636fdf39b2497abf88379fc3388f10 : SUCCESS in 1h 13m 39s\n- openstack-helm-octavia-ovn-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/0f88473ce60c4da898f650a091093788 : SUCCESS in 57m 02s\n- openstack-helm-blazar-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/525632f0aa5345dc8ba4db471f9d9322 : SUCCESS in 51m 56s\n- openstack-helm-freezer-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/d27b637e01664a9e96da2c828629b4de : SUCCESS in 34m 44s\n- openstack-helm-ironic-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/6013e89ea6344d92b3e6f58a51f0ac5e : SUCCESS in 14m 40s\n- openstack-helm-manila-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/746d72e9f8de41869767f41b763306ea : SUCCESS in 49m 25s\n- openstack-helm-watcher-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/1c727be003df438d883751f1dcd35d0b : SUCCESS in 36m 17s\n- openstack-helm-zaqar-2026-1-ubuntu_noble https://zuul.opendev.org/t/openstack/build/101c74ffbc2d4a12ad476be528672d64 : SUCCESS in 27m 59s\n- openstack-helm-compute-kit-2026-2-ubuntu_resolute https://zuul.opendev.org/t/openstack/build/35d3efe9d2e647d39901e5a332c069be : SUCCESS in 1h 18m 27s\n- openstack-helm-logging https://zuul.opendev.org/t/openstack/build/14c9fd8e5ff84b5db4dfc413db0c2396 : SUCCESS in 40m 57s\n- openstack-helm-monitoring https://zuul.opendev.org/t/openstack/build/68283199219f4f898b680f199217ed67 : SUCCESS in 26m 44s","accounts_in_message":[],"_revision_number":2},{"id":"92d186bba4fde5dfffb7bedcef405393b6371474","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2026-11-20 19:48:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"095964904d5ceec037cb23749dd4aa4c8b16ba3a","revisions":{"2a984af4c789025f00ff1a60b52c51270a36d63c":{"kind":"REWORK","_number":1,"created":"2026-11-19 16:16:55.000000000","uploader":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"ref":"refs/changes/12/1016512/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/12/1016512/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/1"}}},"commit":{"parents":[{"commit":"f761cc89686243ac361a881dc9636cf4b8b4aec7","subject":"fix: define the fluentd endpoint in the freezer and octavia charts","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f761cc89686243ac361a881dc9636cf4b8b4aec7"}]}],"author":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-11-18 02:57:02.000000000","tz":-360},"committer":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-11-19 16:16:19.000000000","tz":-360},"subject":"refactor: fill in the fluent logging handler with a helm-toolkit snippet","message":"refactor: fill in the fluent logging handler with a helm-toolkit snippet\n\nSeventeen charts carry the same block that fills in the fluent handler\nand formatter of conf.logging, in two variants that differ only in the\nname used for the fluentd tag: twelve use .Release.Name and five use\n.deployment_name. Move the block into the new\nhelm-toolkit.snippets.oslo_logging_fluent snippet, which takes the name\nas deploymentName and defaults to .Release.Name, and call it from the\ncharts. Each chart passes the name it used before; blazar sets\n.deployment_name too but tags with .Release.Name, and keeps doing so.\n\nEvery chart was rendered before and after the change with the default\nvalues and with each file in values_overrides/, and renders as before,\nso no pod restarts on upgrade. With a fluent handler in conf.logging,\nin a normal and in a subchart release, every logging.conf is the same\nas before, including the per-node ones of neutron and nova.\n\nAssisted-By: Claude Opus 5.5\nChange-Id: I030046eeeec3c1b472b273af54eddec42ea56280\nSigned-off-by: Doug Goldstein \u003ccardoe@cardoe.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2a984af4c789025f00ff1a60b52c51270a36d63c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2a984af4c789025f00ff1a60b52c51270a36d63c"}]},"branch":"refs/heads/master"},"095964904d5ceec037cb23749dd4aa4c8b16ba3a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-19 22:38:04.000000000","uploader":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"ref":"refs/changes/12/1016512/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/12/1016512/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/12/1016512/2"}}},"commit":{"parents":[{"commit":"2f8e033b18c8929c60d5195236d38224ecb58fc1","subject":"fix: define the fluentd endpoint in the freezer and octavia charts","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2f8e033b18c8929c60d5195236d38224ecb58fc1"}]}],"author":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-11-18 02:57:02.000000000","tz":-360},"committer":{"name":"Doug Goldstein","email":"cardoe@cardoe.com","date":"2026-11-19 22:38:04.000000000","tz":0},"subject":"refactor: fill in the fluent logging handler with a helm-toolkit snippet","message":"refactor: fill in the fluent logging handler with a helm-toolkit snippet\n\nSeventeen charts carry the same block that fills in the fluent handler\nand formatter of conf.logging, in two variants that differ only in the\nname used for the fluentd tag: twelve use .Release.Name and five use\n.deployment_name. Move the block into the new\nhelm-toolkit.snippets.oslo_logging_fluent snippet, which takes the name\nas deploymentName and defaults to .Release.Name, and call it from the\ncharts. Each chart passes the name it used before; blazar sets\n.deployment_name too but tags with .Release.Name, and keeps doing so.\n\nEvery chart was rendered before and after the change with the default\nvalues and with each file in values_overrides/, and renders as before,\nso no pod restarts on upgrade. With a fluent handler in conf.logging,\nin a normal and in a subchart release, every logging.conf is the same\nas before, including the per-node ones of neutron and nova.\n\nAssisted-By: Claude Opus 5.5\nChange-Id: I030046eeeec3c1b472b273af54eddec42ea56280\nSigned-off-by: Doug Goldstein \u003ccardoe@cardoe.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/095964904d5ceec037cb23749dd4aa4c8b16ba3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/095964904d5ceec037cb23749dd4aa4c8b16ba3a"}]},"branch":"refs/heads/master","description":"Rebase","conflicts":{"base":"f761cc89686243ac361a881dc9636cf4b8b4aec7","ours":"2a984af4c789025f00ff1a60b52c51270a36d63c","theirs":"2f8e033b18c8929c60d5195236d38224ecb58fc1","merge_strategy":"recursive","contains_conflicts":false}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
