)]}'
{"ceph/templates/bin/_ceph-mon-liveness.sh.tpl":[{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# A liveness check for ceph monitors: exit 0 iff the monitor appears to be at least"},{"line_number":3,"context_line":"# alive (but not necessarily in a quorum)."},{"line_number":4,"context_line":"CEPH\u003d${CEPH_CMD:-/usr/bin/ceph}"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_1c80768b","line":1,"updated":"2017-10-10 17:06:38.000000000","message":"headers","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"0e56fea155c1aa490d3d073ab872190dabcf02f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# A liveness check for ceph monitors: exit 0 iff the monitor appears to be at least"},{"line_number":3,"context_line":"# alive (but not necessarily in a quorum)."},{"line_number":4,"context_line":"CEPH\u003d${CEPH_CMD:-/usr/bin/ceph}"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_d09abfc3","line":1,"in_reply_to":"5f4e5783_1c80768b","updated":"2017-10-10 17:14:30.000000000","message":"Sorry, but could you be more specific?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dd5227e95072dea38746665a02f230d166a6f231","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# A liveness check for ceph monitors: exit 0 iff the monitor appears to be at least"},{"line_number":3,"context_line":"# alive (but not necessarily in a quorum)."},{"line_number":4,"context_line":"CEPH\u003d${CEPH_CMD:-/usr/bin/ceph}"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_90e687e8","line":1,"in_reply_to":"5f4e5783_d09abfc3","updated":"2017-10-10 17:41:35.000000000","message":"https://github.com/openstack/openstack-helm/blob/master/rabbitmq/templates/bin/_rabbitmq-liveness.sh.tpl#L3-L17","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"}],"ceph/templates/bin/_ceph-mon-readiness.sh.tpl":[{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# A readiness check for ceph monitors: exit 0 iff the monitor appears to be at least"},{"line_number":3,"context_line":"# alive (but not necessarily in a quorum)."},{"line_number":4,"context_line":"CEPH\u003d${CEPH_CMD:-/usr/bin/ceph}"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_bc35e2f9","line":1,"updated":"2017-10-10 17:06:38.000000000","message":"headers","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"}],"ceph/templates/bin/_ceph-osd-liveness-readiness.sh.tpl":[{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# A liveness check for ceph OSDs: exit 0 iff"},{"line_number":3,"context_line":"# all OSDs on this host are in the \"active\" state"},{"line_number":4,"context_line":"# per their admin sockets."}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_9c3a26e5","line":1,"updated":"2017-10-10 17:06:38.000000000","message":"headers","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"}],"ceph/templates/bin/_common_functions.sh.tpl":[{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  echo \"${1##*\u003d}\""},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"#"},{"line_number":88,"context_line":"# convert device paths like \u0027scsi@....\u0027"},{"line_number":89,"context_line":"# to block device names, if possible."},{"line_number":90,"context_line":"# only handles scsi devices right now."}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_3fd9e482","line":87,"updated":"2017-10-10 17:06:38.000000000","message":"delete this line","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"}],"ceph/templates/bin/_osd_activate_journal.sh.tpl":[{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"d3290d36a3d0732e088c1eca45a516c7482a21a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  if [! -b \"${OSD_JOURNAL}\" ]; then"},{"line_number":11,"context_line":"   # no need to prepare non-device journals"},{"line_number":12,"context_line":"   exit 0;"},{"line_number":13,"context_line":"  fi"},{"line_number":14,"context_line":"  "}],"source_content_type":"text/x-smarty","patch_set":36,"id":"7f287b81_bcfc1170","line":11,"updated":"2017-08-29 17:39:17.000000000","message":"prepare -\u003e activate","commit_id":"b46a007e733d6fadbea9724735da19c6521b9a21"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"fcf22df822d335e88036f0b2a3e7af98038c3d94","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   # no need to activate non-device journals"},{"line_number":12,"context_line":"   exit 0;"},{"line_number":13,"context_line":"  fi"},{"line_number":14,"context_line":"  "},{"line_number":15,"context_line":"  # watch the udev event queue, and exit if all current events are handled"},{"line_number":16,"context_line":"  udevadm settle --timeout\u003d600"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":37,"id":"7f287b81_0acbd3a4","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2017-08-29 18:50:27.000000000","message":"Please remove this trailing spaces.","commit_id":"a4f2a601133a69d9b1b2d01f2f247950663d1ea1"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"f30f042cebaae77e6d6e7f56be588cb324acd1ba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    exit 1"},{"line_number":8,"context_line":"  fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  if [! -b \"${OSD_JOURNAL}\" ]; then"},{"line_number":11,"context_line":"   # no need to activate non-device journals"},{"line_number":12,"context_line":"   exit 0;"},{"line_number":13,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":39,"id":"7f287b81_6b281996","line":10,"updated":"2017-08-29 21:11:55.000000000","message":"OSD_DEVICE?","commit_id":"c380d64de66986158b533c1ee60238cff08a80ad"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"aca3a6ad7c1fb347177957f3355b4af09c5cc7c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    exit 1"},{"line_number":8,"context_line":"  fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  if [! -b \"${OSD_JOURNAL}\" ]; then"},{"line_number":11,"context_line":"   # no need to activate non-device journals"},{"line_number":12,"context_line":"   exit 0;"},{"line_number":13,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":39,"id":"7f287b81_73536f3a","line":10,"in_reply_to":"7f287b81_6b281996","updated":"2017-08-29 22:58:11.000000000","message":"Nope, we want OSD_JOURNAL here — for once this WASN\u0027T a typo on my part.  We\u0027re working on the journal here, and as the comment says, we only want to activate block device journals.  Directory-backed journals need no activation, so we just return.\n\nThat said, if we decide there\u0027s something we want to do to directory-backed journals (for example, making sure they exist or setting up permissions) this would be the place to do it.","commit_id":"c380d64de66986158b533c1ee60238cff08a80ad"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# NOTE: This does not appear to function correctly in containers,"},{"line_number":3,"context_line":"# as ceph-disk activate-journal attempts to start the OSD using"},{"line_number":4,"context_line":"# the init subsystem, which does not exist here.  It should probably"},{"line_number":5,"context_line":"# go away entirely."},{"line_number":6,"context_line":"set -ex"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function osd_activate_journal {"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_3fc20487","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":19},"updated":"2017-10-10 17:06:38.000000000","message":"?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"67cd5f306474a23a3a5b254c70b6508eb301cd6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# NOTE: This does not appear to function correctly in containers,"},{"line_number":3,"context_line":"# as ceph-disk activate-journal attempts to start the OSD using"},{"line_number":4,"context_line":"# the init subsystem, which does not exist here.  It should probably"},{"line_number":5,"context_line":"# go away entirely."},{"line_number":6,"context_line":"set -ex"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function osd_activate_journal {"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_959e7905","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":19},"in_reply_to":"5f4e5783_3fc20487","updated":"2017-10-10 17:12:13.000000000","message":"Just what it says (though obviously it shouldn\u0027t be in the comments of the script):  I think we can delete this, as it appears to be a failure-prone no-op.","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8d1fc6ad6eda55f75ecb31a4d4ebf63b9b369b6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# NOTE: This does not appear to function correctly in containers,"},{"line_number":3,"context_line":"# as ceph-disk activate-journal attempts to start the OSD using"},{"line_number":4,"context_line":"# the init subsystem, which does not exist here.  It should probably"},{"line_number":5,"context_line":"# go away entirely."},{"line_number":6,"context_line":"set -ex"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function osd_activate_journal {"}],"source_content_type":"text/x-smarty","patch_set":68,"id":"5f4e5783_70f78bf7","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":19},"in_reply_to":"5f4e5783_959e7905","updated":"2017-10-10 17:15:54.000000000","message":"the appropriate thing would be to update it to:\nNOTE(davekormann): foo","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"}],"ceph/templates/bin/_osd_disk_prepare.sh.tpl":[{"author":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"change_message_id":"89ee387ffa1b135f9be81f280106db8d81b4ec75","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_69a2bdb0","line":60,"updated":"2017-11-14 18:50:27.000000000","message":"if OSD_JOURNAL is not defined (collocated). This will fail since the OSD isn\u0027t going to have any partitions (zap happening before and prepare after).","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"change_message_id":"5794abff8e3a4e3e10e291b35da07084ca52d4d8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_c4c19882","line":60,"in_reply_to":"1f485f77_447a4888","updated":"2017-11-14 19:04:54.000000000","message":"I think it\u0027s better to leave it to ceph-disk prepare to create the partition. Not sure what would be the best approach for a fix here without adding another check after ceph-disk prepare. I\u0027ll give it some thoughts.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"change_message_id":"be5d6d81e70ce159da90b95e5e33383531b7468a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_5f90aeed","line":60,"in_reply_to":"1f485f77_4a77e003","updated":"2017-11-15 18:09:22.000000000","message":"Looking at the original script, I assume the intent was to wait for part2 on osd_device to chown it after udevadm settle is invoked since it\u0027s async.. I\u0027m not sure changing ownership on the block device is required since ceph-disk prepare runs as root. \n\nSébastien, I think you\u0027re the original author of the script: Can you share your inputs? I might have missed something","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"change_message_id":"6db43706ed108d33ccaa7bf82fac7744288dd8a5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_f4dad448","line":60,"in_reply_to":"1f485f77_5f90aeed","updated":"2017-11-16 02:21:51.000000000","message":"Just thought of this. This is because it\u0027s the journal partition. Since it contains no FS it has to be owned by the ceph user.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"091d6ccb335e19151c896520ff8a3ee3cd06ff2b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_447a4888","line":60,"in_reply_to":"1f485f77_69a2bdb0","updated":"2017-11-14 19:00:15.000000000","message":"good point.  i\u0027m not sure what the right approach here is — should we add a journal partition if it\u0027s not defined?","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"aba9fbedff6ee175e8c186e3428074e115b5b5d8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_4a77e003","line":60,"in_reply_to":"1f485f77_9d9e4a52","updated":"2017-11-15 07:21:38.000000000","message":"Have pushed a new patchset which removes to else option. Tested the patch with both co-located journal and stand-alone journal disk and verified both conditions to be working. Please let me know your thoughts. Unable to think of a scenario where the wait for partition 2 of OSD_DEVICE is needed.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"1b4b91022cd3b0984ccef6e86054a624a430fa9f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_9d9e4a52","line":60,"in_reply_to":"1f485f77_c4c19882","updated":"2017-11-14 23:56:53.000000000","message":"Just leaving the no OSD_JOURNAL defined case should satisfy that case. I am testing a patch right now and will send it up asap for review.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"change_message_id":"d2ce52e585251d110eb28e48f430a5f486e1da85","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_cc8a9568","line":60,"in_reply_to":"1f485f77_c9f60764","updated":"2017-11-16 19:34:59.000000000","message":"Not sure what you mean by fix up the OSD_DEVICE but I believe it should be fine either way. Just checked and the osd_activate.sh script does the chown of the journal partition as well. With your patch, I think this is good to go.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"8257e0aa3c93d07a5c130f9630b064ae56aafa71","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_d207c781","line":60,"in_reply_to":"1f485f77_cc8a9568","updated":"2017-11-17 00:41:03.000000000","message":"Thanks for checking the patch. I saw the same thing in my tests.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"6fdfbf7d00fc15213d7efeb28d91e9fdda8a2546","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    wait_for_file ${OSD_JOURNAL}"},{"line_number":59,"context_line":"    chown ceph. ${OSD_JOURNAL}"},{"line_number":60,"context_line":"  else"},{"line_number":61,"context_line":"    wait_for_file $(dev_part ${OSD_DEVICE} 2)"},{"line_number":62,"context_line":"    chown ceph. $(dev_part ${OSD_DEVICE} 2)"},{"line_number":63,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":80,"id":"1f485f77_c9f60764","line":60,"in_reply_to":"1f485f77_f4dad448","updated":"2017-11-16 19:20:39.000000000","message":"If it is a separate partition, we will define OSD_JOURNAL and the permissions should get handled by the if condition. I believe the only time we will not define the journal is when it is a inline one and should be covered when we fix up the OSD_DEVICE right? Am i missing a condition that is neither here. I am in no way an expert on ceph, so kindly bare with my ignorance if any.","commit_id":"638e42461b0ac5d84a952d64bf72d31705837f28"}],"ceph/templates/bin/_start_osd.sh.tpl":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"5b255374da6b94d544c08efe27e8d9a9e7c6ea0b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      # journal activation needs to pretty much always"},{"line_number":42,"context_line":"      # happen with disk activation. it was never getting"},{"line_number":43,"context_line":"      # called, so we force it here."},{"line_number":44,"context_line":"      source osd_activate_journal.sh"},{"line_number":45,"context_line":"      source osd_disk_activate.sh"},{"line_number":46,"context_line":"      source osd_common.sh"},{"line_number":47,"context_line":"      osd_activate_journal"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"7f287b81_9ab6d989","line":44,"updated":"2017-08-30 16:00:41.000000000","message":"Should we skip this (and the call below) if OSD_JOURNAL is unset?  Right now, we\u0027re essentially requiring that a journal be specified in all cases (because activate_journal barfs if OSD_JOURNAL is empty).  Do we want to accommodate the case where the user just wants to accept the default?","commit_id":"8eaafb8f13fd3d65d1fe3f7818e05f3ef686e569"}],"ceph/templates/daemonset-osd-devices.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"52dc4a7c1ecf0733966784d5932264aae700e68b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          imagePullPolicy: {{ $.Values.images.pull_policy }}"},{"line_number":43,"context_line":"          volumeMounts:"},{"line_number":44,"context_line":"            - name: devices"},{"line_number":45,"context_line":"              mountPath: /dev"},{"line_number":46,"context_line":"            - name: ceph"},{"line_number":47,"context_line":"              mountPath: /var/lib/ceph"},{"line_number":48,"context_line":"            - name: ceph-conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ffa3b31_2216e6f2","line":45,"updated":"2017-04-19 16:00:12.000000000","message":"If we are doing a pod per osd, there is some safety in ensuring we only pass through the device we intend this osd-specific-pod to control","commit_id":"8fa44ad4184c0dd94e745280acf0a644802a0db4"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"77ebb19e4393ad0bb0aaaa4c97cf964b6cb2927c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"              mountPath: /var/lib/ceph"},{"line_number":48,"context_line":"              readOnly: false"},{"line_number":49,"context_line":"            - name: ceph-etc"},{"line_number":50,"context_line":"              mountPath: /etc/ceph/ceph.conf"},{"line_number":51,"context_line":"              subPath: ceph.conf"},{"line_number":52,"context_line":"              readOnly: true"},{"line_number":53,"context_line":"            - name: ceph-client-admin-keyring"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_951e8c6e","line":50,"updated":"2017-06-29 16:13:58.000000000","message":"this assumes the cluster name is \u0027ceph\u0027. Perhaps we can use the namespace here? Assuming that the name of the namespace is the desired name for the cluster?","commit_id":"c0652ff4c6b3f1bdbd1822963fd905842d4dd4ea"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"3d24e5f0d0944bc068a8a729397f4160835e89b3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"              value: {{ $.Values.debug }}"},{"line_number":117,"context_line":"            {{ end }}"},{"line_number":118,"context_line":"            - name: HOSTNAME"},{"line_number":119,"context_line":"              valueFrom:"},{"line_number":120,"context_line":"                fieldRef:"},{"line_number":121,"context_line":"                  fieldPath: spec.nodeName"},{"line_number":122,"context_line":"          livenessProbe:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f1a1f67_85f22e99","line":119,"updated":"2017-09-21 12:33:55.000000000","message":"maybe allow this to be specified in values.yaml, with spec.nodename as the default.","commit_id":"62c85bb5525cfce590ae65d14a4f68cbe5bd74bc"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"69a86750e9a4af35782d0792a2b515b58d0b82d8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            - name: DEBUG"},{"line_number":116,"context_line":"              value: {{ $.Values.debug }}"},{"line_number":117,"context_line":"            {{ end }}"},{"line_number":118,"context_line":"            - name: HOSTNAME"},{"line_number":119,"context_line":"              valueFrom:"},{"line_number":120,"context_line":"                fieldRef:"},{"line_number":121,"context_line":"                  fieldPath: spec.nodeName"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ff346bd7_cec0d453","line":118,"updated":"2017-07-24 13:25:12.000000000","message":"suggestion: allow this to be overridden from values.yaml.  it might be the case (as, for example, when we have a mix of external and internal disks) that we want finer-grained control over the host a disk advertises itself as attached to.","commit_id":"6138ba772bc9dac6e63c94146260e93ca56a927c"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"a2e7621e635254895f509a876a9f47dfbe057282","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            privileged: true"},{"line_number":97,"context_line":"          env:"},{"line_number":98,"context_line":"            - name: CEPH_DAEMON"},{"line_number":99,"context_line":"              value: osd"},{"line_number":100,"context_line":"            - name: KV_TYPE"},{"line_number":101,"context_line":"              value: k8s"},{"line_number":102,"context_line":"            - name: CLUSTER"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf3e73b7_3376ab08","line":99,"updated":"2017-08-07 16:57:45.000000000","message":"Instead of using OSD, I would like to use OSD_CEPH_DISK_ACTIVATE as CEPH_DAEMON and adding an init container to prepare OSD.","commit_id":"a9d048114d94cb62c6930bee3801dc11381dee2b"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"8056400f24de2c6bc545116581dce56424d864c1","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            - name: JOURNAL"},{"line_number":195,"context_line":"              value: {{ $value.journal }}"},{"line_number":196,"context_line":"            {{ end }}"},{"line_number":197,"context_line":"            - name: OSD_FORCE_ZAP"},{"line_number":198,"context_line":"              value: {{ $value.zap | quote }}"},{"line_number":199,"context_line":"            {{ if $.Values.debug }}"},{"line_number":200,"context_line":"            - name: DEBUG"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bf3e73b7_a1bfdef9","line":197,"updated":"2017-08-07 22:01:03.000000000","message":"ZAP is not used by osd activiate.","commit_id":"b0b0206d1c284fe5a2dfe092b58bba12e5018aef"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"c7b35f1410b4d1a9823d6a920ecce5965c9807b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"7f287b81_b5a73f50","updated":"2017-08-22 13:39:36.000000000","message":"I\u0027m worried about removing journal configuration.   Particularly on machines with multiple OSDs or SSD journals, it\u0027s going to be necessary to specify the journal location, and probably on a per-OSD basis.   Is there some objection to that?","commit_id":"2f6cb7cb5078840ba3d3f65e06162584932f6523"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"9228fce4e1f228e1813b0fdee3e5ce8c12f92966","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"7f287b81_782c2e99","in_reply_to":"7f287b81_b5a73f50","updated":"2017-08-22 13:45:13.000000000","message":"OSD journal device can be prepared but not activated. Currently ceph-docker image offers separate daemon flags for osd and disk activation, thus we cannot activate both. \nI manually tested osd_activate_journal, it failed to start OSD.  \n\nBefore we fix the image, it is less confusing to leave OSD journal blank.","commit_id":"2f6cb7cb5078840ba3d3f65e06162584932f6523"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"2a74bd075205b73d6ec1d557cc16dd7512b85a15","unresolved":false,"context_lines":[{"line_number":108,"context_line":"              value: {{ $value.device }}"},{"line_number":109,"context_line":"            {{- if $value.journal }}"},{"line_number":110,"context_line":"            - name: OSD_JOURNAL"},{"line_number":111,"context_line":"              value: {{ $value.hostname }}"},{"line_number":112,"context_line":"            {{- end }}"},{"line_number":113,"context_line":"            - name: OSD_FORCE_ZAP"},{"line_number":114,"context_line":"              value: {{ $value.zap | quote }}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7f287b81_dc291d37","line":111,"updated":"2017-08-29 17:25:48.000000000","message":"value.journal","commit_id":"44609367cd6503d81e756830c53c9edca349dead"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"a02193deaefe30cd51526265807fcb2de96fe556","unresolved":false,"context_lines":[{"line_number":209,"context_line":"              {{- end }}"},{"line_number":210,"context_line":"            {{- if $value.journal }}"},{"line_number":211,"context_line":"            - name: OSD_JOURNAL"},{"line_number":212,"context_line":"              value: {{ $value.hostname }}"},{"line_number":213,"context_line":"            {{- end }}"},{"line_number":214,"context_line":"          livenessProbe:"},{"line_number":215,"context_line":"              tcpSocket:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7f287b81_7c0109af","line":212,"updated":"2017-08-29 17:25:12.000000000","message":"value.journal","commit_id":"44609367cd6503d81e756830c53c9edca349dead"},{"author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"change_message_id":"dd6f2b637237670f024dc0a7ad47ec02e27aa0cf","unresolved":false,"context_lines":[{"line_number":147,"context_line":"              subPath: osd_disks.sh"},{"line_number":148,"context_line":"              readOnly: true"},{"line_number":149,"context_line":"            - name: ceph-bin"},{"line_number":150,"context_line":"              mountPath: /osd_disk_activate.sh"},{"line_number":151,"context_line":"              subPath: osd_disk_activate.sh"},{"line_number":152,"context_line":"              readOnly: true"},{"line_number":153,"context_line":"            - name: ceph-bin"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"7f287b81_c29c526c","line":150,"updated":"2017-08-31 18:41:51.000000000","message":"need to mount osd_activate_journal.sh as well","commit_id":"79bcb0190efb4c3201349a88f0046985390c4d90"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e80f7199ced507c2561dfec1b0374756424ac6de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":67,"id":"7f515b1d_79861a68","updated":"2017-10-05 23:59:10.000000000","message":"why do we need a separate template for devices? can this be reduced to a single template that covers both uses.","commit_id":"82332d6b9deb8d6fef1d694c3265b6228283a34b"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"a92dc4c1fc95ea67ae2df415aca0db55ee4dbc10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":67,"id":"7f515b1d_3c9bf066","in_reply_to":"7f515b1d_79861a68","updated":"2017-10-06 01:17:08.000000000","message":"completely agree and that\u0027s something that has bugged me, but it seemed like the design from the start of this change was to separate device-backed OSD targeting from directory-backed ones.  Fixing this is straightforward, but not entirely trivial.  Given we _really_ need this merged asap, my personal preference is to eliminate the distinction in a later change.","commit_id":"82332d6b9deb8d6fef1d694c3265b6228283a34b"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"              value: osd_ceph_disk_prepare"},{"line_number":131,"context_line":"            - name: KV_TYPE"},{"line_number":132,"context_line":"              value: k8s"},{"line_number":133,"context_line":"            - name: CLUSTER"},{"line_number":134,"context_line":"              value: ceph"},{"line_number":135,"context_line":"            - name: CEPH_GET_ADMIN_KEY"},{"line_number":136,"context_line":"              value: \"1\""},{"line_number":137,"context_line":"            - name: OSD_DEVICE"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"5f4e5783_95831905","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":25},"updated":"2017-10-10 17:06:38.000000000","message":"is this needed anymore?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"67cd5f306474a23a3a5b254c70b6508eb301cd6f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"              value: osd_ceph_disk_prepare"},{"line_number":131,"context_line":"            - name: KV_TYPE"},{"line_number":132,"context_line":"              value: k8s"},{"line_number":133,"context_line":"            - name: CLUSTER"},{"line_number":134,"context_line":"              value: ceph"},{"line_number":135,"context_line":"            - name: CEPH_GET_ADMIN_KEY"},{"line_number":136,"context_line":"              value: \"1\""},{"line_number":137,"context_line":"            - name: OSD_DEVICE"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"5f4e5783_f5036d0e","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":25},"in_reply_to":"5f4e5783_95831905","updated":"2017-10-10 17:12:13.000000000","message":"While it\u0027s almost never anything but \"ceph\", it\u0027s certainly _possible_ to set it to something else.  Is there a reason not to allow that?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dd5227e95072dea38746665a02f230d166a6f231","unresolved":false,"context_lines":[{"line_number":130,"context_line":"              value: osd_ceph_disk_prepare"},{"line_number":131,"context_line":"            - name: KV_TYPE"},{"line_number":132,"context_line":"              value: k8s"},{"line_number":133,"context_line":"            - name: CLUSTER"},{"line_number":134,"context_line":"              value: ceph"},{"line_number":135,"context_line":"            - name: CEPH_GET_ADMIN_KEY"},{"line_number":136,"context_line":"              value: \"1\""},{"line_number":137,"context_line":"            - name: OSD_DEVICE"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"5f4e5783_50b12f8f","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":25},"in_reply_to":"5f4e5783_f5036d0e","updated":"2017-10-10 17:41:35.000000000","message":"my apologies - i overlooked some of the changes made elsewhere in the ceph chart.  mons and moncheck were changed to use \"NAMESPACE\" as an env var rather than cluster.  should this (and appropriate scripts elsewhere) be changed to use NAMESPACE for consistency?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ce37132e274617f79f5f7916d327fcf60a32b399","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":70,"id":"5f4e5783_d413b30c","line":1,"updated":"2017-10-11 13:32:36.000000000","message":"could this be consolated into a single file with the directory osd template? The amount of repetition her makes me think we could.","commit_id":"6e220f4bfa8466afe0c5d65ab9b4e64e980bb7ae"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"96186a8e3d79090fc6ed9918bac18a2c4d45f3fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":70,"id":"5f4e5783_544583b2","line":1,"in_reply_to":"5f4e5783_d413b30c","updated":"2017-10-11 13:42:28.000000000","message":"Yes, definitely.  My comment earlier (10/5 @ 9:17PM) about this might\u0027ve got missed:\n\n\"completely agree and that\u0027s something that has bugged me, but it seemed like the design from the start of this change was to separate device-backed OSD targeting from directory-backed ones.  Fixing this is straightforward, but not entirely trivial.  Given we _really_ need this merged asap, my personal preference is to eliminate the distinction in a later change.\"","commit_id":"6e220f4bfa8466afe0c5d65ab9b4e64e980bb7ae"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"fe31651182d7ecfac7f3dbdb311e29fdedb5815b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"              value: {{ $.Values.debug }}"},{"line_number":159,"context_line":"            {{ end }}"},{"line_number":160,"context_line":"            - name: HOSTNAME"},{"line_number":161,"context_line":"              {{- if $value.hostname }}"},{"line_number":162,"context_line":"              value: {{ $value.hostname }}"},{"line_number":163,"context_line":"              {{- else }}"},{"line_number":164,"context_line":"              valueFrom:"},{"line_number":165,"context_line":"                fieldRef:"},{"line_number":166,"context_line":"                  fieldPath: spec.nodeName"}],"source_content_type":"text/x-yaml","patch_set":70,"id":"5f4e5783_34068788","line":163,"range":{"start_line":161,"start_character":14,"end_line":163,"end_character":25},"updated":"2017-10-11 13:40:16.000000000","message":"this looks odd, why would you want to set this value?","commit_id":"6e220f4bfa8466afe0c5d65ab9b4e64e980bb7ae"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"ee035554ad86997ad67016f4332312bdcb5e65d1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"              value: {{ $.Values.debug }}"},{"line_number":159,"context_line":"            {{ end }}"},{"line_number":160,"context_line":"            - name: HOSTNAME"},{"line_number":161,"context_line":"              {{- if $value.hostname }}"},{"line_number":162,"context_line":"              value: {{ $value.hostname }}"},{"line_number":163,"context_line":"              {{- else }}"},{"line_number":164,"context_line":"              valueFrom:"},{"line_number":165,"context_line":"                fieldRef:"},{"line_number":166,"context_line":"                  fieldPath: spec.nodeName"}],"source_content_type":"text/x-yaml","patch_set":70,"id":"5f4e5783_744f5fbd","line":163,"range":{"start_line":161,"start_character":14,"end_line":163,"end_character":25},"in_reply_to":"5f4e5783_34068788","updated":"2017-10-11 13:46:23.000000000","message":"the crushmap is based on hostnames.  In a world where you\u0027ve got multiple OSD containers on a single host, you typically want to be certain they all get the same hostname so that the assumptions about failure domains are maintained.  This allows you to control that.\n\nHowever, I think it\u0027s probably not necessarily best to have it set on a per-block-device basis, so this could probably go away.","commit_id":"6e220f4bfa8466afe0c5d65ab9b4e64e980bb7ae"}],"ceph/templates/daemonset-osd.yaml":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"b27eb92be10ecf9d8194e2bea23b0d76c22a5c4a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            privileged: true"},{"line_number":128,"context_line":"          env:"},{"line_number":129,"context_line":"            - name: CEPH_DAEMON"},{"line_number":130,"context_line":"              {{- if $value.type }}"},{"line_number":131,"context_line":"              value: {{ $value.hostname }}"},{"line_number":132,"context_line":"              {{- else }}"},{"line_number":133,"context_line":"              value: {{ $value.hostname }}"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"3f4b6375_27fe4937","line":130,"updated":"2017-10-20 14:17:49.000000000","message":"This test seems to always produce the same result.  Is it right?  Also, should CEPH_DAEMON really be set to the hostname?","commit_id":"6deefe9cfcdd39f6c722f73fa278a5bfda237dfb"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"86cb5f406de75c035e4101b9d0fa53e311355a02","unresolved":false,"context_lines":[{"line_number":228,"context_line":"              mountPath: /variables_entrypoint.sh"},{"line_number":229,"context_line":"              subPath: variables_entrypoint.sh"},{"line_number":230,"context_line":"              readOnly: true"},{"line_number":231,"context_line":"            - name: devices"},{"line_number":232,"context_line":"              mountPath: /dev"},{"line_number":233,"context_line":"            - name: ceph-bin"},{"line_number":234,"context_line":"              mountPath: /osd_disks.sh"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"3f4b6375_e22b7fe8","line":231,"updated":"2017-10-20 14:42:20.000000000","message":"Since this exists in both conditions, it could be moved up out of the conditional section.","commit_id":"6deefe9cfcdd39f6c722f73fa278a5bfda237dfb"}],"ceph/templates/deployment-rbd-provisioner.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4609f586db2ffb20a1032dfba0e3388e12015d89","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    spec:"},{"line_number":35,"context_line":"      affinity:"},{"line_number":36,"context_line":"{{ tuple $envAll \"rbd\" \"provisioner\" | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":37,"context_line":"      hostNetwork: true"},{"line_number":38,"context_line":"      initContainers:"},{"line_number":39,"context_line":"{{ tuple $envAll $dependencies \"[]\" | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":40,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"5f4e5783_617a0d25","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":23},"updated":"2017-10-11 04:33:34.000000000","message":"this does not need to run in the host network - through in a follow-up ps we could make it an option.","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"1bac4441cd717fcfd918267976d80016faf3145c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    spec:"},{"line_number":35,"context_line":"      affinity:"},{"line_number":36,"context_line":"{{ tuple $envAll \"rbd\" \"provisioner\" | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":37,"context_line":"      hostNetwork: true"},{"line_number":38,"context_line":"      initContainers:"},{"line_number":39,"context_line":"{{ tuple $envAll $dependencies \"[]\" | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":40,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"5f4e5783_765407cb","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":23},"in_reply_to":"5f4e5783_617a0d25","updated":"2017-10-11 12:42:45.000000000","message":"I\u0027ll remove it, though in my deployment the provisioner simply didn\u0027t work unless this was enabled.","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ea12c70669860eafd1ece179567c23996bbb8886","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    spec:"},{"line_number":35,"context_line":"      affinity:"},{"line_number":36,"context_line":"{{ tuple $envAll \"rbd\" \"provisioner\" | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":37,"context_line":"      hostNetwork: true"},{"line_number":38,"context_line":"      initContainers:"},{"line_number":39,"context_line":"{{ tuple $envAll $dependencies \"[]\" | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":40,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"5f4e5783_7463dfdd","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":23},"in_reply_to":"5f4e5783_765407cb","updated":"2017-10-11 13:30:46.000000000","message":"We need to investigate whats up with the network setup on your machines - as this issue is not affecting any of our other deployments.","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"}],"ceph/values.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"076f1b23b38d47ab0f17509ea15e3e6811e65d7d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"osd_directory:"},{"line_number":45,"context_line":"  enabled: false"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"osd_devices:"},{"line_number":48,"context_line":"  - name: dev-sdb"},{"line_number":49,"context_line":"    device: /dev/sdb"},{"line_number":50,"context_line":"    type: disk"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ffa3b31_22170648","line":47,"updated":"2017-04-19 15:51:18.000000000","message":"Since I would be deploying a single chart, responsible for ceph across many hosts, how would I be articulating to use these 4 disks in this host, and these 6 disks on this other host with this approach?","commit_id":"8fa44ad4184c0dd94e745280acf0a644802a0db4"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"bb1863ca8089cd5d8b8ff06383f390d95a222552","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"osd_devices:"},{"line_number":48,"context_line":"  - name: dev-sdb"},{"line_number":49,"context_line":"    device: /dev/sdb"},{"line_number":50,"context_line":"    type: disk"},{"line_number":51,"context_line":"    zap: \"1\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ffa3b31_a479ff2f","line":49,"updated":"2017-04-18 22:51:31.000000000","message":"I think we need to recommend using persistent device path such as /dev/disk/by-uuid/\u003cuuid\u003e","commit_id":"8fa44ad4184c0dd94e745280acf0a644802a0db4"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"fd4a476b7a3b4fb83e1cafb814b1e3cd0992b924","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"osd_devices:"},{"line_number":48,"context_line":"  - name: dev-sdb"},{"line_number":49,"context_line":"    device: /dev/sdb"},{"line_number":50,"context_line":"    type: disk"},{"line_number":51,"context_line":"    zap: \"1\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_f08337a8","line":49,"in_reply_to":"1f485f77_355f8173","updated":"2017-11-14 16:06:10.000000000","message":"Yeah, trying to pick an ID which was unlikely to change across reboots was the point of using SCSI IDs as for attached disks they\u0027re unlikely to change.  This point is well-taken though.  I\u0027ll add comments that stress the importance of picking stable device names.  Since as you observe, we already resolve symlinks at the top of osd_disk_{prepare,activate}, we should be OK if users configure this with a link.","commit_id":"8fa44ad4184c0dd94e745280acf0a644802a0db4"},{"author":{"_account_id":27292,"name":"Richard B","email":"richard.bowater@gmail.com"},"change_message_id":"4e0eff905c53bde8ed23a0f7491be1d19cc6977a","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"osd_devices:"},{"line_number":48,"context_line":"  - name: dev-sdb"},{"line_number":49,"context_line":"    device: /dev/sdb"},{"line_number":50,"context_line":"    type: disk"},{"line_number":51,"context_line":"    zap: \"1\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_355f8173","line":49,"in_reply_to":"7ffa3b31_a479ff2f","updated":"2017-11-14 12:43:36.000000000","message":"\u003e I think we need to recommend using persistent device path such as\n \u003e /dev/disk/by-uuid/\u003cuuid\u003e\n\nAgree with this, SCSI IDs may change on a reboot. We\u0027ve worked around this by passing in \"/dev/disk/by-id/wwn-id\" and then adding OSD_DEVICE\u003d$(readlink -f ${OSD_DEVICE}) to _osd_disk_activate.sh.tpl, which is a total hack but works for our use case. :)","commit_id":"8fa44ad4184c0dd94e745280acf0a644802a0db4"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4609f586db2ffb20a1032dfba0e3388e12015d89","unresolved":false,"context_lines":[{"line_number":308,"context_line":"#    ceph-osd-device-{name}\u003denabled"},{"line_number":309,"context_line":"# where {name} is a name: value from this map."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"block_devices:"},{"line_number":312,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":313,"context_line":"    device: scsi@2:0.0.0"},{"line_number":314,"context_line":"    journal:"},{"line_number":315,"context_line":"      device: scsi@3:0.0.0"},{"line_number":316,"context_line":"    zap: \u00271\u0027"},{"line_number":317,"context_line":"  - name: scsi-2-0.0.1"},{"line_number":318,"context_line":"    device: scsi@2:0.0.1"},{"line_number":319,"context_line":"    journal:"},{"line_number":320,"context_line":"      device: scsi@3:0.0.1"},{"line_number":321,"context_line":"    zap: \u00271\u0027"},{"line_number":322,"context_line":"  - name: scsi-2-0.0.2"},{"line_number":323,"context_line":"    device: scsi@2:0.0.2"},{"line_number":324,"context_line":"    journal:"},{"line_number":325,"context_line":"      device: scsi@3:0.0.2"},{"line_number":326,"context_line":"    zap: \u00271\u0027"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  # - name: dev-sdc-j-1"},{"line_number":329,"context_line":"  #   device: /dev/sdc"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"5f4e5783_81f98981","line":326,"range":{"start_line":311,"start_character":0,"end_line":326,"end_character":12},"updated":"2017-10-11 04:33:34.000000000","message":"this should use the snippet from here: http://logs.openstack.org/54/457754/69/check/gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv/e087028/console.html#_2017-10-10_18_37_19_108743\n\nthis snippet will need to be modified to match the format you propose, but it is essential that the OSD deployment is aware of hosts - and able to target potentially differing disc topology across them.","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ea12c70669860eafd1ece179567c23996bbb8886","unresolved":false,"context_lines":[{"line_number":308,"context_line":"#    ceph-osd-device-{name}\u003denabled"},{"line_number":309,"context_line":"# where {name} is a name: value from this map."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"block_devices:"},{"line_number":312,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":313,"context_line":"    device: scsi@2:0.0.0"},{"line_number":314,"context_line":"    journal:"},{"line_number":315,"context_line":"      device: scsi@3:0.0.0"},{"line_number":316,"context_line":"    zap: \u00271\u0027"},{"line_number":317,"context_line":"  - name: scsi-2-0.0.1"},{"line_number":318,"context_line":"    device: scsi@2:0.0.1"},{"line_number":319,"context_line":"    journal:"},{"line_number":320,"context_line":"      device: scsi@3:0.0.1"},{"line_number":321,"context_line":"    zap: \u00271\u0027"},{"line_number":322,"context_line":"  - name: scsi-2-0.0.2"},{"line_number":323,"context_line":"    device: scsi@2:0.0.2"},{"line_number":324,"context_line":"    journal:"},{"line_number":325,"context_line":"      device: scsi@3:0.0.2"},{"line_number":326,"context_line":"    zap: \u00271\u0027"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  # - name: dev-sdc-j-1"},{"line_number":329,"context_line":"  #   device: /dev/sdc"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"5f4e5783_94389bd3","line":326,"range":{"start_line":311,"start_character":0,"end_line":326,"end_character":12},"in_reply_to":"5f4e5783_56746b35","updated":"2017-10-11 13:30:46.000000000","message":"The format is correct, as we have discussed on slack I think this format is better than the initial one I produced - but this should be generated dynamically and not hardcoded into the ceph chart. Your point RE host label targetting is fair - but we need to be able to feed these charts yaml document that represents the disc topology for a whole site - which may include several other services (eg Swift, Cinder LVM etc), this presents choice, either target by hostname as well - or simply ignore that level in the yaml.","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"1bac4441cd717fcfd918267976d80016faf3145c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"#    ceph-osd-device-{name}\u003denabled"},{"line_number":309,"context_line":"# where {name} is a name: value from this map."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"block_devices:"},{"line_number":312,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":313,"context_line":"    device: scsi@2:0.0.0"},{"line_number":314,"context_line":"    journal:"},{"line_number":315,"context_line":"      device: scsi@3:0.0.0"},{"line_number":316,"context_line":"    zap: \u00271\u0027"},{"line_number":317,"context_line":"  - name: scsi-2-0.0.1"},{"line_number":318,"context_line":"    device: scsi@2:0.0.1"},{"line_number":319,"context_line":"    journal:"},{"line_number":320,"context_line":"      device: scsi@3:0.0.1"},{"line_number":321,"context_line":"    zap: \u00271\u0027"},{"line_number":322,"context_line":"  - name: scsi-2-0.0.2"},{"line_number":323,"context_line":"    device: scsi@2:0.0.2"},{"line_number":324,"context_line":"    journal:"},{"line_number":325,"context_line":"      device: scsi@3:0.0.2"},{"line_number":326,"context_line":"    zap: \u00271\u0027"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  # - name: dev-sdc-j-1"},{"line_number":329,"context_line":"  #   device: /dev/sdc"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"5f4e5783_56746b35","line":326,"range":{"start_line":311,"start_character":0,"end_line":326,"end_character":12},"in_reply_to":"5f4e5783_81f98981","updated":"2017-10-11 12:42:45.000000000","message":"Unless I\u0027m missing something, this _is_ the correct format.  The idea is that what goes in values.yaml is not host-specific.  Instead, OSD host targeting happens using labels.   The way the differences in host hardware is expressed is by assigning them different labels corresponding to the name: values in this map.  So, if host1 has a disk at 2:0:0.1 and host2 at 2:0.0.2, host1 would get the label  cephosd-device-scsi-2-0-0-1 and host2 cephosd-device-scsi-2-0-0-2.  Values.yaml, then, contains the union of ALL potential disk presences.","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"1d557ec46c01ab5ddfd775873e6e7a888e3dbc13","unresolved":false,"context_lines":[{"line_number":296,"context_line":"# OSDs are at /dev/sde1 and partitions 1 and 2 of"},{"line_number":297,"context_line":"# scsi@2:0.0.4 respectively."},{"line_number":298,"context_line":"#"},{"line_number":299,"context_line":"# OSD Devices and journals may be specified either as paths "},{"line_number":300,"context_line":"# into /dev or as SCSI IDs; journals may additionally have"},{"line_number":301,"context_line":"# a partition specified (this is not currently supported for"},{"line_number":302,"context_line":"# OSDs)."}],"source_content_type":"text/x-yaml","patch_set":71,"id":"5f4e5783_c231a80d","line":299,"range":{"start_line":299,"start_character":59,"end_line":299,"end_character":60},"updated":"2017-10-11 19:48:33.000000000","message":"Need to remove this extra white space.","commit_id":"f99721e9854b43ad8f09d7bae71cab522f439f2b"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"ed00ebf9b1d8998f83a1e199eeaeb7660ab524aa","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"}],"source_content_type":"text/x-yaml","patch_set":84,"id":"1f485f77_53062222","line":345,"updated":"2017-11-17 22:36:37.000000000","message":"Pardon my ignorance, but wouldn\u0027t using a directory based OSD be better for gate tests? (This is with the understanding that Openstack gate tests are run on VMs) Or is this specific for gate tests handled by the AT\u0026T CI system?","commit_id":"d9640f20db955866686a2bc89916337e27edce7c"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"76334840c10051fdd74cb3b0cf5256f894f7e415","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"}],"source_content_type":"text/x-yaml","patch_set":84,"id":"1f485f77_a1ebc075","line":345,"in_reply_to":"1f485f77_53062222","updated":"2017-11-18 01:09:37.000000000","message":"While that would make the gate scripts a lot simpler, I don\u0027t really think so.  I suspect that most installations will use device-backed OSDs; where feasible, I think we should be testing the most common production scenarios.","commit_id":"d9640f20db955866686a2bc89916337e27edce7c"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"f6f8079c420394ad688a9dc799d6d8a511fbbfc2","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"}],"source_content_type":"text/x-yaml","patch_set":84,"id":"ff82abbf_9f9481ea","line":345,"in_reply_to":"1f485f77_656ca6cd","updated":"2017-11-20 19:23:34.000000000","message":"Just went through the patches and the basis of my insistence of directory based OSD is incorrect. I believe the current change is good as is. Apologies for the noise.","commit_id":"d9640f20db955866686a2bc89916337e27edce7c"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"58c34c81ad3b5013033372205c7e01caf73644e2","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"}],"source_content_type":"text/x-yaml","patch_set":84,"id":"1f485f77_e039a9f1","line":345,"in_reply_to":"1f485f77_a1ebc075","updated":"2017-11-19 07:03:50.000000000","message":"Absolutely agree that we should be running some sort of gate tests with device-backed OSDs. I believe a directory based setup will work in the OpenStack environment as all the gates are run on VMs that might not have a device mounted on them. If this is something that we can enable using another 3rd-party CI, then we can get that script to modify this file prior to running tests?","commit_id":"d9640f20db955866686a2bc89916337e27edce7c"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"e440d27abcd50291563f539a36ae3080cac27ada","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"}],"source_content_type":"text/x-yaml","patch_set":84,"id":"1f485f77_656ca6cd","line":345,"in_reply_to":"1f485f77_e039a9f1","updated":"2017-11-19 17:18:33.000000000","message":"I\u0027m pretty ignorant about the CI setup, but it seems to me that one approach would be to have another gate configuration (like \"legacy-openstack-helm-aio-basic-linuxbridge-rbd\" et al.) that tests directory-, as opposed to device-backed, OSDs.  however, i dunno how much work that is, and unless this is soemthing we\u0027re REALLY not comfortable merging without, i\u0027d like to defer it.","commit_id":"d9640f20db955866686a2bc89916337e27edce7c"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b68ae3be66301406d72b0d68b4324b59ffb50d38","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"},{"line_number":349,"context_line":"    journal:"},{"line_number":350,"context_line":"      device: scsi@3:0.0.0"},{"line_number":351,"context_line":"    zap: \u00271\u0027"},{"line_number":352,"context_line":"  - name: scsi-2-0.0.1"},{"line_number":353,"context_line":"    device: scsi@2:0.0.1"},{"line_number":354,"context_line":"    type: device"},{"line_number":355,"context_line":"    journal:"},{"line_number":356,"context_line":"      device: scsi@3:0.0.1"},{"line_number":357,"context_line":"    zap: \u00271\u0027"},{"line_number":358,"context_line":"  - name: scsi-2-0.0.2"},{"line_number":359,"context_line":"    device: scsi@2:0.0.2"},{"line_number":360,"context_line":"    type: device"},{"line_number":361,"context_line":"    journal:"},{"line_number":362,"context_line":"      device: scsi@3:0.0.2"},{"line_number":363,"context_line":"    zap: \u00271\u0027"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"#Option 2: Directory"},{"line_number":366,"context_line":"# You may specify directory for Ceph Storage."}],"source_content_type":"text/x-yaml","patch_set":86,"id":"ff82abbf_bb851d09","line":363,"range":{"start_line":345,"start_character":0,"end_line":363,"end_character":12},"updated":"2017-11-28 20:23:34.000000000","message":"we cannot have these hardcoded as default values - please rectify this.","commit_id":"7efa6a378a224b038f92221d1478ae7e9e150e26"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"67b700eb54014e836f82616b9264e7b59cf5adde","unresolved":false,"context_lines":[{"line_number":342,"context_line":"# Specifying \"zap\" here tells ceph-disk to repartition/format the OSDs"},{"line_number":343,"context_line":"# before use.  While useful in test, this should not be used in production"},{"line_number":344,"context_line":"# as it will cause pod restarts to fail."},{"line_number":345,"context_line":"block_devices:"},{"line_number":346,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":347,"context_line":"    device: scsi@2:0.0.0"},{"line_number":348,"context_line":"    type: device"},{"line_number":349,"context_line":"    journal:"},{"line_number":350,"context_line":"      device: scsi@3:0.0.0"},{"line_number":351,"context_line":"    zap: \u00271\u0027"},{"line_number":352,"context_line":"  - name: scsi-2-0.0.1"},{"line_number":353,"context_line":"    device: scsi@2:0.0.1"},{"line_number":354,"context_line":"    type: device"},{"line_number":355,"context_line":"    journal:"},{"line_number":356,"context_line":"      device: scsi@3:0.0.1"},{"line_number":357,"context_line":"    zap: \u00271\u0027"},{"line_number":358,"context_line":"  - name: scsi-2-0.0.2"},{"line_number":359,"context_line":"    device: scsi@2:0.0.2"},{"line_number":360,"context_line":"    type: device"},{"line_number":361,"context_line":"    journal:"},{"line_number":362,"context_line":"      device: scsi@3:0.0.2"},{"line_number":363,"context_line":"    zap: \u00271\u0027"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"#Option 2: Directory"},{"line_number":366,"context_line":"# You may specify directory for Ceph Storage."}],"source_content_type":"text/x-yaml","patch_set":86,"id":"ff82abbf_9e7cc772","line":363,"range":{"start_line":345,"start_character":0,"end_line":363,"end_character":12},"in_reply_to":"ff82abbf_bb851d09","updated":"2017-11-28 20:51:19.000000000","message":"Figured these were necessary for the gate scripts, but you\u0027re right: they shouldn\u0027t be here and should be generated when the devices are created there.  I\u0027ll see how to do that.","commit_id":"7efa6a378a224b038f92221d1478ae7e9e150e26"}],"doc/source/install/multinode.rst":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"1d557ec46c01ab5ddfd775873e6e7a888e3dbc13","unresolved":false,"context_lines":[{"line_number":331,"context_line":"their OSDs:"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"::"},{"line_number":334,"context_line":"   "},{"line_number":335,"context_line":"   kubectl label nodes host1 cehpsd-device-dev-sdd\u003denabled"},{"line_number":336,"context_line":"   kubectl label nodes host2 cehpsd-device-scsi-2-0-0-5\u003denabled"},{"line_number":337,"context_line":"   kubectl label nodes host2 cehpsd-device-scsi-2-0-0-6\u003denabled"}],"source_content_type":"text/x-rst","patch_set":71,"id":"5f4e5783_4225b8c1","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":3},"updated":"2017-10-11 19:48:33.000000000","message":"need to remove these white spaces","commit_id":"f99721e9854b43ad8f09d7bae71cab522f439f2b"}],"tools/gate/funcs/common.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4609f586db2ffb20a1032dfba0e3388e12015d89","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    COUNT\u003d$[$COUNT+1]"},{"line_number":201,"context_line":"  done"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  (cd $DEV_INFO_DIR; jq -s \"$JQ_OPT\" *) | json_to_yaml \u003e\u003e ${LOOPBACK_DEV_INFO}"},{"line_number":204,"context_line":"  cat ${LOOPBACK_DEV_INFO}"},{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"function ceph_support_install {"}],"source_content_type":"text/x-sh","patch_set":69,"id":"5f4e5783_4176f108","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":26},"updated":"2017-10-11 04:33:34.000000000","message":"this is the section that should be targeted - not the above.\n\nThe above only applies to the local host - not the cluster.\n\nsee:\n * http://logs.openstack.org/54/457754/69/check/gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv/e087028/console.html#_2017-10-10_18_36_03_745954\n * http://logs.openstack.org/54/457754/69/check/gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv/e087028/console.html#_2017-10-10_18_37_19_108743","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ea12c70669860eafd1ece179567c23996bbb8886","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    COUNT\u003d$[$COUNT+1]"},{"line_number":201,"context_line":"  done"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  (cd $DEV_INFO_DIR; jq -s \"$JQ_OPT\" *) | json_to_yaml \u003e\u003e ${LOOPBACK_DEV_INFO}"},{"line_number":204,"context_line":"  cat ${LOOPBACK_DEV_INFO}"},{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"function ceph_support_install {"}],"source_content_type":"text/x-sh","patch_set":69,"id":"5f4e5783_14d70b4e","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":26},"in_reply_to":"5f4e5783_4176f108","updated":"2017-10-11 13:30:46.000000000","message":"This should be modified to generate output similar to:\nblock_devices:\n  node1-name:\n    ceph:\n    - name: scsi-2-0.0.0\n      device: scsi@2:0.0.0\n      journal:\n        device: scsi@3:0.0.0\n      zap: \u00271\u0027\n    - name: scsi-2-0.0.1\n      device: scsi@2:0.0.1\n      journal:\n        device: scsi@3:0.0.1\n      zap: \u00271\u0027\n    - name: scsi-2-0.0.2\n      device: scsi@2:0.0.2\n      journal:\n        device: scsi@3:0.0.2\n      zap: \u00271\u0027\n     swift:\n       - scsi@4:0.0.0\n       - scsi@4:0.0.1\n       - scsi@4:0.0.2\n  node2-name:\n    ceph:\n    - name: scsi-2-0.0.0\n      device: scsi@2:0.0.0\n      journal:\n        device: scsi@3:0.0.0\n      zap: \u00271\u0027\n    - name: scsi-2-0.0.1\n      device: scsi@2:0.0.1\n      journal:\n        device: scsi@3:0.0.1\n      zap: \u00271\u0027\n    - name: scsi-2-0.0.2\n      device: scsi@2:0.0.2\n      journal:\n        device: scsi@3:0.0.2\n      zap: \u00271\u0027\n     swift:\n       - scsi@4:0.0.0\n       - scsi@4:0.0.1\n       - scsi@4:0.0.2","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"}],"tools/gate/funcs/disk.sh":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"61515d140e537a0aeba8a14db234c787e6cfc1ed","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function prep_loopback_device {"},{"line_number":22,"context_line":"  sudo mkdir -p /data/ceph"},{"line_number":23,"context_line":"  sudo dd if\u003d/dev/zero of\u003d/data/ceph/ceph-osd0.img bs\u003d5M count\u003d6000"},{"line_number":24,"context_line":"  LOOP\u003d$(sudo losetup -f)"},{"line_number":25,"context_line":"  sudo losetup $LOOP /data/ceph/ceph-osd0.img"},{"line_number":26,"context_line":"  sudo parted $LOOP mklabel gpt"}],"source_content_type":"text/x-sh","patch_set":15,"id":"1f1a1f67_07874bb7","line":23,"updated":"2017-07-18 14:34:42.000000000","message":"I suggest creating sparse files here -- this will slow down the gate.  Do we also need 6000*5 or 30G? If its sparse it won\u0027t really matter as it will be... sparse!\n\n dd ... bs\u003d1 count\u003d0 seek\u003d30G","commit_id":"10b9762c04979ed1c3f9de6f31cd12be64fdb0d9"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"cfc01af79aaac3700186ba6e19317ff1fda3439b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function prep_loopback_device {"},{"line_number":22,"context_line":"  sudo mkdir -p /data/ceph"},{"line_number":23,"context_line":"  sudo dd if\u003d/dev/zero of\u003d/data/ceph/ceph-osd0.img bs\u003d5M count\u003d6000"},{"line_number":24,"context_line":"  LOOP\u003d$(sudo losetup -f)"},{"line_number":25,"context_line":"  sudo losetup $LOOP /data/ceph/ceph-osd0.img"},{"line_number":26,"context_line":"  sudo parted $LOOP mklabel gpt"}],"source_content_type":"text/x-sh","patch_set":15,"id":"1f1a1f67_aa3e12b5","line":23,"in_reply_to":"1f1a1f67_07874bb7","updated":"2017-07-18 18:43:24.000000000","message":"Done","commit_id":"10b9762c04979ed1c3f9de6f31cd12be64fdb0d9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"61515d140e537a0aeba8a14db234c787e6cfc1ed","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  LOOP\u003d$(sudo losetup -f)"},{"line_number":25,"context_line":"  sudo losetup $LOOP /data/ceph/ceph-osd0.img"},{"line_number":26,"context_line":"  sudo parted $LOOP mklabel gpt"},{"line_number":27,"context_line":"  sudo dd if\u003d/dev/zero of\u003d/data/ceph/ceph-osd1.img bs\u003d5M count\u003d6000"},{"line_number":28,"context_line":"  LOOP\u003d$(sudo losetup -f)"},{"line_number":29,"context_line":"  sudo losetup $LOOP /data/ceph/ceph-osd1.img"},{"line_number":30,"context_line":"  sudo parted $LOOP mklabel gpt"}],"source_content_type":"text/x-sh","patch_set":15,"id":"1f1a1f67_c78cb3d8","line":27,"updated":"2017-07-18 14:34:42.000000000","message":"and here","commit_id":"10b9762c04979ed1c3f9de6f31cd12be64fdb0d9"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"cfc01af79aaac3700186ba6e19317ff1fda3439b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  LOOP\u003d$(sudo losetup -f)"},{"line_number":25,"context_line":"  sudo losetup $LOOP /data/ceph/ceph-osd0.img"},{"line_number":26,"context_line":"  sudo parted $LOOP mklabel gpt"},{"line_number":27,"context_line":"  sudo dd if\u003d/dev/zero of\u003d/data/ceph/ceph-osd1.img bs\u003d5M count\u003d6000"},{"line_number":28,"context_line":"  LOOP\u003d$(sudo losetup -f)"},{"line_number":29,"context_line":"  sudo losetup $LOOP /data/ceph/ceph-osd1.img"},{"line_number":30,"context_line":"  sudo parted $LOOP mklabel gpt"}],"source_content_type":"text/x-sh","patch_set":15,"id":"1f1a1f67_8a491661","line":27,"in_reply_to":"1f1a1f67_c78cb3d8","updated":"2017-07-18 18:43:24.000000000","message":"Done","commit_id":"10b9762c04979ed1c3f9de6f31cd12be64fdb0d9"}],"tools/gate/launch-osh/basic.sh":[{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"helm search"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [ \"x$PVC_BACKEND\" \u003d\u003d \"xceph\" ]; then"},{"line_number":26,"context_line":"  kubectl label nodes ceph-osd-device-dev-cephosd0\u003denabled --all"},{"line_number":27,"context_line":"  kubectl label nodes ceph-osd-device-dev-cephosd1\u003denabled --all"},{"line_number":28,"context_line":"  kubectl label nodes ceph-osd-device-dev-cephosd2\u003denabled --all"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":68,"id":"5f4e5783_35690525","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":50},"updated":"2017-10-10 17:06:38.000000000","message":"can these osd names be moved to vars.sh?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      --set deployment.rbd_provisioner\u003dtrue \\"},{"line_number":62,"context_line":"      --set deployment.client_secrets\u003dfalse \\"},{"line_number":63,"context_line":"      --set deployment.rgw_keystone_user_and_endpoints\u003dfalse \\"},{"line_number":64,"context_line":"      --set bootstrap.enabled\u003dtrue \\"},{"line_number":65,"context_line":"      --set manifests_enabled.client_secrets\u003dfalse \\"},{"line_number":66,"context_line":"      --set bootstrap.enabled\u003dtrue"},{"line_number":67,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":68,"id":"5f4e5783_7f82bc51","line":64,"updated":"2017-10-10 17:06:38.000000000","message":"redundant line to 68","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"dfe2cbef686e9b7ac6f7a779516cdc24eed4dfd3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      --set deployment.client_secrets\u003dfalse \\"},{"line_number":63,"context_line":"      --set deployment.rgw_keystone_user_and_endpoints\u003dfalse \\"},{"line_number":64,"context_line":"      --set bootstrap.enabled\u003dtrue \\"},{"line_number":65,"context_line":"      --set manifests_enabled.client_secrets\u003dfalse \\"},{"line_number":66,"context_line":"      --set bootstrap.enabled\u003dtrue"},{"line_number":67,"context_line":"  fi"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-sh","patch_set":68,"id":"5f4e5783_3fab24d7","line":65,"updated":"2017-10-10 17:06:38.000000000","message":"is this a valid flag ?","commit_id":"24971ecda62ebc5a3bded852c5589e7d975905fb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ea12c70669860eafd1ece179567c23996bbb8886","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if [ \"x$INTEGRATION\" \u003d\u003d \"xaio\" ]; then"},{"line_number":37,"context_line":"    helm install --namespace\u003dceph ${WORK_DIR}/ceph --name\u003dceph \\"},{"line_number":38,"context_line":"      --set endpoints.identity.namespace\u003dopenstack \\"},{"line_number":39,"context_line":"      --set endpoints.object_store.namespace\u003dceph \\"},{"line_number":40,"context_line":"      --set endpoints.ceph_mon.namespace\u003dceph \\"},{"line_number":41,"context_line":"      --set ceph.rgw_keystone_auth\u003d${CEPH_RGW_KEYSTONE_ENABLED} \\"},{"line_number":42,"context_line":"      --set network.public\u003d${SUBNET_RANGE} \\"},{"line_number":43,"context_line":"      --set network.cluster\u003d${SUBNET_RANGE} \\"},{"line_number":44,"context_line":"      --set deployment.storage_secrets\u003dtrue \\"},{"line_number":45,"context_line":"      --set deployment.ceph\u003dtrue \\"},{"line_number":46,"context_line":"      --set deployment.rbd_provisioner\u003dtrue \\"},{"line_number":47,"context_line":"      --set deployment.client_secrets\u003dfalse \\"},{"line_number":48,"context_line":"      --set deployment.rgw_keystone_user_and_endpoints\u003dfalse \\"},{"line_number":49,"context_line":"      --set bootstrap.enabled\u003dtrue \\"},{"line_number":50,"context_line":"      --values\u003d${WORK_DIR}/tools/overrides/mvp/ceph.yaml"},{"line_number":51,"context_line":"  else"},{"line_number":52,"context_line":"    helm install --namespace\u003dceph ${WORK_DIR}/ceph --name\u003dceph \\"},{"line_number":53,"context_line":"      --set endpoints.identity.namespace\u003dopenstack \\"},{"line_number":54,"context_line":"      --set endpoints.object_store.namespace\u003dceph \\"},{"line_number":55,"context_line":"      --set endpoints.ceph_mon.namespace\u003dceph \\"},{"line_number":56,"context_line":"      --set ceph.rgw_keystone_auth\u003d${CEPH_RGW_KEYSTONE_ENABLED} \\"},{"line_number":57,"context_line":"      --set network.public\u003d${SUBNET_RANGE} \\"},{"line_number":58,"context_line":"      --set network.cluster\u003d${SUBNET_RANGE} \\"},{"line_number":59,"context_line":"      --set deployment.storage_secrets\u003dtrue \\"},{"line_number":60,"context_line":"      --set deployment.ceph\u003dtrue \\"},{"line_number":61,"context_line":"      --set deployment.rbd_provisioner\u003dtrue \\"},{"line_number":62,"context_line":"      --set deployment.client_secrets\u003dfalse \\"},{"line_number":63,"context_line":"      --set deployment.rgw_keystone_user_and_endpoints\u003dfalse \\"},{"line_number":64,"context_line":"      --set bootstrap.enabled\u003dtrue \\"},{"line_number":65,"context_line":"      --set manifests_enabled.client_secrets\u003dfalse \\"},{"line_number":66,"context_line":"      --set bootstrap.enabled\u003dtrue"},{"line_number":67,"context_line":"  fi"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  kube_wait_for_pods ceph ${POD_START_TIMEOUT_CEPH}"}],"source_content_type":"text/x-sh","patch_set":69,"id":"5f4e5783_545103d8","line":66,"range":{"start_line":37,"start_character":0,"end_line":66,"end_character":34},"updated":"2017-10-11 13:30:46.000000000","message":"these should be changed to include a line:\n--values\u003d${LOOPBACK_DEV_INFO}\nto load the disk topology","commit_id":"058cfb8cf8d86120bc35c209c1e53e45954e6927"}],"tools/gate/setup_gate.sh":[{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"eb5a629dc4653ef5a0667b72e1b5673e9122ce33","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  helm_plugin_template_install"},{"line_number":56,"context_line":"  helm_template_run"},{"line_number":57,"context_line":"else"},{"line_number":58,"context_line":"  # Setup the K8s Cluster"},{"line_number":59,"context_line":"  if ! [ \"x$ZUUL_VERSION\" \u003d\u003d \"xv3\" ]; then"},{"line_number":60,"context_line":"    if [ \"x$INTEGRATION\" \u003d\u003d \"xaio\" ]; then"},{"line_number":61,"context_line":"     bash ${WORK_DIR}/tools/gate/kubeadm_aio.sh"}],"source_content_type":"text/x-sh","patch_set":93,"id":"df87a7cf_6e52286a","side":"PARENT","line":58,"updated":"2017-12-03 07:15:07.000000000","message":"i am curious about the reason for moving this piece of code below \u0027pull-all-images\u0027 and the removal of xv3 check. that change let\u0027s the CI build kubeadm_aio which fails on the non-voting tests.","commit_id":"3ff69104fe22dcf4609c7eb4ec5191790bd5c5eb"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"c6ffead4aa288a26be0f424164bd68a228b1ac36","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  helm_plugin_template_install"},{"line_number":56,"context_line":"  helm_template_run"},{"line_number":57,"context_line":"else"},{"line_number":58,"context_line":"  # Setup the K8s Cluster"},{"line_number":59,"context_line":"  if ! [ \"x$ZUUL_VERSION\" \u003d\u003d \"xv3\" ]; then"},{"line_number":60,"context_line":"    if [ \"x$INTEGRATION\" \u003d\u003d \"xaio\" ]; then"},{"line_number":61,"context_line":"     bash ${WORK_DIR}/tools/gate/kubeadm_aio.sh"}],"source_content_type":"text/x-sh","patch_set":93,"id":"df87a7cf_87463d7c","side":"PARENT","line":58,"in_reply_to":"df87a7cf_6e52286a","updated":"2017-12-05 13:55:46.000000000","message":"It was likely a typo on my part — I didn\u0027t do it deliberately.  Definitely OK with undoing it.","commit_id":"3ff69104fe22dcf4609c7eb4ec5191790bd5c5eb"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"6d0003937f994a6067c4b8c6352ae6a1ea21e74d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  helm_plugin_template_install"},{"line_number":56,"context_line":"  helm_template_run"},{"line_number":57,"context_line":"else"},{"line_number":58,"context_line":"  # Setup the K8s Cluster"},{"line_number":59,"context_line":"  if ! [ \"x$ZUUL_VERSION\" \u003d\u003d \"xv3\" ]; then"},{"line_number":60,"context_line":"    if [ \"x$INTEGRATION\" \u003d\u003d \"xaio\" ]; then"},{"line_number":61,"context_line":"     bash ${WORK_DIR}/tools/gate/kubeadm_aio.sh"}],"source_content_type":"text/x-sh","patch_set":93,"id":"df87a7cf_87bb9cc2","side":"PARENT","line":58,"in_reply_to":"df87a7cf_87463d7c","updated":"2017-12-05 14:12:01.000000000","message":"... I\u0027ll change this so the logic reflects the upstream version.  hopefully that\u0027ll fix it.","commit_id":"3ff69104fe22dcf4609c7eb4ec5191790bd5c5eb"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"7eaa3b1936ac6208077eba10e58e34d5d43ef4c8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  helm_plugin_template_install"},{"line_number":56,"context_line":"  helm_template_run"},{"line_number":57,"context_line":"else"},{"line_number":58,"context_line":"  # Setup the K8s Cluster"},{"line_number":59,"context_line":"  if ! [ \"x$ZUUL_VERSION\" \u003d\u003d \"xv3\" ]; then"},{"line_number":60,"context_line":"    if [ \"x$INTEGRATION\" \u003d\u003d \"xaio\" ]; then"},{"line_number":61,"context_line":"     bash ${WORK_DIR}/tools/gate/kubeadm_aio.sh"}],"source_content_type":"text/x-sh","patch_set":93,"id":"df87a7cf_b0ab781b","side":"PARENT","line":58,"in_reply_to":"df87a7cf_87bb9cc2","updated":"2017-12-05 15:53:59.000000000","message":"Thanks a lot for looking into this dave. Wish we had an insight on the 3rd party CI failures instead of blindly guessing the reasons for failure.","commit_id":"3ff69104fe22dcf4609c7eb4ec5191790bd5c5eb"}],"tools/gate/vars.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3e338e7ca2b0a20605fc5595f229a78cbc621699","unresolved":false,"context_lines":[{"line_number":61,"context_line":"export SERVICE_TEST_TIMEOUT\u003d${SERVICE_TEST_TIMEOUT:\u003d\"600\"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Setup Loopback device options"},{"line_number":64,"context_line":"export LOOPBACK_CREATE\u003d${LOOPBACK_CREATE:\u003d\"false\"}"},{"line_number":65,"context_line":"export LOOPBACK_DEV_COUNT\u003d${LOOPBACK_DEV_COUNT:\u003d\"3,3,3\"}"},{"line_number":66,"context_line":"export LOOPBACK_SIZES\u003d${LOOPBACK_SIZES:\u003d\"8192M,8192M,1024M\"}"},{"line_number":67,"context_line":"export LOOPBACK_NAMES\u003d${LOOPBACK_NAMES:\u003d\"cephosd,cephjournal,swift\"}"}],"source_content_type":"text/x-sh","patch_set":81,"id":"1f485f77_98c39c57","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":48},"updated":"2017-11-17 17:14:10.000000000","message":"could we run it through the gate with this enabled as well before merge please? Also have the issues with pod restart been resolved?","commit_id":"c06cd8d5119113f16c654e03e09a2bf10b668592"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"830ff3838ffeee3b4684711194cba3655540fd10","unresolved":false,"context_lines":[{"line_number":61,"context_line":"export SERVICE_TEST_TIMEOUT\u003d${SERVICE_TEST_TIMEOUT:\u003d\"600\"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Setup Loopback device options"},{"line_number":64,"context_line":"export LOOPBACK_CREATE\u003d${LOOPBACK_CREATE:\u003d\"false\"}"},{"line_number":65,"context_line":"export LOOPBACK_DEV_COUNT\u003d${LOOPBACK_DEV_COUNT:\u003d\"3,3,3\"}"},{"line_number":66,"context_line":"export LOOPBACK_SIZES\u003d${LOOPBACK_SIZES:\u003d\"8192M,8192M,1024M\"}"},{"line_number":67,"context_line":"export LOOPBACK_NAMES\u003d${LOOPBACK_NAMES:\u003d\"cephosd,cephjournal,swift\"}"}],"source_content_type":"text/x-sh","patch_set":81,"id":"1f485f77_092400ae","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":48},"in_reply_to":"1f485f77_4e1afecb","updated":"2017-11-17 20:32:09.000000000","message":"Yeah, we definitely shouldn\u0027t be including zap as the default, and I almost think the option should go away entirely.  It\u0027s convenient when first standing up a cluster, but it guarantees that OSD pods won\u0027t restart.","commit_id":"c06cd8d5119113f16c654e03e09a2bf10b668592"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"96323ea422f97c3d93710faf2ece19fcc400ce72","unresolved":false,"context_lines":[{"line_number":61,"context_line":"export SERVICE_TEST_TIMEOUT\u003d${SERVICE_TEST_TIMEOUT:\u003d\"600\"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Setup Loopback device options"},{"line_number":64,"context_line":"export LOOPBACK_CREATE\u003d${LOOPBACK_CREATE:\u003d\"false\"}"},{"line_number":65,"context_line":"export LOOPBACK_DEV_COUNT\u003d${LOOPBACK_DEV_COUNT:\u003d\"3,3,3\"}"},{"line_number":66,"context_line":"export LOOPBACK_SIZES\u003d${LOOPBACK_SIZES:\u003d\"8192M,8192M,1024M\"}"},{"line_number":67,"context_line":"export LOOPBACK_NAMES\u003d${LOOPBACK_NAMES:\u003d\"cephosd,cephjournal,swift\"}"}],"source_content_type":"text/x-sh","patch_set":81,"id":"1f485f77_4e1afecb","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":48},"in_reply_to":"1f485f77_58be44b4","updated":"2017-11-17 19:02:45.000000000","message":"For an OSD to respawn properly into the cluster, i had to remove zap and include the cluster\u0027s fsid under global of values.yaml for it to respawn and join the cluster. Do those seem like the right options?","commit_id":"c06cd8d5119113f16c654e03e09a2bf10b668592"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"bcaa211e80fdec62c87438cc548abe49a22c7b88","unresolved":false,"context_lines":[{"line_number":61,"context_line":"export SERVICE_TEST_TIMEOUT\u003d${SERVICE_TEST_TIMEOUT:\u003d\"600\"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Setup Loopback device options"},{"line_number":64,"context_line":"export LOOPBACK_CREATE\u003d${LOOPBACK_CREATE:\u003d\"false\"}"},{"line_number":65,"context_line":"export LOOPBACK_DEV_COUNT\u003d${LOOPBACK_DEV_COUNT:\u003d\"3,3,3\"}"},{"line_number":66,"context_line":"export LOOPBACK_SIZES\u003d${LOOPBACK_SIZES:\u003d\"8192M,8192M,1024M\"}"},{"line_number":67,"context_line":"export LOOPBACK_NAMES\u003d${LOOPBACK_NAMES:\u003d\"cephosd,cephjournal,swift\"}"}],"source_content_type":"text/x-sh","patch_set":81,"id":"1f485f77_58be44b4","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":48},"in_reply_to":"1f485f77_98c39c57","updated":"2017-11-17 17:20:31.000000000","message":"will do.\n\npod restart issues have been resolved, I believe, with the elimination of \"zap\" from values.yaml; I\u0027ve tested bouncing a node and it came back OK.","commit_id":"c06cd8d5119113f16c654e03e09a2bf10b668592"}]}