)]}'
{"panko/templates/configmap-bin.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"385d922fe29f40eba8278728902da036464d7cdc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- include \"helm-toolkit.scripts.keystone_endpoints\" . | indent 4 }}"},{"line_number":30,"context_line":"  ks-user.sh: |+"},{"line_number":31,"context_line":"{{- include \"helm-toolkit.scripts.keystone_user\" . | indent 4 }}"},{"line_number":32,"context_line":"  ks-domain-user.sh: |+"},{"line_number":33,"context_line":"{{- include \"helm-toolkit.scripts.keystone_domain_user\" . | indent 4 }}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_120c4f92","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":71},"updated":"2017-06-26 12:35:13.000000000","message":"Are you using this script anywhere? It pops up in a few charts but apparently is simply copied from Heat chart without any reason.","commit_id":"44ed25211c6915b849c0d1ded376e28f716aab7d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9a9f883d5bfe90a61b45f38a3a17c6b8b1637cc6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- include \"helm-toolkit.scripts.keystone_endpoints\" . | indent 4 }}"},{"line_number":30,"context_line":"  ks-user.sh: |+"},{"line_number":31,"context_line":"{{- include \"helm-toolkit.scripts.keystone_user\" . | indent 4 }}"},{"line_number":32,"context_line":"  ks-domain-user.sh: |+"},{"line_number":33,"context_line":"{{- include \"helm-toolkit.scripts.keystone_domain_user\" . | indent 4 }}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_c1d15f25","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":71},"in_reply_to":"5f201791_120c4f92","updated":"2017-06-26 14:27:27.000000000","message":"agreed - I\u0027ve been guilty of this as well.","commit_id":"44ed25211c6915b849c0d1ded376e28f716aab7d"}],"panko/values.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"385d922fe29f40eba8278728902da036464d7cdc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"images:"},{"line_number":12,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":13,"context_line":"  # using non-kolla images until kolla supports postgres as"},{"line_number":14,"context_line":"  # an indexer"},{"line_number":15,"context_line":"  db_init: docker.io/kolla/ubuntu-source-panko-api:3.0.3-beta.1"},{"line_number":16,"context_line":"  db_sync: docker.io/kolla/ubuntu-source-panko-api:3.0.3-beta.1"},{"line_number":17,"context_line":"  ks_user: docker.io/kolla/ubuntu-source-kolla-toolbox:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_b2547b54","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":14},"updated":"2017-06-26 12:35:13.000000000","message":"Which of those images are non-kolla? I think I don\u0027t understand this comment.","commit_id":"44ed25211c6915b849c0d1ded376e28f716aab7d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"385d922fe29f40eba8278728902da036464d7cdc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    service:"},{"line_number":91,"context_line":"    - keystone-api"},{"line_number":92,"context_line":"    - mariadb"},{"line_number":93,"context_line":"  evaluator:"},{"line_number":94,"context_line":"    jobs:"},{"line_number":95,"context_line":"    - panko-db-sync"},{"line_number":96,"context_line":"    service:"},{"line_number":97,"context_line":"    - panko-api"},{"line_number":98,"context_line":"    - keystone-api"},{"line_number":99,"context_line":"    - mariadb"},{"line_number":100,"context_line":"  listener:"},{"line_number":101,"context_line":"    jobs:"},{"line_number":102,"context_line":"    - panko-db-sync"},{"line_number":103,"context_line":"    service:"},{"line_number":104,"context_line":"    - panko-api"},{"line_number":105,"context_line":"    - keystone-api"},{"line_number":106,"context_line":"    - mariadb"},{"line_number":107,"context_line":"  notifier:"},{"line_number":108,"context_line":"    jobs:"},{"line_number":109,"context_line":"    - panko-db-sync"},{"line_number":110,"context_line":"    service:"},{"line_number":111,"context_line":"    - panko-api"},{"line_number":112,"context_line":"    - keystone-api"},{"line_number":113,"context_line":"    - mariadb"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"database:"},{"line_number":116,"context_line":"  address: mariadb"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_f2a1d347","line":113,"range":{"start_line":93,"start_character":0,"end_line":113,"end_character":13},"updated":"2017-06-26 12:35:13.000000000","message":"Looks like you\u0027re missing definitions for those pods?","commit_id":"44ed25211c6915b849c0d1ded376e28f716aab7d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"385d922fe29f40eba8278728902da036464d7cdc","unresolved":false,"context_lines":[{"line_number":213,"context_line":"  enabled: false"},{"line_number":214,"context_line":"  panko_api:"},{"line_number":215,"context_line":"    requests:"},{"line_number":216,"context_line":"      memory: \"124Mi\""},{"line_number":217,"context_line":"      cpu: \"100m\""},{"line_number":218,"context_line":"    limits:"},{"line_number":219,"context_line":"      memory: \"1024Mi\""},{"line_number":220,"context_line":"      cpu: \"2000m\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_728dc3d1","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":17},"updated":"2017-06-26 12:35:13.000000000","message":"I doubt this is a good value for an API service.","commit_id":"44ed25211c6915b849c0d1ded376e28f716aab7d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"385d922fe29f40eba8278728902da036464d7cdc","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    limits:"},{"line_number":219,"context_line":"      memory: \"1024Mi\""},{"line_number":220,"context_line":"      cpu: \"2000m\""},{"line_number":221,"context_line":"  panko_evaluator:"},{"line_number":222,"context_line":"    requests:"},{"line_number":223,"context_line":"      memory: \"124Mi\""},{"line_number":224,"context_line":"      cpu: \"100m\""},{"line_number":225,"context_line":"    limits:"},{"line_number":226,"context_line":"      memory: \"1024Mi\""},{"line_number":227,"context_line":"      cpu: \"2000m\""},{"line_number":228,"context_line":"  panko_listener:"},{"line_number":229,"context_line":"    requests:"},{"line_number":230,"context_line":"      memory: \"124Mi\""},{"line_number":231,"context_line":"      cpu: \"100m\""},{"line_number":232,"context_line":"    limits:"},{"line_number":233,"context_line":"      memory: \"1024Mi\""},{"line_number":234,"context_line":"      cpu: \"2000m\""},{"line_number":235,"context_line":"  panko_notifier:"},{"line_number":236,"context_line":"    requests:"},{"line_number":237,"context_line":"      memory: \"124Mi\""},{"line_number":238,"context_line":"      cpu: \"100m\""},{"line_number":239,"context_line":"    limits:"},{"line_number":240,"context_line":"      memory: \"1024Mi\""},{"line_number":241,"context_line":"      cpu: \"2000m\""},{"line_number":242,"context_line":"  panko_db_init:"},{"line_number":243,"context_line":"    requests:"},{"line_number":244,"context_line":"      memory: \"124Mi\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_32c50bf2","line":241,"range":{"start_line":221,"start_character":0,"end_line":241,"end_character":18},"updated":"2017-06-26 12:35:13.000000000","message":"Definitions of those pods are missing.","commit_id":"44ed25211c6915b849c0d1ded376e28f716aab7d"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"8b988dde28d77db2244a5006aa17178c5d7c270c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"dependencies:"},{"line_number":30,"context_line":"  db_init:"},{"line_number":31,"context_line":"    jobs:"},{"line_number":32,"context_line":"    service:"},{"line_number":33,"context_line":"    - mariadb"},{"line_number":34,"context_line":"  db_sync:"},{"line_number":35,"context_line":"    jobs:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7f287b81_3dd229d2","line":32,"updated":"2017-09-01 06:33:22.000000000","message":"\u0027services\u0027 instead of \u0027service\u0027 (leaving \u0027service\u0027 will not break anything at first glance but the dependency will not be set properly)","commit_id":"7ee8b8f0423f44104a74fdfef3b1e0f3f50f3ecb"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"8b988dde28d77db2244a5006aa17178c5d7c270c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  db_init:"},{"line_number":31,"context_line":"    jobs:"},{"line_number":32,"context_line":"    service:"},{"line_number":33,"context_line":"    - mariadb"},{"line_number":34,"context_line":"  db_sync:"},{"line_number":35,"context_line":"    jobs:"},{"line_number":36,"context_line":"    - panko-db-init"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7f287b81_ba99667a","line":33,"updated":"2017-09-01 06:33:22.000000000","message":"Instead of the service name, we should point to the endpoint.  As an example, see my comments in the following PS:\n\nhttps://review.openstack.org/#/c/472381/","commit_id":"7ee8b8f0423f44104a74fdfef3b1e0f3f50f3ecb"}],"tools/gate/basic_launch.sh":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d69227d38f4ba144b7f41ab22468034b699dab4d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  sudo modprobe ip6_tables"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"helm install --namespace\u003dopenstack local/mariadb --name\u003dmariadb"},{"line_number":33,"context_line":"helm install --namespace\u003dopenstack local/memcached --name\u003dmemcached"},{"line_number":34,"context_line":"helm install --namespace\u003dopenstack local/etcd --name\u003detcd-rabbitmq"},{"line_number":35,"context_line":"helm install --namespace\u003dopenstack local/rabbitmq --name\u003drabbitmq"},{"line_number":36,"context_line":"kube_wait_for_pods openstack 420"},{"line_number":37,"context_line":"helm install --namespace\u003dopenstack local/keystone --name\u003dkeystone"},{"line_number":38,"context_line":"helm install --namespace\u003dopenstack local/glance --name\u003dglance \\"},{"line_number":39,"context_line":"    --values\u003d${WORK_DIR}/tools/overrides/mvp/glance.yaml"},{"line_number":40,"context_line":"kube_wait_for_pods openstack 420"},{"line_number":41,"context_line":"helm install --namespace\u003dopenstack local/nova --name\u003dnova \\"},{"line_number":42,"context_line":"    --values\u003d${WORK_DIR}/tools/overrides/mvp/nova.yaml \\"},{"line_number":43,"context_line":"    --set\u003dconf.nova.libvirt.nova.conf.virt_type\u003dqemu"},{"line_number":44,"context_line":"helm install --namespace\u003dopenstack local/neutron --name\u003dneutron \\"},{"line_number":45,"context_line":"    --values\u003d${WORK_DIR}/tools/overrides/mvp/neutron.yaml"},{"line_number":46,"context_line":"kube_wait_for_pods openstack 420"},{"line_number":47,"context_line":"helm install --namespace\u003dopenstack local/cinder --name\u003dcinder"},{"line_number":48,"context_line":"helm install --namespace\u003dopenstack local/heat --name\u003dheat"},{"line_number":49,"context_line":"helm install --namespace\u003dopenstack local/horizon --name\u003dhorizon"},{"line_number":50,"context_line":"helm install --namespace\u003dopenstack local/panko --name\u003dpanko"},{"line_number":51,"context_line":"kube_wait_for_pods openstack 420"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ \"x$INTEGRATION\" \u003d\u003d \"xaio\" ]; then"},{"line_number":54,"context_line":" bash ${WORK_DIR}/tools/gate/openstack_aio_launch.sh"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"helm_test_deployment keystone 600"},{"line_number":58,"context_line":"helm_test_deployment glance 600"},{"line_number":59,"context_line":"helm_test_deployment neutron 600"},{"line_number":60,"context_line":"helm_test_deployment nova 600"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f201791_ed0d4de8","line":60,"range":{"start_line":32,"start_character":0,"end_line":60,"end_character":29},"updated":"2017-06-27 12:00:05.000000000","message":"Can you explain why those changes are needed to run panko? Looks like it\u0027s just an API, so I\u0027m surprised we need to load a new kernel module.","commit_id":"59eb15df85bae774cadef9fc62118e89ef2af354"}]}