)]}'
{"heat/templates/bin/_trusts.sh.tpl":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"42e8dd71edf3db916cfe01eb7935a80b8e48c1d7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# Split roles into an array"},{"line_number":20,"context_line":"IFS\u003d\u0027,\u0027 read -r -a roles \u003c\u003c\u003c \"${SERVICE_OS_ROLES}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Create trust between trustor and trustee"},{"line_number":23,"context_line":"SERVICE_OS_TRUST_ID\u003d$(openstack trust create -f value -c id \\"},{"line_number":24,"context_line":"          --project\u003d\"${OS_PROJECT_NAME}\" \\"},{"line_number":25,"context_line":"          ${roles[@]/#/--role\u003d} \\"},{"line_number":26,"context_line":"          \"${OS_PROJECT_NAME}\" \\"},{"line_number":27,"context_line":"          \"${SERVICE_OS_TRUSTEE}\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Display trust"},{"line_number":30,"context_line":"openstack trust show \"${SERVICE_OS_TRUST_ID}\""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"bf091321_58d71d25","line":27,"range":{"start_line":22,"start_character":0,"end_line":27,"end_character":34},"updated":"2017-06-07 20:07:46.000000000","message":"I\u0027ve got an idea how to make this script idempotent (no filtering in `openstack trust list` makes it a little harder, but still feasible), so let me fix this first before merging.","commit_id":"056004a47e5fbb1fa743196b42709d45ec6d26d9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3c52636a6a9003ea63db5089d405b70db617d23a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"OS_USER_ID\u003d$(openstack user show -f value -c id ${OS_USERNAME})"},{"line_number":22,"context_line":"SERVICE_OS_TRUSTEE_ID\u003d$(openstack user show -f value -c id ${SERVICE_OS_TRUSTEE})"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Check if trust doesn\u0027t already exist"},{"line_number":25,"context_line":"openstack trust list -f value -c \"Project ID\" \\"},{"line_number":26,"context_line":"          -c \"Trustee User ID\" -c \"Trustor User ID\" | \\"},{"line_number":27,"context_line":"          grep \"^${OS_PROJECT_ID} ${SERVICE_OS_TRUSTEE_ID} ${OS_USER_ID}$\" \u0026\u0026 \\"},{"line_number":28,"context_line":"          exit 0"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Split roles into an array"},{"line_number":31,"context_line":"IFS\u003d\u0027,\u0027 read -r -a roles \u003c\u003c\u003c \"${SERVICE_OS_ROLES}\""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bf091321_141ef7b9","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":16},"updated":"2017-06-08 10:59:29.000000000","message":"Okay, this should be a sufficient check.","commit_id":"23ee999a0cd110d00ec0b78a611d02c382031264"}],"heat/templates/job-trusts.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e7034e4bf96ec303ec1476d2125b53b8eea0c6bb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_b49ed551","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"updated":"2017-06-23 12:44:26.000000000","message":"as we have a default defined (by proxy) in the values.yaml - could you remove this.","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4e259f652ab1ee9f996b0150181fdf55a97d0f37","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_c7b4dcd3","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"in_reply_to":"5f201791_6408822b","updated":"2017-06-26 08:59:17.000000000","message":"According to heat code [1], leaving it empty makes heat delegate all the roles user has for the particular project. I think this is the best default setting - it will work fine when we would want to create stacks by non-admin users. What do you think?\n\n[1] https://github.com/openstack/heat/blob/4992593baae8b509af9d1940bf0906f87d810869/heat/common/config.py#L112-L116","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f78686f6ca9bd7adfb1d09ea16b6e298fd5a51e0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_b2d02421","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"in_reply_to":"5f201791_7255ecc5","updated":"2017-06-23 14:22:38.000000000","message":"Okay, I\u0027ve moved it into values.yaml.","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7ec88547f7c7de1d86e0548b6895cdc6c096e389","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_7255ecc5","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"in_reply_to":"5f201791_b26a64b0","updated":"2017-06-23 14:18:09.000000000","message":"It looks like you have done the inverse of what I was suggesting? We really should have all default values in the values.yaml, rather than pushed out to the templates if possible.","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d27f6f7ceef46587d60510dada97b43cfc05bdc2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_6408822b","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"in_reply_to":"5f201791_b2d02421","updated":"2017-06-23 18:27:48.000000000","message":"could you specify the \"admin\" role as the default there - rather than an empty string.","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"00eb04f39509c02c3590ed44a10d8f47c478bd99","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_d47711d4","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"in_reply_to":"5f201791_b49ed551","updated":"2017-06-23 12:55:30.000000000","message":"This gave me an idea for one more enhancement - empty value of trusts_delegated_roles means that Heat will try to delegate *all* of the roles that user has in the particular project. In that case we should fetch them and create trust for each. That way we could simply get rid of both defaults and leave figuring it out to the job.\n\nI\u0027ll try this out in a moment.","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"48fd43ce91f1a02708c44907d0088f185e41de78","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"            - name: SERVICE_OS_ROLES"},{"line_number":56,"context_line":"              value: {{ .Values.conf.heat.default.heat.common.config.trusts_delegated_roles | default \"admin\" }}"},{"line_number":57,"context_line":"            - name: SERVICE_OS_TRUSTEE"},{"line_number":58,"context_line":"              value: {{ .Values.conf.heat.trustee.heat.common.context.username }}"},{"line_number":59,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_b26a64b0","line":56,"range":{"start_line":56,"start_character":94,"end_line":56,"end_character":109},"in_reply_to":"5f201791_d47711d4","updated":"2017-06-23 14:12:06.000000000","message":"Done, now this should be much safer and less error prone.","commit_id":"e874192f4db65e3dc95d73538b6130e0f67380fe"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"51e1590c20ec8c32ef8178a6d188e62507acaa83","unresolved":false,"context_lines":[{"line_number":20,"context_line":"metadata:"},{"line_number":21,"context_line":"  name: heat-trusts"},{"line_number":22,"context_line":"spec:"},{"line_number":23,"context_line":"  template:"},{"line_number":24,"context_line":"    spec:"},{"line_number":25,"context_line":"      restartPolicy: OnFailure"},{"line_number":26,"context_line":"      nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bf3e73b7_92731881","line":23,"updated":"2017-08-07 13:33:05.000000000","message":"To be consistent with other charts - can you add labels as in the following PS?\n\n https://review.openstack.org/#/c/491199/","commit_id":"d0b8c750058cb4df3ec28547c018dcb5b79cd2a1"}]}
