)]}'
{"nova/templates/bin/_ceph-secret-define.sh.tpl":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"eed3fce477f66a04703069261fffcabf9ae48143","unresolved":false,"context_lines":[{"line_number":35,"context_line":"uuid\u003d\"{{ .Values.ceph.secret_uuid }}\""},{"line_number":36,"context_line":"keyring\u003d\"{{ .Values.ceph.cinder_keyring }}\""},{"line_number":37,"context_line":"if [ -z \"$uuid\" ] ; then"},{"line_number":38,"context_line":"    uuid\u003d$(uuidgen)"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"if [ -z \"$keyring\" ] ; then"},{"line_number":41,"context_line":"    # secret wasn\u0027t explicitly given, ugly hack to suck from config"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f231b9d_8ba9cce0","line":38,"updated":"2017-06-11 16:41:20.000000000","message":"This would presume the uuidgen tool is in the container image.  What would happen if it was not and how would we relay that in some sane way to the end user?","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"f614c3d5350ba15282c016378b0dabb493d2d4c6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"uuid\u003d\"{{ .Values.ceph.secret_uuid }}\""},{"line_number":36,"context_line":"keyring\u003d\"{{ .Values.ceph.cinder_keyring }}\""},{"line_number":37,"context_line":"if [ -z \"$uuid\" ] ; then"},{"line_number":38,"context_line":"    uuid\u003d$(uuidgen)"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"if [ -z \"$keyring\" ] ; then"},{"line_number":41,"context_line":"    # secret wasn\u0027t explicitly given, ugly hack to suck from config"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5f201791_21b805e3","line":38,"in_reply_to":"5f201791_eb22ec51","updated":"2017-06-26 23:17:20.000000000","message":"using sprig might be reasonable, but given all values are equally useful here we could default to anything surely?\n\nhttps://xkcd.com/221/\n\ni\u0027m thinking we just yank out all the override stuff; these code paths don\u0027t work as-is and it\u0027s not clear they ever did so i would prefer we pared-down some of these configuration options and reintroducing them when\n\n1. we can test them\n2. they actually work\n3. they have real-life real users who really need them","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"adda9a72ab2001e81c739d76105a7f0a00fe14ed","unresolved":false,"context_lines":[{"line_number":35,"context_line":"uuid\u003d\"{{ .Values.ceph.secret_uuid }}\""},{"line_number":36,"context_line":"keyring\u003d\"{{ .Values.ceph.cinder_keyring }}\""},{"line_number":37,"context_line":"if [ -z \"$uuid\" ] ; then"},{"line_number":38,"context_line":"    uuid\u003d$(uuidgen)"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"if [ -z \"$keyring\" ] ; then"},{"line_number":41,"context_line":"    # secret wasn\u0027t explicitly given, ugly hack to suck from config"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5f201791_eb22ec51","line":38,"in_reply_to":"7f231b9d_4b697423","updated":"2017-06-26 21:36:42.000000000","message":"I think sprig has the ability to generate uuid\u0027s if required.","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7ccea18584a14b27a2723e938553a3bba85cd341","unresolved":false,"context_lines":[{"line_number":35,"context_line":"uuid\u003d\"{{ .Values.ceph.secret_uuid }}\""},{"line_number":36,"context_line":"keyring\u003d\"{{ .Values.ceph.cinder_keyring }}\""},{"line_number":37,"context_line":"if [ -z \"$uuid\" ] ; then"},{"line_number":38,"context_line":"    uuid\u003d$(uuidgen)"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"if [ -z \"$keyring\" ] ; then"},{"line_number":41,"context_line":"    # secret wasn\u0027t explicitly given, ugly hack to suck from config"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f231b9d_4b697423","line":38,"in_reply_to":"7f231b9d_8ba9cce0","updated":"2017-06-11 17:53:03.000000000","message":"i thought of that, but since uuidgen was there i didn\u0027t implement the fallback which might look like\n\n# https://xkcd.com/221/\n... || uuid\u003d07076c92-812e-4118-b760-e3677dfe3e57","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"f614c3d5350ba15282c016378b0dabb493d2d4c6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"uuid\u003d\"{{ .Values.ceph.secret_uuid }}\""},{"line_number":36,"context_line":"keyring\u003d\"{{ .Values.ceph.cinder_keyring }}\""},{"line_number":37,"context_line":"if [ -z \"$uuid\" ] ; then"},{"line_number":38,"context_line":"    uuid\u003d$(uuidgen)"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"if [ -z \"$keyring\" ] ; then"},{"line_number":41,"context_line":"    # secret wasn\u0027t explicitly given, ugly hack to suck from config"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5f201791_e1cd6d85","line":38,"in_reply_to":"7f231b9d_8ba9cce0","updated":"2017-06-26 23:17:20.000000000","message":"uuidgen is there at present","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"}],"nova/templates/etc/_ceph.conf.tpl":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"eed3fce477f66a04703069261fffcabf9ae48143","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{ end }}"},{"line_number":27,"context_line":"{{- else }}"},{"line_number":28,"context_line":"# default monitor"},{"line_number":29,"context_line":"mon_host \u003d ceph-mon.ceph"},{"line_number":30,"context_line":"{{- end }}"},{"line_number":31,"context_line":"{{- end }}"},{"line_number":32,"context_line":"[client]"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f231b9d_abf24805","line":29,"updated":"2017-06-11 16:41:20.000000000","message":"Maybe ceph, like any other infrastructure element should follow the endpoint: pattern? There is a method (used for memcache) to extract a name such as this where we only care about the hostname.  At the moment, we are treating ceph sort of as a unique creature but its just like a database, rabbitmq infrastructure, or memcache.  It is a thing we need auth parameters to, want to have some sane default that works out of the box, and allow the end user to arrive.  Smells a lot like an endpoint:","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7ccea18584a14b27a2723e938553a3bba85cd341","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{ end }}"},{"line_number":27,"context_line":"{{- else }}"},{"line_number":28,"context_line":"# default monitor"},{"line_number":29,"context_line":"mon_host \u003d ceph-mon.ceph"},{"line_number":30,"context_line":"{{- end }}"},{"line_number":31,"context_line":"{{- end }}"},{"line_number":32,"context_line":"[client]"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f231b9d_0b737c17","line":29,"in_reply_to":"7f231b9d_abf24805","updated":"2017-06-11 17:53:03.000000000","message":"i\u0027m fine with that but as a separate PS","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"}],"nova/values.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"eed3fce477f66a04703069261fffcabf9ae48143","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  cinder_user: \"cinder\""},{"line_number":140,"context_line":"  cinder_keyring: null"},{"line_number":141,"context_line":"  nova_pool: \"vms\""},{"line_number":142,"context_line":"  secret_uuid: \"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"libvirt:"},{"line_number":145,"context_line":"  listen_addr: 0.0.0.0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f231b9d_8bf78cf6","line":142,"updated":"2017-06-11 16:41:20.000000000","message":"null vs \"\" -- could we standardize on null -- would that work here in the same way?","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7ccea18584a14b27a2723e938553a3bba85cd341","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  cinder_user: \"cinder\""},{"line_number":140,"context_line":"  cinder_keyring: null"},{"line_number":141,"context_line":"  nova_pool: \"vms\""},{"line_number":142,"context_line":"  secret_uuid: \"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"libvirt:"},{"line_number":145,"context_line":"  listen_addr: 0.0.0.0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f231b9d_8b60ac34","line":142,"in_reply_to":"7f231b9d_8bf78cf6","updated":"2017-06-11 17:53:03.000000000","message":"again, fine with that but i feel those cleanups are often better separate to fixes","commit_id":"6a3b5d27c1735d85cde0c3af741bd2c4dcec3090"}]}
