)]}'
{"helm-toolkit/templates/snippets/_kubernetes_metadata_labels.tpl":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6b5c43460194e4746753b65dbc0f1970965f888d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{{- $envAll :\u003d index . 0 -}}"},{"line_number":17,"context_line":"{{- $application :\u003d index . 1 -}}"},{"line_number":18,"context_line":"{{- $component :\u003d index . 2 -}}"},{"line_number":19,"context_line":"release_group: {{ $envAll.Values.release_group | default $envAll.Release.Name }}"},{"line_number":20,"context_line":"application: {{ $application }}"},{"line_number":21,"context_line":"component: {{ $component }}"},{"line_number":22,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"ff346bd7_065e1f75","line":19,"updated":"2017-07-28 09:26:42.000000000","message":"Can you elaborate why this change is done?","commit_id":"bf7df17290f7bb16861f8c67da5ba5bda71f45ee"}],"neutron/templates/bin/_neutron-server.sh.tpl":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e40ddb303d3bae5cbe99397e698efe2b1462703","unresolved":false,"context_lines":[{"line_number":18,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":19,"context_line":"CONF_FILE\u003d\"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- if .Values.conf.ml2_conf_onos.enable }}"},{"line_number":22,"context_line":"CONF_FILE\u003d$CONF_FILE\" --config-file /etc/neutron/plugins/ml2/ml2_conf_onos.ini\""},{"line_number":23,"context_line":"{{- end }}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"df3967d1_2e6b70f1","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":40},"updated":"2017-08-03 11:02:03.000000000","message":"It should be \u0027enabled\u0027.","commit_id":"8650ddb0fad60da95f8f28a09d0387706dbb361e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e40ddb303d3bae5cbe99397e698efe2b1462703","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{- end }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"function start () {"},{"line_number":26,"context_line":"  exec neutron-server $CONF_FILE"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function stop () {"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"df3967d1_eed1e824","line":26,"updated":"2017-08-03 11:02:03.000000000","message":"We can also implement adding new config file similar to what I did in linux-bridge implementation [1]:\n\nexec neutron-server \\\n    --config-file /etc/neutron/neutron.conf \\\n    --config-file /etc/neutron/plugins/ml2/ml2_conf.ini\n{{- if .Values.conf.ml2_conf_onos.enable }}\n    --config-file /etc/neutron/plugins/ml2/ml2_conf_onos.ini\n{{- end }}\n\n[1] https://review.openstack.org/#/c/466293/14/neutron/templates/bin/_neutron-l3-agent.sh.tpl","commit_id":"8650ddb0fad60da95f8f28a09d0387706dbb361e"}],"neutron/templates/bin/_openvswitch-db-server.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"efc44099eb2657ef82c12bafa10cfcbd711b517f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"umask 000"},{"line_number":27,"context_line":"exec /usr/sbin/ovsdb-server /run/openvswitch/conf.db -vconsole:emer -vconsole:err -vconsole:info --remote\u003dpunix:/run/openvswitch/db.sock --pidfile\u003d/var/run/openvswitch/ovsdb-server.pid"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"9f436f4f_2193daa5","line":27,"updated":"2017-08-14 14:03:02.000000000","message":"could you split this command onto multiple lines.","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"}],"neutron/templates/configmap-bin.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"efc44099eb2657ef82c12bafa10cfcbd711b517f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"{{- include \"helm-toolkit.scripts.keystone_endpoints\" . | indent 4 }}"},{"line_number":39,"context_line":"  ks-user.sh: |+"},{"line_number":40,"context_line":"{{- include \"helm-toolkit.scripts.keystone_user\" . | indent 4 }}"},{"line_number":41,"context_line":"{{- if .Values.manifests.daemonset_dhcp_agent }}"},{"line_number":42,"context_line":"  neutron-dhcp-agent.sh: |+"},{"line_number":43,"context_line":"{{ tuple \"bin/_neutron-dhcp-agent.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":44,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f436f4f_61f682fc","line":41,"updated":"2017-08-14 14:03:02.000000000","message":"I\u0027m not comfortable with this logic being inserted into the configmap could you remove it?","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dfc07eb306f2c8e94205e653e7888d5629c962ae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"{{- include \"helm-toolkit.scripts.keystone_endpoints\" . | indent 4 }}"},{"line_number":39,"context_line":"  ks-user.sh: |+"},{"line_number":40,"context_line":"{{- include \"helm-toolkit.scripts.keystone_user\" . | indent 4 }}"},{"line_number":41,"context_line":"{{- if .Values.manifests.daemonset_dhcp_agent }}"},{"line_number":42,"context_line":"  neutron-dhcp-agent.sh: |+"},{"line_number":43,"context_line":"{{ tuple \"bin/_neutron-dhcp-agent.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":44,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f436f4f_e9281498","line":41,"in_reply_to":"9f436f4f_61f682fc","updated":"2017-08-21 11:05:27.000000000","message":"Yes, I agree that config map can stay untouched.","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"}],"neutron/templates/configmap-etc.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"efc44099eb2657ef82c12bafa10cfcbd711b517f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"{{- if .Values.conf.policy.append -}}"},{"line_number":110,"context_line":"{{ .Values.conf.policy.append | indent 4 }}"},{"line_number":111,"context_line":"{{- end }}"},{"line_number":112,"context_line":"{{- if .Values.manifests.daemonset_dhcp_agent }}"},{"line_number":113,"context_line":"  dhcp_agent.ini: |+"},{"line_number":114,"context_line":"{{ if .Values.conf.dhcp_agent.override -}}"},{"line_number":115,"context_line":"{{ .Values.conf.dhcp_agent.override | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f436f4f_e1e1522c","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":48},"updated":"2017-08-14 14:03:02.000000000","message":"as with the bin configmap I\u0027m not comfortable with the manifest enable/disable being extended within the manifest themselves.","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dfc07eb306f2c8e94205e653e7888d5629c962ae","unresolved":false,"context_lines":[{"line_number":109,"context_line":"{{- if .Values.conf.policy.append -}}"},{"line_number":110,"context_line":"{{ .Values.conf.policy.append | indent 4 }}"},{"line_number":111,"context_line":"{{- end }}"},{"line_number":112,"context_line":"{{- if .Values.manifests.daemonset_dhcp_agent }}"},{"line_number":113,"context_line":"  dhcp_agent.ini: |+"},{"line_number":114,"context_line":"{{ if .Values.conf.dhcp_agent.override -}}"},{"line_number":115,"context_line":"{{ .Values.conf.dhcp_agent.override | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f436f4f_69166458","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":48},"in_reply_to":"9f436f4f_e1e1522c","updated":"2017-08-21 11:05:27.000000000","message":"+1.","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"}],"neutron/templates/daemonset-ovs-db.yaml":[{"author":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"change_message_id":"78f338725c1b48cfeb42c9ea800d3f0ca153dde4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        - name: ovs-db"},{"line_number":42,"context_line":"          image: {{ .Values.images.openvswitch_db_server }}"},{"line_number":43,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":44,"context_line":"          {{- if .Values.network.ovs_db.enabled }}"},{"line_number":45,"context_line":"          lifecycle:"},{"line_number":46,"context_line":"            postStart:"},{"line_number":47,"context_line":"              exec:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f436f4f_4f8589ce","line":44,"updated":"2017-08-14 13:44:42.000000000","message":"We should wrap this entire file in the conditional","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"}],"neutron/templates/deployment-server.yaml":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e40ddb303d3bae5cbe99397e698efe2b1462703","unresolved":false,"context_lines":[{"line_number":80,"context_line":"              mountPath: /etc/neutron/policy.json"},{"line_number":81,"context_line":"              subPath: policy.json"},{"line_number":82,"context_line":"              readOnly: true"},{"line_number":83,"context_line":"            {{- if .Values.conf.ml2_conf_onos.enable }}"},{"line_number":84,"context_line":"            - name: neutron-etc"},{"line_number":85,"context_line":"              mountPath: /etc/neutron/plugins/ml2/ml2_conf_onos.ini"},{"line_number":86,"context_line":"              subPath: ml2_conf_onos.ini"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df3967d1_aea9a024","line":83,"range":{"start_line":83,"start_character":46,"end_line":83,"end_character":52},"updated":"2017-08-03 11:02:03.000000000","message":"It should be \u0027enabled\u0027.","commit_id":"8650ddb0fad60da95f8f28a09d0387706dbb361e"}],"neutron/templates/etc/plugins/_ml2_conf_onos.ini.tpl":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e40ddb303d3bae5cbe99397e698efe2b1462703","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Configuration options for ONOS ML2 Mechanism driver"},{"line_number":2,"context_line":"[onos]"},{"line_number":3,"context_line":"# (StrOpt) ONOS ReST interface URL. This is a mandatory field."},{"line_number":4,"context_line":"url_path \u003d http://onos-sona:8181/onos/openstacknetworking"},{"line_number":5,"context_line":"# (StrOpt) Username for authentication. This is a mandatory field."},{"line_number":6,"context_line":"username \u003d onos"},{"line_number":7,"context_line":"# (StrOpt) Password for authentication. This is a mandatory field."}],"source_content_type":"text/x-smarty","patch_set":8,"id":"df3967d1_2e449073","line":4,"updated":"2017-08-03 11:02:03.000000000","message":"Should this be configurable in Values.yaml?","commit_id":"8650ddb0fad60da95f8f28a09d0387706dbb361e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e40ddb303d3bae5cbe99397e698efe2b1462703","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# (StrOpt) ONOS ReST interface URL. This is a mandatory field."},{"line_number":4,"context_line":"url_path \u003d http://onos-sona:8181/onos/openstacknetworking"},{"line_number":5,"context_line":"# (StrOpt) Username for authentication. This is a mandatory field."},{"line_number":6,"context_line":"username \u003d onos"},{"line_number":7,"context_line":"# (StrOpt) Password for authentication. This is a mandatory field."},{"line_number":8,"context_line":"password \u003d rocks"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"df3967d1_ee61e806","line":6,"updated":"2017-08-03 11:02:03.000000000","message":"Ditto.","commit_id":"8650ddb0fad60da95f8f28a09d0387706dbb361e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e40ddb303d3bae5cbe99397e698efe2b1462703","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# (StrOpt) Username for authentication. This is a mandatory field."},{"line_number":6,"context_line":"username \u003d onos"},{"line_number":7,"context_line":"# (StrOpt) Password for authentication. This is a mandatory field."},{"line_number":8,"context_line":"password \u003d rocks"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"df3967d1_ce5e2443","line":8,"updated":"2017-08-03 11:02:03.000000000","message":"Ditto.","commit_id":"8650ddb0fad60da95f8f28a09d0387706dbb361e"}],"neutron/values.yaml":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6b5c43460194e4746753b65dbc0f1970965f888d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is a YAML-formatted file."},{"line_number":17,"context_line":"# Declare name/value pairs to be passed into your templates."},{"line_number":18,"context_line":"# name: value"},{"line_number":19,"context_line":"release_group: null"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"images:"},{"line_number":22,"context_line":"  bootstrap: docker.io/kolla/ubuntu-source-neutron-server:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_46f66765","line":19,"updated":"2017-07-28 09:26:42.000000000","message":"Any explanation why introducing this key?","commit_id":"bf7df17290f7bb16861f8c67da5ba5bda71f45ee"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"bc39dc526b1a566d7858e91970cb9b09d8aacc7c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is a YAML-formatted file."},{"line_number":17,"context_line":"# Declare name/value pairs to be passed into your templates."},{"line_number":18,"context_line":"# name: value"},{"line_number":19,"context_line":"release_group: null"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"images:"},{"line_number":22,"context_line":"  bootstrap: docker.io/kolla/ubuntu-source-neutron-server:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_bcb083de","line":19,"in_reply_to":"ff346bd7_46f66765","updated":"2017-07-28 12:55:31.000000000","message":"It is required to allow the service(s) to target the appropriate pod - as when the chart is released as several manifests the default behavior in os-h of using the helm release name will break this connection.","commit_id":"bf7df17290f7bb16861f8c67da5ba5bda71f45ee"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"83b356a060f89982ce1de6db14150a44d028efcc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is a YAML-formatted file."},{"line_number":17,"context_line":"# Declare name/value pairs to be passed into your templates."},{"line_number":18,"context_line":"# name: value"},{"line_number":19,"context_line":"release_group: null"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"images:"},{"line_number":22,"context_line":"  bootstrap: docker.io/kolla/ubuntu-source-neutron-server:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_b7553cfc","line":19,"in_reply_to":"ff346bd7_bcb083de","updated":"2017-07-28 13:11:07.000000000","message":"What do you mean by \"when the chart is released as several manifests\" ?\nI still do not follow the use-case here...","commit_id":"bf7df17290f7bb16861f8c67da5ba5bda71f45ee"},{"author":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"change_message_id":"78f338725c1b48cfeb42c9ea800d3f0ca153dde4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is a YAML-formatted file."},{"line_number":17,"context_line":"# Declare name/value pairs to be passed into your templates."},{"line_number":18,"context_line":"# name: value"},{"line_number":19,"context_line":"release_group: null"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"release_group: null"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f436f4f_8f68111d","line":19,"updated":"2017-08-14 13:44:42.000000000","message":"Duplicate line","commit_id":"38bf0de6b63ddf8a5b52c3ec10d10201387dff11"}]}