)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e312a4b5deda818d391d30d4733a7cc9fb4a4bb5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Armada OpenStack deployment yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Armada is a tool for managing multiple helm charts with dependencies by"},{"line_number":10,"context_line":"centralizing all configurations in a single Armada yaml. This yaml is used for"},{"line_number":11,"context_line":"a full OpenStack deployment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70b41f038c2819aeaa4b2c7bb617b7b2c38441d1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_86a7530c","line":10,"range":{"start_line":10,"start_character":70,"end_line":10,"end_character":78},"updated":"2017-07-11 04:08:27.000000000","message":"could you move this to the next line.","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"}],"tools/deployment/armada/openstack-master.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bb6aba323b649e9060f047d750f94d96b733751b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"          values: {}"},{"line_number":12,"context_line":"          source:"},{"line_number":13,"context_line":"            type: git"},{"line_number":14,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"},{"line_number":15,"context_line":"            subpath: helm-toolkit"},{"line_number":16,"context_line":"            reference: master"},{"line_number":17,"context_line":"          dependencies: []"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_48b62f8d","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":70},"updated":"2017-07-07 14:18:56.000000000","message":"The file rename has caused the diff to remove Pete\u0027s previous comment in gerrit, but this still need to be updated.  Re-pasting here.\n\nPete Birley\nJul 6 4:08 PM\ncan you change all of these to point to openstack-infra git, not the github mirror","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"0e9239a7c03a9ac54aff83448b05f0c31c20b245","unresolved":false,"context_lines":[{"line_number":11,"context_line":"          values: {}"},{"line_number":12,"context_line":"          source:"},{"line_number":13,"context_line":"            type: git"},{"line_number":14,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"},{"line_number":15,"context_line":"            subpath: helm-toolkit"},{"line_number":16,"context_line":"            reference: master"},{"line_number":17,"context_line":"          dependencies: []"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_68344bfc","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":70},"in_reply_to":"3f1d235d_48b62f8d","updated":"2017-07-07 14:36:47.000000000","message":"Done","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"0e9239a7c03a9ac54aff83448b05f0c31c20b245","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          name: ceph"},{"line_number":20,"context_line":"          release_name: ceph"},{"line_number":21,"context_line":"          namespace: ceph"},{"line_number":22,"context_line":"          timeout: 3360"},{"line_number":23,"context_line":"          install:"},{"line_number":24,"context_line":"            no_hooks: False"},{"line_number":25,"context_line":"          upgrade:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_437cd071","line":22,"range":{"start_line":22,"start_character":10,"end_line":22,"end_character":23},"updated":"2017-07-07 14:36:47.000000000","message":"Pete\u0027s original comment: why timeouts so long?","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"0e9239a7c03a9ac54aff83448b05f0c31c20b245","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          values:"},{"line_number":50,"context_line":"            ceph:"},{"line_number":51,"context_line":"              namespace: ceph"},{"line_number":52,"context_line":"            manifests_enabled:"},{"line_number":53,"context_line":"              deployment: False"},{"line_number":54,"context_line":"              client_secrets: True"},{"line_number":55,"context_line":"            network:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_63ec6c29","line":52,"updated":"2017-07-07 14:36:47.000000000","message":"Pete\u0027s original comment: what about storage_secrets?","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"0e9239a7c03a9ac54aff83448b05f0c31c20b245","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            reference: master"},{"line_number":63,"context_line":"          dependencies:"},{"line_number":64,"context_line":"            - *helm-toolkit"},{"line_number":65,"context_line":"    - description: Deploys Helm Toolkit and Mariadb"},{"line_number":66,"context_line":"      sequenced: True"},{"line_number":67,"context_line":"      chart_group:"},{"line_number":68,"context_line":"      - chart: \u0026mariadb"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_03db787d","line":65,"range":{"start_line":65,"start_character":19,"end_line":65,"end_character":51},"updated":"2017-07-07 14:36:47.000000000","message":"Pete\u0027s original comment: Is helm toolkit deployed?","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e312a4b5deda818d391d30d4733a7cc9fb4a4bb5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"          upgrade:"},{"line_number":168,"context_line":"            no_hooks: False"},{"line_number":169,"context_line":"            pre:"},{"line_number":170,"context_line":"            delete:"},{"line_number":171,"context_line":"            - name: keystone-db-sync"},{"line_number":172,"context_line":"              type: job"},{"line_number":173,"context_line":"            - name: keystone-db-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_c64f8b68","line":170,"range":{"start_line":170,"start_character":12,"end_line":170,"end_character":19},"updated":"2017-07-11 04:08:27.000000000","message":"does this key need to be indented?\n\nAs Keystone is the only service with this would it make sense to remove the upgrade lifecycle management for now - and add in a later ps.","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bb6aba323b649e9060f047d750f94d96b733751b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            no_hooks: False"},{"line_number":169,"context_line":"            pre:"},{"line_number":170,"context_line":"            delete:"},{"line_number":171,"context_line":"            - name: keystone-db-sync"},{"line_number":172,"context_line":"              type: job"},{"line_number":173,"context_line":"            - name: keystone-db-init"},{"line_number":174,"context_line":"              type: job"},{"line_number":175,"context_line":"          values: {}"},{"line_number":176,"context_line":"          source:"},{"line_number":177,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_08d957f3","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":23},"updated":"2017-07-07 14:18:56.000000000","message":"Do these run in order?  if so, you would need the init before sync.","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"4c358a6871712a8edfa8bdb9d90656f411828f6e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            no_hooks: False"},{"line_number":169,"context_line":"            pre:"},{"line_number":170,"context_line":"            delete:"},{"line_number":171,"context_line":"            - name: keystone-db-sync"},{"line_number":172,"context_line":"              type: job"},{"line_number":173,"context_line":"            - name: keystone-db-init"},{"line_number":174,"context_line":"              type: job"},{"line_number":175,"context_line":"          values: {}"},{"line_number":176,"context_line":"          source:"},{"line_number":177,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_ce4da7c5","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":23},"in_reply_to":"3f1d235d_08d957f3","updated":"2017-07-07 15:14:04.000000000","message":"They should delete in order but I cannot see why the deletion order would matter for the jobs themselves.  The happy path presumes these completed.  If an upgrade is performed immediately after an installation, the jobs (by way of pods spawned) could still be running.  Note this removes the jobs only (the intent), but if they spawned pods, those are left behind until they end.\n\nThere is an outstanding request to support cleaning up the resulting pods as well by supporting a search-by-labels (or any other approach that makes sense) as the scenario I described above can result in duplicate job-pods.","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b1c4231bc2f0251fe602db48f1682607185216ac","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            no_hooks: False"},{"line_number":169,"context_line":"            pre:"},{"line_number":170,"context_line":"            delete:"},{"line_number":171,"context_line":"            - name: keystone-db-sync"},{"line_number":172,"context_line":"              type: job"},{"line_number":173,"context_line":"            - name: keystone-db-init"},{"line_number":174,"context_line":"              type: job"},{"line_number":175,"context_line":"          values: {}"},{"line_number":176,"context_line":"          source:"},{"line_number":177,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_29a2d54c","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":23},"in_reply_to":"3f1d235d_ce4da7c5","updated":"2017-07-07 15:51:02.000000000","message":"+1 to search by labels, it\u0027s the only sane approach long term.","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"0e9239a7c03a9ac54aff83448b05f0c31c20b245","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            no_hooks: False"},{"line_number":227,"context_line":"          upgrade:"},{"line_number":228,"context_line":"            no_hooks: False"},{"line_number":229,"context_line":"          values:"},{"line_number":230,"context_line":"            replicas:"},{"line_number":231,"context_line":"              server: 2"},{"line_number":232,"context_line":"          source:"},{"line_number":233,"context_line":"            type: git"},{"line_number":234,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_63d58c43","line":231,"range":{"start_line":229,"start_character":10,"end_line":231,"end_character":23},"updated":"2017-07-07 14:36:47.000000000","message":"Pete\u0027s original comment: could you add the mvp values here - so we have a working deployment in the gate","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"a688e299d7099221267d9c424fac39eef1ba1c05","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            no_hooks: False"},{"line_number":227,"context_line":"          upgrade:"},{"line_number":228,"context_line":"            no_hooks: False"},{"line_number":229,"context_line":"          values:"},{"line_number":230,"context_line":"            replicas:"},{"line_number":231,"context_line":"              server: 2"},{"line_number":232,"context_line":"          source:"},{"line_number":233,"context_line":"            type: git"},{"line_number":234,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_630530c2","line":231,"range":{"start_line":229,"start_character":10,"end_line":231,"end_character":23},"in_reply_to":"3f1d235d_63d58c43","updated":"2017-07-11 16:16:05.000000000","message":"Done","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"0e9239a7c03a9ac54aff83448b05f0c31c20b245","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            no_hooks: False"},{"line_number":246,"context_line":"          upgrade:"},{"line_number":247,"context_line":"            no_hooks: False"},{"line_number":248,"context_line":"          values:"},{"line_number":249,"context_line":"            control_replicas: 2"},{"line_number":250,"context_line":"          source:"},{"line_number":251,"context_line":"            type: git"},{"line_number":252,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_43ca90a1","line":249,"range":{"start_line":248,"start_character":10,"end_line":249,"end_character":31},"updated":"2017-07-07 14:36:47.000000000","message":"Pete\u0027s original comment: could you add the mvp values here - so we have a working deployment in the gate","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"5c38fb28c6650c5e1bf6d4ef50355ce71b5eaeae","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            no_hooks: False"},{"line_number":246,"context_line":"          upgrade:"},{"line_number":247,"context_line":"            no_hooks: False"},{"line_number":248,"context_line":"          values:"},{"line_number":249,"context_line":"            control_replicas: 2"},{"line_number":250,"context_line":"          source:"},{"line_number":251,"context_line":"            type: git"},{"line_number":252,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_7a6274af","line":249,"range":{"start_line":248,"start_character":10,"end_line":249,"end_character":31},"in_reply_to":"3f1d235d_43ca90a1","updated":"2017-07-11 15:07:57.000000000","message":"i don\u0027t think this is a valid value anymore, must have been missed in the docs overhaul","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"a688e299d7099221267d9c424fac39eef1ba1c05","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            no_hooks: False"},{"line_number":246,"context_line":"          upgrade:"},{"line_number":247,"context_line":"            no_hooks: False"},{"line_number":248,"context_line":"          values:"},{"line_number":249,"context_line":"            control_replicas: 2"},{"line_number":250,"context_line":"          source:"},{"line_number":251,"context_line":"            type: git"},{"line_number":252,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_23ddf841","line":249,"range":{"start_line":248,"start_character":10,"end_line":249,"end_character":31},"in_reply_to":"3f1d235d_7a6274af","updated":"2017-07-11 16:16:05.000000000","message":"gotcha I\u0027ll remove it. for the record, I pulled it from the OSH multinode install doc so it should probably be removed from there as well.","commit_id":"5928e256ee82a6e8dd68a2e5816f04498fc4a79b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"          upgrade:"},{"line_number":130,"context_line":"            no_hooks: False"},{"line_number":131,"context_line":"          values:"},{"line_number":132,"context_line":"            replicas: 1"},{"line_number":133,"context_line":"          source:"},{"line_number":134,"context_line":"            type: git"},{"line_number":135,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_b507f61c","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":23},"updated":"2017-07-11 19:40:15.000000000","message":"remove","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            no_hooks: False"},{"line_number":167,"context_line":"          upgrade:"},{"line_number":168,"context_line":"            no_hooks: False"},{"line_number":169,"context_line":"            pre:"},{"line_number":170,"context_line":"              delete:"},{"line_number":171,"context_line":"              - name: keystone-db-sync"},{"line_number":172,"context_line":"                type: job"},{"line_number":173,"context_line":"              - name: keystone-db-init"},{"line_number":174,"context_line":"                type: job"},{"line_number":175,"context_line":"          values: {}"},{"line_number":176,"context_line":"          source:"},{"line_number":177,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_551d4271","line":174,"range":{"start_line":169,"start_character":0,"end_line":174,"end_character":25},"updated":"2017-07-11 19:40:15.000000000","message":"can you remove for now","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            no_hooks: False"},{"line_number":207,"context_line":"          upgrade:"},{"line_number":208,"context_line":"            no_hooks: False"},{"line_number":209,"context_line":"          values:"},{"line_number":210,"context_line":"            replicas:"},{"line_number":211,"context_line":"              api: 2"},{"line_number":212,"context_line":"              registry: 2"},{"line_number":213,"context_line":"            storage: pvc"},{"line_number":214,"context_line":"            conf:"},{"line_number":215,"context_line":"              glance:"},{"line_number":216,"context_line":"                default:"},{"line_number":217,"context_line":"                  oslo:"},{"line_number":218,"context_line":"                    log:"},{"line_number":219,"context_line":"                      debug: false"},{"line_number":220,"context_line":"                glance_store:"},{"line_number":221,"context_line":"                  glance:"},{"line_number":222,"context_line":"                    store:"},{"line_number":223,"context_line":"                      stores: file, http"},{"line_number":224,"context_line":"                      default_store: file"},{"line_number":225,"context_line":"                      filesystem_store_datadir: /var/lib/glance/images"},{"line_number":226,"context_line":"          source:"},{"line_number":227,"context_line":"            type: git"},{"line_number":228,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_3546467e","line":225,"range":{"start_line":209,"start_character":0,"end_line":225,"end_character":70},"updated":"2017-07-11 19:40:15.000000000","message":"this can go","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":240,"context_line":"          upgrade:"},{"line_number":241,"context_line":"            no_hooks: False"},{"line_number":242,"context_line":"          values:"},{"line_number":243,"context_line":"            replicas:"},{"line_number":244,"context_line":"              server: 2"},{"line_number":245,"context_line":"            network:"},{"line_number":246,"context_line":"              interface:"},{"line_number":247,"context_line":"                tunnel: docker0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_f55fae3e","line":244,"range":{"start_line":243,"start_character":0,"end_line":244,"end_character":23},"updated":"2017-07-11 19:40:15.000000000","message":"remove","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            no_hooks: False"},{"line_number":295,"context_line":"          upgrade:"},{"line_number":296,"context_line":"            no_hooks: False"},{"line_number":297,"context_line":"          values:"},{"line_number":298,"context_line":"            control_replicas: 2"},{"line_number":299,"context_line":"            ceph:"},{"line_number":300,"context_line":"              enabled: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_153eaad9","line":297,"updated":"2017-07-11 19:40:15.000000000","message":"can you add this: https://github.com/openstack/openstack-helm/blob/master/tools/gate/basic_launch.sh#L83","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":17592,"name":"Alexis Rivera","email":"gardlt@tetrasol.org","username":"gariveradlt"},"change_message_id":"54bf1097086559f1982891394e1621aedafc3303","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            no_hooks: False"},{"line_number":295,"context_line":"          upgrade:"},{"line_number":296,"context_line":"            no_hooks: False"},{"line_number":297,"context_line":"          values:"},{"line_number":298,"context_line":"            control_replicas: 2"},{"line_number":299,"context_line":"            ceph:"},{"line_number":300,"context_line":"              enabled: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_caf9b080","line":297,"in_reply_to":"3f1d235d_153eaad9","updated":"2017-07-11 20:28:22.000000000","message":"that line is exist below. in L310 if what is the diff?","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"28600696b17333d94ea4507551c4f3501dac6fea","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            no_hooks: False"},{"line_number":295,"context_line":"          upgrade:"},{"line_number":296,"context_line":"            no_hooks: False"},{"line_number":297,"context_line":"          values:"},{"line_number":298,"context_line":"            control_replicas: 2"},{"line_number":299,"context_line":"            ceph:"},{"line_number":300,"context_line":"              enabled: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_5bdd7012","line":297,"in_reply_to":"3f1d235d_caf9b080","updated":"2017-07-11 22:08:54.000000000","message":"whoops sorry I missed it - cheers alex.","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":295,"context_line":"          upgrade:"},{"line_number":296,"context_line":"            no_hooks: False"},{"line_number":297,"context_line":"          values:"},{"line_number":298,"context_line":"            control_replicas: 2"},{"line_number":299,"context_line":"            ceph:"},{"line_number":300,"context_line":"              enabled: false"},{"line_number":301,"context_line":"            conf:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_75315e0b","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":31},"updated":"2017-07-11 19:40:15.000000000","message":"remove","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"18578c774ad6799a210ac26fd36c98a050adb39f","unresolved":false,"context_lines":[{"line_number":336,"context_line":"          upgrade:"},{"line_number":337,"context_line":"            no_hooks: False"},{"line_number":338,"context_line":"          values:"},{"line_number":339,"context_line":"            replicas:"},{"line_number":340,"context_line":"              api: 2"},{"line_number":341,"context_line":"            storage: \"gate\""},{"line_number":342,"context_line":"            conf:"},{"line_number":343,"context_line":"              cinder:"},{"line_number":344,"context_line":"                default:"},{"line_number":345,"context_line":"                  oslo:"},{"line_number":346,"context_line":"                    log:"},{"line_number":347,"context_line":"                      debug: false"},{"line_number":348,"context_line":"                  cinder:"},{"line_number":349,"context_line":"                    backup_driver: \"cinder.backup.drivers.nfs\""},{"line_number":350,"context_line":"              backends:"},{"line_number":351,"context_line":"                rbd1:"},{"line_number":352,"context_line":"                  volume_driver: \"cinder.volume.drivers.nfs.NfsDriver\""},{"line_number":353,"context_line":"          source:"},{"line_number":354,"context_line":"            type: git"},{"line_number":355,"context_line":"            location: git://git.openstack.org/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_95299a9c","line":352,"range":{"start_line":339,"start_character":0,"end_line":352,"end_character":70},"updated":"2017-07-11 19:40:15.000000000","message":"remove","commit_id":"8e64fc7ec4098af35e0f8135c456e3cdc3bddd87"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d606f61df37a7f9d0a12f4e6cd420f6984bf3aee","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  name: helm-toolkit"},{"line_number":6,"context_line":"data:"},{"line_number":7,"context_line":"  chart_name: helm-toolkit"},{"line_number":8,"context_line":"  release: helm-toolkit"},{"line_number":9,"context_line":"  namespace: helm-toolkit"},{"line_number":10,"context_line":"  values: {}"},{"line_number":11,"context_line":"  source:"},{"line_number":12,"context_line":"    type: git"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_c55b1185","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":25},"updated":"2017-07-31 15:08:50.000000000","message":"is this getting released to the cluster? These values are confusing.","commit_id":"7f9e19a5adcc438ab0c6213cc8eaa09d94915dd9"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"122ea80da5e951464e90505bfd319587caf0abf0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  name: helm-toolkit"},{"line_number":6,"context_line":"data:"},{"line_number":7,"context_line":"  chart_name: helm-toolkit"},{"line_number":8,"context_line":"  release: helm-toolkit"},{"line_number":9,"context_line":"  namespace: helm-toolkit"},{"line_number":10,"context_line":"  values: {}"},{"line_number":11,"context_line":"  source:"},{"line_number":12,"context_line":"    type: git"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_21e76ce7","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":25},"in_reply_to":"df3967d1_c55b1185","updated":"2017-07-31 17:57:25.000000000","message":"it\u0027s not being deployed. see the response to Alan\u0027s comment in revision 11","commit_id":"7f9e19a5adcc438ab0c6213cc8eaa09d94915dd9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d606f61df37a7f9d0a12f4e6cd420f6984bf3aee","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  schema: metadata/Document/v1"},{"line_number":172,"context_line":"  name: ingress"},{"line_number":173,"context_line":"data:"},{"line_number":174,"context_line":"  chart_name: ingress "},{"line_number":175,"context_line":"  release: ingress "},{"line_number":176,"context_line":"  namespace: openstack"},{"line_number":177,"context_line":"  timeout: 100"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_e5cbb51b","line":174,"range":{"start_line":174,"start_character":21,"end_line":174,"end_character":22},"updated":"2017-07-31 15:08:50.000000000","message":"can you remove all ws from this.","commit_id":"7f9e19a5adcc438ab0c6213cc8eaa09d94915dd9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8fb4834fa7b73f7c33a5f77f136a6296e7026a16","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    no_hooks: false"},{"line_number":204,"context_line":"    pre:"},{"line_number":205,"context_line":"      delete:"},{"line_number":206,"context_line":"        - name: keystone-db-sync"},{"line_number":207,"context_line":"          type: job"},{"line_number":208,"context_line":"        - name: keystone-db-init"},{"line_number":209,"context_line":"          type: job"},{"line_number":210,"context_line":"  values: {}"},{"line_number":211,"context_line":"  source:"},{"line_number":212,"context_line":"    type: git"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df3967d1_858869c6","line":209,"range":{"start_line":206,"start_character":0,"end_line":209,"end_character":19},"updated":"2017-07-31 15:10:44.000000000","message":"can you target these by the job\u0027s labels - and roll out for all services.","commit_id":"e446efe2bb07c5546d50c6591014d1bdd76b89a0"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"14ffaf973492efa0a6564aab46b3b228f4c90b27","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    no_hooks: false"},{"line_number":204,"context_line":"    pre:"},{"line_number":205,"context_line":"      delete:"},{"line_number":206,"context_line":"        - name: keystone-db-sync"},{"line_number":207,"context_line":"          type: job"},{"line_number":208,"context_line":"        - name: keystone-db-init"},{"line_number":209,"context_line":"          type: job"},{"line_number":210,"context_line":"  values: {}"},{"line_number":211,"context_line":"  source:"},{"line_number":212,"context_line":"    type: git"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df3967d1_41a6f0c3","line":209,"range":{"start_line":206,"start_character":0,"end_line":209,"end_character":19},"in_reply_to":"df3967d1_858869c6","updated":"2017-07-31 17:57:17.000000000","message":"you can. I will update this with an example to reflect that.","commit_id":"e446efe2bb07c5546d50c6591014d1bdd76b89a0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"dbabf22497669b9623200f2658034897695a5c8a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    no_hooks: false"},{"line_number":274,"context_line":"  upgrade:"},{"line_number":275,"context_line":"    no_hooks: false"},{"line_number":276,"context_line":"    pre:"},{"line_number":277,"context_line":"      update:"},{"line_number":278,"context_line":"        - name: neautron-l3-agent"},{"line_number":279,"context_line":"          type: daemonset"},{"line_number":280,"context_line":"          labels:"},{"line_number":281,"context_line":"            - component: l3-agent"},{"line_number":282,"context_line":"            - application: neutron"},{"line_number":283,"context_line":"  values:"},{"line_number":284,"context_line":"    network:"},{"line_number":285,"context_line":"      interface:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df3967d1_404a6f55","line":282,"range":{"start_line":276,"start_character":0,"end_line":282,"end_character":34},"updated":"2017-07-31 15:18:49.000000000","message":"could you explain this more? is it documented? theres also a typo in the name.","commit_id":"e446efe2bb07c5546d50c6591014d1bdd76b89a0"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"14ffaf973492efa0a6564aab46b3b228f4c90b27","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    no_hooks: false"},{"line_number":274,"context_line":"  upgrade:"},{"line_number":275,"context_line":"    no_hooks: false"},{"line_number":276,"context_line":"    pre:"},{"line_number":277,"context_line":"      update:"},{"line_number":278,"context_line":"        - name: neautron-l3-agent"},{"line_number":279,"context_line":"          type: daemonset"},{"line_number":280,"context_line":"          labels:"},{"line_number":281,"context_line":"            - component: l3-agent"},{"line_number":282,"context_line":"            - application: neutron"},{"line_number":283,"context_line":"  values:"},{"line_number":284,"context_line":"    network:"},{"line_number":285,"context_line":"      interface:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df3967d1_a1c91c79","line":282,"range":{"start_line":276,"start_character":0,"end_line":282,"end_character":34},"in_reply_to":"df3967d1_404a6f55","updated":"2017-07-31 17:57:17.000000000","message":"this is documented in the daemonset upgrade github PR but basically it will delete the daemonset containing this name and labels and will then redeploy. typo is my bad.","commit_id":"e446efe2bb07c5546d50c6591014d1bdd76b89a0"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"a20263993cc3270758d4e23dbcca6dfe83fefedd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  name: helm-toolkit"},{"line_number":6,"context_line":"data:"},{"line_number":7,"context_line":"  chart_name: helm-toolkit"},{"line_number":8,"context_line":"  release: helm-toolkit"},{"line_number":9,"context_line":"  namespace: helm-toolkit"},{"line_number":10,"context_line":"  timeout: 100"},{"line_number":11,"context_line":"  values: {}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df3967d1_9ec5573f","line":8,"updated":"2017-07-31 17:17:27.000000000","message":"Line 8 and Line 9 used to be \"null\" signifying that this chart was not actually to be released - it was defined only to be used as a dependency by other charts.  This appears to have been lost in this transformation.  The dependency section would rely on this definition in the form of a YAML anchor to repeat this declaration for each chart.  Now I presume dependencies below can point to Chart documents like this one by name: however it still does not need to be installed as an actual helm release, just placed as a dependency when the tiller chart object inside armada is constructed.","commit_id":"253aec9ebbb7e520b5bcacc862b740edccd5bf6e"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"8b2e5976c5c2d21535cd8762804ed79d1cda20fa","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  name: helm-toolkit"},{"line_number":6,"context_line":"data:"},{"line_number":7,"context_line":"  chart_name: helm-toolkit"},{"line_number":8,"context_line":"  release: helm-toolkit"},{"line_number":9,"context_line":"  namespace: helm-toolkit"},{"line_number":10,"context_line":"  timeout: 100"},{"line_number":11,"context_line":"  values: {}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df3967d1_81c29832","line":8,"in_reply_to":"df3967d1_9ec5573f","updated":"2017-07-31 17:57:10.000000000","message":"You are correct, the other charts do point to this one as a dependency but it is not being deployed. We added the release and namespace values because Armada currently won\u0027t validate a manifest with them as null. I believe @gardlt has plans to iterate on this and create a separate chart type specifically for dependencies.","commit_id":"253aec9ebbb7e520b5bcacc862b740edccd5bf6e"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"83bff3a0b03a9425c5677f624007082374615e70","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      enabled: True"},{"line_number":37,"context_line":"    network:"},{"line_number":38,"context_line":"      public: 10.0.2.15/24"},{"line_number":39,"context_line":"      cluster: 10.0.2.15/24"},{"line_number":40,"context_line":"    conf:"},{"line_number":41,"context_line":"      ceph:"},{"line_number":42,"context_line":"        config:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df3967d1_cfe68717","line":39,"updated":"2017-07-31 19:05:14.000000000","message":"these IPs will need to be the VM cluster IP. we recommend using an environmental variable here but it can be input manually on a case-by-case basis.","commit_id":"a6bc1d50e7f1aeb7435f00206fddd46b70c3d426"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"695ebbeb9c90ba1f8f2ad6a7ccc34eb3fa9df584","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      enabled: True"},{"line_number":37,"context_line":"    network:"},{"line_number":38,"context_line":"      public: 10.0.2.15/24"},{"line_number":39,"context_line":"      cluster: 10.0.2.15/24"},{"line_number":40,"context_line":"    conf:"},{"line_number":41,"context_line":"      ceph:"},{"line_number":42,"context_line":"        config:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df3967d1_d06ce837","line":39,"in_reply_to":"df3967d1_cfe68717","updated":"2017-07-31 20:32:20.000000000","message":"these should be the subnet that ceph will use for clustering.","commit_id":"a6bc1d50e7f1aeb7435f00206fddd46b70c3d426"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"695ebbeb9c90ba1f8f2ad6a7ccc34eb3fa9df584","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  schema: metadata/Document/v1"},{"line_number":176,"context_line":"  name: ingress"},{"line_number":177,"context_line":"data:"},{"line_number":178,"context_line":"  chart_name: ingress "},{"line_number":179,"context_line":"  release: ingress "},{"line_number":180,"context_line":"  namespace: openstack"},{"line_number":181,"context_line":"  timeout: 100"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df3967d1_b0528466","line":178,"range":{"start_line":178,"start_character":21,"end_line":178,"end_character":22},"updated":"2017-07-31 20:32:20.000000000","message":"can you also remove all the ws.","commit_id":"a6bc1d50e7f1aeb7435f00206fddd46b70c3d426"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"eb2488c616ec1cf6145ee592f7bf93e193143300","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    bootstrap:"},{"line_number":36,"context_line":"      enabled: True"},{"line_number":37,"context_line":"    network:"},{"line_number":38,"context_line":"      public: 10.0.2.15/24"},{"line_number":39,"context_line":"      cluster: 10.0.2.15/24"},{"line_number":40,"context_line":"    conf:"},{"line_number":41,"context_line":"      ceph:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df3967d1_97451e46","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":26},"updated":"2017-08-01 13:39:32.000000000","message":"could you change this to the calico default of 192.168.0.0/16 along with all other ceph cidrs in this file.","commit_id":"c065f40d61ab32abdeba1209926c66db98e71733"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"d742544bda0e40b3f5ce46a25df5b3e617d31fab","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    bootstrap:"},{"line_number":36,"context_line":"      enabled: True"},{"line_number":37,"context_line":"    network:"},{"line_number":38,"context_line":"      public: 10.0.2.15/24"},{"line_number":39,"context_line":"      cluster: 10.0.2.15/24"},{"line_number":40,"context_line":"    conf:"},{"line_number":41,"context_line":"      ceph:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df3967d1_3a46577e","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":26},"in_reply_to":"df3967d1_97451e46","updated":"2017-08-01 14:43:16.000000000","message":"Done","commit_id":"c065f40d61ab32abdeba1209926c66db98e71733"}],"tools/deployment/armada/openstack.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1da59f14b2f1dcf4bd8baeb7b25460fed4a39a64","unresolved":false,"context_lines":[{"line_number":11,"context_line":"          values: {}"},{"line_number":12,"context_line":"          source:"},{"line_number":13,"context_line":"              type: git"},{"line_number":14,"context_line":"              location: git://github.com/openstack/openstack-helm"},{"line_number":15,"context_line":"              subpath: helm-toolkit"},{"line_number":16,"context_line":"              reference: master"},{"line_number":17,"context_line":"          dependencies: []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_977b5f8a","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":65},"updated":"2017-07-06 21:08:21.000000000","message":"can you change all of these to point to openstack-infra git, not the github mirror","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":11,"context_line":"          values: {}"},{"line_number":12,"context_line":"          source:"},{"line_number":13,"context_line":"              type: git"},{"line_number":14,"context_line":"              location: git://github.com/openstack/openstack-helm"},{"line_number":15,"context_line":"              subpath: helm-toolkit"},{"line_number":16,"context_line":"              reference: master"},{"line_number":17,"context_line":"          dependencies: []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_5de02fcd","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":65},"in_reply_to":"3f1d235d_977b5f8a","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1da59f14b2f1dcf4bd8baeb7b25460fed4a39a64","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          name: ceph"},{"line_number":20,"context_line":"          release_name: ceph"},{"line_number":21,"context_line":"          namespace: ceph"},{"line_number":22,"context_line":"          timeout: 3360"},{"line_number":23,"context_line":"          install:"},{"line_number":24,"context_line":"            no_hooks: false"},{"line_number":25,"context_line":"          upgrade:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3715ab40","line":22,"range":{"start_line":22,"start_character":19,"end_line":22,"end_character":23},"updated":"2017-07-06 21:08:21.000000000","message":"why timeouts so long?","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            no_hooks: false"},{"line_number":27,"context_line":"          values:"},{"line_number":28,"context_line":"              manifests_enabled:"},{"line_number":29,"context_line":"                  client_secretes: false"},{"line_number":30,"context_line":"              network:"},{"line_number":31,"context_line":"                  public: 10.32.0.0/12"},{"line_number":32,"context_line":"                  cluster: 10.32.0.0/12"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_ba864265","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":33},"updated":"2017-07-06 21:33:26.000000000","message":"client_secrets","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            no_hooks: false"},{"line_number":27,"context_line":"          values:"},{"line_number":28,"context_line":"              manifests_enabled:"},{"line_number":29,"context_line":"                  client_secretes: false"},{"line_number":30,"context_line":"              network:"},{"line_number":31,"context_line":"                  public: 10.32.0.0/12"},{"line_number":32,"context_line":"                  cluster: 10.32.0.0/12"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_9dc0072d","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":33},"in_reply_to":"3f1d235d_ba864265","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"              manifests_enabled:"},{"line_number":29,"context_line":"                  client_secretes: false"},{"line_number":30,"context_line":"              network:"},{"line_number":31,"context_line":"                  public: 10.32.0.0/12"},{"line_number":32,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":33,"context_line":"          source:"},{"line_number":34,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_fab6fa3d","line":31,"range":{"start_line":31,"start_character":26,"end_line":31,"end_character":38},"updated":"2017-07-06 21:33:26.000000000","message":"192.168.0.0/16","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":28,"context_line":"              manifests_enabled:"},{"line_number":29,"context_line":"                  client_secretes: false"},{"line_number":30,"context_line":"              network:"},{"line_number":31,"context_line":"                  public: 10.32.0.0/12"},{"line_number":32,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":33,"context_line":"          source:"},{"line_number":34,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_bdc3c338","line":31,"range":{"start_line":31,"start_character":26,"end_line":31,"end_character":38},"in_reply_to":"3f1d235d_fab6fa3d","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                  client_secretes: false"},{"line_number":30,"context_line":"              network:"},{"line_number":31,"context_line":"                  public: 10.32.0.0/12"},{"line_number":32,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":33,"context_line":"          source:"},{"line_number":34,"context_line":"            type: git"},{"line_number":35,"context_line":"            location: git://github.com/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_1a953687","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":39},"updated":"2017-07-06 21:33:26.000000000","message":"192.168.0.0/16","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                  client_secretes: false"},{"line_number":30,"context_line":"              network:"},{"line_number":31,"context_line":"                  public: 10.32.0.0/12"},{"line_number":32,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":33,"context_line":"          source:"},{"line_number":34,"context_line":"            type: git"},{"line_number":35,"context_line":"            location: git://github.com/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_fdc93b5a","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":39},"in_reply_to":"3f1d235d_1a953687","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          values:"},{"line_number":50,"context_line":"              ceph:"},{"line_number":51,"context_line":"                  namespace: ceph"},{"line_number":52,"context_line":"              manifests_enabled:"},{"line_number":53,"context_line":"                  deployment: false"},{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3ac8f2a3","line":52,"updated":"2017-07-06 21:33:26.000000000","message":"what about storage_secrets?","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  namespace: ceph"},{"line_number":52,"context_line":"              manifests_enabled:"},{"line_number":53,"context_line":"                  deployment: false"},{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"},{"line_number":56,"context_line":"                  public: 10.32.0.0/12"},{"line_number":57,"context_line":"                  cluster: 10.32.0.0/12"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_9aa026f6","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":33},"updated":"2017-07-06 21:33:26.000000000","message":"client_secrets - also should this not be true?","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  namespace: ceph"},{"line_number":52,"context_line":"              manifests_enabled:"},{"line_number":53,"context_line":"                  deployment: false"},{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"},{"line_number":56,"context_line":"                  public: 10.32.0.0/12"},{"line_number":57,"context_line":"                  cluster: 10.32.0.0/12"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3db0d3dd","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":33},"in_reply_to":"3f1d235d_9aa026f6","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                  deployment: false"},{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"},{"line_number":56,"context_line":"                  public: 10.32.0.0/12"},{"line_number":57,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":58,"context_line":"          source:"},{"line_number":59,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3ab11248","line":56,"range":{"start_line":56,"start_character":26,"end_line":56,"end_character":38},"updated":"2017-07-06 21:33:26.000000000","message":"192.168.0.0/16","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                  deployment: false"},{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"},{"line_number":56,"context_line":"                  public: 10.32.0.0/12"},{"line_number":57,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":58,"context_line":"          source:"},{"line_number":59,"context_line":"            type: git"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_5dbb8fc3","line":56,"range":{"start_line":56,"start_character":26,"end_line":56,"end_character":38},"in_reply_to":"3f1d235d_3ab11248","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"30b8f475e29b9a9d02e4438847e64a44b36b5eb0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"},{"line_number":56,"context_line":"                  public: 10.32.0.0/12"},{"line_number":57,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":58,"context_line":"          source:"},{"line_number":59,"context_line":"            type: git"},{"line_number":60,"context_line":"            location: git://github.com/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_fa8f1a72","line":57,"range":{"start_line":57,"start_character":27,"end_line":57,"end_character":39},"updated":"2017-07-06 21:33:26.000000000","message":"192.168.0.0/16","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                  client_secretes: false"},{"line_number":55,"context_line":"              network:"},{"line_number":56,"context_line":"                  public: 10.32.0.0/12"},{"line_number":57,"context_line":"                  cluster: 10.32.0.0/12"},{"line_number":58,"context_line":"          source:"},{"line_number":59,"context_line":"            type: git"},{"line_number":60,"context_line":"            location: git://github.com/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_7db64bdf","line":57,"range":{"start_line":57,"start_character":27,"end_line":57,"end_character":39},"in_reply_to":"3f1d235d_fa8f1a72","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1da59f14b2f1dcf4bd8baeb7b25460fed4a39a64","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            reference: master"},{"line_number":63,"context_line":"          dependencies:"},{"line_number":64,"context_line":"            - *helm-toolkit"},{"line_number":65,"context_line":"    - description: Deploys Helm Toolkit and Mariadb"},{"line_number":66,"context_line":"      sequenced: True"},{"line_number":67,"context_line":"      chart_group:"},{"line_number":68,"context_line":"      - chart: \u0026mariadb"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_a512a860","line":65,"range":{"start_line":65,"start_character":19,"end_line":65,"end_character":51},"updated":"2017-07-06 21:08:21.000000000","message":"Is helm toolkit deployed?","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1da59f14b2f1dcf4bd8baeb7b25460fed4a39a64","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            reference: master"},{"line_number":83,"context_line":"          dependencies:"},{"line_number":84,"context_line":"            - *helm-toolkit"},{"line_number":85,"context_line":"    - description: Undercloud Services add-ons"},{"line_number":86,"context_line":"      sequenced: False"},{"line_number":87,"context_line":"      chart_group:"},{"line_number":88,"context_line":"      - chart: \u0026memcached"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_6527f0cb","line":85,"range":{"start_line":85,"start_character":19,"end_line":85,"end_character":46},"updated":"2017-07-06 21:08:21.000000000","message":"OpenStack-Helm Infra Services","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":26364,"name":"Tim Heyer","email":"theyer3@gmail.com","username":"theyer"},"change_message_id":"195fb533d5680a5672f7d72663b99d4be834d428","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            reference: master"},{"line_number":83,"context_line":"          dependencies:"},{"line_number":84,"context_line":"            - *helm-toolkit"},{"line_number":85,"context_line":"    - description: Undercloud Services add-ons"},{"line_number":86,"context_line":"      sequenced: False"},{"line_number":87,"context_line":"      chart_group:"},{"line_number":88,"context_line":"      - chart: \u0026memcached"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_fdcedb59","line":85,"range":{"start_line":85,"start_character":19,"end_line":85,"end_character":46},"in_reply_to":"3f1d235d_6527f0cb","updated":"2017-07-07 14:36:34.000000000","message":"Done","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1da59f14b2f1dcf4bd8baeb7b25460fed4a39a64","unresolved":false,"context_lines":[{"line_number":226,"context_line":"              no_hooks: false"},{"line_number":227,"context_line":"          upgrade:"},{"line_number":228,"context_line":"              no_hooks: false"},{"line_number":229,"context_line":"          values:"},{"line_number":230,"context_line":"              replicas:"},{"line_number":231,"context_line":"                  server: 2"},{"line_number":232,"context_line":"          source:"},{"line_number":233,"context_line":"            type: git"},{"line_number":234,"context_line":"            location: git://github.com/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_2558d853","line":231,"range":{"start_line":229,"start_character":10,"end_line":231,"end_character":27},"updated":"2017-07-06 21:08:21.000000000","message":"could you add the mvp values here - so we have a working deployment in the gate","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1da59f14b2f1dcf4bd8baeb7b25460fed4a39a64","unresolved":false,"context_lines":[{"line_number":245,"context_line":"              no_hooks: false"},{"line_number":246,"context_line":"          upgrade:"},{"line_number":247,"context_line":"              no_hooks: false"},{"line_number":248,"context_line":"          values:"},{"line_number":249,"context_line":"              control_replicas: 2"},{"line_number":250,"context_line":"          source:"},{"line_number":251,"context_line":"            type: git"},{"line_number":252,"context_line":"            location: git://github.com/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_c536c403","line":249,"range":{"start_line":248,"start_character":10,"end_line":249,"end_character":33},"updated":"2017-07-06 21:08:21.000000000","message":"could you add the mvp values here - so we have a working deployment in the gate","commit_id":"3d9ba7335ec74e652ff98d6431d08ae7ce49020d"}],"tools/gate/armada_launch.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7cfb646d993cd9b10c2b6ff672ed30d37198b159","unresolved":false,"context_lines":[{"line_number":71,"context_line":"MON_POD\u003d$(kubectl get pods -l application\u003dceph -l component\u003dmon -n ceph --no-headers | awk \u0027{ print $1; exit }\u0027)"},{"line_number":72,"context_line":"kubectl exec -n ceph ${MON_POD} -- ceph -s"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"if [ \"x$INTEGRATION\" \u003d\u003d \"xmulti\" ]; then"},{"line_number":75,"context_line":"  helm_test_deployment osh-keystone ${SERVICE_TEST_TIMEOUT}"},{"line_number":76,"context_line":"  helm_test_deployment osh-glance ${SERVICE_TEST_TIMEOUT}"},{"line_number":77,"context_line":"  helm_test_deployment osh-cinder ${SERVICE_TEST_TIMEOUT}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"9f436f4f_0cb25de7","line":74,"updated":"2017-08-09 14:42:47.000000000","message":"once armada supports helm test we will be able to remove this section.","commit_id":"47bb6d2a858089543f225ea7769415b30d2e3b2b"}]}