)]}'
{"tools/gate/funcs/common.sh":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c581d348620d78dbd4df66c6ec10e2887fc172d3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      iscsitarget-dkms \\"},{"line_number":40,"context_line":"      open-iscsi \\"},{"line_number":41,"context_line":"      lshw"},{"line_number":42,"context_line":"    sudo sed -i \"s|^node.startup \u003d manual|node.startup \u003d automatic|g\" /etc/iscsi/iscsid.conf"},{"line_number":43,"context_line":"    sudo systemctl restart iscsid"},{"line_number":44,"context_line":"    sudo sed -i \"s|^ISCSITARGET_ENABLE\u003dfalse|ISCSITARGET_ENABLE\u003dtrue|g\" /etc/default/iscsitarget"},{"line_number":45,"context_line":"    sudo systemctl restart iscsitarget"}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_9a190c8a","line":42,"updated":"2017-07-28 21:45:10.000000000","message":"why is this done?  node.start \u003d automatic means on on [re]boot the VM will try to contact the target which may or may not be up\n\nfor ubuntu it\u0027s not so we get a delay or worse a hang","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c581d348620d78dbd4df66c6ec10e2887fc172d3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  sudo targetcli iscsi/ create iqn.2016-01.com.example:target"},{"line_number":68,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/luns/ create /backstores/fileio/testfile"},{"line_number":69,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":70,"context_line":"  sudo iscsiadm --mode discovery --type sendtargets --portal $HOST_IP"},{"line_number":71,"context_line":"  sudo iscsiadm -m node -T iqn.2016-01.com.example:target -l"},{"line_number":72,"context_line":"  sudo iscsiadm -m session -P 0"},{"line_number":73,"context_line":"  sudo lshw -class disk"}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_5d215e9f","line":70,"updated":"2017-07-28 21:45:10.000000000","message":"on ubuntu a portal isn\u0027t created by default\n\npete; i take it for your env you do see that though?","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"809a34897d04b8bf551996b46881da7aa598ac9e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  sudo targetcli iscsi/ create iqn.2016-01.com.example:target"},{"line_number":68,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/luns/ create /backstores/fileio/testfile"},{"line_number":69,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":70,"context_line":"  sudo iscsiadm --mode discovery --type sendtargets --portal $HOST_IP"},{"line_number":71,"context_line":"  sudo iscsiadm -m node -T iqn.2016-01.com.example:target -l"},{"line_number":72,"context_line":"  sudo iscsiadm -m session -P 0"},{"line_number":73,"context_line":"  sudo lshw -class disk"}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_a5670826","line":70,"in_reply_to":"df3967d1_5d215e9f","updated":"2017-07-29 14:06:24.000000000","message":"yes - for centos/fedora it is.","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c581d348620d78dbd4df66c6ec10e2887fc172d3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":70,"context_line":"  sudo iscsiadm --mode discovery --type sendtargets --portal $HOST_IP"},{"line_number":71,"context_line":"  sudo iscsiadm -m node -T iqn.2016-01.com.example:target -l"},{"line_number":72,"context_line":"  sudo iscsiadm -m session -P 0"},{"line_number":73,"context_line":"  sudo lshw -class disk"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_3d5b3a2f","line":72,"updated":"2017-07-28 21:45:10.000000000","message":"debugging?","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"809a34897d04b8bf551996b46881da7aa598ac9e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":70,"context_line":"  sudo iscsiadm --mode discovery --type sendtargets --portal $HOST_IP"},{"line_number":71,"context_line":"  sudo iscsiadm -m node -T iqn.2016-01.com.example:target -l"},{"line_number":72,"context_line":"  sudo iscsiadm -m session -P 0"},{"line_number":73,"context_line":"  sudo lshw -class disk"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_e5a7504f","line":72,"in_reply_to":"df3967d1_3d5b3a2f","updated":"2017-07-29 14:06:24.000000000","message":"yup","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d5e416c5be79d1a0c2b8f9ac688c6ffc2ee2c062","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      open-iscsi \\"},{"line_number":42,"context_line":"      lshw"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # FIXME(cw) don\u0027t set node.startup to automatic; it means if the"},{"line_number":45,"context_line":"    # VM reboots things hang/delay; need to hear from pete/larry as to"},{"line_number":46,"context_line":"    # the need for this"},{"line_number":47,"context_line":"    #"},{"line_number":48,"context_line":"    #sudo sed -i \"s|^node.startup \u003d manual|node.startup \u003d automatic|g\" /etc/iscsi/iscsid.conf"},{"line_number":49,"context_line":"    sudo systemctl restart iscsid"},{"line_number":50,"context_line":"    sudo sed -i \"s|^ISCSITARGET_ENABLE\u003dfalse|ISCSITARGET_ENABLE\u003dtrue|g\" /etc/default/iscsitarget"},{"line_number":51,"context_line":"    sudo systemctl restart iscsitarget"}],"source_content_type":"text/x-sh","patch_set":8,"id":"df3967d1_257318ea","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":93},"updated":"2017-07-29 14:06:42.000000000","message":"I was stabbing in the dark here :) It can go.","commit_id":"cc39ddf4e889c55c60b27abd33eb3cd14459aad8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d5e416c5be79d1a0c2b8f9ac688c6ffc2ee2c062","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  sudo targetcli iscsi/ create iqn.2016-01.com.example:target"},{"line_number":74,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/luns/ create /backstores/fileio/testfile"},{"line_number":75,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":76,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1 set attribute authentication\u003d0"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  # FIXME(cw) why is this needed? without it portal creation"},{"line_number":79,"context_line":"  # fails... do this only for Ubuntu?"},{"line_number":80,"context_line":"  sudo systemctl stop iscsitarget"},{"line_number":81,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  sudo iscsiadm --mode discovery --type sendtargets --portal $HOST_IP"},{"line_number":84,"context_line":"  sudo iscsiadm -m node -T iqn.2016-01.com.example:target -l"}],"source_content_type":"text/x-sh","patch_set":8,"id":"df3967d1_0580148b","line":81,"range":{"start_line":76,"start_character":2,"end_line":81,"end_character":73},"updated":"2017-07-29 14:06:42.000000000","message":"We only need these for Ubuntu.","commit_id":"cc39ddf4e889c55c60b27abd33eb3cd14459aad8"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1f1fa386ce1d340c6736db788162eab0bdc4baad","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  fi"},{"line_number":68,"context_line":"  sudo targetcli iscsi/ create iqn.2016-01.com.example:target"},{"line_number":69,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/luns/ create /backstores/fileio/testfile"},{"line_number":70,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":73,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1 set attribute authentication\u003d0"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_33f92280","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":159},"updated":"2017-07-29 22:20:34.000000000","message":"maybe we can test without this?","commit_id":"ddb6b20397af6a39f3e640d3c0690e287e256f32"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1f1fa386ce1d340c6736db788162eab0bdc4baad","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":73,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1 set attribute authentication\u003d0"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(cw) why is this needed? without it portal creation"},{"line_number":76,"context_line":"    # fails..."}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_73ffaa67","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":9},"updated":"2017-07-29 22:20:34.000000000","message":"that should be safe on non-ubuntu as well\nwe probably don\u0027t need the acl","commit_id":"ddb6b20397af6a39f3e640d3c0690e287e256f32"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"21047ecd8125832a11968ccb37b9af0da7f64f4e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/acls/ create $(sudo cat /etc/iscsi/initiatorname.iscsi | awk -F \u0027\u003d\u0027 \u0027/^InitiatorName/ { print $NF}\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":73,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1 set attribute authentication\u003d0"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(cw) why is this needed? without it portal creation"},{"line_number":76,"context_line":"    # fails..."}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_73344a4b","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":9},"in_reply_to":"df3967d1_73ffaa67","updated":"2017-07-29 22:30:14.000000000","message":"I\u0027ve tried and this fails on rhel\u0027s targetcli, I\u0027ll push another ps that only sets up the acl on rhel like distros.","commit_id":"ddb6b20397af6a39f3e640d3c0690e287e256f32"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1f1fa386ce1d340c6736db788162eab0bdc4baad","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1 set attribute authentication\u003d0"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(cw) why is this needed? without it portal creation"},{"line_number":76,"context_line":"    # fails..."},{"line_number":77,"context_line":"    sudo systemctl stop iscsitarget"},{"line_number":78,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create"},{"line_number":79,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_13cdfe5c","line":76,"range":{"start_line":76,"start_character":6,"end_line":76,"end_character":11},"updated":"2017-07-29 22:20:34.000000000","message":"when this is working we should probably remove that","commit_id":"ddb6b20397af6a39f3e640d3c0690e287e256f32"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1f1fa386ce1d340c6736db788162eab0bdc4baad","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(cw) why is this needed? without it portal creation"},{"line_number":76,"context_line":"    # fails..."},{"line_number":77,"context_line":"    sudo systemctl stop iscsitarget"},{"line_number":78,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create"},{"line_number":79,"context_line":"  fi"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_f3d95a22","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":35},"updated":"2017-07-29 22:20:34.000000000","message":"unclear why stopping this doesn\u0027t break things, need to look more here","commit_id":"ddb6b20397af6a39f3e640d3c0690e287e256f32"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"9e5cdfbcc4054bec6c7b904c9b75ec0bcfa85e25","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  sudo targetcli iscsi/ create iqn.2016-01.com.example:target"},{"line_number":68,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":69,"context_line":"    sudo systemctl stop iscsitarget"},{"line_number":70,"context_line":"    sudo systemctl staus iscsitarget"},{"line_number":71,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create"},{"line_number":72,"context_line":"    sudo systemctl staus iscsitarget"},{"line_number":73,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"df3967d1_b3ef5286","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":36},"updated":"2017-07-29 23:04:33.000000000","message":"status?","commit_id":"29f7ec64adeac2b7dd765e986ee82a63afdd6c71"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"0dfd32ac93bd968a2af78ca74327d843187a4c6c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  sudo targetcli iscsi/ create iqn.2016-01.com.example:target"},{"line_number":68,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xubuntu\" ]; then"},{"line_number":69,"context_line":"    sudo systemctl stop iscsitarget"},{"line_number":70,"context_line":"    sudo systemctl staus iscsitarget"},{"line_number":71,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create"},{"line_number":72,"context_line":"    sudo systemctl staus iscsitarget"},{"line_number":73,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"df3967d1_739e8a08","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":36},"in_reply_to":"df3967d1_b3ef5286","updated":"2017-07-29 23:08:01.000000000","message":"doh!","commit_id":"29f7ec64adeac2b7dd765e986ee82a63afdd6c71"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"f9443fd274df842d93e5201d30ace0b60b4507bd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    sudo apt-get update -y"},{"line_number":47,"context_line":"    sudo apt-get install -y --no-install-recommends \\"},{"line_number":48,"context_line":"      targetcli \\"},{"line_number":49,"context_line":"      iscsitarget \\"},{"line_number":50,"context_line":"      \"linux-headers-$(uname -r)\" \\"},{"line_number":51,"context_line":"      iscsitarget-dkms \\"},{"line_number":52,"context_line":"      open-iscsi \\"}],"source_content_type":"text/x-sh","patch_set":23,"id":"df3967d1_c0b53ff0","line":49,"updated":"2017-07-31 15:29:18.000000000","message":"is this needed?","commit_id":"18b03058a145aa52a8d286486e34f3413fa6271e"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"f9443fd274df842d93e5201d30ace0b60b4507bd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      targetcli \\"},{"line_number":49,"context_line":"      iscsitarget \\"},{"line_number":50,"context_line":"      \"linux-headers-$(uname -r)\" \\"},{"line_number":51,"context_line":"      iscsitarget-dkms \\"},{"line_number":52,"context_line":"      open-iscsi \\"},{"line_number":53,"context_line":"      lshw"},{"line_number":54,"context_line":"    sudo systemctl restart iscsid"}],"source_content_type":"text/x-sh","patch_set":23,"id":"df3967d1_80cf377e","line":51,"updated":"2017-07-31 15:29:18.000000000","message":"ditto","commit_id":"18b03058a145aa52a8d286486e34f3413fa6271e"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"f9443fd274df842d93e5201d30ace0b60b4507bd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      open-iscsi \\"},{"line_number":53,"context_line":"      lshw"},{"line_number":54,"context_line":"    sudo systemctl restart iscsid"},{"line_number":55,"context_line":"    sudo sed -i \"s|^ISCSITARGET_ENABLE\u003dfalse|ISCSITARGET_ENABLE\u003dtrue|g\" /etc/default/iscsitarget"},{"line_number":56,"context_line":"    sudo systemctl restart iscsitarget"},{"line_number":57,"context_line":"  elif [ \"x$HOST_OS\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":58,"context_line":"    sudo yum install -y \\"}],"source_content_type":"text/x-sh","patch_set":23,"id":"df3967d1_40c94f76","line":55,"updated":"2017-07-31 15:29:18.000000000","message":"ditto","commit_id":"18b03058a145aa52a8d286486e34f3413fa6271e"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"f9443fd274df842d93e5201d30ace0b60b4507bd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      lshw"},{"line_number":54,"context_line":"    sudo systemctl restart iscsid"},{"line_number":55,"context_line":"    sudo sed -i \"s|^ISCSITARGET_ENABLE\u003dfalse|ISCSITARGET_ENABLE\u003dtrue|g\" /etc/default/iscsitarget"},{"line_number":56,"context_line":"    sudo systemctl restart iscsitarget"},{"line_number":57,"context_line":"  elif [ \"x$HOST_OS\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":58,"context_line":"    sudo yum install -y \\"},{"line_number":59,"context_line":"      targetcli \\"}],"source_content_type":"text/x-sh","patch_set":23,"id":"df3967d1_20c64b69","line":56,"updated":"2017-07-31 15:29:18.000000000","message":"ditto","commit_id":"18b03058a145aa52a8d286486e34f3413fa6271e"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"f9443fd274df842d93e5201d30ace0b60b4507bd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create 127.0.0.1 3260"},{"line_number":83,"context_line":"  else"},{"line_number":84,"context_line":"    #FIXME (Portdirect): I\u0027m not sure why this is required."},{"line_number":85,"context_line":"    sudo systemctl stop iscsitarget"},{"line_number":86,"context_line":"    #NOTE (Portdirect): Frustratingly it appears that Ubuntu\u0027s targetcli wont"},{"line_number":87,"context_line":"    # let you bind to localhost."},{"line_number":88,"context_line":"    sudo targetcli iscsi/iqn.2016-01.com.example:target/tpg1/portals create 0.0.0.0 3260"}],"source_content_type":"text/x-sh","patch_set":23,"id":"df3967d1_c0aadf83","line":85,"updated":"2017-07-31 15:29:18.000000000","message":"ditto","commit_id":"18b03058a145aa52a8d286486e34f3413fa6271e"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e60fe5faec77ab7308e007b5264938701023018e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    sudo apt-get update -y"},{"line_number":47,"context_line":"    sudo apt-get install -y --no-install-recommends \\"},{"line_number":48,"context_line":"      targetcli \\"},{"line_number":49,"context_line":"      open-iscsi \\"},{"line_number":50,"context_line":"      lshw"},{"line_number":51,"context_line":"    sudo systemctl restart iscsid"},{"line_number":52,"context_line":"  elif [ \"x$HOST_OS\" \u003d\u003d \"xcentos\" ]; then"}],"source_content_type":"text/x-sh","patch_set":24,"id":"df3967d1_816058d0","line":49,"updated":"2017-07-31 17:39:25.000000000","message":"\"linux-headers-$(uname -r)\" \nis required\n\nnot sure about the rest, perhaps so","commit_id":"dca94b6fc1b32ad2d1b063a33e6f1b63c98d8e1e"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ccb1304e4d5ed8c87bfba173aab86d08c6f27b6c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    sudo apt-get update -y"},{"line_number":47,"context_line":"    sudo apt-get install -y --no-install-recommends \\"},{"line_number":48,"context_line":"      targetcli \\"},{"line_number":49,"context_line":"      open-iscsi \\"},{"line_number":50,"context_line":"      lshw"},{"line_number":51,"context_line":"    sudo systemctl restart iscsid"},{"line_number":52,"context_line":"  elif [ \"x$HOST_OS\" \u003d\u003d \"xcentos\" ]; then"}],"source_content_type":"text/x-sh","patch_set":24,"id":"df3967d1_292865e0","line":49,"in_reply_to":"df3967d1_816058d0","updated":"2017-08-01 04:39:40.000000000","message":"the headers were only required to build the dkms module - which was a red herring.","commit_id":"dca94b6fc1b32ad2d1b063a33e6f1b63c98d8e1e"}],"tools/gate/setup_gate.sh":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c581d348620d78dbd4df66c6ec10e2887fc172d3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  loopback_setup"},{"line_number":51,"context_line":"  ceph_support_install"},{"line_number":52,"context_line":"fi"},{"line_number":53,"context_line":"exit 1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# We setup the network for pre kube here, to enable cluster restarts on"},{"line_number":56,"context_line":"# development machines"}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_fd65b2e2","line":53,"updated":"2017-07-28 21:45:10.000000000","message":"is this needed?  the script runs -e","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"809a34897d04b8bf551996b46881da7aa598ac9e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  loopback_setup"},{"line_number":51,"context_line":"  ceph_support_install"},{"line_number":52,"context_line":"fi"},{"line_number":53,"context_line":"exit 1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# We setup the network for pre kube here, to enable cluster restarts on"},{"line_number":56,"context_line":"# development machines"}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_c54b2c85","line":53,"in_reply_to":"df3967d1_fd65b2e2","updated":"2017-07-29 14:06:24.000000000","message":"The 1st patch sets ran correctly on fedora/centos so this just gets a result quicker.","commit_id":"c7967ea9c7e466734763d3ac1b384357bb72def0"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"9e5cdfbcc4054bec6c7b904c9b75ec0bcfa85e25","unresolved":false,"context_lines":[{"line_number":48,"context_line":"if [ \"x$PVC_BACKEND\" \u003d\u003d \"xceph\" ]; then"},{"line_number":49,"context_line":"  loopback_support_install"},{"line_number":50,"context_line":"  loopback_setup"},{"line_number":51,"context_line":"  exit 1"},{"line_number":52,"context_line":"  ceph_support_install"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"df3967d1_73e9ea7e","line":51,"updated":"2017-07-29 23:04:33.000000000","message":"needed?","commit_id":"29f7ec64adeac2b7dd765e986ee82a63afdd6c71"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"0dfd32ac93bd968a2af78ca74327d843187a4c6c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"if [ \"x$PVC_BACKEND\" \u003d\u003d \"xceph\" ]; then"},{"line_number":49,"context_line":"  loopback_support_install"},{"line_number":50,"context_line":"  loopback_setup"},{"line_number":51,"context_line":"  exit 1"},{"line_number":52,"context_line":"  ceph_support_install"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"df3967d1_1385fead","line":51,"in_reply_to":"df3967d1_73e9ea7e","updated":"2017-07-29 23:08:01.000000000","message":"not needed - but just gets us through zuul quicker/makes it easier to view console log - will remove when getting ready to merge.","commit_id":"29f7ec64adeac2b7dd765e986ee82a63afdd6c71"}]}
