)]}'
{"id":"openstack%2Fopenstack-helm~490027","triplet_id":"openstack%2Fopenstack-helm~master~I013a37f5e6dec43232c6ee300be8f918f9ef554a","project":"openstack/openstack-helm","branch":"master","topic":"joinlistwithcommaupdate","hashtags":[],"change_id":"I013a37f5e6dec43232c6ee300be8f918f9ef554a","subject":"Fix joinListWithComma rendering when invoked with CLI values","status":"MERGED","created":"2017-08-02 13:37:39.000000000","updated":"2017-08-02 20:26:55.000000000","submitted":"2017-08-02 20:26:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b7e27f9277594b33dd7b60fb68c32018b7957259","_number":490027,"virtual_id_number":490027,"owner":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2017-08-02 20:26:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":2,"date":"2017-08-02 20:23:24.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-08-02 15:28:30.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2017-08-02 13:45:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":1,"date":"2017-08-02 20:23:24.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-02 13:45:12.000000000","updated_by":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"reviewer":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"state":"REVIEWER"},{"updated":"2017-08-02 15:28:30.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2017-08-02 20:23:24.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2017-08-02 20:26:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cf2e8b592494199336d73d59f467c4714c093343","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-08-02 13:37:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de78e7d63a27e09a7c954788520b58be5f482caa","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-08-02 13:38:38.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"006a9b24dde3b403d644b2faa874a6ea4cdd5165","author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"date":"2017-08-02 13:45:12.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f79cbf864a56768dfcbaae499ef8bde00664bc4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-02 14:36:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/27/490027/2/check/gate-openstack-helm-docs-ubuntu-xenial/558b686//doc/build/html/ : SUCCESS in 2m 31s\n- gate-openstack-helm-nocluster-linter-ubuntu-xenial http://logs.openstack.org/27/490027/2/check/gate-openstack-helm-nocluster-linter-ubuntu-xenial/e828967/ : SUCCESS in 3m 44s\n- gate-openstack-helm-aio-basic-ubuntu-xenial-nv http://logs.openstack.org/27/490027/2/check/gate-openstack-helm-aio-basic-ubuntu-xenial-nv/256c47e/ : FAILURE in 19m 04s (non-voting)\n- gate-openstack-helm-aio-basic-centos-7-nv http://logs.openstack.org/27/490027/2/check/gate-openstack-helm-aio-basic-centos-7-nv/f49b28e/ : SUCCESS in 24m 52s (non-voting)\n- gate-openstack-helm-aio-basic-fedora-25-nv http://logs.openstack.org/27/490027/2/check/gate-openstack-helm-aio-basic-fedora-25-nv/095ad67/ : SUCCESS in 30m 56s (non-voting)\n- gate-openstack-helm-multi-basic-ubuntu-xenial-2-node-nv http://logs.openstack.org/27/490027/2/check/gate-openstack-helm-multi-basic-ubuntu-xenial-2-node-nv/f4f489c/ : SUCCESS in 40m 59s (non-voting)\n- gate-openstack-helm-multi-basic-ubuntu-xenial-3-node-nv http://logs.openstack.org/27/490027/2/check/gate-openstack-helm-multi-basic-ubuntu-xenial-3-node-nv/0263e38/ : FAILURE in 55m 31s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"20c72e36f8e92b4bc2a9c2c29bac4a3beccdc408","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2017-08-02 15:28:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a53a8a7cd9d8c7d85207dd74027f1273753fbac9","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-08-02 20:23:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"06841fdaa087562c5867f16ef82c52b2818c9316","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-02 20:23:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a67f8eff84e4e7370a5f16b60205cdd2ab8b3102","date":"2017-08-02 20:26:55.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"226ac9741f579c672e5fe2f6516f17411a785402","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-02 20:26:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/27/490027/2/gate/gate-openstack-helm-docs-ubuntu-xenial/8e275c9//doc/build/html/ : SUCCESS in 3m 02s\n- gate-openstack-helm-nocluster-linter-ubuntu-xenial http://logs.openstack.org/27/490027/2/gate/gate-openstack-helm-nocluster-linter-ubuntu-xenial/9dd2f64/ : SUCCESS in 3m 00s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"04e05fcea42455e40b1b8b5cfcd00d6e0a86dd57","revisions":{"ac50a87e70ddcc7c9f8df382ed1b4d0405755801":{"kind":"REWORK","_number":1,"created":"2017-08-02 13:37:39.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/27/490027/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/27/490027/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/1"}}},"commit":{"parents":[{"commit":"f84716f43ef93b98608dcc6adbbd3f0881b384e2","subject":"Glance: Add paste_deploy values","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f84716f43ef93b98608dcc6adbbd3f0881b384e2"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2017-08-02 13:34:46.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"pete@port.direct","date":"2017-08-02 13:34:46.000000000","tz":-300},"subject":"Fix joinListWithComma rendering when use via CLI values.","message":"Fix joinListWithComma rendering when use via CLI values.\n\nThis PS fises a rendering erros in the joinListWithComma function\nwhen used with values from the helm --set cli command.\n\nFrom Kolla-Kubernetes: https://review.openstack.org/#/c/488513/\nAll Credit to: Serguei Bezverkhi\n\nChange-Id: I013a37f5e6dec43232c6ee300be8f918f9ef554a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/ac50a87e70ddcc7c9f8df382ed1b4d0405755801"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/ac50a87e70ddcc7c9f8df382ed1b4d0405755801"}]},"branch":"refs/heads/master"},"04e05fcea42455e40b1b8b5cfcd00d6e0a86dd57":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-08-02 13:38:38.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/27/490027/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/27/490027/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/27/490027/2"}}},"commit":{"parents":[{"commit":"f84716f43ef93b98608dcc6adbbd3f0881b384e2","subject":"Glance: Add paste_deploy values","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f84716f43ef93b98608dcc6adbbd3f0881b384e2"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2017-08-02 13:34:46.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"pete@port.direct","date":"2017-08-02 13:38:14.000000000","tz":-300},"subject":"Fix joinListWithComma rendering when invoked with CLI values","message":"Fix joinListWithComma rendering when invoked with CLI values\n\nThis PS fises a rendering erros in the joinListWithComma function\nwhen used with values from the helm --set cli command.\n\nFrom Kolla-Kubernetes: https://review.openstack.org/#/c/488513/\nAll Credit to: Serguei Bezverkhi\n\nChange-Id: I013a37f5e6dec43232c6ee300be8f918f9ef554a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/04e05fcea42455e40b1b8b5cfcd00d6e0a86dd57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/04e05fcea42455e40b1b8b5cfcd00d6e0a86dd57"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
