)]}'
{"id":"openstack%2Fopenstack-helm~496823","triplet_id":"openstack%2Fopenstack-helm~master~I2a7a0970493d6cab90023a460f9cbdcfa9b03084","project":"openstack/openstack-helm","branch":"master","topic":"ceph-readiness-liveness","hashtags":[],"change_id":"I2a7a0970493d6cab90023a460f9cbdcfa9b03084","subject":"Use \"ceph status\" for liveness/readiness probes","status":"ABANDONED","created":"2017-08-23 16:19:14.000000000","updated":"2017-08-29 12:34:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6a19573790a7af282fc6cab84084137958627a79","_number":496823,"virtual_id_number":496823,"owner":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-08-23 19:08:47.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":1,"date":"2017-08-23 17:07:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-08-23 19:15:37.000000000","_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"date":"2017-08-23 16:28:13.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"value":0,"date":"2017-08-23 16:43:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-23 16:28:13.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-08-23 16:43:42.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2017-08-23 17:07:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-08-23 19:08:47.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"}],"messages":[{"id":"f7be7daf55e3a38720ba7a948be185155d1f95d5","author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"date":"2017-08-23 16:19:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f887e0fc99f3d5b27f459294365217bb8e07883c","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-08-23 16:19:22.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/community-singlenode/job/osh-singlenode/393/ (1/2)","accounts_in_message":[],"_revision_number":1},{"id":"8e131fbfc8a869bb621392837e2aca414bc66cb4","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-08-23 16:19:23.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/OSH/job/openstack/job/openstack-helm/job/basic/263/ (2/2)","accounts_in_message":[],"_revision_number":1},{"id":"c84932140b92d25225ba31046beda9d4fd8a8d49","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-08-23 16:28:13.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://10.24.20.18:30081/job/community-singlenode/job/osh-singlenode/393/ : FAILURE (skipped)\n\nhttp://10.24.20.18:30081/job/OSH/job/openstack/job/openstack-helm/job/basic/263/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ccf01b0ec16eb62fc99af9b6748146a7f2647bcd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-23 17:07:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/23/496823/1/check/gate-openstack-helm-docs-ubuntu-xenial/c8c241b//doc/build/html/ : SUCCESS in 2m 39s\n- gate-openstack-helm-nocluster-linter-ubuntu-xenial http://logs.openstack.org/23/496823/1/check/gate-openstack-helm-nocluster-linter-ubuntu-xenial/a2c41bf/ : SUCCESS in 3m 03s\n- gate-openstack-helm-aio-basic-ubuntu-xenial-nv http://logs.openstack.org/23/496823/1/check/gate-openstack-helm-aio-basic-ubuntu-xenial-nv/57fa4d4/ : SUCCESS in 33m 15s (non-voting)\n- gate-openstack-helm-aio-basic-centos-7-nv http://logs.openstack.org/23/496823/1/check/gate-openstack-helm-aio-basic-centos-7-nv/fe99589/ : SUCCESS in 31m 38s (non-voting)\n- gate-openstack-helm-aio-basic-fedora-26-nv http://logs.openstack.org/23/496823/1/check/gate-openstack-helm-aio-basic-fedora-26-nv/ca9953d/ : SUCCESS in 34m 06s (non-voting)\n- gate-openstack-helm-multi-basic-ubuntu-xenial-3-node-nv http://logs.openstack.org/23/496823/1/check/gate-openstack-helm-multi-basic-ubuntu-xenial-3-node-nv/bc3c3e1/ : FAILURE in 33m 16s (non-voting)\n- gate-openstack-helm-multi-armada-ubuntu-xenial-3-node-nv http://logs.openstack.org/23/496823/1/check/gate-openstack-helm-multi-armada-ubuntu-xenial-3-node-nv/06dd670/ : FAILURE in 22m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"25f27b33e138b01bf1d7aa4623ae9257ccc49a30","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-08-23 19:08:47.000000000","message":"Patch Set 1:\n\ni really like the idea of using `ceph status` to get status\n\nbut i worry *when* status checks fail we won\u0027t always do the right thing","accounts_in_message":[],"_revision_number":1},{"id":"b862f258ea97852acbab16a18156fbcda9405938","author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"date":"2017-08-23 19:15:37.000000000","message":"Patch Set 1:\n\nYeah, I think the _right_ solution actually involves wrapping this up in something that parses the output or does some other, deeper check.  That said, I\u0027m not sure there\u0027s much useful we CAN do in liveness/readiness checks as opposed to the sort of more robust monitoring of the sort you\u0027d get with nagios/prometheus/etc — this definitely isn\u0027t intended to supplant that, just to improve on the previous \"is there a TCP listener yet?\" check.\n\n \u003e i really like the idea of using `ceph status` to get status\n \u003e \n \u003e but i worry *when* status checks fail we won\u0027t always do the right\n \u003e thing","accounts_in_message":[],"_revision_number":1},{"id":"c2660135f52d73b31e269185cc3e95b88526cb33","author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"date":"2017-08-23 19:53:45.000000000","message":"Patch Set 1:\n\none alternative I\u0027m thinking about, by the way, is to get the status off the local unix-domain socket; this gets us the actual state of the local daemon, where \u0027ceph status\u0027 by itself only tells us whether we can reach the monitor — it doesn\u0027t actually say anything at ALL about whether the OSD is working.  but there\u0027s no clean way i can see to find the unix-domain socket (the name depends on the OSD ID) or to handle the case where you\u0027ve got more than one OSD in a pod.","accounts_in_message":[],"_revision_number":1},{"id":"1ee6683239a0c736c45b2f679497b13d4aa18604","author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"date":"2017-08-29 12:34:40.000000000","message":"Abandoned\n\nChange 497417 is a  better way of accomplishing this, so I\u0027m dropping this approach.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e5c1bb24842415a60c2fe9ca9d60b7afab79f7a","revisions":{"3e5c1bb24842415a60c2fe9ca9d60b7afab79f7a":{"kind":"REWORK","_number":1,"created":"2017-08-23 16:19:14.000000000","uploader":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"ref":"refs/changes/23/496823/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/23/496823/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/23/496823/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/23/496823/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/23/496823/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/23/496823/1"}}},"commit":{"parents":[{"commit":"87723a700cef3f3efe777ee85c92277b48682312","subject":"Merge \"Helm-Toolkit: Configmap templater\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/87723a700cef3f3efe777ee85c92277b48682312"}]}],"author":{"name":"dave kormann","email":"davek@research.att.com","date":"2017-08-23 16:11:39.000000000","tz":-240},"committer":{"name":"dave kormann","email":"davek@research.att.com","date":"2017-08-23 16:13:53.000000000","tz":-240},"subject":"Use \"ceph status\" for liveness/readiness probes","message":"Use \"ceph status\" for liveness/readiness probes\n\nTCP-based liveness/readiness probes fail when using a network other\nthan the one associated with the primary hostname.  Switch to using\n\"ceph status\" instead, which should fail if OSDs cannot talk to\nmonitors.  This is arguably a better readiness test than just presence\nof the port listener anyway.  For liveness, it\u0027d probably be better to\nactually check the command output to make sure the OSD is functional,\nbut this is a reasonable first step.\n\nChange-Id: I2a7a0970493d6cab90023a460f9cbdcfa9b03084\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3e5c1bb24842415a60c2fe9ca9d60b7afab79f7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3e5c1bb24842415a60c2fe9ca9d60b7afab79f7a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
