)]}'
{"nova/templates/bin/_ssh-setup.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cf9ac8c0327618e38be9d6e08d06b3c349f61846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f2577a7_f91dc20f","updated":"2017-09-08 21:56:17.000000000","message":"should this not be ssh-start or similar?","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cf9ac8c0327618e38be9d6e08d06b3c349f61846","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"SSH_HOST_KEY_TYPES\u003d( \"rsa\" \"dsa\" \"ecdsa\" \"ed25519\" )"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"for key_type in ${SSH_HOST_KEY_TYPES[@]}; do"},{"line_number":24,"context_line":"    KEY_PATH\u003d/etc/ssh/ssh_host_${key_type}_key"},{"line_number":25,"context_line":"    if [[ ! -f \"${KEY_PATH}\" ]]; then"},{"line_number":26,"context_line":"        ssh-keygen -q -t ${key_type} -f ${KEY_PATH} -N \"\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_59273666","line":23,"range":{"start_line":23,"start_character":16,"end_line":23,"end_character":40},"updated":"2017-09-08 21:56:17.000000000","message":"why not just: rsa dsa ecdsa ed25519, or declare via an override/value if this may vary?","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a5326dc39b44d56f40bc2aebf07849229896c05b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"SSH_HOST_KEY_TYPES\u003d( \"rsa\" \"dsa\" \"ecdsa\" \"ed25519\" )"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"for key_type in ${SSH_HOST_KEY_TYPES[@]}; do"},{"line_number":24,"context_line":"    KEY_PATH\u003d/etc/ssh/ssh_host_${key_type}_key"},{"line_number":25,"context_line":"    if [[ ! -f \"${KEY_PATH}\" ]]; then"},{"line_number":26,"context_line":"        ssh-keygen -q -t ${key_type} -f ${KEY_PATH} -N \"\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_12936951","line":23,"range":{"start_line":23,"start_character":16,"end_line":23,"end_character":40},"in_reply_to":"5f2577a7_59273666","updated":"2017-09-13 16:24:14.000000000","message":"Done","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"43ba39377ff621246e8005dcb6e9ed2ddba63bec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"mkdir -p /var/lib/nova/.ssh"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ $(stat -c %U:%G /var/lib/nova/.ssh) !\u003d \"nova:nova\" ]]; then"},{"line_number":33,"context_line":"    chown nova: /var/lib/nova/.ssh"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_10ff21ab","line":30,"updated":"2017-09-11 19:14:31.000000000","message":"If we\u0027re going to bake in our presumption about a nova user existing (which I think is where we are at), we should at least let the home directory be discovered (e.g.)\n\n  mkdir -p ~nova/.ssh","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a5326dc39b44d56f40bc2aebf07849229896c05b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"mkdir -p /var/lib/nova/.ssh"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ $(stat -c %U:%G /var/lib/nova/.ssh) !\u003d \"nova:nova\" ]]; then"},{"line_number":33,"context_line":"    chown nova: /var/lib/nova/.ssh"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_b2a3759e","line":30,"in_reply_to":"5f2577a7_10ff21ab","updated":"2017-09-13 16:24:14.000000000","message":"Done","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"43ba39377ff621246e8005dcb6e9ed2ddba63bec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"mkdir -p /var/lib/nova/.ssh"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ $(stat -c %U:%G /var/lib/nova/.ssh) !\u003d \"nova:nova\" ]]; then"},{"line_number":33,"context_line":"    chown nova: /var/lib/nova/.ssh"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"chmod 0600 /root/.ssh/authorized_keys"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_f02db546","line":33,"updated":"2017-09-11 19:14:31.000000000","message":"Sae, ~nova/.ssh","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a5326dc39b44d56f40bc2aebf07849229896c05b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"mkdir -p /var/lib/nova/.ssh"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ $(stat -c %U:%G /var/lib/nova/.ssh) !\u003d \"nova:nova\" ]]; then"},{"line_number":33,"context_line":"    chown nova: /var/lib/nova/.ssh"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"chmod 0600 /root/.ssh/authorized_keys"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_929e3952","line":33,"in_reply_to":"5f2577a7_f02db546","updated":"2017-09-13 16:24:14.000000000","message":"Done","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"43ba39377ff621246e8005dcb6e9ed2ddba63bec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    chown nova: /var/lib/nova/.ssh"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"chmod 0600 /root/.ssh/authorized_keys"},{"line_number":37,"context_line":"chmod 0600 /root/.ssh/id_rsa"},{"line_number":38,"context_line":"chmod 0600 /root/.ssh/id_rsa.pub"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_d032b9a7","line":36,"updated":"2017-09-11 19:14:31.000000000","message":"Same, ~root/.ssh/...","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a5326dc39b44d56f40bc2aebf07849229896c05b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    chown nova: /var/lib/nova/.ssh"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"chmod 0600 /root/.ssh/authorized_keys"},{"line_number":37,"context_line":"chmod 0600 /root/.ssh/id_rsa"},{"line_number":38,"context_line":"chmod 0600 /root/.ssh/id_rsa.pub"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_72ad0d87","line":36,"in_reply_to":"5f2577a7_d032b9a7","updated":"2017-09-13 16:24:14.000000000","message":"Done","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cf9ac8c0327618e38be9d6e08d06b3c349f61846","unresolved":false,"context_lines":[{"line_number":37,"context_line":"chmod 0600 /root/.ssh/id_rsa"},{"line_number":38,"context_line":"chmod 0600 /root/.ssh/id_rsa.pub"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/usr/sbin/sshd -D -e -o Port\u003d{{ .Values.network.ssh.port }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_99047ec8","line":40,"range":{"start_line":40,"start_character":29,"end_line":40,"end_character":59},"updated":"2017-09-08 21:56:17.000000000","message":"can we get this from an env var","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cf9ac8c0327618e38be9d6e08d06b3c349f61846","unresolved":false,"context_lines":[{"line_number":37,"context_line":"chmod 0600 /root/.ssh/id_rsa"},{"line_number":38,"context_line":"chmod 0600 /root/.ssh/id_rsa.pub"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/usr/sbin/sshd -D -e -o Port\u003d{{ .Values.network.ssh.port }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_d96c469e","line":40,"updated":"2017-09-08 21:56:17.000000000","message":"exec","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a5326dc39b44d56f40bc2aebf07849229896c05b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"chmod 0600 /root/.ssh/id_rsa"},{"line_number":38,"context_line":"chmod 0600 /root/.ssh/id_rsa.pub"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/usr/sbin/sshd -D -e -o Port\u003d{{ .Values.network.ssh.port }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_52a8d175","line":40,"range":{"start_line":40,"start_character":29,"end_line":40,"end_character":59},"in_reply_to":"5f2577a7_99047ec8","updated":"2017-09-13 16:24:14.000000000","message":"Done","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a5326dc39b44d56f40bc2aebf07849229896c05b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"chmod 0600 /root/.ssh/id_rsa"},{"line_number":38,"context_line":"chmod 0600 /root/.ssh/id_rsa.pub"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/usr/sbin/sshd -D -e -o Port\u003d{{ .Values.network.ssh.port }}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f2577a7_f2b21de6","line":40,"in_reply_to":"5f2577a7_d96c469e","updated":"2017-09-13 16:24:14.000000000","message":"Done","commit_id":"6683130896ccb35b94dd8780a52a4d10f0aa188f"}],"nova/templates/bin/_ssh-start.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f3d0b9f91ea0d4e4c9b35118bf33edac7a1d5304","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for key_type in $KEY_TYPES; do"},{"line_number":22,"context_line":"    KEY_PATH\u003d/etc/ssh/ssh_host_${key_type}_key"},{"line_number":23,"context_line":"    if [[ ! -f \"${KEY_PATH}\" ]]; then"},{"line_number":24,"context_line":"        ssh-keygen -q -t ${key_type} -f ${KEY_PATH} -N \"\""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f2577a7_5531dbeb","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":12},"updated":"2017-09-13 16:29:58.000000000","message":"For consistency, uppercase would be better.","commit_id":"f25f327d72936f36f63f45f95596253b34942541"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e7cbea0c3da584c18de0cee402835b0fe0cb2a09","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for key_type in $KEY_TYPES; do"},{"line_number":22,"context_line":"    KEY_PATH\u003d/etc/ssh/ssh_host_${key_type}_key"},{"line_number":23,"context_line":"    if [[ ! -f \"${KEY_PATH}\" ]]; then"},{"line_number":24,"context_line":"        ssh-keygen -q -t ${key_type} -f ${KEY_PATH} -N \"\""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f2577a7_95798330","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":12},"in_reply_to":"5f2577a7_5531dbeb","updated":"2017-09-13 16:36:01.000000000","message":"Done","commit_id":"f25f327d72936f36f63f45f95596253b34942541"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"12bcbdc0148de6abbd68673d310f1015913fe607","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"mkdir -p ~nova/.ssh"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"if [[ $(stat -c %U:%G /var/lib/nova/.ssh) !\u003d \"nova:nova\" ]]; then"},{"line_number":31,"context_line":"    chown nova: ~nova/.ssh"},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f2577a7_d5494b8b","line":30,"updated":"2017-09-13 16:46:13.000000000","message":"Missed one here","commit_id":"f25f327d72936f36f63f45f95596253b34942541"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"d3a90b19f126d73700fef0e4abcabc36c01b357e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"mkdir -p ~nova/.ssh"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"if [[ $(stat -c %U:%G /var/lib/nova/.ssh) !\u003d \"nova:nova\" ]]; then"},{"line_number":31,"context_line":"    chown nova: ~nova/.ssh"},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f2577a7_488dbe79","line":30,"in_reply_to":"5f2577a7_d5494b8b","updated":"2017-09-13 16:53:04.000000000","message":"Done","commit_id":"f25f327d72936f36f63f45f95596253b34942541"}],"nova/templates/daemonset-compute.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f3d0b9f91ea0d4e4c9b35118bf33edac7a1d5304","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        - name: nova-compute-ssh"},{"line_number":199,"context_line":"          image: {{ .Values.images.compute_ssh }}"},{"line_number":200,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":201,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.compute | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":202,"context_line":"          securityContext:"},{"line_number":203,"context_line":"            privileged: true"},{"line_number":204,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f2577a7_f57e8769","line":201,"range":{"start_line":201,"start_character":46,"end_line":201,"end_character":53},"updated":"2017-09-13 16:29:58.000000000","message":"should this not get its own resource allocation, separate from the nova compute daemon?","commit_id":"f25f327d72936f36f63f45f95596253b34942541"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e7cbea0c3da584c18de0cee402835b0fe0cb2a09","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        - name: nova-compute-ssh"},{"line_number":199,"context_line":"          image: {{ .Values.images.compute_ssh }}"},{"line_number":200,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":201,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.compute | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":202,"context_line":"          securityContext:"},{"line_number":203,"context_line":"            privileged: true"},{"line_number":204,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f2577a7_b57ebf16","line":201,"range":{"start_line":201,"start_character":46,"end_line":201,"end_character":53},"in_reply_to":"5f2577a7_f57e8769","updated":"2017-09-13 16:36:01.000000000","message":"Done","commit_id":"f25f327d72936f36f63f45f95596253b34942541"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f3d0b9f91ea0d4e4c9b35118bf33edac7a1d5304","unresolved":false,"context_lines":[{"line_number":224,"context_line":"              mountPath: /tmp/ssh-setup.sh"},{"line_number":225,"context_line":"              subPath: ssh-setup.sh"},{"line_number":226,"context_line":"              readOnly: true"},{"line_number":227,"context_line":"          ports:"},{"line_number":228,"context_line":"            - containerPort: {{ .Values.network.ssh.port }}"},{"line_number":229,"context_line":"          command:"},{"line_number":230,"context_line":"            - /tmp/ssh-start.sh"},{"line_number":231,"context_line":"      volumes:"},{"line_number":232,"context_line":"        - name: nova-bin"},{"line_number":233,"context_line":"          configMap:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f2577a7_35d3ef62","line":230,"range":{"start_line":227,"start_character":0,"end_line":230,"end_character":31},"updated":"2017-09-13 16:29:58.000000000","message":"for consistency could these be moved above the volumeMount declaration.","commit_id":"f25f327d72936f36f63f45f95596253b34942541"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e7cbea0c3da584c18de0cee402835b0fe0cb2a09","unresolved":false,"context_lines":[{"line_number":224,"context_line":"              mountPath: /tmp/ssh-setup.sh"},{"line_number":225,"context_line":"              subPath: ssh-setup.sh"},{"line_number":226,"context_line":"              readOnly: true"},{"line_number":227,"context_line":"          ports:"},{"line_number":228,"context_line":"            - containerPort: {{ .Values.network.ssh.port }}"},{"line_number":229,"context_line":"          command:"},{"line_number":230,"context_line":"            - /tmp/ssh-start.sh"},{"line_number":231,"context_line":"      volumes:"},{"line_number":232,"context_line":"        - name: nova-bin"},{"line_number":233,"context_line":"          configMap:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f2577a7_358bef1f","line":230,"range":{"start_line":227,"start_character":0,"end_line":230,"end_character":31},"in_reply_to":"5f2577a7_35d3ef62","updated":"2017-09-13 16:36:01.000000000","message":"Done","commit_id":"f25f327d72936f36f63f45f95596253b34942541"}]}