)]}'
{"id":"openstack%2Fopenstack-helm~504160","triplet_id":"openstack%2Fopenstack-helm~master~I8a08dc7930c15ae90e1c6fb8a5fa3344cca2380f","project":"openstack/openstack-helm","branch":"master","topic":"bug/1715702","hashtags":[],"change_id":"I8a08dc7930c15ae90e1c6fb8a5fa3344cca2380f","subject":"Check libvirtd based on /proc instead of /var/run","status":"MERGED","created":"2017-09-14 18:06:28.000000000","updated":"2017-09-22 03:21:33.000000000","submitted":"2017-09-22 03:21:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"504160-1506050493141-75eacdef","meta_rev_id":"4b4bfe3dd13b80d54386f9b6137228fbfb5d7a47","_number":504160,"virtual_id_number":504160,"owner":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2017-09-14 21:26:01.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2017-09-22 03:21:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-09-14 18:39:57.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"date":"2017-09-14 22:02:07.000000000","_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"recommended":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2017-09-15 19:04:08.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":2,"date":"2017-09-22 03:18:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":2,"date":"2017-09-21 21:06:18.000000000","_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"value":1,"date":"2017-09-16 12:46:42.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":1,"date":"2017-09-22 03:18:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-14 18:39:57.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-09-14 21:26:01.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2017-09-16 12:46:42.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2017-09-21 21:06:18.000000000","updated_by":{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},"reviewer":{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},"state":"REVIEWER"},{"updated":"2017-09-22 03:18:00.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2017-09-22 03:21:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8d83c07316fd8c22df2686cf0cf5b23ce2bc76ff","author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"date":"2017-09-14 18:06:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2771aa170e6fcf34e0640136c4999fd9b68624e8","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-09-14 18:06:35.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/OSH/job/openstack/job/openstack-helm/job/basic/949/","accounts_in_message":[],"_revision_number":1},{"id":"cc722a31bef298856dee5aa493d33779cfcb0af2","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-09-14 18:39:57.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/949/org.openstack.helm-949.x-gtar : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3e33cb51fae3cf5117f370da4c4153b3e1e06b3c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-14 19:14:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/60/504160/1/check/gate-openstack-helm-docs-ubuntu-xenial/40a930a//doc/build/html/ : SUCCESS in 6m 46s\n- gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial/f4a3080/ : SUCCESS in 5m 12s\n- gate-openstack-helm-aio-basic-ovs-rbd-ubuntu-xenial-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-ovs-rbd-ubuntu-xenial-nv/d5d5602/ : FAILURE in 12m 05s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-swift-ubuntu-xenial-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-ovs-swift-ubuntu-xenial-nv/274d575/ : FAILURE in 19m 37s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-radosgw-ubuntu-xenial-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-ovs-radosgw-ubuntu-xenial-nv/0cfd81f/ : SUCCESS in 25m 32s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-pvc-ubuntu-xenial-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-ovs-pvc-ubuntu-xenial-nv/3937eb8/ : SUCCESS in 23m 12s (non-voting)\n- gate-openstack-helm-aio-basic-linuxbridge-rbd-ubuntu-xenial-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-linuxbridge-rbd-ubuntu-xenial-nv/1743292/ : FAILURE in 19m 13s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-rbd-centos-7-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-ovs-rbd-centos-7-nv/f84b382/ : FAILURE in 30m 30s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-rbd-fedora-26-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-aio-basic-ovs-rbd-fedora-26-nv/09a4fe5/ : SUCCESS in 33m 50s (non-voting)\n- gate-openstack-helm-multi-basic-ovs-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-multi-basic-ovs-rbd-ubuntu-xenial-3-node-nv/4063afd/ : FAILURE in 27m 02s (non-voting)\n- gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv/a946164/ : SUCCESS in 1h 04m 42s (non-voting)\n- gate-openstack-helm-multi-armada-ovs-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/60/504160/1/check/gate-openstack-helm-multi-armada-ovs-rbd-ubuntu-xenial-3-node-nv/a578de1/ : SUCCESS in 38m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0ed0840bd2b5693ad6845a06255edfb5b07e4bed","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-09-14 21:26:01.000000000","message":"Patch Set 1:\n\nif the [/var]/run files can\u0027t be trusted - can the socket be trusted?","accounts_in_message":[],"_revision_number":1},{"id":"176edf918923987ac9d1c51ab6825d9df41a7a13","author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"date":"2017-09-14 22:02:07.000000000","message":"Patch Set 1:\n\nIt\u0027s up to the application or application deployer where on the filesystem to store a PID file - if it chooses to at all. It\u0027s certainly best practice to do so for any daemonset to manage its own PID lifecycle (start/stop/restart etc), and best practice to store this in /var/run, but is configurable userspace behavior. procfs is populated by the kernel directly so would be the most accurate source of truth of any processes truly running at a given point in time, regardless of adherence to best practices on the part of the application implementation or configuration.","accounts_in_message":[],"_revision_number":1},{"id":"ade3175de334babf3e57dbe509ea52eb04cf55c7","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2017-09-14 22:27:02.000000000","message":"Patch Set 1:\n\n\u003e if the [/var]/run files can\u0027t be trusted - can the socket be\n \u003e trusted?\n\nWe trust the socket this daemonset will drop down, as well as any pid file.  The issue, per the bug, is that the operator may already have libvirtd running on the baremetal host and we will end up with a conflict.  While normally that in itself is not worth handling in any special way on the openstack-helm front, this particular conflict is 1) common and 2) results in an extremely obtuse error message that confuses end users so this check with its net cast wider should help people discover libvirtd is already running on their systems","accounts_in_message":[],"_revision_number":1},{"id":"08264cbb1dd0abbcc16dd1707a16230717815f6e","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-09-15 19:04:08.000000000","message":"Patch Set 1: Code-Review+1\n\nwfm","accounts_in_message":[],"_revision_number":1},{"id":"87c288f43498e6b6a032fc729f2a049d8b1275d9","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2017-09-16 12:46:42.000000000","message":"Patch Set 1: Code-Review+1\n\nWorks for me; I have run into this before and this messaging will help folks.","accounts_in_message":[],"_revision_number":1},{"id":"69e2f3d3ba957df734f4023c4314a7783434b33f","author":{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},"date":"2017-09-21 21:06:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7feae3c8fc3ceede6c858402082042aa4909afd8","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2017-09-22 03:18:00.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nLGTM, thanks Craig.","accounts_in_message":[],"_revision_number":1},{"id":"70f1bb3ed5d5fde6251cf26e16c293d112bdc097","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-22 03:18:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e4c98806d4b241dbcb350fce420da6f26889679c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-22 03:21:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/60/504160/1/gate/gate-openstack-helm-docs-ubuntu-xenial/8f35836//doc/build/html/ : SUCCESS in 2m 22s\n- gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial http://logs.openstack.org/60/504160/1/gate/gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial/fd72202/ : SUCCESS in 2m 47s","accounts_in_message":[],"_revision_number":1},{"id":"7bade63a4d1b6d4443dad92f08b2abba2321880a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-22 03:21:33.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"388562e6729bcc7b8e792050ec30017eb566dcf5","revisions":{"388562e6729bcc7b8e792050ec30017eb566dcf5":{"kind":"REWORK","_number":1,"created":"2017-09-14 18:06:28.000000000","uploader":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"ref":"refs/changes/60/504160/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/60/504160/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/60/504160/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/60/504160/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/60/504160/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/60/504160/1"}}},"commit":{"parents":[{"commit":"af77125f10ec1e6bf75a1f61e3d0de8049bf62db","subject":"Merge \"gate: Introduce POD_START_TIMEOUT (default 480s)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/af77125f10ec1e6bf75a1f61e3d0de8049bf62db"}]}],"author":{"name":"Craig Anderson","email":"craig.anderson@att.com","date":"2017-09-14 17:56:51.000000000","tz":-420},"committer":{"name":"Craig Anderson","email":"craig.anderson@att.com","date":"2017-09-14 18:06:27.000000000","tz":-420},"subject":"Check libvirtd based on /proc instead of /var/run","message":"Check libvirtd based on /proc instead of /var/run\n\nChange libvirtd check to look for pre-existing libvirt processes on the host based on /proc, which is more reliable than pidfiles written under /var/run/ which may be stale or may not be written at all.\n\nChange-Id: I8a08dc7930c15ae90e1c6fb8a5fa3344cca2380f\nCloses-Bug: #1715702\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/388562e6729bcc7b8e792050ec30017eb566dcf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/388562e6729bcc7b8e792050ec30017eb566dcf5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}