)]}'
{"neutron/templates/bin/_neutron-server.sh.tpl":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"adfe6c051c379b3a27754679a4d9dcac954ac39b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{{- end }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function start () {"},{"line_number":28,"context_line":"  exec neutron-server $CONF_FILE"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function stop () {"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"9f5c4f37_3ccfbb80","line":28,"updated":"2017-09-21 10:34:09.000000000","message":"This can be also written like we have it in [1]\n\nexec neutron-server \\\n        --config-file /etc/neutron/neutron.conf \\\n        --config-file /etc/neutron/plugins/ml2/ml2_conf.ini\n{{- if .Values.conf.ml2_conf_onos.enabled }} \\\n        --config-file /etc/neutron/plugins/ml2/ml2_conf_onos.ini\n{{- end }}\n[1] https://github.com/openstack/openstack-helm/blob/master/neutron/templates/bin/_neutron-dhcp-agent.sh.tpl","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":21892,"name":"Siri Kim","email":"siri.kim@sk.com","username":"shiriul"},"change_message_id":"e0f48a51b688dc9affd55e3cb83e46198f62e23e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{{- end }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function start () {"},{"line_number":28,"context_line":"  exec neutron-server $CONF_FILE"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function stop () {"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7f515b1d_839411ea","line":28,"in_reply_to":"9f5c4f37_3ccfbb80","updated":"2017-10-12 09:35:57.000000000","message":"Done","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"be275e5f94df8459da7ce5c81dadb4e5c6e09cbe","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  exec neutron-server \\"},{"line_number":24,"context_line":"        --config-file /etc/neutron/neutron.conf \\"},{"line_number":25,"context_line":"        --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":26,"context_line":"{{- if .Values.conf.plugins.ml2_conf_onos.enabled }} \\"},{"line_number":27,"context_line":"        --config-file /etc/neutron/plugins/ml2/ml2_conf_onos.ini"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"3f4b6375_abed918c","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":49},"updated":"2017-10-30 08:32:29.000000000","message":"It was removed from values.yaml?","commit_id":"1b2acc19f0344a58a1a1a8f44c38e1b0a54adcca"}],"neutron/templates/deployment-server.yaml":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"be275e5f94df8459da7ce5c81dadb4e5c6e09cbe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              mountPath: /etc/neutron/policy.json"},{"line_number":85,"context_line":"              subPath: policy.json"},{"line_number":86,"context_line":"              readOnly: true"},{"line_number":87,"context_line":"{{ if .Values.conf.plugins.ml2_conf_onos.onos.user }}"},{"line_number":88,"context_line":"            - name: neutron-etc"},{"line_number":89,"context_line":"              mountPath: /etc/neutron/plugins/ml2/ml2_conf_onos.ini"},{"line_number":90,"context_line":"              subPath: ml2_conf_onos.ini"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_cb332d62","line":87,"updated":"2017-10-30 08:32:29.000000000","message":"It is looking somehow strange, why ml2_conf_onos.enabled was dropped?","commit_id":"1b2acc19f0344a58a1a1a8f44c38e1b0a54adcca"}],"neutron/templates/etc/plugins/_ml2_conf_onos.ini.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f0e9b881c5209e868444734c6bdbdd79c45db89c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f515b1d_4d1b8680","updated":"2017-09-26 14:17:53.000000000","message":"is this file needed? it could be generated dynamically using to_ini.","commit_id":"d7d8fd5035dc82a7fd014de4a080e975dc72c8ed"}],"neutron/values.yaml":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"adfe6c051c379b3a27754679a4d9dcac954ac39b","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        # core_plugin can be: ml2, calico"},{"line_number":611,"context_line":"        core_plugin: ml2"},{"line_number":612,"context_line":"        # service_plugin can be: router, odl-router, empty for calico,"},{"line_number":613,"context_line":"        # networking_ovn.l3.l3_ovn.OVNL3RouterPlugin for OVN"},{"line_number":614,"context_line":"        service_plugins: router"},{"line_number":615,"context_line":"        metadata_proxy_socket: /var/lib/neutron/openstack-helm/metadata_proxy"},{"line_number":616,"context_line":"        db:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f5c4f37_bc360bb4","line":613,"updated":"2017-09-21 10:34:09.000000000","message":"We can add \"onos_router\" as an example, that this is valid value for service_plugins.","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":21892,"name":"Siri Kim","email":"siri.kim@sk.com","username":"shiriul"},"change_message_id":"e0f48a51b688dc9affd55e3cb83e46198f62e23e","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        # core_plugin can be: ml2, calico"},{"line_number":611,"context_line":"        core_plugin: ml2"},{"line_number":612,"context_line":"        # service_plugin can be: router, odl-router, empty for calico,"},{"line_number":613,"context_line":"        # networking_ovn.l3.l3_ovn.OVNL3RouterPlugin for OVN"},{"line_number":614,"context_line":"        service_plugins: router"},{"line_number":615,"context_line":"        metadata_proxy_socket: /var/lib/neutron/openstack-helm/metadata_proxy"},{"line_number":616,"context_line":"        db:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_c391e9f3","line":613,"in_reply_to":"9f5c4f37_bc360bb4","updated":"2017-10-12 09:35:57.000000000","message":"Done","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"adfe6c051c379b3a27754679a4d9dcac954ac39b","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        ml2:"},{"line_number":667,"context_line":"          extension_drivers: port_security"},{"line_number":668,"context_line":"          # mechnism_drivers can be: openvswitch, linuxbridge,"},{"line_number":669,"context_line":"          # opendaylight, ovn"},{"line_number":670,"context_line":"          mechanism_drivers: openvswitch,l2population"},{"line_number":671,"context_line":"          type_drivers: flat,vlan,vxlan"},{"line_number":672,"context_line":"          tenant_network_types: vxlan"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f5c4f37_9cd6a74f","line":669,"updated":"2017-09-21 10:34:09.000000000","message":"Can you add here the \"onos_ml2\" as an exmaple what can be used as mechanism_drivers?","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":21892,"name":"Siri Kim","email":"siri.kim@sk.com","username":"shiriul"},"change_message_id":"e0f48a51b688dc9affd55e3cb83e46198f62e23e","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        ml2:"},{"line_number":667,"context_line":"          extension_drivers: port_security"},{"line_number":668,"context_line":"          # mechnism_drivers can be: openvswitch, linuxbridge,"},{"line_number":669,"context_line":"          # opendaylight, ovn"},{"line_number":670,"context_line":"          mechanism_drivers: openvswitch,l2population"},{"line_number":671,"context_line":"          type_drivers: flat,vlan,vxlan"},{"line_number":672,"context_line":"          tenant_network_types: vxlan"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_e384e5b3","line":669,"in_reply_to":"9f5c4f37_9cd6a74f","updated":"2017-10-12 09:35:57.000000000","message":"Done","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"adfe6c051c379b3a27754679a4d9dcac954ac39b","unresolved":false,"context_lines":[{"line_number":796,"context_line":"              l2_population: True"},{"line_number":797,"context_line":"              arp_responder: True"},{"line_number":798,"context_line":"  ml2_conf_onos:"},{"line_number":799,"context_line":"    enabled:"},{"line_number":800,"context_line":"    url_path:"},{"line_number":801,"context_line":"    auth:"},{"line_number":802,"context_line":"      user:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f5c4f37_7c409308","line":799,"updated":"2017-09-21 10:34:09.000000000","message":"We do not need \"enabled: false\" here?","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":21892,"name":"Siri Kim","email":"siri.kim@sk.com","username":"shiriul"},"change_message_id":"e0f48a51b688dc9affd55e3cb83e46198f62e23e","unresolved":false,"context_lines":[{"line_number":796,"context_line":"              l2_population: True"},{"line_number":797,"context_line":"              arp_responder: True"},{"line_number":798,"context_line":"  ml2_conf_onos:"},{"line_number":799,"context_line":"    enabled:"},{"line_number":800,"context_line":"    url_path:"},{"line_number":801,"context_line":"    auth:"},{"line_number":802,"context_line":"      user:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_038821c4","line":799,"in_reply_to":"9f5c4f37_7c409308","updated":"2017-10-12 09:35:57.000000000","message":"Done","commit_id":"1ede545352adfe06b90f0ea958a8fd1e4760a05a"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"9e67355facf9ac761bb982ec9455c3a5e876af1a","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"        default: 9696"},{"line_number":1201,"context_line":"        public: 80"},{"line_number":1202,"context_line":"  network_onos:"},{"line_number":1203,"context_line":"    name: "},{"line_number":1204,"context_line":"    hosts:"},{"line_number":1205,"context_line":"      default: onos-sona"},{"line_number":1206,"context_line":"      public: onos-web"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_08584e85","line":1203,"range":{"start_line":1203,"start_character":9,"end_line":1203,"end_character":10},"updated":"2017-10-27 13:35:29.000000000","message":"pls remove trailing space","commit_id":"6a9256518cafaf0fdc9b548b03b7bc92427c4a00"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"9e67355facf9ac761bb982ec9455c3a5e876af1a","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"      web:"},{"line_number":1215,"context_line":"        default: 8181"},{"line_number":1216,"context_line":"        public: 80"},{"line_number":1217,"context_line":" "},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"manifests:"},{"line_number":1220,"context_line":"  configmap_bin: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_a8481ab2","line":1217,"range":{"start_line":1217,"start_character":0,"end_line":1217,"end_character":1},"updated":"2017-10-27 13:35:29.000000000","message":"pls remove here as well","commit_id":"6a9256518cafaf0fdc9b548b03b7bc92427c4a00"}],"tools/overrides/mvp/neutron-onos.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f0e9b881c5209e868444734c6bdbdd79c45db89c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"images:"},{"line_number":2,"context_line":"  server: \"opensona/neutron-sona\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"network:"},{"line_number":5,"context_line":"  external_bridge: \"\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f515b1d_470a488a","line":2,"range":{"start_line":2,"start_character":11,"end_line":2,"end_character":32},"updated":"2017-09-26 14:17:53.000000000","message":"can you pin this to a tag, rather than using \u0027:latest\u0027","commit_id":"d7d8fd5035dc82a7fd014de4a080e975dc72c8ed"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f0e9b881c5209e868444734c6bdbdd79c45db89c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        mechanism_drivers: \"onos_ml2\""},{"line_number":15,"context_line":"    ml2_conf_onos:"},{"line_number":16,"context_line":"      enabled: true"},{"line_number":17,"context_line":"      url_path: \"http://onos-sona:8181/onos/openstacknetworking\""},{"line_number":18,"context_line":"      auth:"},{"line_number":19,"context_line":"        user: \"onos\""},{"line_number":20,"context_line":"        password: \"rocks\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f515b1d_4d4dc698","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":64},"updated":"2017-09-26 14:17:53.000000000","message":"could we get this from the endpoints section and use lookups?","commit_id":"d7d8fd5035dc82a7fd014de4a080e975dc72c8ed"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f0e9b881c5209e868444734c6bdbdd79c45db89c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    ml2_conf_onos:"},{"line_number":16,"context_line":"      enabled: true"},{"line_number":17,"context_line":"      url_path: \"http://onos-sona:8181/onos/openstacknetworking\""},{"line_number":18,"context_line":"      auth:"},{"line_number":19,"context_line":"        user: \"onos\""},{"line_number":20,"context_line":"        password: \"rocks\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"manifests:"},{"line_number":23,"context_line":"  daemonset_dhcp_agent: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f515b1d_8d5a9e4c","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":25},"updated":"2017-09-26 14:17:53.000000000","message":"As above, I\u0027d be more comfortable if credentials are in the endpoints section, separating them from config.","commit_id":"d7d8fd5035dc82a7fd014de4a080e975dc72c8ed"}]}