)]}'
{"playbooks/roles/deploy-ceph-utils/tasks/centos.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    state: latest"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: centos | installing ceph repo"},{"line_number":19,"context_line":"  command: sudo rpm -Uhv http://download.ceph.com/rpm-luminous/el7/noarch/ceph-release-1-1.el7.noarch.rpm"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: centos | installing ceph"},{"line_number":22,"context_line":"  yum:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_445d1877","line":19,"updated":"2017-10-02 22:23:58.000000000","message":"yum module can install from url","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c78e5245c08f7f2ee5b26858cdb8634dccbd3b4d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    state: latest"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: centos | installing ceph repo"},{"line_number":19,"context_line":"  command: sudo rpm -Uhv http://download.ceph.com/rpm-luminous/el7/noarch/ceph-release-1-1.el7.noarch.rpm"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: centos | installing ceph"},{"line_number":22,"context_line":"  yum:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_455bd2f4","line":19,"in_reply_to":"7f515b1d_445d1877","updated":"2017-10-03 04:38:30.000000000","message":"Done","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-docker/tasks/centos.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  when: need_docker | failed"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: centos | moving systemd unit into place"},{"line_number":20,"context_line":"  command: sudo cp -f /usr/lib/systemd/system/docker-latest.service /etc/systemd/system/docker.service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: centos | changing docker storage location"},{"line_number":23,"context_line":"  command: sudo sed -i \"s|/var/lib/docker-latest|/var/lib/docker|g\" /etc/systemd/system/docker.service"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_e4fbe443","line":20,"updated":"2017-10-02 22:23:58.000000000","message":"This whole section hurts me a bit. Please look at:\n\nhttps://review.openstack.org/#/c/508718/11/playbooks/setup-gate.yaml","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1636e60f167b3e99f6b07c7deb1b009c64af137d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  when: need_docker | failed"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: centos | moving systemd unit into place"},{"line_number":20,"context_line":"  command: sudo cp -f /usr/lib/systemd/system/docker-latest.service /etc/systemd/system/docker.service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: centos | changing docker storage location"},{"line_number":23,"context_line":"  command: sudo sed -i \"s|/var/lib/docker-latest|/var/lib/docker|g\" /etc/systemd/system/docker.service"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_a5eba610","line":20,"in_reply_to":"7f515b1d_e4fbe443","updated":"2017-10-03 02:59:39.000000000","message":"yeah - this is just a 1-1 conversion of the current gate script","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-docker/tasks/fedora.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  when: need_docker | failed"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: fedora | moving systemd unit into place"},{"line_number":20,"context_line":"  command: sudo cp -f /usr/lib/systemd/system/docker-latest.service /etc/systemd/system/docker.service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: fedora | changing docker storage location"},{"line_number":23,"context_line":"  command: sudo sed -i \"s|/var/lib/docker-latest|/var/lib/docker|g\" /etc/systemd/system/docker.service"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_c4f6a85d","line":20,"updated":"2017-10-02 22:23:58.000000000","message":"This whole section hurts me a bit. Please look at:\n\nhttps://review.openstack.org/#/c/508718/11/playbooks/setup-gate.yaml","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-helm/tasks/master.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    name: \"{{item}}\""},{"line_number":18,"context_line":"    state: installed"},{"line_number":19,"context_line":"  with_items:"},{"line_number":20,"context_line":"   - git"},{"line_number":21,"context_line":"   - make"},{"line_number":22,"context_line":"   - curl"},{"line_number":23,"context_line":"   - ca-certificates"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_849af010","line":20,"updated":"2017-10-02 22:23:58.000000000","message":"should be indented one more (and the same goes for the ones below)","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"670f30841e621f0c2097917b660fa2cb15cddf4e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    name: \"{{item}}\""},{"line_number":18,"context_line":"    state: installed"},{"line_number":19,"context_line":"  with_items:"},{"line_number":20,"context_line":"   - git"},{"line_number":21,"context_line":"   - make"},{"line_number":22,"context_line":"   - curl"},{"line_number":23,"context_line":"   - ca-certificates"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_a53046a0","line":20,"in_reply_to":"7f515b1d_65f12e01","updated":"2017-10-03 03:08:19.000000000","message":"idk. proper indention? you are one space indented while the rest of the files and lines are two spaced\n\n\nIts my OCD ok? just be cool. for once. be cool man. just once.","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1636e60f167b3e99f6b07c7deb1b009c64af137d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    name: \"{{item}}\""},{"line_number":18,"context_line":"    state: installed"},{"line_number":19,"context_line":"  with_items:"},{"line_number":20,"context_line":"   - git"},{"line_number":21,"context_line":"   - make"},{"line_number":22,"context_line":"   - curl"},{"line_number":23,"context_line":"   - ca-certificates"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_65f12e01","line":20,"in_reply_to":"7f515b1d_849af010","updated":"2017-10-03 02:59:39.000000000","message":"why?","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-iscsi-loopback/tasks/main.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    name: \"{{item}}\""},{"line_number":17,"context_line":"    state: installed"},{"line_number":18,"context_line":"  with_items:"},{"line_number":19,"context_line":"   - targetcli"},{"line_number":20,"context_line":"   - open-iscsi"},{"line_number":21,"context_line":"   - lshw"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_44a07842","line":19,"updated":"2017-10-02 22:23:58.000000000","message":"should be indented more","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-kube/tasks/main.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | setting up mounts for kubelet"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    sudo mkdir -p /var/lib/kubelet"},{"line_number":16,"context_line":"    sudo mount --bind /var/lib/kubelet /var/lib/kubelet"},{"line_number":17,"context_line":"    sudo mount --make-shared /var/lib/kubelet"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_e49084ef","line":14,"updated":"2017-10-02 22:23:58.000000000","message":"convert to mount_module?","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c78e5245c08f7f2ee5b26858cdb8634dccbd3b4d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | setting up mounts for kubelet"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    sudo mkdir -p /var/lib/kubelet"},{"line_number":16,"context_line":"    sudo mount --bind /var/lib/kubelet /var/lib/kubelet"},{"line_number":17,"context_line":"    sudo mount --make-shared /var/lib/kubelet"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_45b752f6","line":14,"in_reply_to":"7f515b1d_e49084ef","updated":"2017-10-03 04:38:30.000000000","message":"will need to look into it.","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    sudo docker rm -f kubelet || true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: common | removing any old docker containers"},{"line_number":25,"context_line":"  shell: |"},{"line_number":26,"context_line":"    sudo docker ps -aq | xargs -r -l1 -P16 sudo docker rm -f"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: common | removing any pre-existing dirs on host"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_84c310ed","line":25,"updated":"2017-10-02 22:23:58.000000000","message":"could do this with the docker_module from ansible","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c78e5245c08f7f2ee5b26858cdb8634dccbd3b4d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    sudo docker rm -f kubelet || true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: common | removing any old docker containers"},{"line_number":25,"context_line":"  shell: |"},{"line_number":26,"context_line":"    sudo docker ps -aq | xargs -r -l1 -P16 sudo docker rm -f"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: common | removing any pre-existing dirs on host"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_05e4ba0b","line":25,"in_reply_to":"7f515b1d_84c310ed","updated":"2017-10-03 04:38:30.000000000","message":"Done","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    sudo docker ps -aq | xargs -r -l1 -P16 sudo docker rm -f"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: common | removing any pre-existing dirs on host"},{"line_number":29,"context_line":"  shell: |"},{"line_number":30,"context_line":"    sudo rm -rfv \\"},{"line_number":31,"context_line":"        /etc/cni/net.d \\"},{"line_number":32,"context_line":"        /etc/kubernetes \\"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_c48b48bd","line":29,"updated":"2017-10-02 22:23:58.000000000","message":"convert to file module","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c78e5245c08f7f2ee5b26858cdb8634dccbd3b4d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    sudo docker ps -aq | xargs -r -l1 -P16 sudo docker rm -f"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: common | removing any pre-existing dirs on host"},{"line_number":29,"context_line":"  shell: |"},{"line_number":30,"context_line":"    sudo rm -rfv \\"},{"line_number":31,"context_line":"        /etc/cni/net.d \\"},{"line_number":32,"context_line":"        /etc/kubernetes \\"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_c5c22253","line":29,"in_reply_to":"7f515b1d_c48b48bd","updated":"2017-10-03 04:38:30.000000000","message":"Done","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-kube/tasks/master.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  command: sudo sed -i \"/^search.*/d\" /etc/resolv.conf"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: common | launching kubeadm-aio master container"},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"          sudo docker run -dt \\"},{"line_number":19,"context_line":"            --name\u003dkubeadm-aio \\"},{"line_number":20,"context_line":"            --net\u003dhost \\"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_24b45c7f","line":17,"updated":"2017-10-02 22:23:58.000000000","message":"should use docker module for this","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          done"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: common | setting ownership of admin config"},{"line_number":53,"context_line":"  shell: sudo chown $(id -u):$(id -g) ${HOME}/.kubeadm-aio/admin.conf"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: common | makeing required dir on host"},{"line_number":56,"context_line":"  command: mkdir -p ${HOME}/.kube"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_c4a4684d","line":53,"updated":"2017-10-02 22:23:58.000000000","message":"file module for this","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  shell: sudo chown $(id -u):$(id -g) ${HOME}/.kubeadm-aio/admin.conf"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: common | makeing required dir on host"},{"line_number":56,"context_line":"  command: mkdir -p ${HOME}/.kube"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: common | copying kubeconfig into place"},{"line_number":59,"context_line":"  command: cp -f ${HOME}/.kubeadm-aio/admin.conf ${HOME}/.kube/config"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_a465ec1f","line":56,"updated":"2017-10-02 22:23:58.000000000","message":"file module for this","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  command: mkdir -p ${HOME}/.kube"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: common | copying kubeconfig into place"},{"line_number":59,"context_line":"  command: cp -f ${HOME}/.kubeadm-aio/admin.conf ${HOME}/.kube/config"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: common | waiting for kube master node to be ready"},{"line_number":62,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_646b74f0","line":59,"updated":"2017-10-02 22:23:58.000000000","message":"copy module for this","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-osh/tasks/ceph-admin-creds.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | ceph | namespace credential deploy"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"          helm install --namespace\u003dopenstack ./ceph --name\u003dceph-openstack-config \\"},{"line_number":16,"context_line":"            --set endpoints.identity.namespace\u003dopenstack \\"},{"line_number":17,"context_line":"            --set endpoints.object_store.namespace\u003dceph \\"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_446e3800","line":14,"updated":"2017-10-02 22:23:58.000000000","message":"dont need shell for this (use command)","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-osh/tasks/ceph-radosgw-keystone.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | ceph | radosgw keystone"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"          helm install --namespace\u003dopenstack ${WORK_DIR}/ceph --name\u003dradosgw-openstack \\"},{"line_number":16,"context_line":"            --set endpoints.identity.namespace\u003dopenstack \\"},{"line_number":17,"context_line":"            --set endpoints.object_store.namespace\u003dceph \\"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_2479fcc6","line":14,"updated":"2017-10-02 22:23:58.000000000","message":"command module","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-osh/tasks/ceph.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  command: modprobe rbd"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: common | openstack-helm | ceph | primary deploy"},{"line_number":29,"context_line":"  shell: |"},{"line_number":30,"context_line":"          helm install --namespace\u003dceph ./ceph --name\u003dceph \\"},{"line_number":31,"context_line":"            --set endpoints.identity.namespace\u003dopenstack \\"},{"line_number":32,"context_line":"            --set endpoints.object_store.namespace\u003dceph \\"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_0474c0cd","line":29,"updated":"2017-10-02 22:23:58.000000000","message":"command module","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-osh/tasks/cinder.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | cinder"},{"line_number":14,"context_line":"  command: helm install --namespace\u003dopenstack ./glance --name\u003dcinder"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: /home/harbor/Development/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_c47908c5","line":13,"updated":"2017-10-02 22:23:58.000000000","message":"this playbook and the ones like it can be collapsed into a single generic playbook with a {{ variable }}\n\nso much so i wont comment on the rest","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c78e5245c08f7f2ee5b26858cdb8634dccbd3b4d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | cinder"},{"line_number":14,"context_line":"  command: helm install --namespace\u003dopenstack ./glance --name\u003dcinder"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: /home/harbor/Development/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_17fbd1c0","line":13,"in_reply_to":"7f515b1d_45299234","updated":"2017-10-03 04:38:30.000000000","message":"thats fair - though it is a WIP - and cinders not enabled yet in the main.yaml ;)","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"670f30841e621f0c2097917b660fa2cb15cddf4e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | cinder"},{"line_number":14,"context_line":"  command: helm install --namespace\u003dopenstack ./glance --name\u003dcinder"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: /home/harbor/Development/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_45299234","line":13,"in_reply_to":"7f515b1d_45cd12b5","updated":"2017-10-03 03:08:19.000000000","message":"hmmm i feel like you are introducing risk of errors rather and complication doing it like this. Ansible is made to use the variables like I describe and be reusable rather than explict like you are doing.\n\nbut its functionally the same, your way just introduces the possibilites of inconsitencies\n\npoint and case, look at the line below. \"./glance --name\u003dcinder\" is clearly wrong and a copy/paste error","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1636e60f167b3e99f6b07c7deb1b009c64af137d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | cinder"},{"line_number":14,"context_line":"  command: helm install --namespace\u003dopenstack ./glance --name\u003dcinder"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: /home/harbor/Development/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_45cd12b5","line":13,"in_reply_to":"7f515b1d_c47908c5","updated":"2017-10-03 02:59:39.000000000","message":"this may be possible later - but during dev of this patch I\u0027d prefer to keep them sperate.","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-osh/tasks/neutron.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | neutron | ensureing ebtables module loaded"},{"line_number":14,"context_line":"  command: modprobe ebtables"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: common | openstack-helm | neutron | ensureing ip6_tables module loaded"},{"line_number":17,"context_line":"  command: modprobe ip6_tables"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_24621c0b","line":14,"updated":"2017-10-02 22:23:58.000000000","message":"modprobe_module","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}],"playbooks/roles/deploy-osh/tasks/openvswitch.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0b093059fd2c8b290af8bcd92a9bbf23375298e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: common | openstack-helm | infra | openvswitch | ensureing openvswitch module loaded"},{"line_number":14,"context_line":"  command: modprobe openvswitch"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: common | openstack-helm | infra | openvswitch | ensureing gre module loaded"},{"line_number":17,"context_line":"  command: modprobe gre"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_c4522835","line":14,"updated":"2017-10-02 22:23:58.000000000","message":"modprobe module","commit_id":"bf87eb697d02718b5e552d5dd6fc7dee7d6ec61b"}]}