)]}'
{"ceph/templates/daemonset-osd-devices.yaml":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"cf6e91010b8e35a63bd1223af4d481d1845ebe3a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"kind: DaemonSet"},{"line_number":23,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":24,"context_line":"metadata:"},{"line_number":25,"context_line":"  name: ceph-cephosd-device-{{ $value.name }}"},{"line_number":26,"context_line":"spec:"},{"line_number":27,"context_line":"  template:"},{"line_number":28,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_7a12e1b6","line":25,"updated":"2017-10-03 16:13:33.000000000","message":"I think this could stay as ceph-osd-{{$value.name}}.  it\u0027s just the pod name, and doesn\u0027t need to follow the label syntax.","commit_id":"ec6ff98a013f38e52fa158b3d3c7791ef5f4f91c"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"cf6e91010b8e35a63bd1223af4d481d1845ebe3a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    spec:"},{"line_number":32,"context_line":"      nodeSelector:"},{"line_number":33,"context_line":"        {{ $.Values.labels.osd.node_selector_key }}: {{ $.Values.labels.osd.node_selector_value }}"},{"line_number":34,"context_line":"        {{ $value.name}}: enabled"},{"line_number":35,"context_line":"      hostNetwork: true"},{"line_number":36,"context_line":"      hostPID: true"},{"line_number":37,"context_line":"      dnsPolicy: {{ $.Values.pod.dns_policy }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_3a0c6993","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":33},"updated":"2017-10-03 16:13:33.000000000","message":"I think you meant to put what\u0027s on line 25 above here.","commit_id":"ec6ff98a013f38e52fa158b3d3c7791ef5f4f91c"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a6cd8a3b33c6103c10d71f36f133f036a6f37ec9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    spec:"},{"line_number":32,"context_line":"      nodeSelector:"},{"line_number":33,"context_line":"        {{ $.Values.labels.osd.node_selector_key }}: {{ $.Values.labels.osd.node_selector_value }}"},{"line_number":34,"context_line":"        ceph-cephosd-device-{{ $value.name }}: enabled"},{"line_number":35,"context_line":"      hostNetwork: true"},{"line_number":36,"context_line":"      hostPID: true"},{"line_number":37,"context_line":"      dnsPolicy: {{ $.Values.pod.dns_policy }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_f78fff2b","line":34,"updated":"2017-10-03 23:32:58.000000000","message":"why ceph-cephxxx ?","commit_id":"dfa9df8d50186b3afdb3f9424bfb3053a99f8ae7"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"03362ef6344d826ff67dab7c7c78d722dccf577b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    spec:"},{"line_number":32,"context_line":"      nodeSelector:"},{"line_number":33,"context_line":"        {{ $.Values.labels.osd.node_selector_key }}: {{ $.Values.labels.osd.node_selector_value }}"},{"line_number":34,"context_line":"        ceph-cephosd-device-{{ $value.name }}: enabled"},{"line_number":35,"context_line":"      hostNetwork: true"},{"line_number":36,"context_line":"      hostPID: true"},{"line_number":37,"context_line":"      dnsPolicy: {{ $.Values.pod.dns_policy }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_253aef33","line":34,"in_reply_to":"7f515b1d_f78fff2b","updated":"2017-10-04 13:12:37.000000000","message":"+1.  see comment on line 151 of kube.sh; if that change is made, the \"ceph-\" prefix could go away here.","commit_id":"dfa9df8d50186b3afdb3f9424bfb3053a99f8ae7"}],"ceph/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"5ae06659d8dd7ebaeacae1cabc768d6413f5a303","unresolved":false,"context_lines":[{"line_number":305,"context_line":"# and"},{"line_number":306,"context_line":"#    ceph-osd-device-{name}\u003denabled"},{"line_number":307,"context_line":"# where {name} is a name: value from this map."},{"line_number":308,"context_line":"osd_devices:"},{"line_number":309,"context_line":"  - name: scsi-2-0.0.0"},{"line_number":310,"context_line":"    device: scsi@2:0.0.0"},{"line_number":311,"context_line":"    journal:"},{"line_number":312,"context_line":"      device: scsi@3:0.0.0"},{"line_number":313,"context_line":"    zap: \"1\""},{"line_number":314,"context_line":"  - name: scsi-2-0.0.1"},{"line_number":315,"context_line":"    device: scsi@2:0.0.1"},{"line_number":316,"context_line":"    journal:"},{"line_number":317,"context_line":"     device: scsi@3:0.0.1"},{"line_number":318,"context_line":"    zap: \"1\""},{"line_number":319,"context_line":"  - name: scsi-2-0.0.2"},{"line_number":320,"context_line":"    device: scsi@2:0.0.2"},{"line_number":321,"context_line":"    journal:"},{"line_number":322,"context_line":"     device: scsi@3:0.0.2"},{"line_number":323,"context_line":"    zap: \"1\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"bootstrap:"},{"line_number":326,"context_line":"  enabled: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_c368be88","line":323,"range":{"start_line":308,"start_character":0,"end_line":323,"end_character":12},"updated":"2017-10-04 06:51:01.000000000","message":"this should be provided via the dynamically generated yaml from the loopback setup functions - which may need modification to match this improved format.","commit_id":"dfa9df8d50186b3afdb3f9424bfb3053a99f8ae7"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"5e59341ed4cda6ef41b1b26ea09c4ef8093f659c","unresolved":false,"context_lines":[{"line_number":325,"context_line":"#    zap: \"1\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"#Testing following output /tmp/loopback-dev-values.yaml"},{"line_number":328,"context_line":"block_devices:"},{"line_number":329,"context_line":"- device: scsi@2:0.0.0"},{"line_number":330,"context_line":"  journal:"},{"line_number":331,"context_line":"    device: scsi@3:0.0.0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f515b1d_e4626b16","line":328,"updated":"2017-10-05 16:50:26.000000000","message":"no particular objection to this, but why the change from osd_devices?","commit_id":"f28322039ae3bbd548ff4154a12f63581ab4d41c"}],"tools/gate/funcs/kube.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"5ae06659d8dd7ebaeacae1cabc768d6413f5a303","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    for DEV_TYPE in $(cat $LOOPBACK_DEV_INFO | yaml_to_json | jq -r \".block_devices.\\\"$HOST\\\" |  keys? | .[]\"); do"},{"line_number":149,"context_line":"      DEV_ADDRS\u003d$(cat $LOOPBACK_DEV_INFO | yaml_to_json | jq -r \".block_devices.\\\"$HOST\\\".\\\"$DEV_TYPE\\\" | .[]\")"},{"line_number":150,"context_line":"      for DEV_ADDR in $(cat $LOOPBACK_DEV_INFO | yaml_to_json | jq -r \".block_devices.\\\"$HOST\\\".\\\"$DEV_TYPE\\\" | .[]\"); do"},{"line_number":151,"context_line":"        kubectl label node $HOST ceph-$DEV_TYPE-device-$(echo $DEV_ADDR | tr \u0027@\u0027 \u0027-\u0027 | tr \u0027:\u0027 \u0027-\u0027 )\u003denabled"},{"line_number":152,"context_line":"      done"},{"line_number":153,"context_line":"    done"},{"line_number":154,"context_line":"  done"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f515b1d_833ac695","line":151,"range":{"start_line":151,"start_character":33,"end_line":151,"end_character":37},"updated":"2017-10-04 06:51:01.000000000","message":"why is this changed to ceph, rather than device? You may want to use a block device for things other than ceph (ie swift/cinder lvm)","commit_id":"dfa9df8d50186b3afdb3f9424bfb3053a99f8ae7"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"03362ef6344d826ff67dab7c7c78d722dccf577b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    for DEV_TYPE in $(cat $LOOPBACK_DEV_INFO | yaml_to_json | jq -r \".block_devices.\\\"$HOST\\\" |  keys? | .[]\"); do"},{"line_number":149,"context_line":"      DEV_ADDRS\u003d$(cat $LOOPBACK_DEV_INFO | yaml_to_json | jq -r \".block_devices.\\\"$HOST\\\".\\\"$DEV_TYPE\\\" | .[]\")"},{"line_number":150,"context_line":"      for DEV_ADDR in $(cat $LOOPBACK_DEV_INFO | yaml_to_json | jq -r \".block_devices.\\\"$HOST\\\".\\\"$DEV_TYPE\\\" | .[]\"); do"},{"line_number":151,"context_line":"        kubectl label node $HOST ceph-$DEV_TYPE-device-$(echo $DEV_ADDR | tr \u0027@\u0027 \u0027-\u0027 | tr \u0027:\u0027 \u0027-\u0027 )\u003denabled"},{"line_number":152,"context_line":"      done"},{"line_number":153,"context_line":"    done"},{"line_number":154,"context_line":"  done"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f515b1d_c5043b81","line":151,"range":{"start_line":151,"start_character":33,"end_line":151,"end_character":37},"in_reply_to":"7f515b1d_833ac695","updated":"2017-10-04 13:12:37.000000000","message":"agreed.  it seems like this would work well:\n\nkubectl label node $HOST $DEV_TYPE-device-$(echo $DEV_ADDR | tr \u0027@\u0027 \u0027-\u0027 | tr \u0027:\u0027 \u0027-\u0027 )\u003denabled\n\n... and then removing the redundant \"ceph-\" prefix on line 34 of daemonset-osd-devices.yaml, killing two birds with one stone.","commit_id":"dfa9df8d50186b3afdb3f9424bfb3053a99f8ae7"}]}
