)]}'
{"id":"openstack%2Fopenstack-helm~509250","triplet_id":"openstack%2Fopenstack-helm~master~Ib733ed72df49e134a9199e4024b2893629b990dc","project":"openstack/openstack-helm","branch":"master","topic":"clarify-auto_bridge_add","hashtags":[],"change_id":"Ib733ed72df49e134a9199e4024b2893629b990dc","subject":"Clarify type of auto_bridge_add","status":"MERGED","created":"2017-10-03 18:41:23.000000000","updated":"2017-10-04 04:53:37.000000000","submitted":"2017-10-04 04:53:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"509250-1507092817276-9f0f0144","meta_rev_id":"4ab114cb028f2ced88d872d551f7855c8f18dffd","_number":509250,"virtual_id_number":509250,"owner":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2017-10-04 04:53:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2017-10-04 01:19:37.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":2,"date":"2017-10-04 04:49:02.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-10-04 01:41:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":1,"date":"2017-10-04 04:49:02.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-03 20:53:59.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2017-10-03 20:54:06.000000000","updated_by":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"reviewer":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"state":"REVIEWER"},{"updated":"2017-10-04 01:19:37.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-10-04 01:41:44.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2017-10-04 04:49:02.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2017-10-04 04:53:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c25773fc7defddc96a8d075f06e9480ba07a8c5d","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-10-03 18:41:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d7fdb4f617c90514c0a762d6592c4980e6e2046","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-10-03 19:20:46.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/OSH/job/openstack/job/openstack-helm/job/basic/1412/","accounts_in_message":[],"_revision_number":1},{"id":"f9bf708d196b26a789b6f59c1699b27473a453da","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-10-03 19:37:36.000000000","message":"Patch Set 1:\n\nBuild Failed \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/1412/org.openstack.helm-1412.x-gtar : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"cecee88bdb97681d18ae36cd9136e7af730a0625","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-10-03 23:54:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d535add5d3d448c763bba6f11139eb1c5055bfa5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 00:49:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/50/509250/2/check/gate-openstack-helm-docs-ubuntu-xenial/aadcfd6//doc/build/html/ : SUCCESS in 2m 21s\n- gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial/53251c1/ : SUCCESS in 3m 02s\n- gate-openstack-helm-aio-basic-ovs-rbd-ubuntu-xenial-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-ovs-rbd-ubuntu-xenial-nv/915676f/ : SUCCESS in 24m 11s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-swift-ubuntu-xenial-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-ovs-swift-ubuntu-xenial-nv/b98a030/ : SUCCESS in 26m 57s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-radosgw-ubuntu-xenial-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-ovs-radosgw-ubuntu-xenial-nv/06b42fa/ : SUCCESS in 25m 04s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-pvc-ubuntu-xenial-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-ovs-pvc-ubuntu-xenial-nv/12f19bc/ : SUCCESS in 25m 18s (non-voting)\n- gate-openstack-helm-aio-basic-linuxbridge-rbd-ubuntu-xenial-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-linuxbridge-rbd-ubuntu-xenial-nv/4f3150b/ : SUCCESS in 25m 49s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-rbd-centos-7-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-ovs-rbd-centos-7-nv/7d617ee/ : FAILURE in 26m 57s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-rbd-fedora-26-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-aio-basic-ovs-rbd-fedora-26-nv/3e5e2e5/ : FAILURE in 1m 45s (non-voting)\n- gate-openstack-helm-multi-basic-ovs-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-multi-basic-ovs-rbd-ubuntu-xenial-3-node-nv/dcfea1d/ : SUCCESS in 54m 22s (non-voting)\n- gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv/511ae42/ : SUCCESS in 49m 06s (non-voting)\n- gate-openstack-helm-multi-armada-ovs-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/50/509250/2/check/gate-openstack-helm-multi-armada-ovs-rbd-ubuntu-xenial-3-node-nv/6ab183a/ : SUCCESS in 41m 49s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a22ef75716e740696d0084ad194e40e442ac7208","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-10-04 00:53:09.000000000","message":"Patch Set 2:\n\nBuild Started http://10.24.20.18:30081/job/OSH/job/openstack/job/openstack-helm/job/basic/1426/","accounts_in_message":[],"_revision_number":2},{"id":"94c84801613a3e97d00fabbfb0a028f222fc2e98","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-10-04 01:19:37.000000000","message":"Patch Set 2:\n\nBuild Failed \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/1426/org.openstack.helm-1426.x-gtar : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"e52a9120caae3e1b07c40225992f000a1cd89572","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-10-04 01:41:44.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3d7a077098cb7bdf59eaf15fd96f5cb3b7d3298d","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-10-04 04:49:02.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"96b2b0ad0d9bb679b91ead2a51d12cb82ea777b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 04:49:13.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"d102105dcd7cc785f03bf81dbebf669a6b65160b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 04:53:37.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/50/509250/2/gate/gate-openstack-helm-docs-ubuntu-xenial/c58351f//doc/build/html/ : SUCCESS in 4m 17s\n- gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial http://logs.openstack.org/50/509250/2/gate/gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial/2c276f0/ : SUCCESS in 3m 42s","accounts_in_message":[],"_revision_number":2},{"id":"3fc355b7071efbe036ded3f14cdb234bfccd0725","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 04:53:37.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cb28c05da5e2003263d4b4be2db1813033f070fb","revisions":{"274d910de8955b20312705be8aa8671a37195732":{"kind":"REWORK","_number":1,"created":"2017-10-03 18:41:23.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/50/509250/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/50/509250/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/1"}}},"commit":{"parents":[{"commit":"2ca580a9b4319ac7fa8c28d4e2928e81294b874b","subject":"Merge \"gate: move \u0027root check\u0027 to setup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2ca580a9b4319ac7fa8c28d4e2928e81294b874b"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-10-03 18:24:49.000000000","tz":0},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-10-03 18:24:49.000000000","tz":0},"subject":"Clarify type of auto_bridge_add","message":"Clarify type of auto_bridge_add\n\nWith auto_bridge_add defined as:\n\n  auto_bridge_add:\n  # nothing here\n\nhelm doesn\u0027t treat is as am empty table so issues warnings in the most\ncommon case which is where we use --values\u003d... to replace this value.\n\nThis change clarifies it is indeed a table and the warnings no long\nappear.\n\nChange-Id: Ib733ed72df49e134a9199e4024b2893629b990dc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/274d910de8955b20312705be8aa8671a37195732"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/274d910de8955b20312705be8aa8671a37195732"}]},"branch":"refs/heads/master"},"cb28c05da5e2003263d4b4be2db1813033f070fb":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2017-10-03 23:54:29.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/50/509250/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/50/509250/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/50/509250/2"}}},"commit":{"parents":[{"commit":"e5304b45e0cd73ba527b7b08b4adefac0689f6d8","subject":"Telemetry: add mongodb chart","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e5304b45e0cd73ba527b7b08b4adefac0689f6d8"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-10-03 18:24:49.000000000","tz":0},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-10-03 23:54:05.000000000","tz":0},"subject":"Clarify type of auto_bridge_add","message":"Clarify type of auto_bridge_add\n\nWith auto_bridge_add defined as:\n\n  auto_bridge_add:\n  # nothing here\n\nhelm doesn\u0027t treat is as am empty table so issues warnings such as:\n\n    2017/10/03 19:24:37 warning: destination for auto_bridge_add is a table. Ignoring non-table value \u003cnil\u003e\n\nThis happens most of the time as we use `helm --values\u003d...` to augment\nvalues.yaml in the chart.\n\nThis change clarifies it is indeed a table and the warnings no long\nappear.\n\nChange-Id: Ib733ed72df49e134a9199e4024b2893629b990dc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/cb28c05da5e2003263d4b4be2db1813033f070fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/cb28c05da5e2003263d4b4be2db1813033f070fb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
